[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265638#comment-17265638 ] Hudson commented on HBASE-25279: Results for branch branch-2.4 [build #32 on

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264871#comment-17264871 ] Viraj Jasani commented on HBASE-25279: -- >From daemonizing threads viewpoint, it seems only

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264634#comment-17264634 ] Viraj Jasani commented on HBASE-25279: -- >From historical context, One of the critical bugs to make

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264587#comment-17264587 ] Lars Hofhansl commented on HBASE-25279: --- I agree the failure to close the watcher is the bug.

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264557#comment-17264557 ] Bharath Vissapragada commented on HBASE-25279: -- > Why is the watcher not being closed? That

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264547#comment-17264547 ] Andrew Kyle Purtell commented on HBASE-25279: - Filed HBASE-25505 for follow up > Non-daemon

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264545#comment-17264545 ] Andrew Kyle Purtell commented on HBASE-25279: - Ok, I've thought about it, and I'm going to

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264543#comment-17264543 ] Andrew Kyle Purtell commented on HBASE-25279: - I was going to wait until we have a proper

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264542#comment-17264542 ] Josh Elser commented on HBASE-25279: bq. If they are daemonized if the process exits the thread can

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264541#comment-17264541 ] Duo Zhang commented on HBASE-25279: --- It used to be daemon for a long time until IIRC, [~vjasani]

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264539#comment-17264539 ] Andrew Kyle Purtell commented on HBASE-25279: - [~zhangduo] bq. I think this is a bug fix,

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264537#comment-17264537 ] Andrew Kyle Purtell commented on HBASE-25279: - Why is the watcher not being closed? That is

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264536#comment-17264536 ] Andrew Kyle Purtell commented on HBASE-25279: - [~elserj] [~bharathv] [~larsh] So what do

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264535#comment-17264535 ] Josh Elser commented on HBASE-25279: bq. Don't commit it there, please. Not everyone agrees it is

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264534#comment-17264534 ] Duo Zhang commented on HBASE-25279: --- I think this is a bug fix, without the patch it is impossible to

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264533#comment-17264533 ] Andrew Kyle Purtell commented on HBASE-25279: - Don't commit it there, please. Not everyone

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264532#comment-17264532 ] Josh Elser commented on HBASE-25279: {quote}This was committed to master and branch-2, setting fix

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264529#comment-17264529 ] Andrew Kyle Purtell commented on HBASE-25279: - This was committed to master and branch-2,

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264528#comment-17264528 ] Andrew Kyle Purtell commented on HBASE-25279: - Why is this marked as fixed in 2.4.1?

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264527#comment-17264527 ] Lars Hofhansl commented on HBASE-25279: --- I just came across this as well. Currently my 2.4.1 the

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257246#comment-17257246 ] Hudson commented on HBASE-25279: Results for branch branch-2 [build #143 on

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257192#comment-17257192 ] Hudson commented on HBASE-25279: Results for branch master [build #170 on

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2020-12-31 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257120#comment-17257120 ] Josh Elser commented on HBASE-25279: [~vjasani], it's been a while, but I believe I was able to

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2020-11-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231220#comment-17231220 ] Viraj Jasani commented on HBASE-25279: -- HMaster creates two ZKWatchers: 1. Inherited from

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2020-11-12 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231063#comment-17231063 ] Bharath Vissapragada commented on HBASE-25279: -- > I'm not sure if we get into any troubles

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2020-11-12 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231052#comment-17231052 ] Josh Elser commented on HBASE-25279: Yeah, I think you're right. I didn't go looking to see if it

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2020-11-12 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231007#comment-17231007 ] Bharath Vissapragada commented on HBASE-25279: -- [~elserj] Not sure I follow. Doesn't that

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2020-11-12 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230984#comment-17230984 ] Josh Elser commented on HBASE-25279: [~bharathv], [~vjasani], be careful here please, gents. Marking