2005hithlj commented on PR #4358:
URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105432048
I have deleted TestHRegionServer.java in the second commit, but still remind
that this class failed to compile.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/HBASE-25983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525809#comment-17525809
]
Duo Zhang commented on HBASE-25983:
---
OK, this is the last unresolved issue.
Let's take a look again.
[
https://issues.apache.org/jira/browse/HBASE-25326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525781#comment-17525781
]
Igor Bernstein commented on HBASE-25326:
Hi, are there any plans to publish a release with these
Apache-HBase commented on PR #4337:
URL: https://github.com/apache/hbase/pull/4337#issuecomment-1105395230
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
[
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-22172.
---
Resolution: Duplicate
HBASE-25058 has been resolved and we expose several jdk modules out to avoid
Apache-HBase commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105433164
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
pankaj72981 merged PR #4362:
URL: https://github.com/apache/hbase/pull/4362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 merged PR #4337:
URL: https://github.com/apache/hbase/pull/4337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-26947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26947:
--
Fix Version/s: 2.5.0
3.0.0-alpha-3
> Implement a special TestAppender to limit the
ndimiduk commented on PR #3999:
URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105527814
Okay, this change just got complicated. Now we include both JDK versions in
the docker file (the easy part) and support the user specifying which JDK they
want used for the build (the
[
https://issues.apache.org/jira/browse/HBASE-25058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-25058.
---
Fix Version/s: 2.5.0
3.0.0-alpha-3
Hadoop Flags: Reviewed
Resolution:
[
https://issues.apache.org/jira/browse/HBASE-26964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pankaj Kumar resolved HBASE-26964.
--
Fix Version/s: 3.0.0-alpha-3
Resolution: Fixed
Thanks [~liangxs] for the
[
https://issues.apache.org/jira/browse/HBASE-26947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-26947.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.5+.
Thanks [~ndimiduk] for
apurtell commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105668094
@Apache9 I did not save the error text. It is the standard error text you
get when LICENSE.vm cannot be processed. It said to add "apache license 2.0" to
non_aggregated_fine. So that is
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526070#comment-17526070
]
Andrew Kyle Purtell edited comment on HBASE-26760 at 4/21/22 8:47 PM:
Apache-HBase commented on PR #3999:
URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105775875
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s |
[
https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526094#comment-17526094
]
Josh Elser commented on HBASE-26708:
[~vjasani] did you ever get to the bottom of this one? We have
apurtell commented on code in PR #4353:
URL: https://github.com/apache/hbase/pull/4353#discussion_r855525069
##
hbase-compression/hbase-compression-zstd/src/main/java/org/apache/hadoop/hbase/io/compress/zstd/ZstdCodec.java:
##
@@ -121,10 +123,10 @@ static int
Apache-HBase commented on PR #3999:
URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105792127
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526070#comment-17526070
]
Andrew Kyle Purtell commented on HBASE-26760:
-
I tried this with brotli4j and the
apurtell commented on code in PR #4353:
URL: https://github.com/apache/hbase/pull/4353#discussion_r855578555
##
hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm:
##
@@ -1381,7 +1381,7 @@ You can redistribute it and/or modify it under either the
terms of the
## See
Apache-HBase commented on PR #4337:
URL: https://github.com/apache/hbase/pull/4337#issuecomment-1105675701
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s |
busbey commented on code in PR #4353:
URL: https://github.com/apache/hbase/pull/4353#discussion_r855535440
##
hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm:
##
@@ -1381,7 +1381,7 @@ You can redistribute it and/or modify it under either the
terms of the
## See
apurtell commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105670399
Unless @busbey actually responds soon I have an approval and will merge this
to move forward. He's not around much these days. Let me give it another day.
--
This is an automated
apurtell commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105732799
After ingesting ~5TB of CommonCrawl data, brotli compressing at level 7
offers a few % improvement (-85% vs -82%) over zstandard also compressing at
its notion of level 7. This stands to
[
https://issues.apache.org/jira/browse/HBASE-26959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526067#comment-17526067
]
Andrew Kyle Purtell commented on HBASE-26959:
-
After ingesting ~5TB of CommonCrawl data,
apurtell commented on code in PR #4353:
URL: https://github.com/apache/hbase/pull/4353#discussion_r855592677
##
hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm:
##
@@ -1381,7 +1381,7 @@ You can redistribute it and/or modify it under either the
terms of the
## See
apurtell commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105758772
Rebased on master, using supplemental models to fix the LICENSE.vm issue as
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Apache-HBase commented on PR #4337:
URL: https://github.com/apache/hbase/pull/4337#issuecomment-1105777880
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #3999:
URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105792777
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 22s |
Apache-HBase commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105885157
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 56s |
liangxs commented on PR #4362:
URL: https://github.com/apache/hbase/pull/4362#issuecomment-1106008613
@pankaj72981 Thanks very much for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1106034187
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 5s |
Apache-HBase commented on PR #4353:
URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105983000
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 45s |
comnetwork commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104874108
@Apache9 , `RegionReplicationSink.add` is invoked by
`MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very
elegant and somewhat tricky to not write WAL but
Apache9 commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104779728
This will cause we write extra data in WAL.
Maybe a more lightweight solution is to call RegionReplicationSink.add even
when writeFlushWalMarker is false?
--
This is an automated
Apache9 commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104879841
> @Apache9 , `RegionReplicationSink.add` is invoked by
`MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very
elegant and somewhat tricky to not write WAL but still
Apache-HBase commented on PR #4360:
URL: https://github.com/apache/hbase/pull/4360#issuecomment-1104767746
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
Apache-HBase commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105070192
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 11s |
[
https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525655#comment-17525655
]
Nick Dimiduk commented on HBASE-26938:
--
bq. I see that CompactionProgress is also shared via
[
https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525659#comment-17525659
]
LiangJun He commented on HBASE-26943:
-
Thanks for your reminder [~ndimiduk] , I will revert and see
[
https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li reopened HBASE-26943:
---
Thanks for chiming in [~ndimiduk].
The original change for this JIRA was exactly editing the css definitions
ndimiduk commented on code in PR #4337:
URL: https://github.com/apache/hbase/pull/4337#discussion_r855116476
##
pom.xml:
##
@@ -3036,7 +3036,16 @@
${releaseTarget}
---add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}
Apache9 commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104895102
OK, checked the code again, the problem here is that, if we do not write
WAL, then we will not have a MVCC.WriteEntry then we can not use
WriteEntry.attachCompletionAction trick.
Apache-HBase commented on PR #4363:
URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104964531
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 12s |
Nick Dimiduk created HBASE-26965:
Summary: Replace fully qualified class names with import
statements where possible
Key: HBASE-26965
URL: https://issues.apache.org/jira/browse/HBASE-26965
Project:
ndimiduk commented on PR #4363:
URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104984360
I filed HBASE-26965 for the follow-up to avoid this in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ndimiduk merged PR #4363:
URL: https://github.com/apache/hbase/pull/4363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-26965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525610#comment-17525610
]
Duo Zhang commented on HBASE-26965:
---
For some logging related tests, I used this trick to use the
ndimiduk commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105014084
HBASE-26954 is fixed, so reverted that commit from the changeset. Let's see
how it does (should be fine).
Do you have further concerns, @Apache9 ?
--
This is an automated message
Apache-HBase commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105026469
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
Apache-HBase commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105026760
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
Apache-HBase commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105026859
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
[
https://issues.apache.org/jira/browse/HBASE-26960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26960:
-
Description:
Besides HBASE-26768, there is another case replication in
{{RegionReplicationSink}}
[
https://issues.apache.org/jira/browse/HBASE-26960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26960:
-
Status: Patch Available (was: Open)
> Another case for unnecessary replication suspending in
ndimiduk opened a new pull request, #4363:
URL: https://github.com/apache/hbase/pull/4363
I think this reference to HTrace was simply missed in early changes. It
happens to have not been noticed because earlier versions of Hadoop provide an
HTrace jar in the dependency set. Our import ban
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26954:
-
Status: Patch Available (was: In Progress)
> Compilation of master vs hadoop-3.3.2 fails
>
Apache-HBase commented on PR #4363:
URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104966350
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 7s |
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26954:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Compilation of master vs
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26954:
-
Fix Version/s: 3.0.0-alpha-3
> Compilation of master vs hadoop-3.3.2 fails
>
comnetwork commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104906271
@Apache9, thank you very much , ok, I think we could also add a MVCC entry
to maintain the MVCC order to invoke the `RegionReplicationSink.add`?
--
This is an automated message from
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-26954:
Assignee: Nick Dimiduk
> Compilation of master vs hadoop-3.3.2 fails
>
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-26954 started by Nick Dimiduk.
> Compilation of master vs hadoop-3.3.2 fails
>
Apache-HBase commented on PR #4363:
URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104970626
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 3s |
[
https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525607#comment-17525607
]
Nick Dimiduk commented on HBASE-26943:
--
Heya [~heliangjun]. The visual improvement from your
carp84 commented on code in PR #4358:
URL: https://github.com/apache/hbase/pull/4358#discussion_r855109431
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java:
##
@@ -85,7 +85,7 @@ public static void install(final Configuration conf, final
ndimiduk commented on PR #105:
URL:
https://github.com/apache/hbase-operator-tools/pull/105#issuecomment-1105156673
@clarax Okay, this is looking good. Anything else you want to tweak before I
commit?
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HBASE-26966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525676#comment-17525676
]
Nick Dimiduk commented on HBASE-26966:
--
Heya [~busbey] here's some more kindling for your interest
[
https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525679#comment-17525679
]
Nick Dimiduk commented on HBASE-26943:
--
Hey, no problem [~liyu], [~heliangjun]. I'm happy to help
Nick Dimiduk created HBASE-26966:
Summary: Packaging and Integration Stage can fail with
BindingException
Key: HBASE-26966
URL: https://issues.apache.org/jira/browse/HBASE-26966
Project: HBase
Apache-HBase commented on PR #4358:
URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105244526
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s |
Apache-HBase commented on PR #4358:
URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105248800
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 53s |
Apache-HBase commented on PR #4358:
URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105252253
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s |
[
https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525739#comment-17525739
]
Yu Li commented on HBASE-26943:
---
Thanks [~ndimiduk], no problem (smile).
> HMaster page style display
[
https://issues.apache.org/jira/browse/HBASE-26961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ruanhui updated HBASE-26961:
Summary: cache region locations when getAllRegionLocations() for
branch-2.4+ (was: cache region
[
https://issues.apache.org/jira/browse/HBASE-26961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ruanhui updated HBASE-26961:
Description: backport HBASE-26942 to branch-2.4 and branch-2.5 (was:
backport HBASE-26942 for
Apache9 commented on code in PR #4337:
URL: https://github.com/apache/hbase/pull/4337#discussion_r855243274
##
pom.xml:
##
@@ -3036,7 +3036,16 @@
${releaseTarget}
---add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}
+
Apache9 commented on code in PR #4305:
URL: https://github.com/apache/hbase/pull/4305#discussion_r855257735
##
pom.xml:
##
@@ -3032,7 +3033,8 @@
--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}
-3.2.0
+
+
Boris created HBASE-26967:
-
Summary: FilterList with FuzzyRowFilter and
SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as
expected
Key: HBASE-26967
URL:
clarax commented on PR #105:
URL:
https://github.com/apache/hbase-operator-tools/pull/105#issuecomment-1105324434
> @clarax Okay, this is looking good. Anything else you want to tweak before
I commit?
Not for now. Thank you.
--
This is an automated message from the Apache Git
Apache9 commented on PR #4359:
URL: https://github.com/apache/hbase/pull/4359#issuecomment-1105328262
Mind taking a full size capture of the region page, so we can know what is
whole page looks like?
Thanks.
--
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on PR #4305:
URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105336868
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache9 merged PR #4340:
URL: https://github.com/apache/hbase/pull/4340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
83 matches
Mail list logo
