[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256821429 haha - yeah already pushed (force) the PORT PORT PORT thing. I also thought about the hashing which would be a fine approach. But I'd do that as part of what appears to be a lot of

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256818257 The issue doesnt appear to occur on the previous version though the change should close the risk and also tests to work well. Testing did reveal that file listing logic doesn't work

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256803484 Verified behavior before was not correct. Verified behavior after is working as expected. Verified logic in provided example from NII-10532 before/after specifically for FTP processors.

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256603422 need to do some manual testing now on before/after. Have only walked through the code and made suggeste change. Will share details soon -- This is an automated message from the Apache