[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r997061283 ## libminifi/include/core/flow/StructuredConfiguration.h: ## @@ -0,0 +1,227 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r997051098 ## libminifi/src/core/flow/StructuredConfiguration.cpp: ## @@ -0,0 +1,896 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r980174559 ## libminifi/include/core/json/JsonConfiguration.h: ## @@ -0,0 +1,71 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r980160534 ## libminifi/include/core/flow/StructuredConfiguration.h: ## @@ -0,0 +1,234 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r979882035 ## libminifi/include/core/flow/README.md: ## @@ -0,0 +1,57 @@ +## Differences between JSON and YAML implementation + +### YAML + +The possible types of a

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r976409031 ## libminifi/include/Defaults.h: ## @@ -19,12 +19,14 @@ #ifdef WIN32 #define DEFAULT_NIFI_CONFIG_YML "\\conf\\config.yml" +#define DEFAULT_NIFI_CONFIG_JSON