cxzl25 commented on PR #1906:
URL: https://github.com/apache/orc/pull/1906#issuecomment-2071361180
Fix compilation failure via #1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cxzl25 opened a new pull request, #1907:
URL: https://github.com/apache/orc/pull/1907
### What changes were proposed in this pull request?
This PR aims to upgrade `commons-cli` to 1.7.0.
### Why are the changes needed?
Release 1.7.0 – 2024-04-13
[
https://issues.apache.org/jira/browse/ORC-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gang Wu reassigned ORC-1688:
Assignee: Yuanping Wu
> [C++] Do not access TZDB if there is no timestamp type
>
[
https://issues.apache.org/jira/browse/ORC-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gang Wu resolved ORC-1661.
--
Fix Version/s: 2.1.0
Resolution: Fixed
> [C++] Better handling when TZDB is unavailable
>
[
https://issues.apache.org/jira/browse/ORC-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gang Wu resolved ORC-1688.
--
Fix Version/s: 2.0.1
2.1.0
Resolution: Fixed
Issue resolved by pull request 1893
[
https://issues.apache.org/jira/browse/ORC-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gang Wu updated ORC-1661:
-
Fix Version/s: 2.0.1
> [C++] Better handling when TZDB is unavailable
>
[
https://issues.apache.org/jira/browse/ORC-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gang Wu resolved ORC-1690.
--
Fix Version/s: 2.1.0
Resolution: Fixed
> [C++] Refactor CMake to use imported thirdtparty libraries
>
wgtmac closed pull request #1893: ORC-1688: [C++] Do not access TZDB if there
is no timestamp type
URL: https://github.com/apache/orc/pull/1893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2071264602
@stiga-huang
On the Apache Impala side, we can remove
[FindOrc.cmake](https://github.com/apache/impala/blob/master/cmake_modules/FindOrc.cmake)
by doing following things:
- Add the
wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2071248675
Thanks for the check and feedback! @h-vetinari
For the 2nd patch, unfortunately it requires some additional change (not
just removing `STATIC` keyword). The only patch on the Conan
h-vetinari commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2071079098
> @h-vetinari @xhochy Could you help check if this breaks conda?
Thanks for the ping - happy to provide feedback and to try things out!
CC also @nehaljwani, who has been
deshanxiao commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2069529985
Hi @wgtmac I checked vcpkg and the previous patch can not apply any more:
```
-- Downloading https://github.com/wgtmac/orc/archive/ORC-1689.tar.gz ->
dependabot[bot] opened a new pull request, #1906:
URL: https://github.com/apache/orc/pull/1906
Bumps commons-cli:commons-cli from 1.6.0 to 1.7.0.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #1904:
URL: https://github.com/apache/orc/pull/1904
Bumps [org.bouncycastle:bcpkix-jdk18on](https://github.com/bcgit/bc-java)
from 1.78 to 1.78.1.
Commits
See full diff in https://github.com/bcgit/bc-java/commits;>compare view
wgtmac commented on code in PR #1893:
URL: https://github.com/apache/orc/pull/1893#discussion_r1574667774
##
c++/src/Timezone.cc:
##
@@ -691,12 +683,68 @@ namespace orc {
try {
std::unique_ptr file = readFile(filename);
size_t size =
dependabot[bot] opened a new pull request, #1905:
URL: https://github.com/apache/orc/pull/1905
Bumps
[org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin)
from 3.4.0 to 3.4.1.
Release notes
Sourced from
dependabot[bot] opened a new pull request, #1903:
URL: https://github.com/apache/orc/pull/1903
Bumps
[org.threeten:threeten-extra](https://github.com/ThreeTen/threeten-extra) from
1.7.1 to 1.8.0.
Release notes
Sourced from
wgtmac commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1574452384
##
cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -132,6 +154,9 @@ else ()
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
add_built_library (snappy_ep orc_snappy
wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2068945756
cc @dongjoon-hyun @stiga-huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kou commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1574440859
##
cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -132,6 +154,9 @@ else ()
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
add_built_library (snappy_ep orc_snappy
wgtmac commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1574429589
##
cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -132,6 +154,9 @@ else ()
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
add_built_library (snappy_ep orc_snappy
kou commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1574421813
##
cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -132,6 +154,9 @@ else ()
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
add_built_library (snappy_ep orc_snappy
cxzl25 opened a new pull request, #1902:
URL: https://github.com/apache/orc/pull/1902
### What changes were proposed in this pull request?
This PR aims to fix `IllegalArgumentException` when reading json timestamp
type in bechmark.
### Why are the changes needed?
ORC-1191
dongjoon-hyun closed issue #1901: ORC-1696: Fix ClassCastException when reading
avro decimal type in bechmark
URL: https://github.com/apache/orc/issues/1901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dongjoon-hyun commented on issue #1901:
URL: https://github.com/apache/orc/issues/1901#issuecomment-2068761604
This is resolved via
https://github.com/apache/orc/commit/1f20fd627570b15cbcbed175a9caf6aec56102ee
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on issue #1900:
URL: https://github.com/apache/orc/issues/1900#issuecomment-2068759759
This is resolved via
https://github.com/apache/orc/commit/506b34165ba98404e9cc43c6e55b966957e92c9c
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun closed issue #1900: ORC-1696: Fix ClassCastException when reading
avro decimal type in bechmark
URL: https://github.com/apache/orc/issues/1900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dongjoon-hyun commented on issue #1899:
URL: https://github.com/apache/orc/issues/1899#issuecomment-2068757637
This is resolved via
https://github.com/apache/orc/commit/e21eafa1eac1e770d1642bec2bb7f8ffc885fb12
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun closed issue #1899: ORC-1696: Fix ClassCastException when reading
avro decimal type in bechmark
URL: https://github.com/apache/orc/issues/1899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/ORC-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun resolved ORC-1696.
Fix Version/s: 1.9.4
1.8.8
1.7.11
2.0.1
dongjoon-hyun commented on PR #1898:
URL: https://github.com/apache/orc/pull/1898#issuecomment-2068755162
Merged to main/2.0/1.9/1.8/1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/ORC-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun updated ORC-1696:
---
Issue Type: Bug (was: Improvement)
> Fix ClassCastException when reading avro decimal type in
dongjoon-hyun closed pull request #1898: ORC-1696: Fix ClassCastException when
reading avro decimal type in bechmark
URL: https://github.com/apache/orc/pull/1898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/ORC-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun reassigned ORC-1696:
--
Assignee: dzcxzl
> Fix ClassCastException when reading avro decimal type in bechmark
>
dongjoon-hyun commented on PR #1896:
URL: https://github.com/apache/orc/pull/1896#issuecomment-2068743287
Thanks. If we can run the Hive benchmark without any issues, yes, we can
upgrade this. :)
--
This is an automated message from the Apache Git Service.
To respond to the message,
wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2068729308
@h-vetinari Could you help check if this breaks conda? I saw there are some
patches https://github.com/conda-forge/orc-feedstock/tree/main/recipe/patches.
Is it possible to add
wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2068726019
@deshanxiao Could you help check if this breaks vcpkg? Is it possible to add
`ORC_PACKAGE_KIND=vcpkg` to remove the patch file
cxzl25 commented on code in PR #1898:
URL: https://github.com/apache/orc/pull/1898#discussion_r1574287229
##
java/bench/core/src/java/org/apache/orc/bench/core/convert/avro/AvroReader.java:
##
@@ -201,7 +202,11 @@ public void convert(ColumnVector cv, int row, Object
value) {
wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2068694134
Finally I make it work for all modes (vendored, providing XXX_HOME, or
conan) and this is ready for review. Would you mind taking a look at this
again? @kou
--
This is an automated
cxzl25 opened a new pull request, #1898:
URL: https://github.com/apache/orc/pull/1898
### What changes were proposed in this pull request?
This PR aims to fix `ClassCastException` when reading avro decimal type in
bechmark.
### Why are the changes needed?
ORC-1191 Forcing
cxzl25 commented on PR #1896:
URL: https://github.com/apache/orc/pull/1896#issuecomment-2068661059
> I checked Apache Spark master branch too. Apache Spark 4.0.0 will use old
gson too still
Thanks to dongjoon for mentioning this.
> Is this compatible?
I noticed that
41 matches
Mail list logo
