ffacs commented on PR #1915:
URL: https://github.com/apache/orc/pull/1915#issuecomment-2080356385
> Got it. Are these all leftovers due to the recent variable renaming change?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun commented on PR #1915:
URL: https://github.com/apache/orc/pull/1915#issuecomment-2080345557
Feel free to merge, @wgtmac ~ :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wgtmac commented on PR #1910:
URL: https://github.com/apache/orc/pull/1910#issuecomment-2080342459
Should we use INT32 and INT64 for decimals where applicable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun merged PR #17:
URL: https://github.com/apache/orc-format/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ffacs opened a new pull request, #1915:
URL: https://github.com/apache/orc/pull/1915
### What changes were proposed in this pull request?
1. Fix build break w/ BUILD_CPP_ENABLE_METRICS=ON
2. Add -DBUILD_CPP_ENABLE_METRICS=ON on format check actions.
3. Fix a typo on README file
dongjoon-hyun commented on code in PR #1910:
URL: https://github.com/apache/orc/pull/1910#discussion_r1581243641
##
java/bench/core/src/resources/taxi.schema:
##
@@ -9,13 +9,13 @@ struct<
PULocationID: bigint,
DOLocationID: bigint,
payment_type: bigint,
- fare_amount:
dongjoon-hyun commented on PR #1896:
URL: https://github.com/apache/orc/pull/1896#issuecomment-2079677311
Since this is blocked by the others, I'll put it to `Draft` status to avoid
any accidental merging.
> I can retest after
[ORC-1697](https://issues.apache.org/jira/browse/ORC-1697)
[
https://issues.apache.org/jira/browse/ORC-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun reassigned ORC-1705:
--
Assignee: dzcxzl
> Upgrade `zstd-jni` to 1.5.6-3
> -
>
>
[
https://issues.apache.org/jira/browse/ORC-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun resolved ORC-1705.
Fix Version/s: 2.0.1
2.1.0
Resolution: Fixed
Issue resolved by pull
dongjoon-hyun commented on PR #1914:
URL: https://github.com/apache/orc/pull/1914#issuecomment-2079675413
Merged to main/2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on PR #1914:
URL: https://github.com/apache/orc/pull/1914#issuecomment-2079675260
Thank you, @cxzl25 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun closed pull request #1914: ORC-1705: Upgrade `zstd-jni` to 1.5.6-3
URL: https://github.com/apache/orc/pull/1914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wgtmac commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1581223823
##
c++/orcConfig.cmake.in:
##
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
stiga-huang commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1581136738
##
c++/orcConfig.cmake.in:
##
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
14 matches
Mail list logo
