ankitsinghal commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679463373
+1,
@richardantal , should we have a backport ticket for this?
This is an automated message
[
https://issues.apache.org/jira/browse/PHOENIX-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183678#comment-17183678
]
Lars Hofhansl commented on PHOENIX-6101:
[~kozdemir] please have a careful look.
> Avoid
brfrn169 commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679442764
@ankitsinghal @stoty @joshelser I just modified the patch. Can you please
review this?
Also, I posted the steps to reproduce the issue to the Jira:
[
https://issues.apache.org/jira/browse/PHOENIX-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183656#comment-17183656
]
Toshihiro Suzuki commented on PHOENIX-6098:
---
{quote}
Do you have an example SQL query which
[
https://issues.apache.org/jira/browse/PHOENIX-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183649#comment-17183649
]
Geoffrey Jacoby commented on PHOENIX-5881:
--
[~elserj] - it's a port of existing logic in 4.x
[
https://issues.apache.org/jira/browse/PHOENIX-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183637#comment-17183637
]
Josh Elser commented on PHOENIX-5881:
-
{code:java}
+if (!isMaxLookbackSupported) {
+
brfrn169 commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679406787
@ankitsinghal @stoty Ah, okay. Thank you for pointing that out. I will
modify this patch and apply the fix to phoenix-hive3.
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183602#comment-17183602
]
Kadir OZDEMIR commented on PHOENIX-6090:
I think 4.x and master are the only ones we need to
ankitsinghal commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679329841
yes, that makes sense, thanks @stoty for clarification, I didn't know that
we have Hive3 connector separately. Changes look good to me for phoenix-hive3
(and for
[
https://issues.apache.org/jira/browse/PHOENIX-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183551#comment-17183551
]
Josh Elser commented on PHOENIX-6098:
-
{quote}It's very hard to add tests to phoenix-hive module of
[
https://issues.apache.org/jira/browse/PHOENIX-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183539#comment-17183539
]
Istvan Toth commented on PHOENIX-6056:
--
Jenkins tries to run the builds on windows hosts.
Pushed
stoty commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679294453
@richardantal has recently resurrected the Hive 3 connector from the old
master branch with various fixes,
and is working on backporting it to Hive 2 for 4.x.
So
ankitsinghal commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679291484
It seems HIVE-11398 introduced the change where GenericUDFOPAnd can expect
more than 2 arguments but Phoenix still uses Hive 1.2.1
[
https://issues.apache.org/jira/browse/PHOENIX-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183501#comment-17183501
]
Geoffrey Jacoby commented on PHOENIX-6069:
--
+1
> We should check that the parent table key is
[
https://issues.apache.org/jira/browse/PHOENIX-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183480#comment-17183480
]
Swaroopa Kadam commented on PHOENIX-5946:
-
Thanks for pointing out [~stoty]. I ll push the
[
https://issues.apache.org/jira/browse/PHOENIX-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183451#comment-17183451
]
Lars Hofhansl commented on PHOENIX-6097:
Pushed to 4.x and master to cover the PHOENIX-6090
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183437#comment-17183437
]
Lars Hofhansl commented on PHOENIX-6094:
Hi [~stoty] , first thanks for working on this (fixing
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183415#comment-17183415
]
Lars Hofhansl commented on PHOENIX-6064:
{quote}Anyone who wants to make Tephra work can show
stoty commented on pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27#issuecomment-679216015
You're going to need to rebase this for the tests to pass, to get the
changes from Phoenix-6100, @brfrn169
stoty closed pull request #28:
URL: https://github.com/apache/phoenix-connectors/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stoty closed pull request #852:
URL: https://github.com/apache/phoenix/pull/852
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
stoty closed pull request #863:
URL: https://github.com/apache/phoenix/pull/863
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
richardantal commented on pull request #28:
URL: https://github.com/apache/phoenix-connectors/pull/28#issuecomment-679198679
@stoty Could you review this change please?
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/PHOENIX-6099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183374#comment-17183374
]
Richard Antal commented on PHOENIX-6099:
Nice job [~stoty], it fixes this issue.
LGTM
>
[
https://issues.apache.org/jira/browse/PHOENIX-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183310#comment-17183310
]
Istvan Toth commented on PHOENIX-5946:
--
[~swaroopa] I finally got PreCommit running, and it shows
[
https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183307#comment-17183307
]
Richard Antal commented on PHOENIX-6091:
Yes, adding an entry for 4.16 seems to solve this is
[
https://issues.apache.org/jira/browse/PHOENIX-6099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183305#comment-17183305
]
Hadoop QA commented on PHOENIX-6099:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183267#comment-17183267
]
Hadoop QA commented on PHOENIX-6056:
{color:red}-1 overall{color}. Here are the results of testing
richardantal opened a new pull request #28:
URL: https://github.com/apache/phoenix-connectors/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/PHOENIX-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183172#comment-17183172
]
Istvan Toth commented on PHOENIX-6056:
--
Changed the multibranch job to always wipe the workspace
stoty opened a new pull request #863:
URL: https://github.com/apache/phoenix/pull/863
…verify
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/PHOENIX-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183123#comment-17183123
]
Istvan Toth commented on PHOENIX-6089:
--
[~larsh] you need to add the branch name to the attachment
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183114#comment-17183114
]
Istvan Toth commented on PHOENIX-6094:
--
[~larsh] It seems that the precommit job is started with a
[
https://issues.apache.org/jira/browse/PHOENIX-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183046#comment-17183046
]
Toshihiro Suzuki commented on PHOENIX-6098:
---
CC: [~elserj] [~an...@apache.org]
>
[
https://issues.apache.org/jira/browse/PHOENIX-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183042#comment-17183042
]
Toshihiro Suzuki edited comment on PHOENIX-6098 at 8/24/20, 8:13 AM:
[
https://issues.apache.org/jira/browse/PHOENIX-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183042#comment-17183042
]
Toshihiro Suzuki commented on PHOENIX-6098:
---
I created a PR for this. It's very hard to add
brfrn169 opened a new pull request #27:
URL: https://github.com/apache/phoenix-connectors/pull/27
…es and residual predicates
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183000#comment-17183000
]
Istvan Toth commented on PHOENIX-6064:
--
I've noticed that I mixed up Tephra and Guava in my
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175356#comment-17175356
]
Istvan Toth edited comment on PHOENIX-6064 at 8/24/20, 7:20 AM:
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182975#comment-17182975
]
Istvan Toth commented on PHOENIX-6094:
--
[~larsh] Can you show me a recent example where the
40 matches
Mail list logo
