[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186129#comment-17186129 ] Josh Elser commented on PHOENIX-6107: - A belated +1 on doing this. Thanks for suggesting Lars and

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186055#comment-17186055 ] Lars Hofhansl commented on PHOENIX-6107: Awesome! Thanks for coming up with a better patch than

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186000#comment-17186000 ] Lars Hofhansl commented on PHOENIX-6107: Yep. I don't think it's related. I'm still +1 on your

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185999#comment-17185999 ] Istvan Toth commented on PHOENIX-6107: -- That is unrelated to this one, we are getting quite a lot

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185996#comment-17185996 ] Lars Hofhansl commented on PHOENIX-6107: Looks like build 61 failed with java.sql.SQLException:

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185976#comment-17185976 ] Lars Hofhansl commented on PHOENIX-6107: Cool. Let's commit the rest :) > Discuss speed up of

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185948#comment-17185948 ] Istvan Toth commented on PHOENIX-6107: -- It's not. I mixed up the source tabs, I'll revert it. >

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185944#comment-17185944 ] Lars Hofhansl commented on PHOENIX-6107: Why is the change to BasePermissionsIT needed? >

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185943#comment-17185943 ] Lars Hofhansl commented on PHOENIX-6107: Nice! And runtime is still under 2h. Patch looks good

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185933#comment-17185933 ] Hadoop QA commented on PHOENIX-6107: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185864#comment-17185864 ] Istvan Toth commented on PHOENIX-6107: -- I've uploaded the @BeforeParam patch.  The basic idea is

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185657#comment-17185657 ] Istvan Toth commented on PHOENIX-6107: -- All we need to do is move the table initialization from

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185654#comment-17185654 ] Istvan Toth commented on PHOENIX-6107: -- I've debugged into this test, and got quite a shock.

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185630#comment-17185630 ] Lars Hofhansl commented on PHOENIX-6107: The entire suite finished in less then 2h. It's

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185614#comment-17185614 ] Hadoop QA commented on PHOENIX-6107: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185602#comment-17185602 ] Istvan Toth commented on PHOENIX-6107: -- Most of the tests modify the table contents in some way,

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185597#comment-17185597 ] Istvan Toth commented on PHOENIX-6107: -- I'm going to test, and make a patch for consolidating the

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185593#comment-17185593 ] Lars Hofhansl commented on PHOENIX-6107: That's a good call. Not a fan of giant classes, but

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185591#comment-17185591 ] Istvan Toth commented on PHOENIX-6107: -- AFAICT Precommit-Admin does exactly the same thing as

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185589#comment-17185589 ] Istvan Toth commented on PHOENIX-6107: -- These tests are relatively small (code line wise), and as

[jira] [Commented] (PHOENIX-6107) Discuss speed up of BaseQueryIT

[ https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185587#comment-17185587 ] Lars Hofhansl commented on PHOENIX-6107: Looks like precommit is broken... Trunk compilation