[jira] [Commented] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640882#comment-16640882 ] Tsz Wo Nicholas Sze commented on RATIS-337: --- r337_20181007.patch: updated with trunk. > In

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: (was: r337_20181006b.patch) > In RaftServerImpl,

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: r337_20181007.patch > In RaftServerImpl, leaderState/heartbeatMonitor may

[jira] [Updated] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-341: -- Attachment: RATIS-341.003_committed.patch > Raft log index on the follower should be

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640878#comment-16640878 ] Tsz Wo Nicholas Sze commented on RATIS-341: --- +1 the 003 patch looks good except that the

[jira] [Commented] (RATIS-274) Read/Write-path of log stream state machine

2018-10-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640849#comment-16640849 ] Ted Yu commented on RATIS-274: -- {code} + LogStream createLog(LogName name, LogServiceConfiguration config);

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640847#comment-16640847 ] Hadoop QA commented on RATIS-341: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Updated] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-341: Attachment: (was: RATIS-341.002.patch) > Raft log index on the follower should be

[jira] [Updated] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-341: Attachment: RATIS-341.003.patch > Raft log index on the follower should be applied to state

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640793#comment-16640793 ] Mukul Kumar Singh commented on RATIS-341: - Thanks for the review [~szetszwo]. Patch v3 fixes the

[jira] [Commented] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640683#comment-16640683 ] Hadoop QA commented on RATIS-337: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640681#comment-16640681 ] Tsz Wo Nicholas Sze commented on RATIS-337: --- Oops, the last patch does not compile.

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: r337_20181006b.patch > In RaftServerImpl, leaderState/heartbeatMonitor may

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: (was: r337_20181006.patch) > In RaftServerImpl,

[jira] [Commented] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640680#comment-16640680 ] Hadoop QA commented on RATIS-337: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: r337_20181006.patch > In RaftServerImpl, leaderState/heartbeatMonitor may

[jira] [Commented] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640679#comment-16640679 ] Tsz Wo Nicholas Sze commented on RATIS-337: --- r337_20181006.patch: fixes some bugs. > In

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: (was: r337_20181006.patch) > In RaftServerImpl,

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: (was: r337_20181002.patch) > In RaftServerImpl,

[jira] [Updated] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-337: -- Attachment: r337_20181006.patch > In RaftServerImpl, leaderState/heartbeatMonitor may

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640661#comment-16640661 ] Tsz Wo Nicholas Sze commented on RATIS-341: --- > ..., why do we need to change LeaderState? In

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640653#comment-16640653 ] Mukul Kumar Singh commented on RATIS-341: - Thanks for the review [~szetszwo]. The changes in

[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640652#comment-16640652 ] Hadoop QA commented on RATIS-262: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640648#comment-16640648 ] Tsz Wo Nicholas Sze commented on RATIS-341: --- The change in RaftServerImpl looks good. However,

[jira] [Commented] (RATIS-337) In RaftServerImpl, leaderState/heartbeatMonitor may be accessed without proper null check

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640647#comment-16640647 ] Hadoop QA commented on RATIS-337: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640643#comment-16640643 ] Tsz Wo Nicholas Sze commented on RATIS-262: --- r262_20181006.patch: fix/suppress warnings. There

[jira] [Assigned] (RATIS-262) Fix compilation warning and deprecated api usage

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reassigned RATIS-262: - Assignee: Tsz Wo Nicholas Sze > Fix compilation warning and deprecated api usage

[jira] [Updated] (RATIS-262) Fix compilation warning and deprecated api usage

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-262: -- Attachment: r262_20181006.patch > Fix compilation warning and deprecated api usage >

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640631#comment-16640631 ] Shashikant Banerjee commented on RATIS-341: --- Thanks [~msingh] for the patch and offline