[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668849#comment-16668849 ] Ted Yu commented on RATIS-377: -- bq. How could this be possible? May I know how the contents of HEADER_BYTES

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668147#comment-16668147 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- > It seems if HEADER_BYTES_CLONE is modified. ...

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667813#comment-16667813 ] Ted Yu commented on RATIS-377: -- In LogSegment#loadSegment : {code} if (entryCount == 0) { // The

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1766#comment-1766 ] Jitendra Nath Pandey commented on RATIS-377: +1 for the latest patch. > Tolerate partially

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1755#comment-1755 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- In the original code, we do preallocation (i.e.

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1598#comment-1598 ] Jitendra Nath Pandey commented on RATIS-377: {code:java} if

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1415#comment-1415 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1406#comment-1406 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181028c.patch: adds multiple attempts in

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1369#comment-1369 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1357#comment-1357 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181028b.patch: It should be "!= -1" in

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1340#comment-1340 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1328#comment-1328 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181028.patch: addresses [~jnp]'s comments.

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1327#comment-1327 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- Oops, I forgot that isTerminator is also used by

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1307#comment-1307 ] Jitendra Nath Pandey commented on RATIS-377: Thanks for the patch [~szetszwo], a few comments.

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1254#comment-1254 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1245#comment-1245 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181027b.patch: fixes a bug. > Tolerate

[jira] [Commented] (RATIS-377) Tolerate partially written log header

[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1200#comment-1200 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||