[ https://issues.apache.org/jira/browse/SPARK-34943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414616#comment-17414616 ]
Shane Knapp edited comment on SPARK-34943 at 9/13/21, 10:15 PM: ---------------------------------------------------------------- flake8 tests passing w/3.8.0! from [https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143223] {noformat} ======================================================================== Running Python style checks ======================================================================== starting python compilation test... python compilation succeeded. downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.7.0/pycodestyle.py... starting pycodestyle test... pycodestyle checks passed. starting flake8 test... flake8 checks passed. The mypy command was not found. Skipping for now. all lint-python tests passed!{noformat} checking on the jenkins worker directly: {noformat} (py36) jenkins@research-jenkins-worker-08:~/workspace$ grep MINIMUM_FLAKE8 SparkPullRequestBuilder/dev/lint-python MINIMUM_FLAKE8="3.8.0" {noformat} was (Author: shaneknapp): flake8 tests passing w/3.8.0! from [https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143223] {noformat} ======================================================================== Running Python style checks ======================================================================== starting python compilation test... python compilation succeeded. downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.7.0/pycodestyle.py... starting pycodestyle test... pycodestyle checks passed. starting flake8 test... flake8 checks passed. The mypy command was not found. Skipping for now. all lint-python tests passed!{noformat} checking on the jenkins worker directly: {noformat} (py36) jenkins@research-jenkins-worker-08:~/workspace$ grep MINIMUM_FLAKE8 SparkPullRequestBuilder/dev/lint-python MINIMUM_FLAKE8="3.8.0" {noformat} > Upgrade flake8 to 3.8.0 or above in Jenkins > ------------------------------------------- > > Key: SPARK-34943 > URL: https://issues.apache.org/jira/browse/SPARK-34943 > Project: Spark > Issue Type: Improvement > Components: PySpark > Affects Versions: 3.2.0 > Reporter: Haejoon Lee > Assignee: Shane Knapp > Priority: Major > > In flake8 < 3.8.0, F401 error occurs for imports in *if* statements when > TYPE_CHECKING is True. However, TYPE_CHECKING is always False at runtime, so > there is no need to treat it as an error in static analysis. > Since this behavior is fixed In flake8 >= 3.8.0, we should upgrade the flake8 > installed in Jenkins to 3.8.0 or above. Otherwise, it occurs F401 error for > several lines in pandas-on-PySpark that uses TYPE_CHECKING. > And also we might update the {{MINIMUM_FLAKE8}} in the {{lint-python}} from > 3.5.0 to 3.8.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org