[ 
https://issues.apache.org/jira/browse/SPARK-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981819#comment-13981819
 ] 

Nan Zhu commented on SPARK-1299:
--------------------------------

addressed in https://github.com/apache/spark/pull/186

> making comments of RDD.doCheckpoint consistent with its usage
> -------------------------------------------------------------
>
>                 Key: SPARK-1299
>                 URL: https://issues.apache.org/jira/browse/SPARK-1299
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 1.0.0
>            Reporter: Nan Zhu
>            Assignee: Nan Zhu
>            Priority: Trivial
>             Fix For: 1.0.0
>
>
> another trivial thing I found occasionally, the comments of function is 
> saying that
> /**
>    * Performs the checkpointing of this RDD by saving this. It is called by 
> the DAGScheduler
>    * after a job using this RDD has completed (therefore the RDD has been 
> materialized and
>    * potentially stored in memory). doCheckpoint() is called recursively on 
> the parent RDDs.
>    */
> actually this function is called in SparkContext.runJob
> we can either change the comments or call it in DAGScheduler, I personally 
> prefer the later one, as this calling seems like a auto-checkpoint , better 
> put it in a non-user-facing component



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to