[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309666#comment-14309666
]
Josh Rosen commented on SPARK-4877:
---
I've gone ahead and committed this PR because it
[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305810#comment-14305810
]
holdenk commented on SPARK-4877:
Hi Matt,
I don't believe we need to override loadClass,
[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306104#comment-14306104
]
Stephen Haberman commented on SPARK-4877:
-
Hi Matt,
I know about the
[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306082#comment-14306082
]
Matt Whelan commented on SPARK-4877:
Overriding only findClass ignores caching, which
[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288945#comment-14288945
]
Stephen Haberman commented on SPARK-4877:
-
Hi Matt,
I don't doubt you are right,
[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288023#comment-14288023
]
Matthew Whelan commented on SPARK-4877:
---
Looking at the PR, you're still overriding
[
https://issues.apache.org/jira/browse/SPARK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257855#comment-14257855
]
Stephen Haberman commented on SPARK-4877:
-
FWIW two reviewers have okay'd this PR;