Josh Rosen created SPARK-15975:
----------------------------------
Summary: Improper Popen.wait() return code handling in
dev/run-tests
Key: SPARK-15975
URL: https://issues.apache.org/jira/browse/SPARK-15975
Project: Spark
Issue Type: Bug
Components: Project Infra
Affects Versions: 1.6.0
Reporter: Josh Rosen
Assignee: Josh Rosen
In dev/run-tests.py there's a line where we effectively do
{code}
retcode = some_popen_instance.wait()
if retcode > 0:
err
# else do nothing
{code}
but this code is subtlety wrong because Popen's return code will be negative if
the child process was terminated by a signal:
https://docs.python.org/2/library/subprocess.html#subprocess.Popen.returncode
We should change this to {{retcode != 0}} so that we properly error out and
exit due to termination by signal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
