yuhao yang created SPARK-18901:
----------------------------------

             Summary: Require in LR LogisticAggregator is redundant
                 Key: SPARK-18901
                 URL: https://issues.apache.org/jira/browse/SPARK-18901
             Project: Spark
          Issue Type: Improvement
            Reporter: yuhao yang
            Priority: Minor


require(numFeatures == features.size, ....)
require(weight >= 0.0, ...)

in LogisticAggregator (add and merge) will never be triggered as the dimension 
and weight has been checked in MultivariateOnlineSummarizer. 

Given the frequent usage of function add, the redundant require should be 
removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to