[
https://issues.apache.org/jira/browse/SPARK-46584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SPARK-46584:
-----------------------------------
Labels: pull-request-available (was: )
> Remove invalid attachCleanupResourceChecker in JoinSuite
> --------------------------------------------------------
>
> Key: SPARK-46584
> URL: https://issues.apache.org/jira/browse/SPARK-46584
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 3.5.0
> Reporter: Mingliang Zhu
> Priority: Major
> Labels: pull-request-available
>
> AttachCleanupResourceChecker in JoinSuite is invalid:
> 1. The matching of SortExec needs to be in `QueryExecution.executePlan` not
> `QueryExecution.sparkPlan`, The correct way is
> `foreachUp(df.queryExecution.executedPlan)\{f()}`.
> 2. `Mockito` counts the number of function calls, only for objects after
> `spy`. Calls to the original object are not counted. Therefore, when using
> df.queryExecution.executedPlan correctly to match, count is always 0.
> 3. Not all SortMergeJoin joinTypes will trigger cleanupResources(), such as
> 'full outer join'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
