[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313760#comment-16313760
]
Joseph K. Bradley commented on SPARK-13030:
---
Merged https://github.com/apache/spark/pull/20132
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307333#comment-16307333
]
Apache Spark commented on SPARK-13030:
--
User 'jkbradley' has created a pull request for this issue:
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227094#comment-16227094
]
yuhao yang commented on SPARK-13030:
I see. Thanks for the response [~mlnick].
The Estimator is
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226448#comment-16226448
]
Nick Pentreath commented on SPARK-13030:
I just think it makes sense for OHE to be an Estimator
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226307#comment-16226307
]
yuhao yang commented on SPARK-13030:
Sorry to jumping in so late. I can see there's been a lot of
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209203#comment-16209203
]
Liang-Chi Hsieh commented on SPARK-13030:
-
[~josephkb] I think as we add a new class, it is
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209018#comment-16209018
]
Apache Spark commented on SPARK-13030:
--
User 'viirya' has created a pull request for this issue:
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208607#comment-16208607
]
Joseph K. Bradley commented on SPARK-13030:
---
Does multi-column support need to be put in this
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196717#comment-16196717
]
Weichen Xu commented on SPARK-13030:
[~bago.amirbekian]
Multi-column means generate separated columns
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196478#comment-16196478
]
zhengruifeng commented on SPARK-13030:
--
[~bago.amirbekian] Agree that it should support
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193389#comment-16193389
]
Bago Amirbekian commented on SPARK-13030:
-
Just so I'm clear, does multi-column in this context
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180114#comment-16180114
]
Weichen Xu commented on SPARK-13030:
+1 for multi column support.
> Change OneHotEncoder to
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180090#comment-16180090
]
Liang-Chi Hsieh commented on SPARK-13030:
-
Yes. I can do it.
> Change OneHotEncoder to
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180073#comment-16180073
]
Nick Pentreath commented on SPARK-13030:
Yes definitely needs to support multi column. [~viirya]
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180059#comment-16180059
]
zhengruifeng commented on SPARK-13030:
--
[~WeichenXu123] Just a suggestion, current impl only support
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180022#comment-16180022
]
Weichen Xu commented on SPARK-13030:
+1 changing name to OneHotEncoderEstimator
I can work on this
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179460#comment-16179460
]
Joseph K. Bradley commented on SPARK-13030:
---
I agree there are several cases in MLlib of
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178554#comment-16178554
]
zhengruifeng commented on SPARK-13030:
--
Agree that we create another estimator and rename it
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177939#comment-16177939
]
Nick Pentreath commented on SPARK-13030:
It's ugly but we can introduce a new class
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176534#comment-16176534
]
Weichen Xu commented on SPARK-13030:
[~josephkb] What about create a new name estimator for this ? It
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175833#comment-16175833
]
zhengruifeng commented on SPARK-13030:
--
I approve that one-hot encoder should be a estimtor, and
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431319#comment-15431319
]
Nick Pentreath commented on SPARK-13030:
Yes I also agree OHE needs to be an {{Estimator}} in
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186722#comment-15186722
]
Wojciech Jurczyk commented on SPARK-13030:
--
I am not sure if I get you correctly. Are you
[
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174685#comment-15174685
]
Joseph K. Bradley commented on SPARK-13030:
---
I agree this is an issue, but I think we need to
24 matches
Mail list logo
