[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2017-02-10 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862298#comment-15862298 ] Apache Spark commented on SPARK-17897: -- User 'gatorsmile' has created a pull request for this issue:

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706606#comment-15706606 ] Apache Spark commented on SPARK-17897: -- User 'gatorsmile' has created a pull request for this issue:

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706086#comment-15706086 ] Xiao Li commented on SPARK-17897: - My first PR does not cover all the cases. Found the root cause. The

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705627#comment-15705627 ] Liang-Chi Hsieh commented on SPARK-17897: - And I think Attribute is the input of itself? > not

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705621#comment-15705621 ] Liang-Chi Hsieh commented on SPARK-17897: - I think the original idea should be, in

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Wenchen Fan (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705342#comment-15705342 ] Wenchen Fan commented on SPARK-17897: - oh sorry the web page was not refreshed and I did see you

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Wenchen Fan (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705318#comment-15705318 ] Wenchen Fan commented on SPARK-17897: - After looking at the code, why we make `Attribute` extends

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705036#comment-15705036 ] Apache Spark commented on SPARK-17897: -- User 'cloud-fan' has created a pull request for this issue:

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-29 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704608#comment-15704608 ] Apache Spark commented on SPARK-17897: -- User 'gatorsmile' has created a pull request for this issue:

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-28 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704547#comment-15704547 ] Xiao Li commented on SPARK-17897: - Actually, the fix is super simple. Just one line. > not isnotnull is

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-28 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704486#comment-15704486 ] Xiao Li commented on SPARK-17897: - I can reproduce it. Will fix it tomorrow. Thanks for reporting this!

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-28 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704347#comment-15704347 ] Xiao Li commented on SPARK-17897: - Let me try to reproduce it in master > not isnotnull is converted to

[jira] [Commented] (SPARK-17897) not isnotnull is converted to the always false condition isnotnull && not isnotnull

2016-11-28 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704335#comment-15704335 ] Reynold Xin commented on SPARK-17897: - cc [~cloud_fan], [~smilegator], [~hvanhovell] > not isnotnull