[jira] [Commented] (SPARK-20246) Should check determinism when pushing predicates down through aggregation
[
https://issues.apache.org/jira/browse/SPARK-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960432#comment-15960432
]
Apache Spark commented on SPARK-20246:
--
User 'cloud-fan' has created a pull request for this issue:
https://github.com/apache/spark/pull/17562
> Should check determinism when pushing predicates down through aggregation
> -
>
> Key: SPARK-20246
> URL: https://issues.apache.org/jira/browse/SPARK-20246
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Weiluo Ren
> Labels: correctness
>
> {code}import org.apache.spark.sql.functions._
> spark.range(1,1000).distinct.withColumn("random",
> rand()).filter(col("random") > 0.3).orderBy("random").show{code}
> gives wrong result.
> In the optimized logical plan, it shows that the filter with the
> non-deterministic predicate is pushed beneath the aggregate operator, which
> should not happen.
> cc [~lian cheng]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20246) Should check determinism when pushing predicates down through aggregation
[
https://issues.apache.org/jira/browse/SPARK-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960329#comment-15960329
]
Apache Spark commented on SPARK-20246:
--
User 'viirya' has created a pull request for this issue:
https://github.com/apache/spark/pull/17559
> Should check determinism when pushing predicates down through aggregation
> -
>
> Key: SPARK-20246
> URL: https://issues.apache.org/jira/browse/SPARK-20246
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Weiluo Ren
> Labels: correctness
>
> {code}import org.apache.spark.sql.functions._
> spark.range(1,1000).distinct.withColumn("random",
> rand()).filter(col("random") > 0.3).orderBy("random").show{code}
> gives wrong result.
> In the optimized logical plan, it shows that the filter with the
> non-deterministic predicate is pushed beneath the aggregate operator, which
> should not happen.
> cc [~lian cheng]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20246) Should check determinism when pushing predicates down through aggregation
[
https://issues.apache.org/jira/browse/SPARK-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960325#comment-15960325
]
Liang-Chi Hsieh commented on SPARK-20246:
-
For union and window, we don't have the replacement of expression. So I think
they should be safe.
> Should check determinism when pushing predicates down through aggregation
> -
>
> Key: SPARK-20246
> URL: https://issues.apache.org/jira/browse/SPARK-20246
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Weiluo Ren
> Labels: correctness
>
> {code}import org.apache.spark.sql.functions._
> spark.range(1,1000).distinct.withColumn("random",
> rand()).filter(col("random") > 0.3).orderBy("random").show{code}
> gives wrong result.
> In the optimized logical plan, it shows that the filter with the
> non-deterministic predicate is pushed beneath the aggregate operator, which
> should not happen.
> cc [~lian cheng]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20246) Should check determinism when pushing predicates down through aggregation
[
https://issues.apache.org/jira/browse/SPARK-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960300#comment-15960300
]
Liang-Chi Hsieh commented on SPARK-20246:
-
We should also check determinism of the [replaced
expression|https://github.com/apache/spark/blob/a4491626ed8169f0162a0dfb78736c9b9e7fb434/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L810].
> Should check determinism when pushing predicates down through aggregation
> -
>
> Key: SPARK-20246
> URL: https://issues.apache.org/jira/browse/SPARK-20246
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Weiluo Ren
> Labels: correctness
>
> {code}import org.apache.spark.sql.functions._
> spark.range(1,1000).distinct.withColumn("random",
> rand()).filter(col("random") > 0.3).orderBy("random").show{code}
> gives wrong result.
> In the optimized logical plan, it shows that the filter with the
> non-deterministic predicate is pushed beneath the aggregate operator, which
> should not happen.
> cc [~lian cheng]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20246) Should check determinism when pushing predicates down through aggregation
[
https://issues.apache.org/jira/browse/SPARK-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960287#comment-15960287
]
Liang-Chi Hsieh commented on SPARK-20246:
-
Seems we have checked determinism in
[here|https://github.com/apache/spark/blob/a4491626ed8169f0162a0dfb78736c9b9e7fb434/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L805].
> Should check determinism when pushing predicates down through aggregation
> -
>
> Key: SPARK-20246
> URL: https://issues.apache.org/jira/browse/SPARK-20246
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Weiluo Ren
> Labels: correctness
>
> {code}import org.apache.spark.sql.functions._
> spark.range(1,1000).distinct.withColumn("random",
> rand()).filter(col("random") > 0.3).orderBy("random").show{code}
> gives wrong result.
> In the optimized logical plan, it shows that the filter with the
> non-deterministic predicate is pushed beneath the aggregate operator, which
> should not happen.
> cc [~lian cheng]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20246) Should check determinism when pushing predicates down through aggregation
[
https://issues.apache.org/jira/browse/SPARK-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959946#comment-15959946
]
Cheng Lian commented on SPARK-20246:
[This
line|https://github.com/apache/spark/blob/a4491626ed8169f0162a0dfb78736c9b9e7fb434/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L795]
should be the root cause. We didn't check determinism of the predicates before
pushing them down.
The same thing also applies when pushing predicates through union and window
operators.
cc [~cloud_fan]
> Should check determinism when pushing predicates down through aggregation
> -
>
> Key: SPARK-20246
> URL: https://issues.apache.org/jira/browse/SPARK-20246
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Weiluo Ren
>
> {code}import org.apache.spark.sql.functions._
> spark.range(1,1000).distinct.withColumn("random",
> rand()).filter(col("random") > 0.3).orderBy("random").show{code}
> gives wrong result.
> In the optimized logical plan, it shows that the filter with the
> non-deterministic predicate is pushed beneath the aggregate operator, which
> should not happen.
> cc [~lian cheng]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
