Please review a relatively simple fix to work around weirdly configured web
servers.
As first reported in this email,
https://mail.openjdk.org/pipermail/javadoc-dev/2023-January/005502.html
`docs.oracle.com` will redirect links to
https://docs.oracle.com/javase/8/docs/api/element-list to
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
On Mon, 20 Nov 2023 13:56:13 GMT, Christian Stein wrote:
>> src/java.base/share/classes/java/lang/Class.java line 4839:
>>
>>> 4837: @PreviewFeature(feature=PreviewFeature.Feature.IMPLICIT_CLASSES)
>>> 4838: @CallerSensitive
>>> 4839: public Method getMainMethod() {
>>
>> This is a
On Mon, 20 Nov 2023 10:06:50 GMT, Hannes Wallnöfer wrote:
> Please review a fix for multiple issues that caused a horizontal scrollbar to
> appear on the list of search results in JavaDoc-generated documentation even
> when not required by the list content. The problems are described in more
On Mon, 13 Nov 2023 21:45:51 GMT, Hannes Wallnöfer wrote:
> Please review a trivial fix to make javadoc use the correct heading for
> listings of inherited nested classes.
This pull request has now been integrated.
Changeset: cee54de4
Author:Hannes Wallnöfer
URL:
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Mon, 20 Nov 2023 10:25:55 GMT, Hannes Wallnöfer wrote:
>> Please review a fix for multiple issues that caused a horizontal scrollbar
>> to appear on the list of search results in JavaDoc-generated documentation
>> even when not required by the list content. The problems are described in
>>
On Mon, 13 Nov 2023 21:45:51 GMT, Hannes Wallnöfer wrote:
> Please review a trivial fix to make javadoc use the correct heading for
> listings of inherited nested classes.
Marked as reviewed by jjg (Reviewer).
-
PR Review:
On Fri, 17 Nov 2023 18:14:53 GMT, Pavel Rappo wrote:
> Back when DocLint lived in jdk.compiler, neither jdk.javadoc had access to
> DocLint, nor DocLint had access to jdk.javadoc. Since DocLint moved to
> jdk.javadoc, some redundancy can be eliminated and functionality shared;
> AccessKind is
On Mon, 20 Nov 2023 17:31:14 GMT, Pavel Rappo wrote:
>> Back when DocLint lived in jdk.compiler, neither jdk.javadoc had access to
>> DocLint, nor DocLint had access to jdk.javadoc. Since DocLint moved to
>> jdk.javadoc, some redundancy can be eliminated and functionality shared;
>>
On Mon, 20 Nov 2023 17:20:14 GMT, Pavel Rappo wrote:
>> While it is not _necessary_ to indicate that an enum implements
>> `Comparable`, it is permissible to state it explicitly, such as in `enum Foo
>> implements Comparable { foo1, foo2 }`. which is a somewhat more
>> linguistic way of
> Back when DocLint lived in jdk.compiler, neither jdk.javadoc had access to
> DocLint, nor DocLint had access to jdk.javadoc. Since DocLint moved to
> jdk.javadoc, some redundancy can be eliminated and functionality shared;
> AccessKind is one such functionality.
>
> There's more that could
On Mon, 20 Nov 2023 17:13:47 GMT, Jonathan Gibbons wrote:
>>> For better or worse, every enum exposes its constants' declaration order.
>>> That order may unexpectedly become relied upon elsewhere, and the author of
>>> the enum cannot do anything about it. T
>>
>> Since any `enum` implements
On Mon, 20 Nov 2023 11:55:57 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 464:
>>
>>> 462: }
>>> 463: for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
>>> 464: if (sym.kind == TYP && sym.name ==
On Mon, 20 Nov 2023 16:41:08 GMT, Jonathan Gibbons wrote:
>>> How much is the order actually relied on?
>>
>> Clients of `doclint.Env.AccessKind` use `compareTo()`, which is effectively
>> defined through `ordinal()`.
>>
>>> A different solution, if one is really needed, would be a regression
On Mon, 20 Nov 2023 14:03:21 GMT, Pavel Rappo wrote:
> For better or worse, every enum exposes its constants' declaration order.
> That order may unexpectedly become relied upon elsewhere, and the author of
> the enum cannot do anything about it. T
Since any `enum` implements `Comparable`, it
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Fri, 17 Nov 2023 22:07:39 GMT, Jonathan Gibbons wrote:
>> A different solution, if one is really needed, would be a regression test to
>> verify the expected order.
>
> Yet another alternate suggestion would be to use something like
>
>
> assert List.of(AccessLevel.values())
>
On Mon, 20 Nov 2023 13:50:45 GMT, Alan Bateman wrote:
> [...] it does make the java launcher code much simpler.
Yes. That's a very nice effect of surfacing the launch protocol directyl in
`java.lang.Class`
> So I'm not sure about the naming, it feels more like a `findMainMethod` to
>
On Sun, 19 Nov 2023 20:14:10 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Fri, 17 Nov 2023 13:56:13 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Mon, 20 Nov 2023 11:53:35 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Allow nested class of same name as file
>>
>> Since it doesn't create a conflicting symbol and would
> Please review a fix for multiple issues that caused a horizontal scrollbar to
> appear on the list of search results in JavaDoc-generated documentation even
> when not required by the list content. The problems are described in more
> detail in the JBS issue, but to summarize:
>
> - Our
Please review a fix for multiple issues that caused a horizontal scrollbar to
appear on the list of search results in JavaDoc-generated documentation even
when not required by the list content. The problems are described in more
detail in the JBS issue, but to summarize:
- Our category
27 matches
Mail list logo
