On Wed, 20 Dec 2023 19:00:50 GMT, Alisen Chung wrote:
> Backport of JDK-8322041
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/22#pullrequestreview-1791633961
On Wed, 20 Dec 2023 19:00:50 GMT, Alisen Chung wrote:
> Backport of JDK-8322041
The patch looks good. Additionally, I confirmed that the files in question are
identical to those in jdk mainline after this patch is applied.
It will need a "R"eviewer to approve.
-
Marked as
Backport of JDK-8322041
-
Commit messages:
- Backport b061b6678fde891974d5b58cec963b3481099a8d
Changes: https://git.openjdk.org/jdk22/pull/22/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22=22=00
Issue: https://bugs.openjdk.org/browse/JDK-8322041
Stats: 290 lines in 36
On Thu, 14 Dec 2023 22:17:54 GMT, Alisen Chung wrote:
>> Translation drop for JDK22 RDP1
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed quotes around Ablehnen
The diffs are more conveniently available here:
On Thu, 14 Dec 2023 22:17:54 GMT, Alisen Chung wrote:
>> Translation drop for JDK22 RDP1
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed quotes around Ablehnen
The java.xml changes look good.
-
On Thu, 14 Dec 2023 19:01:22 GMT, Joe Wang wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed quotes around Ablehnen
>
>
> Translation drop for JDK22 RDP1
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed quotes around Ablehnen
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17096/files
- new:
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
mach5 looks green
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1856733375
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by asemenyuk (Reviewer).
jpackage changes look good
-
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1782697421
PR Comment:
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
All around LGTM. From a skim I don't see any of the typical l10n related file
mode issues, line ending issues, or values that should not be changed (like
_WixLocalization Culture_). Might be worth filing a
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties
line 111:
> 109: doclet.Factory=ファクトリ:
> 110: doclet.UnknownTag=不明なタグ。未登録のカスタム・タグ?
> 111:
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
line 331:
> 329:
> 330: # Implementation Property DTD
> 331: JDK_DTD_DENY = JAXP00010008: DOCTYPE
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by cstein (Committer).
German translations read OK.
Nit: some layouts get lost in translated files - it would be great to have
similar usage of `\n` and `` in the translated files.
For
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
jpackage part looks fine.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1780705685
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
@JoeWang-Java can u review the xml changes?
@jonathan-gibbons can u review the compiler changes?
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1854853944
PR Comment:
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
@alexeysemenyukoracle please review jpackage part
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1854847266
16 matches
Mail list logo
