On Thu, 2 Nov 2023 18:10:27 GMT, Rémi Forax wrote:
>> Hmmm. I'll check with Gavin, but I thought in discussions Alex said that it
>> should be mandated. At any rate, seems the ACC_MANDATED should be removed
>> for stated reasons.
>
> It should be MANDATED in theory given it's not an artifact
On Thu, 2 Nov 2023 12:24:31 GMT, Jim Laskey wrote:
>> Uhmm. In the spec I see implicit classes named here:
>>
>>
>> For reference, the following constructs are declared implicitly in source
>> code, but are not marked as mandated because only formal parameters and
>> modules can be so
On Thu, 2 Nov 2023 17:21:02 GMT, Jan Lahoda wrote:
>> No. It should be left at the first preview level.
>
> `UNNAMED_CLASSES` should probably be removed, as I think it is fully replaced
> with `IMPLICIT_CLASSES`, and I don't think there are bootstrap problems here
> (unlike in
On Thu, 2 Nov 2023 11:55:50 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 249:
>>
>>> 247: STRING_TEMPLATES(JDK21, Fragments.FeatureStringTemplates,
>>> DiagKind.PLURAL),
>>> 248: UNNAMED_CLASSES(JDK21,
On Thu, 2 Nov 2023 12:11:52 GMT, Maurizio Cimadamore
wrote:
>> The spec has been updated to include implicit classes.
>
> Uhmm. In the spec I see implicit classes named here:
>
>
> For reference, the following constructs are declared implicitly in source
> code, but are not marked as
On Thu, 2 Nov 2023 11:53:09 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
>> line 4057:
>>
>>> 4055: Name name = names.fromString(simplename);
>>> 4056: JCModifiers implicitMods = F.at(Position.NOPOS)
>>> 4057:
On Thu, 2 Nov 2023 11:55:17 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java line 442:
>>
>>> 440: Errors.ClassPublicShouldBeInFile(topElement,
>>> tree.name));
>>> 441: }
>>> 442: if
On Thu, 2 Nov 2023 11:12:14 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove obsolete tests
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 249:
>
>>
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
13 matches
Mail list logo
