Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:26:19 GMT, Jan Lahoda wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revised implicit class test > > test/jdk/java/lang/Class/ImplicitClass/TestImplicitClass.java line 25: > >> 23: >> 24: /*

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:17:42 GMT, Jan Lahoda wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revised implicit class test > > src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 33: > >> 31:

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 15:45:03 GMT, Jim Laskey wrote: > Amazingly enough I seem to have the JNI straight on the first try. Oh, I wasn't expecting that. My comment was suggesting we change LauncherHelper.checkAndLoadMain to set both appClass and mainType after the validate succeeds.

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jan Lahoda
On Thu, 2 Nov 2023 16:19:07 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull