feyman2016 commented on pull request #8020:
URL: https://github.com/apache/kafka/pull/8020#issuecomment-622673014
@mjsax Thanks for closing this.
This is an automated message from the Apache Git Service.
To respond to the
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418885536
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -505,4 +550,35 @@ private
ijuma commented on pull request #8533:
URL: https://github.com/apache/kafka/pull/8533#issuecomment-622662404
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622661309
System test run passed (as did all three builds, wow!)
This is an automated message from the Apache Git
feyman2016 commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622661261
@mjsax I see, thanks :)
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418858652
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -505,4 +550,35 @@ private
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418852189
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -789,7 +789,7 @@ private void
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418851326
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -70,18 +69,16 @@ static void
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418850721
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418850068
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -505,4 +550,35 @@ private
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418838526
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -70,18 +69,16 @@ static void
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418842202
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -155,9 +155,6 @@ void handleCorruption(final
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418840101
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -789,7 +789,7 @@ private void
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418838526
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -70,18 +69,16 @@ static void
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418837867
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -70,18 +69,16 @@ static void
mjsax edited a comment on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622654288
@guozhangwang The failing test run has truncate logs. So it's hard to know
what the root cause it. The high level "pattern" seems to be similar to what we
have observed
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418833053
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java
##
@@ -235,9 +264,16 @@ void
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622654288
@guozhangwang The failing test run has truncate logs. So it's hard to know
what the root cause it. The high level "pattern" seems to be similar to what we
have observed before: we
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418831978
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622653480
Java 11 passed.
Java 8:
```
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418830079
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622653502
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8600:
URL: https://github.com/apache/kafka/pull/8600#issuecomment-622653176
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-8940:
Reopening. Failed again:
ableegoldman commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622652864
Version probing test passing locally now, kicked off a branch builder to
confirm: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3927/
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780890
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
[
https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097779#comment-17097779
]
Matthias J. Sax commented on KAFKA-9831:
I run this test like 500 times locally but could not
[
https://issues.apache.org/jira/browse/KAFKA-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-9896.
Resolution: Cannot Reproduce
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097778#comment-17097778
]
Matthias J. Sax commented on KAFKA-9896:
[~guozhang] [~bchen225242] I ran this test like 500
mjsax edited a comment on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723
Thanks for the update. I'll wait for Jenkins and do another pass afterwards.
Btw: the comment "Retest this please" is not for you, but for Jenkins to run
the build :)
mjsax commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651782
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax edited a comment on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723
Thanks for the update. I'll wait for Jenkins and do another pass afterwards.
This is an automated message
mjsax commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723
Thanks for the update. I'll wait for Jenkins and do another pass afterwards.
Retest this please.
This is an
mjsax commented on pull request #8520:
URL: https://github.com/apache/kafka/pull/8520#issuecomment-622651340
Don't worry about it. Not a big deal.
This is an automated message from the Apache Git Service.
To respond to the
zhaohaidao commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651191
> Retest this please.
@mjsax I have modified the codes according to your suggestion and passed the
test. Could you continue to review it?
mjsax commented on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-622651059
> we should create two repartiton topics as that's what the user is
expecting.
Is she? I guess it's clearly document that the name is use for repartition
topics, too, but it
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418820500
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
mjsax commented on a change in pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#discussion_r418818822
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java
##
@@ -989,16 +994,18 @@ private void to(final
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418817105
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418816470
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418815490
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418815217
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418814943
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418813975
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java
##
@@ -104,6 +114,54 @@ public void
mjsax edited a comment on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-618073161
> Ideally, the fix should be to generate a repartition topic name each time
to avoid such issues. But IMHO that ship has already sailed because by
introducing a new name
mjsax commented on pull request #8555:
URL: https://github.com/apache/kafka/pull/8555#issuecomment-622648385
I am not familiar with this code. Maybe @mumrah or @cmccabe can help?
This is an automated message from the Apache
mjsax commented on a change in pull request #8483:
URL: https://github.com/apache/kafka/pull/8483#discussion_r418809026
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -450,6 +452,24 @@ public void
mjsax commented on pull request #8483:
URL: https://github.com/apache/kafka/pull/8483#issuecomment-622648248
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622632765
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418794862
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1423,22 +1434,44 @@ public void
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418793917
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1338,7 +1346,7 @@ public void
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418793644
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1009,14 +1018,18 @@ private
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418792433
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -907,6 +905,17 @@ private void
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418791000
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -556,14 +548,8 @@ void runLoop() {
mjsax commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622630109
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622630031
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418788022
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -877,7 +877,7 @@
public static final String
ableegoldman commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622628637
Also cc @mjsax for some feedback on making the rebalancing comprehensible in
system test logs
This is an
mjsax commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418784189
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java
##
@@ -104,6 +114,54 @@ public void
hachikuji opened a new pull request #8602:
URL: https://github.com/apache/kafka/pull/8602
This test case should ensure that clients and the bounce scheduler get
shutdown properly.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
mjsax commented on pull request #8020:
URL: https://github.com/apache/kafka/pull/8020#issuecomment-622615014
@feyman2016 closing this PR in favor of #8589 -- I assume it's a replacement.
This is an automated message from the
mjsax commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622614438
@feyman2016 Only committers can trigger Jenkins retesting...
Retest this please.
This is an automated
mjsax commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418782542
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780890
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780240
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
cmccabe opened a new pull request #8601:
URL: https://github.com/apache/kafka/pull/8601
duplicate of https://github.com/apache/kafka/pull/8527 to get jenkins run
This is an automated message from the Apache Git Service.
To
ijuma commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418778603
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
ijuma commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418778470
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
[
https://issues.apache.org/jira/browse/KAFKA-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-8122.
Resolution: Fixed
> Flaky Test
cmccabe commented on pull request #8527:
URL: https://github.com/apache/kafka/pull/8527#issuecomment-622610148
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097736#comment-17097736
]
Matthias J. Sax commented on KAFKA-8122:
Closing this test if favor of
Jason Gustafson created KAFKA-9947:
--
Summary: TransactionsBounceTest may leave threads running
Key: KAFKA-9947
URL: https://issues.apache.org/jira/browse/KAFKA-9947
Project: Kafka
Issue
guozhangwang commented on pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#issuecomment-622602829
@mjsax thanks for the review! Addressed your comments.
This is an automated message from the Apache Git
guozhangwang commented on a change in pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#discussion_r418768692
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java
##
@@ -1262,6 +1266,7 @@ public void
vvcephei commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418768140
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r414837565
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418767753
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java
##
@@ -148,6 +161,82 @@ public void
ijuma commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418766141
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
ableegoldman edited a comment on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622218685
Kicked off the version probing system test since I'm mucking around in the
rebalance triggering code and log messages, and I've broken it that way before
:
[
https://issues.apache.org/jira/browse/KAFKA-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-9939:
---
Affects Version/s: 2.5.0
> Fetch request metrics are updated twice for delayed fetches
>
[
https://issues.apache.org/jira/browse/KAFKA-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-9939.
Fix Version/s: 2.6.0
Resolution: Fixed
> Fetch request metrics are updated twice
hachikuji commented on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-622593285
The 32 test failures on jdk11 were due to threads being left behind after a
failure in `TransactionsBounceTest`. I will submit a separate fix for this. The
other failure seems
hachikuji commented on pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#issuecomment-622590281
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-9896:
--
Assignee: Matthias J. Sax
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-8122:
--
Assignee: Matthias J. Sax
> Flaky Test
hachikuji commented on a change in pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#discussion_r418759371
##
File path:
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##
@@ -230,6 +231,11 @@ public SslEngineFactory
hachikuji commented on a change in pull request #8570:
URL: https://github.com/apache/kafka/pull/8570#discussion_r418756784
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java
##
@@ -99,7 +100,7 @@ public String name() {
/**
* Return
hachikuji commented on pull request #8577:
URL: https://github.com/apache/kafka/pull/8577#issuecomment-622580718
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622579708
Rebase this PR -- failed before, because the `ProcessorContext` "generics"
commit was reverted.
This is an
[
https://issues.apache.org/jira/browse/KAFKA-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097684#comment-17097684
]
John Roesler commented on KAFKA-7224:
-
Hi all,
Thanks for the good points all around.
Just to close
hachikuji commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418741006
##
File path: core/src/test/scala/unit/kafka/security/authorizer/AclEntryTest.scala
##
@@ -23,27 +23,28 @@ import
mjsax commented on a change in pull request #8600:
URL: https://github.com/apache/kafka/pull/8600#discussion_r418737835
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java
##
@@ -304,59 +382,64 @@ private void
mjsax opened a new pull request #8600:
URL: https://github.com/apache/kafka/pull/8600
Most changes thus improve the error message output in case a test fails.
Potential fix: remove producer config `retries=1`
Call for review @guozhangwang
vvcephei commented on a change in pull request #8593:
URL: https://github.com/apache/kafka/pull/8593#discussion_r418735906
##
File path: streams/src/test/java/org/apache/kafka/test/MockSourceNode.java
##
@@ -48,7 +48,7 @@ public void process(final K key, final V value) {
hachikuji commented on pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#issuecomment-622565563
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Wang reassigned KAFKA-8120:
---
Assignee: Jun Wang
> Getting NegativeArraySizeException when using Kafka Connect to send data to
>
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622557984
Java 8 passed.
Java 11:
`org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin`
Java 14:
```
hachikuji commented on a change in pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#discussion_r418718645
##
File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
##
@@ -1,206 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF)
hachikuji commented on a change in pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#discussion_r418702601
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,
val
hachikuji commented on a change in pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#discussion_r418702601
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,
val
1 - 100 of 136 matches
Mail list logo
