[jira] [Created] (KAFKA-10064) Add documentation for KIP-571

2020-05-28 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10064: --- Summary: Add documentation for KIP-571 Key: KAFKA-10064 URL: https://issues.apache.org/jira/browse/KAFKA-10064 Project: Kafka Issue Type: Task

[jira] [Commented] (KAFKA-10036) Improve error message if user violates `Supplier` pattern

2020-05-28 Thread Alex Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119271#comment-17119271 ] Alex Sun commented on KAFKA-10036: -- PR created: [https://github.com/apache/kafka/pull/8752] > Improve

[GitHub] [kafka] sneakyburro opened a new pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-05-28 Thread GitBox
sneakyburro opened a new pull request #8752: URL: https://github.com/apache/kafka/pull/8752 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] ableegoldman commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-05-28 Thread GitBox
ableegoldman commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-635750374 call for review any of @guozhangwang @hachikuji @vvcephei This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119261#comment-17119261 ] Sophie Blee-Goldman commented on KAFKA-9987: Hey [~hai_lin] and [~twmb], I finally finished

[GitHub] [kafka] ableegoldman commented on a change in pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8668: URL: https://github.com/apache/kafka/pull/8668#discussion_r432246028 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -425,8 +422,36 @@ public void

[jira] [Commented] (KAFKA-10036) Improve error message if user violates `Supplier` pattern

2020-05-28 Thread Alex Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119257#comment-17119257 ] Alex Sun commented on KAFKA-10036: -- Simplified version is: Multiple ProcessorContext tried to register

[jira] [Commented] (KAFKA-10036) Improve error message if user violates `Supplier` pattern

2020-05-28 Thread Alex Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119253#comment-17119253 ] Alex Sun commented on KAFKA-10036: -- Hi [~mjsax], just to confirm the root cause. It is because that

[GitHub] [kafka] ableegoldman commented on a change in pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8668: URL: https://github.com/apache/kafka/pull/8668#discussion_r432231137 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -582,35 +578,6 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8668: URL: https://github.com/apache/kafka/pull/8668#discussion_r432230560 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java ## @@ -169,10 +169,10 @@ public void

[GitHub] [kafka] ijuma opened a new pull request #8751: MINOR: Update to Gradle 6.5

2020-05-28 Thread GitBox
ijuma opened a new pull request #8751: URL: https://github.com/apache/kafka/pull/8751 `./gradlew clean install` with gradle daemon reuse: Gradle 6.4: `BUILD SUCCESSFUL in 2m 18s Gradle 6.5-rc-1: `BUILD SUCCESSFUL in 1m 50s` ### Committer Checklist (excluded from commit

[jira] [Assigned] (KAFKA-10038) ConsumerPerformance.scala supports the setting of client.id

2020-05-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10038: - Assignee: Luke Chen > ConsumerPerformance.scala supports the setting of client.id >

[jira] [Commented] (KAFKA-10043) Some parameters will be overwritten which was configured in consumer.config where running "ConsumerPerformance.scala"

2020-05-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119210#comment-17119210 ] Luke Chen commented on KAFKA-10043: --- hi [~tigertan], are you working on this issue? if no, I can take

[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-05-28 Thread GitBox
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-635718737 @mjsax Just rebase & force-pushed. You can start review when you available. This is an automated message from

[GitHub] [kafka] showuon commented on pull request #8750: kafka-10052: Small Refactor

2020-05-28 Thread GitBox
showuon commented on pull request #8750: URL: https://github.com/apache/kafka/pull/8750#issuecomment-635717082 hi @kkonstantine , I did some investigation for this flaky errors days ago, but today, I found out you already fix it, and fix it with better way! Cool! This is a small

[GitHub] [kafka] showuon opened a new pull request #8750: kafka-10052: Small Refactor

2020-05-28 Thread GitBox
showuon opened a new pull request #8750: URL: https://github.com/apache/kafka/pull/8750 1. Remove redundant `connect.stop();` since we'll do it after each test case in `close()` function 2. Refine the error message to make it better explain the errors ### Committer Checklist

[GitHub] [kafka] ableegoldman commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
ableegoldman commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635711087 Thanks! I actually don't think there ended up being anything relevant t o2.5 in the final form of this PR. Except maybe adding `@throws StreamsException` to the

[GitHub] [kafka] vvcephei commented on pull request #8677: KAFKA-9999: Make internal topic creation error non-fatal

2020-05-28 Thread GitBox
vvcephei commented on pull request #8677: URL: https://github.com/apache/kafka/pull/8677#issuecomment-635707062 Hey @abbccdda , I've just recently been in some investigation of these timeouts as part of https://github.com/apache/kafka/pull/8738 , and we're also planning to implement

[GitHub] [kafka] mjsax commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635706567 Merged to `trunk` and cherry-picked to `2.6`. Do we want this in `2.5`, too? If yes, we would need a new PR. Not possible to cherry-pick.

[jira] [Commented] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-28 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119197#comment-17119197 ] Adam Bellemare commented on KAFKA-10049: Found the bug. The SubscriptionWrapperSerde wraps a Key

[GitHub] [kafka] ijuma commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-28 Thread GitBox
ijuma commented on a change in pull request #8705: URL: https://github.com/apache/kafka/pull/8705#discussion_r432209283 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -1886,19 +1926,13 @@ class SocketServerTest {

[GitHub] [kafka] vitojeng edited a comment on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-05-28 Thread GitBox
vitojeng edited a comment on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-635703849 > Hey @vitojeng -- sorry for the long delay... We had a big KIP review back log... @mjsax Never mind, I understand. :) I'll be rebase master again and update

[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-05-28 Thread GitBox
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-635703849 > Hey @vitojeng -- sorry for the long delay... We had a big KIP review back log... Never mind, I understand. :) I'll be rebase master again and update this PR ASAP.

[GitHub] [kafka] mjsax merged pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax merged pull request #8738: URL: https://github.com/apache/kafka/pull/8738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-05-28 Thread GitBox
mjsax commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-635696040 Hey @vitojeng -- sorry for the long delay... We had a big KIP review back log... I would dedicate review time now to get KIP-216 merged. Are you still interested in pushing it over

[GitHub] [kafka] ableegoldman commented on a change in pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8668: URL: https://github.com/apache/kafka/pull/8668#discussion_r432200092 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -303,79 +469,17 @@ private int

[jira] [Commented] (KAFKA-10057) optimize class ConfigCommand method alterConfig parameters

2020-05-28 Thread qianrui (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119186#comment-17119186 ] qianrui commented on KAFKA-10057: - I know this parameter will be used in the future, but it is not used

[GitHub] [kafka] hachikuji commented on a change in pull request #8739: KAFKA-10056; Ensure consumer metadata contains new topics on subscription change

2020-05-28 Thread GitBox
hachikuji commented on a change in pull request #8739: URL: https://github.com/apache/kafka/pull/8739#discussion_r432197918 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -345,7 +345,17 @@ synchronized boolean

[GitHub] [kafka] hachikuji commented on a change in pull request #8739: KAFKA-10056; Ensure consumer metadata contains new topics on subscription change

2020-05-28 Thread GitBox
hachikuji commented on a change in pull request #8739: URL: https://github.com/apache/kafka/pull/8739#discussion_r432197918 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -345,7 +345,17 @@ synchronized boolean

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432190091 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -263,27 +259,28 @@ private

[jira] [Updated] (KAFKA-10063) UnsupportedOperation when querying cleaner metrics after shutdown

2020-05-28 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10063: Description: We have a few log cleaner metrics which iterate the set of cleaners. For

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432185717 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -259,7 +263,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432183678 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -1468,9 +1456,6 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-05-28 Thread GitBox
hachikuji commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r432178706 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java ## @@ -31,8 +37,21 @@ * @param isSimpleConsumerGroup

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432178832 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -79,25 +88,27 @@ private static

[GitHub] [kafka] vvcephei merged pull request #8748: HOTFIX: relax constraint on randomized percentiles test

2020-05-28 Thread GitBox
vvcephei merged pull request #8748: URL: https://github.com/apache/kafka/pull/8748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji opened a new pull request #8749: KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation`

2020-05-28 Thread GitBox
hachikuji opened a new pull request #8749: URL: https://github.com/apache/kafka/pull/8749 We have seen this test failing from time to time. In spite of the low quota, it is possible for one or more of the reassignments to complete before verification that the reassignment is in progress.

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432174885 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -259,7 +263,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432171931 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -79,25 +88,27 @@ private static

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432172108 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -290,6 +295,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432171069 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -259,7 +263,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] vvcephei commented on pull request #8747: MINOR: Log the reason for coordinator discovery failure

2020-05-28 Thread GitBox
vvcephei commented on pull request #8747: URL: https://github.com/apache/kafka/pull/8747#issuecomment-635659313 Thanks for the review, @abbccdda ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei commented on pull request #8747: MINOR: Log the reason for coordinator discovery failure

2020-05-28 Thread GitBox
vvcephei commented on pull request #8747: URL: https://github.com/apache/kafka/pull/8747#issuecomment-635659034 Java 11 build timed out. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432166896 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -259,7 +263,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432166896 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -259,7 +263,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432166675 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -223,8 +224,20 @@ class

[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
vinothchandar commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432164756 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -247,8 +247,12 @@ object TopicCommand extends Logging { val

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432162663 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -736,8 +743,8 @@ object TopicCommand extends Logging { allTopicLevelOpts --

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432162663 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -736,8 +743,8 @@ object TopicCommand extends Logging { allTopicLevelOpts --

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432162100 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -223,8 +224,20 @@ class TopicCommandWithAdminClientTest

[GitHub] [kafka] mjsax commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635644144 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635644310 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432159935 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -324,7 +331,7 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432159364 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -290,6 +295,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432159364 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -290,6 +295,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432158637 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -259,7 +263,8 @@ object TopicCommand extends Logging { override def

[GitHub] [kafka] ableegoldman commented on a change in pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432158766 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1246,7 +1246,7 @@ public void cleanUp() { }

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432157321 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -247,8 +247,12 @@ object TopicCommand extends Logging { val createResult =

[GitHub] [kafka] cmccabe commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-28 Thread GitBox
cmccabe commented on a change in pull request #8737: URL: https://github.com/apache/kafka/pull/8737#discussion_r432157321 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -247,8 +247,12 @@ object TopicCommand extends Logging { val createResult =

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432155323 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -1247,4 +1270,33 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432155159 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -79,25 +88,27 @@ private static

[GitHub] [kafka] mjsax commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635637908 Checkstyle error: ``` [ant:checkstyle] [ERROR]

[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432153623 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1246,7 +1246,7 @@ public void cleanUp() { }

[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432153623 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1246,7 +1246,7 @@ public void cleanUp() { }

[GitHub] [kafka] mjsax commented on a change in pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8706: URL: https://github.com/apache/kafka/pull/8706#discussion_r432144610 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/QueryableStoreProvider.java ## @@ -58,9 +58,21 @@ public

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-28 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-635633908 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635633587 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635633530 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] srpanwar-confluent commented on a change in pull request #8723: KIP-569-KAFKA-9494: DescribeConfigsResponse - include additional metadata information

2020-05-28 Thread GitBox
srpanwar-confluent commented on a change in pull request #8723: URL: https://github.com/apache/kafka/pull/8723#discussion_r432148295 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -201,6 +201,13 @@ public String getString(String

[GitHub] [kafka] srpanwar-confluent commented on a change in pull request #8723: KIP-569-KAFKA-9494: DescribeConfigsResponse - include additional metadata information

2020-05-28 Thread GitBox
srpanwar-confluent commented on a change in pull request #8723: URL: https://github.com/apache/kafka/pull/8723#discussion_r432145568 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -2052,6 +2057,49 @@ void handleFailure(Throwable

[GitHub] [kafka] ableegoldman commented on a change in pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r431571493 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java ## @@ -90,24 +96,21 @@ public static String

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432143143 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -79,25 +88,27 @@ private static final

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-28 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-635625227 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-28 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-635625057 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (KAFKA-10063) UnsupportedOperation when querying cleaner metrics after shutdown

2020-05-28 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10063: --- Summary: UnsupportedOperation when querying cleaner metrics after shutdown Key: KAFKA-10063 URL: https://issues.apache.org/jira/browse/KAFKA-10063 Project:

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-28 Thread GitBox
mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-635616335 > Are you guys using some formatting tool I use IntelliJ that does have some auto-formatting. Use it basically with default settings. In doubt, disable auto-formatting to

[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432123361 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1246,7 +1247,12 @@ public void cleanUp() { }

[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432123697 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1246,7 +1247,12 @@ public void cleanUp() { }

[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432121655 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ClientUtilsTest.java ## @@ -45,42 +50,42 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432121276 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -79,25 +88,27 @@ private static

[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
mjsax commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r432121258 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ClientUtilsTest.java ## @@ -45,42 +50,42 @@ public void

[GitHub] [kafka] mimaison commented on pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-05-28 Thread GitBox
mimaison commented on pull request #8238: URL: https://github.com/apache/kafka/pull/8238#issuecomment-635604107 @hachikuji Thanks for the feedback. I've pushed updates addressing your comments. I've also updated the KIP accordingly and I'll send a message to the VOTE thread on the

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635603373 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635603479 \o/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] vvcephei commented on pull request #8747: MINOR: Log the reason for coordinator discovery failure

2020-05-28 Thread GitBox
vvcephei commented on pull request #8747: URL: https://github.com/apache/kafka/pull/8747#issuecomment-635602993 The java 14 test failure is unrelated and fixed in https://github.com/apache/kafka/pull/8748 This is an

[GitHub] [kafka] vvcephei commented on pull request #8748: HOTFIX: relax constraint on randomized percentiles test

2020-05-28 Thread GitBox
vvcephei commented on pull request #8748: URL: https://github.com/apache/kafka/pull/8748#issuecomment-635603081 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-05-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10062: Labels: needs-kip (was: ) > Add a method to retrieve the current timestamp as known by

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-28 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r432109207 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -1247,4 +1270,33 @@ public void

[GitHub] [kafka] ableegoldman opened a new pull request #8748: HOTFIX: relax constraint on randomized percentiles test

2020-05-28 Thread GitBox
ableegoldman opened a new pull request #8748: URL: https://github.com/apache/kafka/pull/8748 Should go to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-05-28 Thread Piotr Smolinski (Jira)
Piotr Smolinski created KAFKA-10062: --- Summary: Add a method to retrieve the current timestamp as known by the Streams app Key: KAFKA-10062 URL: https://issues.apache.org/jira/browse/KAFKA-10062

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635589437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-10061) Flaky Test `ReassignPartitionsIntegrationTest .testCancellation`

2020-05-28 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10061: Description: We have seen this a few times: {code}

[jira] [Created] (KAFKA-10061) Flaky Test `ReassignPartitionsIntegrationTest .testCancellation`

2020-05-28 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10061: --- Summary: Flaky Test `ReassignPartitionsIntegrationTest .testCancellation` Key: KAFKA-10061 URL: https://issues.apache.org/jira/browse/KAFKA-10061 Project:

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635562805 I just resolved the conflicts. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635563117 ... or not This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635562905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-28 Thread GitBox
vvcephei commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-635561957 Oh, actually @ableegoldman , it looks like there was a conflict with the other PR I just merged. This is an

[GitHub] [kafka] vvcephei merged pull request #8743: MINOR: regression test for task assignor config

2020-05-28 Thread GitBox
vvcephei merged pull request #8743: URL: https://github.com/apache/kafka/pull/8743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-3468) Java clients never fail when bootstrap uses incorrect port

2020-05-28 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119027#comment-17119027 ] Brad Schoening commented on KAFKA-3468: --- Similar behavior occurs when security.protocol is not

[GitHub] [kafka] ijuma commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-05-28 Thread GitBox
ijuma commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r432073518 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

  1   2   3   >