[GitHub] [kafka] JunHe77 commented on pull request #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-10-27 Thread GitBox
JunHe77 commented on pull request #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-717710128 Really appreciated for the feedback, @lizthegrey . Glad to know there are actual use cases to run and test Kafka on Arm64, and it seems that merging this will help

[GitHub] [kafka] ableegoldman commented on pull request #9515: KAFKA-10561: read offsets directly from checkpoint for uninitialized tasks

2020-10-27 Thread GitBox
ableegoldman commented on pull request #9515: URL: https://github.com/apache/kafka/pull/9515#issuecomment-717691656 > Although, as I'm typing this, I'm realizing the bug is probably that when the task is initialized, we'd report some high offsetSum, which the assignor interprets as a low

[GitHub] [kafka] vvcephei commented on pull request #9515: KAFKA-10561: read offsets directly from checkpoint for uninitialized tasks

2020-10-27 Thread GitBox
vvcephei commented on pull request #9515: URL: https://github.com/apache/kafka/pull/9515#issuecomment-717683830 Thanks for this quick fix, @ableegoldman ! It looks like the bug before was that we would skip to encode these uninitialized tasks since they'd look "apparently

[jira] [Comment Edited] (KAFKA-10526) Explore performance impact of leader fsync deferral

2020-10-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221881#comment-17221881 ] Jason Gustafson edited comment on KAFKA-10526 at 10/28/20, 1:23 AM:

[jira] [Commented] (KAFKA-10526) Explore performance impact of leader fsync deferral

2020-10-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221881#comment-17221881 ] Jason Gustafson commented on KAFKA-10526: - [~sagarrao] Yes, of course. I might suggest

[jira] [Created] (KAFKA-10652) Raft leader should flush accumulated writes after a min size is reached

2020-10-27 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10652: --- Summary: Raft leader should flush accumulated writes after a min size is reached Key: KAFKA-10652 URL: https://issues.apache.org/jira/browse/KAFKA-10652

[GitHub] [kafka] ableegoldman commented on a change in pull request #9515: KAFKA-10561: read offsets directly from checkpoint for uninitialized tasks

2020-10-27 Thread GitBox
ableegoldman commented on a change in pull request #9515: URL: https://github.com/apache/kafka/pull/9515#discussion_r513114972 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -2479,7 +2502,7 @@ public void

[GitHub] [kafka] ableegoldman opened a new pull request #9515: KAFKA-10561: read offsets directly from checkpoint for uninitialized tasks

2020-10-27 Thread GitBox
ableegoldman opened a new pull request #9515: URL: https://github.com/apache/kafka/pull/9515 Uninitialized tasks just return an empty collection in `changelogOffsets()` and are indistinguishable from genuinely stateless (or un-logged) tasks. We should just skip over these tasks and read

[jira] [Updated] (KAFKA-10651) Assignor reports offsets from uninitialized task

2020-10-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10651: --- Description: In KIP-441, the new HA assignor makes an informed decision

[GitHub] [kafka] rodesai commented on a change in pull request #9498: MINOR: call super.close() when closing RocksDB options

2020-10-27 Thread GitBox
rodesai commented on a change in pull request #9498: URL: https://github.com/apache/kafka/pull/9498#discussion_r513100855 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -1396,5

[GitHub] [kafka] rodesai commented on a change in pull request #9498: MINOR: call super.close() when closing RocksDB options

2020-10-27 Thread GitBox
rodesai commented on a change in pull request #9498: URL: https://github.com/apache/kafka/pull/9498#discussion_r513095994 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -1396,5

[jira] [Resolved] (KAFKA-10644) Fix VotedToUnattached test error

2020-10-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10644. - Resolution: Fixed > Fix VotedToUnattached test error >

[GitHub] [kafka] hachikuji merged pull request #9503: KAFKA-10644: Fix VotedToUnattached test error

2020-10-27 Thread GitBox
hachikuji merged pull request #9503: URL: https://github.com/apache/kafka/pull/9503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on a change in pull request #9498: fix: call super.close when closing rocksdb options

2020-10-27 Thread GitBox
mjsax commented on a change in pull request #9498: URL: https://github.com/apache/kafka/pull/9498#discussion_r513093711 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -1396,5

[GitHub] [kafka] bbejeck merged pull request #9514: MINOR: Add KIP-431 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck merged pull request #9514: URL: https://github.com/apache/kafka/pull/9514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on pull request #9514: MINOR: Add KIP-431 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9514: URL: https://github.com/apache/kafka/pull/9514#issuecomment-717602293 only HTML, merging now This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck commented on pull request #9514: MINOR: Add KIP-431 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9514: URL: https://github.com/apache/kafka/pull/9514#issuecomment-717602172 Thanks @mjsax This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] bbejeck opened a new pull request #9514: MINOR: Add KIP-431 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck opened a new pull request #9514: URL: https://github.com/apache/kafka/pull/9514 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Assigned] (KAFKA-10651) Assignor reports offsets from uninitialized task

2020-10-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-10651: -- Assignee: A. Sophie Blee-Goldman > Assignor reports offsets from

[jira] [Created] (KAFKA-10651) Assignor reports offsets from uninitialized task

2020-10-27 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-10651: -- Summary: Assignor reports offsets from uninitialized task Key: KAFKA-10651 URL: https://issues.apache.org/jira/browse/KAFKA-10651 Project: Kafka

[jira] [Commented] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-10-27 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221813#comment-17221813 ] Guozhang Wang commented on KAFKA-8803: -- [~pdeole] I was OOO and just saw your message. So far all

[GitHub] [kafka] rajinisivaram commented on pull request #7751: KAFKA-7987: Reinitialize ZookeeperClient after auth failures

2020-10-27 Thread GitBox
rajinisivaram commented on pull request #7751: URL: https://github.com/apache/kafka/pull/7751#issuecomment-717541120 @parafiend Will you be updating the PR to address the review comments from @junrao ? As mentioned in the JIRA, this issue also affects the ZooKeeper client used by

[jira] [Commented] (KAFKA-7987) a broker's ZK session may die on transient auth failure

2020-10-27 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221756#comment-17221756 ] Rajini Sivaram commented on KAFKA-7987: --- [~junrao]Thank you! I will follow up on the PR. > a

[GitHub] [kafka] mjsax opened a new pull request #9513: MINOR: improve `null` checks for headers

2020-10-27 Thread GitBox
mjsax opened a new pull request #9513: URL: https://github.com/apache/kafka/pull/9513 Headers are not allowed to be `null`, and thus the code does not check for `null` headers. However, we don't have proper guards in place and had NPE in the past if a header was `null`. This PR adds

[jira] [Updated] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10370: Fix Version/s: (was: 2.7.0) > WorkerSinkTask: IllegalStateException cased by

[jira] [Updated] (KAFKA-10378) issue when create producer using java

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10378: Fix Version/s: (was: 2.6.1) (was: 2.7.0) > issue when create producer

[jira] [Updated] (KAFKA-9497) Brokers start up even if SASL provider is not loaded and throw NPE when clients connect

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9497: --- Fix Version/s: (was: 2.7.0) > Brokers start up even if SASL provider is not loaded and throw NPE

[jira] [Updated] (KAFKA-10297) Don't use deprecated producer config `retries`

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10297: Fix Version/s: (was: 2.7.0) > Don't use deprecated producer config `retries` >

[jira] [Commented] (KAFKA-10645) Forwarding a record from a punctuator sometimes it results in a NullPointerException

2020-10-27 Thread Filippo Machi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221709#comment-17221709 ] Filippo Machi commented on KAFKA-10645: --- My input data doesn´t have headers. I am getting this

[GitHub] [kafka] hachikuji commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-27 Thread GitBox
hachikuji commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r512370043 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1388,6 +1390,7 @@ class Log(@volatile private var _dir: File, var validBytesCount = 0

[jira] [Commented] (KAFKA-10645) Forwarding a record from a punctuator sometimes it results in a NullPointerException

2020-10-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221678#comment-17221678 ] Matthias J. Sax commented on KAFKA-10645: - Well, I would have assumed that your input data would

[jira] [Resolved] (KAFKA-10601) Add linger semantics to raft

2020-10-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10601. - Resolution: Fixed > Add linger semantics to raft > > >

[GitHub] [kafka] hachikuji merged pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-27 Thread GitBox
hachikuji merged pull request #9418: URL: https://github.com/apache/kafka/pull/9418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10648) Add Prefix Scan support to State Stores

2020-10-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10648: Component/s: streams > Add Prefix Scan support to State Stores >

[jira] [Updated] (KAFKA-10648) Add Prefix Scan support to State Stores

2020-10-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10648: Labels: kip (was: ) > Add Prefix Scan support to State Stores >

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-10-27 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r512951535 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1246,7 +1337,57 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] ramesh-muthusamy commented on a change in pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-10-27 Thread GitBox
ramesh-muthusamy commented on a change in pull request #9319: URL: https://github.com/apache/kafka/pull/9319#discussion_r512945677 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -577,15

[GitHub] [kafka] ramesh-muthusamy edited a comment on pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-10-27 Thread GitBox
ramesh-muthusamy edited a comment on pull request #9319: URL: https://github.com/apache/kafka/pull/9319#issuecomment-717450100 @kkonstantine this is a good scenario, let me test and see if it is already captured. Thanks for test case.

[GitHub] [kafka] ramesh-muthusamy commented on a change in pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-10-27 Thread GitBox
ramesh-muthusamy commented on a change in pull request #9319: URL: https://github.com/apache/kafka/pull/9319#discussion_r512938623 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -445,16

[GitHub] [kafka] bbejeck commented on pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9511: URL: https://github.com/apache/kafka/pull/9511#issuecomment-717454236 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ramesh-muthusamy commented on a change in pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-10-27 Thread GitBox
ramesh-muthusamy commented on a change in pull request #9319: URL: https://github.com/apache/kafka/pull/9319#discussion_r512938005 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -577,15

[GitHub] [kafka] ramesh-muthusamy commented on pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-10-27 Thread GitBox
ramesh-muthusamy commented on pull request #9319: URL: https://github.com/apache/kafka/pull/9319#issuecomment-717450100 @kkonstantine this is a good scenario, let me test and see it is already captured. Thanks for test case.

[GitHub] [kafka] bbejeck commented on pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9511: URL: https://github.com/apache/kafka/pull/9511#issuecomment-717449278 Merged #9511 into trunk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck merged pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck merged pull request #9511: URL: https://github.com/apache/kafka/pull/9511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9511: URL: https://github.com/apache/kafka/pull/9511#issuecomment-717447946 only HTML so merging This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-10-27 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r512928815 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1207,14 +1286,26 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] kkonstantine commented on pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

2020-10-27 Thread GitBox
kkonstantine commented on pull request #9319: URL: https://github.com/apache/kafka/pull/9319#issuecomment-717433838 After writing another test, I confirmed my impression after first reading the code. So, this fix would help if all the lost workers joined after leaving the group at about

[jira] [Commented] (KAFKA-7987) a broker's ZK session may die on transient auth failure

2020-10-27 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221624#comment-17221624 ] Jun Rao commented on KAFKA-7987: [~rsivaram], yes, I think this issue still exists on all versions of

[GitHub] [kafka] lizthegrey commented on pull request #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-10-27 Thread GitBox
lizthegrey commented on pull request #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-717421301 Honeycomb doesn't directly have an interest in this as we use Confluent's packages, but we do run Confluent's Kafka distro on ARM64 (successfully).

[GitHub] [kafka] guozhangwang commented on pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-27 Thread GitBox
guozhangwang commented on pull request #9418: URL: https://github.com/apache/kafka/pull/9418#issuecomment-717420938 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-10638) QueryableStateIntegrationTest fails due to stricter store checking

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10638: Priority: Major (was: Blocker) > QueryableStateIntegrationTest fails due to stricter store

[jira] [Comment Edited] (KAFKA-10638) QueryableStateIntegrationTest fails due to stricter store checking

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221610#comment-17221610 ] Bill Bejeck edited comment on KAFKA-10638 at 10/27/20, 5:48 PM: Hey

[jira] [Updated] (KAFKA-10638) QueryableStateIntegrationTest fails due to stricter store checking

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10638: Fix Version/s: (was: 2.7.0) 2.7.1 2.8.0 >

[jira] [Commented] (KAFKA-10638) QueryableStateIntegrationTest fails due to stricter store checking

2020-10-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221610#comment-17221610 ] Bill Bejeck commented on KAFKA-10638: - Hey [~vvcephei] I appreciate you wanting to get a fix in for

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-10-27 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r512888360 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -526,10 +527,14 @@ private[kafka] abstract class

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-10-27 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r512887499 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -697,6 +714,31 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-10-27 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r512887499 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -697,6 +714,31 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] jsancio opened a new pull request #9512: [DRAFT] - KAFKA-10394: generate snapshot

2020-10-27 Thread GitBox
jsancio opened a new pull request #9512: URL: https://github.com/apache/kafka/pull/9512 This PR depends on https://github.com/apache/kafka/pull/9505. I will rebase this PR once https://github.com/apache/kafka/pull/9505 has been merged. This PR adds support for generating snapshot

[GitHub] [kafka] bbejeck commented on pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9511: URL: https://github.com/apache/kafka/pull/9511#issuecomment-717387683 Once merged I'll cherry-pick this to 2.7 This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] bbejeck commented on pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck commented on pull request #9511: URL: https://github.com/apache/kafka/pull/9511#issuecomment-717387337 @kowshik here's the text we discussed offline yesterday for the upgrade section. This is an automated message

[GitHub] [kafka] bbejeck opened a new pull request #9511: MINOR: Add KIP-584 to upgrade.html file

2020-10-27 Thread GitBox
bbejeck opened a new pull request #9511: URL: https://github.com/apache/kafka/pull/9511 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-27 Thread GitBox
hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512847195 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] brbrown25 edited a comment on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…

2020-10-27 Thread GitBox
brbrown25 edited a comment on pull request #9057: URL: https://github.com/apache/kafka/pull/9057#issuecomment-717322569 - [x] update with latest master - [ ] implement nested field support - [ ] implement salt support

[jira] [Commented] (KAFKA-10637) KafkaProducer: IllegalMonitorStateException

2020-10-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221527#comment-17221527 ] Chia-Ping Tsai commented on KAFKA-10637: [~katiforis] Thanks for your report. Could you share

[GitHub] [kafka] joshuagrisham commented on pull request #9492: KAFKA-10627: Added support for Connect TimestampConverter to convert multiple fields using a comma-separated list, and changed the Strin

2020-10-27 Thread GitBox
joshuagrisham commented on pull request #9492: URL: https://github.com/apache/kafka/pull/9492#issuecomment-717335784 Yeah unfortunately some of the downstream the checks are still failing, it seems to be related to this issue https://issues.apache.org/jira/browse/KAFKA-10017 But all

[jira] [Created] (KAFKA-10650) Use Murmur3 hashing instead of MD5 in SkimpyOffsetMap

2020-10-27 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-10650: --- Summary: Use Murmur3 hashing instead of MD5 in SkimpyOffsetMap Key: KAFKA-10650 URL: https://issues.apache.org/jira/browse/KAFKA-10650 Project: Kafka

[jira] [Updated] (KAFKA-10650) Use Murmur3 hashing instead of MD5 in SkimpyOffsetMap

2020-10-27 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-10650: Description: The usage of MD5 has been uncovered during testing Kafka for FIPS

[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…

2020-10-27 Thread GitBox
brbrown25 commented on pull request #9057: URL: https://github.com/apache/kafka/pull/9057#issuecomment-717322569 - [ ] update with latest master - [ ] implement nested field support - [ ] implement salt support This is

[GitHub] [kafka] rondagostino closed pull request #9510: Add additional MetadataRecordType enums

2020-10-27 Thread GitBox
rondagostino closed pull request #9510: URL: https://github.com/apache/kafka/pull/9510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rondagostino opened a new pull request #9510: Add additional MetadataRecordType enums

2020-10-27 Thread GitBox
rondagostino opened a new pull request #9510: URL: https://github.com/apache/kafka/pull/9510 Note that I had to remove `"mapKey": true` from `FeatureLevelRecord.json` because with it I was seeing this stack trace during the build: ``` Exception in thread "main"

[GitHub] [kafka] showuon commented on pull request #9507: KAFKA-10628: remove unneeded javadoc for TopologyTestDriver and some refactor

2020-10-27 Thread GitBox
showuon commented on pull request #9507: URL: https://github.com/apache/kafka/pull/9507#issuecomment-717223593 tests/Build/JDK 8: Pass tests/Build/JDK 15: unrelated to my change failed -

[jira] [Resolved] (KAFKA-10108) The cached configs of SslFactory should be updated only if the ssl Engine Factory is updated successfully

2020-10-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10108. Resolution: Won't Fix > The cached configs of SslFactory should be updated only if the

[jira] [Resolved] (KAFKA-10125) The partition which is removing should be considered to be under reassignment

2020-10-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10125. Resolution: Won't Fix > The partition which is removing should be considered to be under

[GitHub] [kafka] chia7712 closed pull request #8837: KAFKA-10125 The partition which is removing should be considered to b…

2020-10-27 Thread GitBox
chia7712 closed pull request #8837: URL: https://github.com/apache/kafka/pull/8837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 closed pull request #8806: KAFKA-10108 The cached configs of SslFactory should be updated only i…

2020-10-27 Thread GitBox
chia7712 closed pull request #8806: URL: https://github.com/apache/kafka/pull/8806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-9697) ControlPlaneNetworkProcessorAvgIdlePercent is always NaN

2020-10-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221385#comment-17221385 ] Chia-Ping Tsai commented on KAFKA-9697: --- the patch may break metrics so KIP is required. >

[jira] [Updated] (KAFKA-9697) ControlPlaneNetworkProcessorAvgIdlePercent is always NaN

2020-10-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-9697: -- Labels: need-kip (was: ) > ControlPlaneNetworkProcessorAvgIdlePercent is always NaN >

[jira] [Assigned] (KAFKA-9697) ControlPlaneNetworkProcessorAvgIdlePercent is always NaN

2020-10-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-9697: - Assignee: (was: Chia-Ping Tsai) > ControlPlaneNetworkProcessorAvgIdlePercent is

[GitHub] [kafka] chia7712 commented on pull request #9283: KAFKA-9697 hide the metrics of control.plane.listener.name if it is u…

2020-10-27 Thread GitBox
chia7712 commented on pull request #9283: URL: https://github.com/apache/kafka/pull/9283#issuecomment-717212130 As it may break metrics compatibility, I'm going to close it. This is an automated message from the Apache Git

[GitHub] [kafka] chia7712 closed pull request #9283: KAFKA-9697 hide the metrics of control.plane.listener.name if it is u…

2020-10-27 Thread GitBox
chia7712 closed pull request #9283: URL: https://github.com/apache/kafka/pull/9283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #9169: MINOR: the scheduler used to perform rebalance should have thread prefix

2020-10-27 Thread GitBox
chia7712 commented on pull request #9169: URL: https://github.com/apache/kafka/pull/9169#issuecomment-717211456 @ijuma Does it need a KIP to resolve naming conflict in metrics? Although I'm wonder whether is there a use case using this conflicted name.

[GitHub] [kafka] chia7712 closed pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

2020-10-27 Thread GitBox
chia7712 closed pull request #9469: URL: https://github.com/apache/kafka/pull/9469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

2020-10-27 Thread GitBox
chia7712 commented on pull request #9469: URL: https://github.com/apache/kafka/pull/9469#issuecomment-717207972 @ijuma Thanks for your comment. close it due to the bad refactor :( This is an automated message from the Apache

[GitHub] [kafka] chia7712 commented on pull request #9509: MINOR: rename metrics "iotime-total" to "io-time-total" and "io-waitt…

2020-10-27 Thread GitBox
chia7712 commented on pull request #9509: URL: https://github.com/apache/kafka/pull/9509#issuecomment-717207173 @dajac thanks for reminder. I don't think this patch is worth doing that effort. close it. This is an automated

[GitHub] [kafka] chia7712 closed pull request #9509: MINOR: rename metrics "iotime-total" to "io-time-total" and "io-waitt…

2020-10-27 Thread GitBox
chia7712 closed pull request #9509: URL: https://github.com/apache/kafka/pull/9509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-8124) Beginning offset is after the ending offset for topic partition

2020-10-27 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221366#comment-17221366 ] Yu Wang commented on KAFKA-8124: +1 spark2.3.2 with kafka2.0 > Beginning offset is after the ending

[jira] [Updated] (KAFKA-7987) a broker's ZK session may die on transient auth failure

2020-10-27 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-7987: -- Issue Type: Bug (was: Improvement) Priority: Critical (was: Major) > a broker's ZK

[jira] [Commented] (KAFKA-7987) a broker's ZK session may die on transient auth failure

2020-10-27 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221328#comment-17221328 ] Rajini Sivaram commented on KAFKA-7987: --- [~junrao] This is still an open issue for all versions of

[GitHub] [kafka] dajac commented on pull request #9509: MINOR: rename metrics "iotime-total" to "io-time-total" and "io-waitt…

2020-10-27 Thread GitBox
dajac commented on pull request #9509: URL: https://github.com/apache/kafka/pull/9509#issuecomment-717165385 @chia7712 Thanks for the PR. Renaming it may break monitoring of existing users. As metrics are part of the public API, we may need a KIP to fix this...

[jira] [Commented] (KAFKA-10649) CPU increase after the upgrade to Kafka 2.5

2020-10-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221296#comment-17221296 ] Ismael Juma commented on KAFKA-10649: - Thanks for the report. This is likely KAFKA-9731. I would

[GitHub] [kafka] chia7712 commented on a change in pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch

2020-10-27 Thread GitBox
chia7712 commented on a change in pull request #9505: URL: https://github.com/apache/kafka/pull/9505#discussion_r512566562 ## File path: clients/src/main/resources/common/message/FetchSnapshotRequest.json ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-10647) Only serialize owned partition when consumer protocol version >= 0

2020-10-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10647. - Resolution: Fixed > Only serialize owned partition when consumer protocol version >= 0 >

[GitHub] [kafka] dajac merged pull request #9506: KAFKA-10647; Only serialize owned partitions when consumer protocol version >= 1

2020-10-27 Thread GitBox
dajac merged pull request #9506: URL: https://github.com/apache/kafka/pull/9506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #9506: KAFKA-10647; Only serialize owned partitions when consumer protocol version >= 1

2020-10-27 Thread GitBox
dajac commented on pull request #9506: URL: https://github.com/apache/kafka/pull/9506#issuecomment-717132358 @hachikuji @chia7712 Thanks for your review! Merging to trunk and 2.7. This is an automated message from the Apache

[jira] [Updated] (KAFKA-10649) CPU increase after the upgrade to Kafka 2.5

2020-10-27 Thread Valentina Glagoleva (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentina Glagoleva updated KAFKA-10649: Description: After an upgrade from Kafka 2.2.1 to Kafka 2.5.1 we noticed, that

[jira] [Updated] (KAFKA-10649) CPU increase after the upgrade to Kafka 2.5

2020-10-27 Thread Valentina Glagoleva (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentina Glagoleva updated KAFKA-10649: Description: After an upgrade from Kafka 2.2.1 to Kafka 2.5.1 we noticed, that

[jira] [Updated] (KAFKA-10649) CPU increase after the upgrade to Kafka 2.5

2020-10-27 Thread Valentina Glagoleva (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentina Glagoleva updated KAFKA-10649: Description: After an upgrade from Kafka 2.2.1 to Kafka 2.5.1 we noticed, that

[GitHub] [kafka] showuon commented on pull request #9507: KAFKA-10628: remove unneeded javadoc for TopologyTestDriver and some refactor

2020-10-27 Thread GitBox
showuon commented on pull request #9507: URL: https://github.com/apache/kafka/pull/9507#issuecomment-717119800 @chia7712 , thanks for your reminder. I've removed all the unnecessary parameters (BOOTSTRAP_SERVERS_CONFIG and APPLICATION_ID_CONFIG) from the tests which are using

[jira] [Updated] (KAFKA-10649) CPU increase after the upgrade to Kafka 2.5

2020-10-27 Thread Valentina Glagoleva (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentina Glagoleva updated KAFKA-10649: Description: After an upgrade from Kafka 2.2.1 to Kafka 2.5.1 we noticed, that

[GitHub] [kafka] chia7712 merged pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-27 Thread GitBox
chia7712 merged pull request #9162: URL: https://github.com/apache/kafka/pull/9162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >