[GitHub] [kafka] abbccdda opened a new pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-04 Thread GitBox
abbccdda opened a new pull request #9564: URL: https://github.com/apache/kafka/pull/9564 Right now the forwarding request will retry indefinitely, which is not the ideal behavior. We should timeout the enqueued request when it hits the request timeout. ### Committer Checklist

[GitHub] [kafka] chia7712 commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
chia7712 commented on pull request #9562: URL: https://github.com/apache/kafka/pull/9562#issuecomment-722185108 @kowshik Thanks for patch. Merge to trunk This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 merged pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
chia7712 merged pull request #9562: URL: https://github.com/apache/kafka/pull/9562 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-04 Thread GitBox
chia7712 commented on pull request #9563: URL: https://github.com/apache/kafka/pull/9563#issuecomment-722184706 Does this improvement work for other requests? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] chia7712 commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-04 Thread GitBox
chia7712 commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r517824324 ## File path: clients/src/main/java/org/apache/kafka/common/network/SendBuilder.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] chia7712 commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-04 Thread GitBox
chia7712 commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r517822478 ## File path: clients/src/main/resources/common/message/EnvelopeRequest.json ## @@ -23,7 +23,7 @@ "fields": [ { "name": "RequestData", "type":

[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-11-04 Thread Sarita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224651#comment-17224651 ] Sarita edited comment on KAFKA-7500 at 11/5/20, 6:24 AM: - Hi [~ryannedolan] We

[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-11-04 Thread Sarita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224651#comment-17224651 ] Sarita edited comment on KAFKA-7500 at 11/5/20, 6:13 AM: - Hi [~ryannedolan] We

[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-11-04 Thread Sarita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224651#comment-17224651 ] Sarita edited comment on KAFKA-7500 at 11/5/20, 6:13 AM: - Hi [~ryannedolan] We

[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-11-04 Thread Sarita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224651#comment-17224651 ] Sarita edited comment on KAFKA-7500 at 11/5/20, 6:12 AM: - Hi [~ryannedolan] We

[jira] [Comment Edited] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-11-04 Thread Sarita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224651#comment-17224651 ] Sarita edited comment on KAFKA-7500 at 11/5/20, 6:11 AM: - Hi [~ryannedolan] We

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-11-04 Thread Sarita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226507#comment-17226507 ] Sarita commented on KAFKA-7500: --- Was able to fix the bootstrap-server disconnect issue. Went through all

[jira] [Updated] (KAFKA-10685) --to-datetime passed to kafka-consumer-groups interpreting microseconds wrong

2020-11-04 Thread Russell Sayers (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russell Sayers updated KAFKA-10685: --- Description: If you pass more than 3 decimal places for the fractional seconds of the

[jira] [Updated] (KAFKA-10685) --to-datetime passed to kafka-consumer-groups interpreting microseconds wrong

2020-11-04 Thread Russell Sayers (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russell Sayers updated KAFKA-10685: --- Description: f you pass more than 3 decimal places for the fractional seconds of the

[jira] [Updated] (KAFKA-10685) --to-datetime passed to kafka-consumer-groups interpreting microseconds wrong

2020-11-04 Thread Russell Sayers (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russell Sayers updated KAFKA-10685: --- Summary: --to-datetime passed to kafka-consumer-groups interpreting microseconds wrong

[jira] [Created] (KAFKA-10685) --to-datetime passed to kafka-consumer-groups getting interpreted as a timezone

2020-11-04 Thread Russell Sayers (Jira)
Russell Sayers created KAFKA-10685: -- Summary: --to-datetime passed to kafka-consumer-groups getting interpreted as a timezone Key: KAFKA-10685 URL: https://issues.apache.org/jira/browse/KAFKA-10685

[GitHub] [kafka] hachikuji opened a new pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-04 Thread GitBox
hachikuji opened a new pull request #9563: URL: https://github.com/apache/kafka/pull/9563 This patch creates a new `SendBuilder` class which allows us to avoid copying "bytes" types when transmitting an api message over the network. This is used in `EnvelopeRequest` and `EnvelopeResponse`

[jira] [Created] (KAFKA-10684) Avoid additional copies in envelope path when transmitting over network

2020-11-04 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10684: --- Summary: Avoid additional copies in envelope path when transmitting over network Key: KAFKA-10684 URL: https://issues.apache.org/jira/browse/KAFKA-10684

[GitHub] [kafka] kowshik commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
kowshik commented on pull request #9562: URL: https://github.com/apache/kafka/pull/9562#issuecomment-722130040 @chia7712 I've rebased now on top of #9559. Hopefully the build will go green. Thank you for the review! This is

[GitHub] [kafka] chia7712 commented on pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-04 Thread GitBox
chia7712 commented on pull request #8826: URL: https://github.com/apache/kafka/pull/8826#issuecomment-722128511 @junrao Thanks for your response. fixed. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
chia7712 commented on pull request #9562: URL: https://github.com/apache/kafka/pull/9562#issuecomment-722124176 @kowshik I have merged #9559. Could you rebase PR to trigger QA again? This is an automated message from the

[GitHub] [kafka] chia7712 merged pull request #9559: HOTFIX: RequestContext constructor change

2020-11-04 Thread GitBox
chia7712 merged pull request #9559: URL: https://github.com/apache/kafka/pull/9559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] kowshik edited a comment on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration

2020-11-04 Thread GitBox
kowshik edited a comment on pull request #9561: URL: https://github.com/apache/kafka/pull/9561#issuecomment-722113042 The build in CI is broken due to absence of https://github.com/apache/kafka/pull/9559. I'll rebase on top of latest AK trunk, after that PR is merged.

[GitHub] [kafka] kowshik edited a comment on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
kowshik edited a comment on pull request #9562: URL: https://github.com/apache/kafka/pull/9562#issuecomment-722119275 The build in CI is broken due to absence of #9559. I'll rebase on top of latest AK trunk, after that PR is merged.

[GitHub] [kafka] kowshik commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
kowshik commented on pull request #9562: URL: https://github.com/apache/kafka/pull/9562#issuecomment-722119275 The build in CI is broken due to #9559 . I'll rebase on top of latest AK trunk, after that PR is merged. This is

[GitHub] [kafka] kowshik commented on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration

2020-11-04 Thread GitBox
kowshik commented on pull request #9561: URL: https://github.com/apache/kafka/pull/9561#issuecomment-722113042 The build in CI is broken due to https://github.com/apache/kafka/pull/9559 . I'll rebase on top of latest AK trunk, after that PR is merged.

[GitHub] [kafka] kowshik opened a new pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

2020-11-04 Thread GitBox
kowshik opened a new pull request #9562: URL: https://github.com/apache/kafka/pull/9562 Fixed the param doc in `FinalizedFeatureChangeListener.initOrThrow` method. The parameter `waitOnceForCacheUpdateMs` is expected to be > 0, but the doc was incorrect.

[GitHub] [kafka] kowshik commented on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration

2020-11-04 Thread GitBox
kowshik commented on pull request #9561: URL: https://github.com/apache/kafka/pull/9561#issuecomment-722097335 @junrao @abbccdda: this PR is ready for review. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kowshik opened a new pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration

2020-11-04 Thread GitBox
kowshik opened a new pull request #9561: URL: https://github.com/apache/kafka/pull/9561 In this PR, I've switched the `FeatureZNodeStatus` enum to be a sealed trait. In Scala, we prefer sealed traits over Enumeration since the former gives you exhaustiveness checking. With Scala

[jira] [Assigned] (KAFKA-10624) [Easy] FeatureZNodeStatus should use sealed trait instead of Enumeration

2020-11-04 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam reassigned KAFKA-10624: Assignee: Kowshik Prakasam > [Easy] FeatureZNodeStatus should use sealed trait

[GitHub] [kafka] abbccdda opened a new pull request #9560: KAFKA-10345: Add ZK-notification based update for trust/key store paths

2020-11-04 Thread GitBox
abbccdda opened a new pull request #9560: URL: https://github.com/apache/kafka/pull/9560 SSL trust store and key store paths update could no longer go through the direct per broker update due to forwarding. We need to add a mechanism to trigger the update through ZK notification.

[jira] [Resolved] (KAFKA-10181) Create Envelope RPC and redirection template for configuration change RPCs

2020-11-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10181. - Resolution: Fixed > Create Envelope RPC and redirection template for configuration change RPCs

[GitHub] [kafka] abbccdda opened a new pull request #9559: HOTFIX: RequestContext constructor change

2020-11-04 Thread GitBox
abbccdda opened a new pull request #9559: URL: https://github.com/apache/kafka/pull/9559 Hit an unfortunate merge conflict at the same time with https://github.com/apache/kafka/commit/5df8457e05f6808145e90f5637d7f8a4aed548d9 ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] abbccdda opened a new pull request #9558: KAFKA-10342: migrate remaining RPCs to forwarding

2020-11-04 Thread GitBox
abbccdda opened a new pull request #9558: URL: https://github.com/apache/kafka/pull/9558 This PR will follow up https://github.com/apache/kafka/commit/0814e4f645880a3c63102fc197c8912c63846ad5 to migrate the remaining RPCs which need forwarding: - CreateAcls - DeleteAcls -

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703078 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703953 ## File path: raft/src/main/java/org/apache/kafka/snapshot/BatchedSnapshotWriter.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703625 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703078 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517699783 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517672247 ## File path: core/src/main/scala/kafka/snapshot/KafkaSnapshotReader.scala ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517651742 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517665383 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517665383 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void

[GitHub] [kafka] abbccdda merged pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-11-04 Thread GitBox
abbccdda merged pull request #9103: URL: https://github.com/apache/kafka/pull/9103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517665383 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void

[GitHub] [kafka] abbccdda commented on pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-11-04 Thread GitBox
abbccdda commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-722005317 Mvn failure is not related, merging This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] niteshmor commented on pull request #9556: MINOR: Update jetty to 9.4.33

2020-11-04 Thread GitBox
niteshmor commented on pull request #9556: URL: https://github.com/apache/kafka/pull/9556#issuecomment-721998495 Test failure seems to be unrelated. `java.nio.file.DirectoryNotEmptyException` in

[GitHub] [kafka] niteshmor edited a comment on pull request #9556: MINOR: Update jetty to 9.4.33

2020-11-04 Thread GitBox
niteshmor edited a comment on pull request #9556: URL: https://github.com/apache/kafka/pull/9556#issuecomment-721898016 For applying this fix to older branches, this commit can be cherry-picked to `2.7` branch. For branches `2.6` and earlier, `jersey` version also needs to be

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517651742 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517649219 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517645718 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] junrao commented on pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-04 Thread GitBox
junrao commented on pull request #8826: URL: https://github.com/apache/kafka/pull/8826#issuecomment-721987780 @chia7712 : Thanks for the PR. I ran the following command with the PR. bin/kafka-topics.sh --bootstrap-server localhost:9092 --command-config kafka.properties --create

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r517630320 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -783,12 +781,13 @@ private KafkaStreams(final

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r517630194 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -783,12 +781,13 @@ private KafkaStreams(final

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r517629961 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -719,8 +718,7 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517627843 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StreamsAssignmentProtocolVersions.java ## @@ -19,7 +19,7 @@

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517621757 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -294,7 +304,10 @@ public static StreamThread

[jira] [Created] (KAFKA-10683) Consumer.position() Ignores Transaction Marker with read_uncommitted

2020-11-04 Thread Gary Russell (Jira)
Gary Russell created KAFKA-10683: Summary: Consumer.position() Ignores Transaction Marker with read_uncommitted Key: KAFKA-10683 URL: https://issues.apache.org/jira/browse/KAFKA-10683 Project: Kafka

[jira] [Resolved] (KAFKA-7987) a broker's ZK session may die on transient auth failure

2020-11-04 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-7987. --- Fix Version/s: 2.8.0 Reviewer: Jun Rao Resolution: Fixed > a broker's ZK

[GitHub] [kafka] rajinisivaram closed pull request #9550: [DO NOT MERGE] Temporary PR to track test failure in Jenkins build

2020-11-04 Thread GitBox
rajinisivaram closed pull request #9550: URL: https://github.com/apache/kafka/pull/9550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram merged pull request #7751: KAFKA-7987: Reinitialize ZookeeperClient after auth failures

2020-11-04 Thread GitBox
rajinisivaram merged pull request #7751: URL: https://github.com/apache/kafka/pull/7751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram commented on pull request #7751: KAFKA-7987: Reinitialize ZookeeperClient after auth failures

2020-11-04 Thread GitBox
rajinisivaram commented on pull request #7751: URL: https://github.com/apache/kafka/pull/7751#issuecomment-721940645 Streams test failure not related, merging to trunk. This is an automated message from the Apache Git

[GitHub] [kafka] bbejeck merged pull request #9544: MINOR: Add back 2.6 notable update section taken out by mistake

2020-11-04 Thread GitBox
bbejeck merged pull request #9544: URL: https://github.com/apache/kafka/pull/9544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on pull request #9544: MINOR: Add back 2.6 notable update section taken out by mistake

2020-11-04 Thread GitBox
bbejeck commented on pull request #9544: URL: https://github.com/apache/kafka/pull/9544#issuecomment-721937375 Merged #9544 into trunk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517576758 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -311,6 +317,22 @@ public void run() {

[GitHub] [kafka] lbradstreet commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
lbradstreet commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517562348 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void

[GitHub] [kafka] lbradstreet commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
lbradstreet commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517562348 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void

[jira] [Resolved] (KAFKA-10682) Windows Kafka cluster not reachable via Azure data Bricks

2020-11-04 Thread navin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] navin resolved KAFKA-10682. --- Resolution: Fixed kafka\config Add  listeners = PLAINTEXT://10.53.56.140:9092 > Windows Kafka cluster

[jira] [Commented] (KAFKA-10682) Windows Kafka cluster not reachable via Azure data Bricks

2020-11-04 Thread navin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226342#comment-17226342 ] navin commented on KAFKA-10682: --- uncommented below command  in server-properties located at kafka\config;

[GitHub] [kafka] mikebin commented on pull request #8690: KAFKA-9965: Fix uneven distribution in RoundRobinPartitioner

2020-11-04 Thread GitBox
mikebin commented on pull request #8690: URL: https://github.com/apache/kafka/pull/8690#issuecomment-721907104 Looks like this is still pending completion? Just wanted to check on status of getting this merged. This is an

[GitHub] [kafka] cmccabe closed pull request #9557: Kip 500 move legacy

2020-11-04 Thread GitBox
cmccabe closed pull request #9557: URL: https://github.com/apache/kafka/pull/9557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe opened a new pull request #9557: Kip 500 move legacy

2020-11-04 Thread GitBox
cmccabe opened a new pull request #9557: URL: https://github.com/apache/kafka/pull/9557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-10682) Windows Kafka cluster not reachable via Azure data Bricks

2020-11-04 Thread navin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] navin updated KAFKA-10682: -- Description: We have windows Kafka cluster, * We enabled inbound and outbound for port 9092/9093 * Topic

[jira] [Updated] (KAFKA-10682) Windows Kafka cluster not reachable via Azure data Bricks

2020-11-04 Thread navin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] navin updated KAFKA-10682: -- Description: We have windows Kafka cluster, * We enabled inbound and outbound for port 9092/9093 * Topic

[jira] [Created] (KAFKA-10682) Windows Kafka cluster not reachable via Azure data Bricks

2020-11-04 Thread navin (Jira)
navin created KAFKA-10682: - Summary: Windows Kafka cluster not reachable via Azure data Bricks Key: KAFKA-10682 URL: https://issues.apache.org/jira/browse/KAFKA-10682 Project: Kafka Issue Type: Bug

[GitHub] [kafka] niteshmor commented on pull request #9556: MINOR: Update jetty to 9.4.33

2020-11-04 Thread GitBox
niteshmor commented on pull request #9556: URL: https://github.com/apache/kafka/pull/9556#issuecomment-721900447 cc @ijuma @kkonstantine @rhauch @C0urante This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] niteshmor commented on pull request #9556: MINOR: Update jetty to 9.4.33

2020-11-04 Thread GitBox
niteshmor commented on pull request #9556: URL: https://github.com/apache/kafka/pull/9556#issuecomment-721898016 For applying this fix to older branches, this commit can be cherry-picked to `2.7` branch. For branches `2.6` and earlier, `jersey` version also needs to be upgraded to

[GitHub] [kafka] niteshmor opened a new pull request #9556: MINOR: Update jetty to 9.4.33

2020-11-04 Thread GitBox
niteshmor opened a new pull request #9556: URL: https://github.com/apache/kafka/pull/9556 Jetty 9.4.32 and before are affected by CVE-2020-27216. This vulnerability is fixed in Jetty 9.4.33, please see the jetty project security advisory for details:

[GitHub] [kafka] ableegoldman commented on pull request #8953: MINOR: re-enable EosBetaUpgradeIntegrationTest

2020-11-04 Thread GitBox
ableegoldman commented on pull request #8953: URL: https://github.com/apache/kafka/pull/8953#issuecomment-721896700 I believe @mjsax is planning to look into it after his current work, but it seems reasonable to disable it again until then

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517543638 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StreamsAssignmentProtocolVersions.java ## @@ -19,7 +19,7

[GitHub] [kafka] vvcephei commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
vvcephei commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r517539432 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -719,8 +718,7 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Assigned] (KAFKA-7556) KafkaConsumer.beginningOffsets does not return actual first offsets

2020-11-04 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-7556: - Assignee: Justine Olshan > KafkaConsumer.beginningOffsets does not return actual first

[GitHub] [kafka] wcarlson5 commented on pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
wcarlson5 commented on pull request #9543: URL: https://github.com/apache/kafka/pull/9543#issuecomment-721881768 @cadonna Looks like all those changes made sense This is an automated message from the Apache Git Service. To

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r517516580 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -719,8 +718,7 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Created] (KAFKA-10681) MM2 translateOffsets returns wrong offsets

2020-11-04 Thread Carlo Bongiovanni (Jira)
Carlo Bongiovanni created KAFKA-10681: - Summary: MM2 translateOffsets returns wrong offsets Key: KAFKA-10681 URL: https://issues.apache.org/jira/browse/KAFKA-10681 Project: Kafka Issue

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517485257 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -997,6 +1064,72 @@ private boolean close(final long timeoutMs) {

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517481718 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +374,66 @@ public void setUncaughtExceptionHandler(final

[jira] [Assigned] (KAFKA-10679) AK site docs changes need to get ported to Kafka/docs

2020-11-04 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-10679: --- Assignee: Bill Bejeck > AK site docs changes need to get ported to Kafka/docs >

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-11-04 Thread GitBox
vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r517462186 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -317,6 +317,9 @@ private void appendLeaderChangeMessage(LeaderState

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-04 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517464968 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StreamsAssignmentProtocolVersions.java ## @@ -19,7 +19,7 @@

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-11-04 Thread GitBox
vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r517462186 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -317,6 +317,9 @@ private void appendLeaderChangeMessage(LeaderState

[GitHub] [kafka] cadonna commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-04 Thread GitBox
cadonna commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r517426911 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -145,7 +145,7 @@ private final String clientId; private

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-04 Thread GitBox
dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517317354 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] bbejeck commented on pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

2020-11-04 Thread GitBox
bbejeck commented on pull request #9554: URL: https://github.com/apache/kafka/pull/9554#issuecomment-721734486 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] bbejeck commented on pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

2020-11-04 Thread GitBox
bbejeck commented on pull request #9554: URL: https://github.com/apache/kafka/pull/9554#issuecomment-721732656 Merged #9554 into trunk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck merged pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

2020-11-04 Thread GitBox
bbejeck merged pull request #9554: URL: https://github.com/apache/kafka/pull/9554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on a change in pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

2020-11-04 Thread GitBox
bbejeck commented on a change in pull request #9554: URL: https://github.com/apache/kafka/pull/9554#discussion_r517339602 ## File path: docs/streams/upgrade-guide.html ## @@ -135,14 +134,12 @@ Streams API tasks to their new owners in the background. Check out

[GitHub] [kafka] bbejeck commented on a change in pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

2020-11-04 Thread GitBox
bbejeck commented on a change in pull request #9554: URL: https://github.com/apache/kafka/pull/9554#discussion_r517339026 ## File path: docs/streams/developer-guide/testing.html ## @@ -73,67 +71,55 @@ // Processor API Topology topology = new Topology();

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-11-04 Thread GitBox
soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-721637971 > Took way to long to get this merged. My fault for screwing up several times. Thanks for not giving up on this and all the time dedicated to reviewing.

[GitHub] [kafka] tombentley commented on pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-11-04 Thread GitBox
tombentley commented on pull request #9365: URL: https://github.com/apache/kafka/pull/9365#issuecomment-721626482 @chia7712 I think there's overlap, but I think this one removes additional warnings because it also propagates usage tracking in `SslFactory`. (It also provides a non-public

  1   2   >