[jira] [Created] (KAFKA-10823) AdminOperationException has no error code

2020-12-07 Thread Lincong Li (Jira)
Lincong Li created KAFKA-10823: -- Summary: AdminOperationException has no error code Key: KAFKA-10823 URL: https://issues.apache.org/jira/browse/KAFKA-10823 Project: Kafka Issue Type: Bug

[GitHub] [kafka] lmr3796 commented on pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-07 Thread GitBox
lmr3796 commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-740431014 @chia7712 @ijuma I just rebased to latest trunk. Please take a look This is an automated message from the Apache

[GitHub] [kafka] showuon commented on pull request #9672: MINOR: work in progress for Eos test(don't review)

2020-12-07 Thread GitBox
showuon commented on pull request #9672: URL: https://github.com/apache/kafka/pull/9672#issuecomment-740423573 Hey @chia7712 , thanks for reminding. I know that actually, but actually, I think there's some other issues in this test. Just want to find it out. Maybe I'm wrong, but I just

[GitHub] [kafka] chia7712 commented on pull request #9672: MINOR: work in progress for Eos test(don't review)

2020-12-07 Thread GitBox
chia7712 commented on pull request #9672: URL: https://github.com/apache/kafka/pull/9672#issuecomment-740413073 FYI: #9688 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] UnityLung closed pull request #9703: KAFKA-10697 Remove ProduceResponse.responses

2020-12-07 Thread GitBox
UnityLung closed pull request #9703: URL: https://github.com/apache/kafka/pull/9703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10822) Force some stdout from downgrade_test.py/upgrade_test.py for Travis

2020-12-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10822: --- Summary: Force some stdout from downgrade_test.py/upgrade_test.py for Travis (was: Force

[jira] [Updated] (KAFKA-10822) Force some stdout from downgrade_test.py/upgrade_test.py for Travis

2020-12-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10822: --- Description: downgrade_test.py/upgrade_test.py does upgrade/downgrade for each tests. the

[jira] [Updated] (KAFKA-10822) Force some stdout from downgrade_test.py for Travis

2020-12-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10822: --- Description: downgrade_test.py does upgrade/downgrade for each tests. the upgrade/downgrade

[GitHub] [kafka] chia7712 opened a new pull request #9712: KAFKA-10822 Force some stdout from downgrade_test.py for Travis

2020-12-07 Thread GitBox
chia7712 opened a new pull request #9712: URL: https://github.com/apache/kafka/pull/9712 downgrade_test.py does upgrade/downgrade for each tests. the upgrade/downgrade tasks take 10+ mins in Travis env so we ought to print something in order to avoid timeout caused by Travis. ###

[jira] [Created] (KAFKA-10822) Force some stdout from downgrade_test.py for Travis

2020-12-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10822: -- Summary: Force some stdout from downgrade_test.py for Travis Key: KAFKA-10822 URL: https://issues.apache.org/jira/browse/KAFKA-10822 Project: Kafka

[GitHub] [kafka] guozhangwang commented on pull request #9690: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-07 Thread GitBox
guozhangwang commented on pull request #9690: URL: https://github.com/apache/kafka/pull/9690#issuecomment-740405554 LGTM. Left some comment on the PR for trunk. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] guozhangwang commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-07 Thread GitBox
guozhangwang commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r538062610 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -540,18 +535,18 @@ public void

[GitHub] [kafka] chia7712 commented on pull request #9711: MINOR: add "flush=True" to all print in system tests

2020-12-07 Thread GitBox
chia7712 commented on pull request #9711: URL: https://github.com/apache/kafka/pull/9711#issuecomment-740404375 @guozhangwang Please take a look as this is related to #9196 (which updated python from 2 to 3) This is an

[GitHub] [kafka] chia7712 opened a new pull request #9711: MINOR: add "flush=True" to all print in system tests

2020-12-07 Thread GitBox
chia7712 opened a new pull request #9711: URL: https://github.com/apache/kafka/pull/9711 That makes the behavior of ```print``` equal to pyhton2. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-07 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r538060397 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[jira] [Commented] (KAFKA-7878) Connect Task already exists in this worker when failed to create consumer

2020-12-07 Thread Loy Larvin Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245659#comment-17245659 ] Loy Larvin Rao commented on KAFKA-7878: --- Seeing the same issue in 2.6.0. > Connect Task already

[GitHub] [kafka] chia7712 commented on pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-07 Thread GitBox
chia7712 commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-740351361 @lmr3796 Thanks for your updating. Could you rebase code to include recent big commits to trigger QA again?

[jira] [Created] (KAFKA-10821) Send cluster id information with the FetchSnapshot request

2020-12-07 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10821: -- Summary: Send cluster id information with the FetchSnapshot request Key: KAFKA-10821 URL: https://issues.apache.org/jira/browse/KAFKA-10821

[jira] [Created] (KAFKA-10820) Update start offset and end offset of the replicated log

2020-12-07 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10820: -- Summary: Update start offset and end offset of the replicated log Key: KAFKA-10820 URL: https://issues.apache.org/jira/browse/KAFKA-10820

[jira] [Created] (KAFKA-10819) The freeze operation should validate the content of the snapshot

2020-12-07 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10819: -- Summary: The freeze operation should validate the content of the snapshot Key: KAFKA-10819 URL: https://issues.apache.org/jira/browse/KAFKA-10819

[GitHub] [kafka] chia7712 commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-07 Thread GitBox
chia7712 commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r537998894 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -391,6 +391,23 @@ Sender newSender(LogContext

[GitHub] [kafka] chia7712 commented on a change in pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

2020-12-07 Thread GitBox
chia7712 commented on a change in pull request #9707: URL: https://github.com/apache/kafka/pull/9707#discussion_r537998495 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -1115,6 +1115,10 @@ private void ensureValidRecordSize(int

[GitHub] [kafka] chia7712 commented on pull request #9694: MINOR: Change the input type of DescribeAclsResponse#aclsResources from Collection to Iterable to avoid creating useless collection

2020-12-07 Thread GitBox
chia7712 commented on pull request #9694: URL: https://github.com/apache/kafka/pull/9694#issuecomment-740342002 @chris8099 Could you rebase code to include https://github.com/apache/kafka/commit/8db3b1a09af0bad274e07161336994610d616b35? Also, please fix the conflicting.

[GitHub] [kafka] chia7712 commented on pull request #9705: MINOR: Using primitive data types for loop index

2020-12-07 Thread GitBox
chia7712 commented on pull request #9705: URL: https://github.com/apache/kafka/pull/9705#issuecomment-740340757 @APaMio Could you rebase code to include https://github.com/apache/kafka/commit/8db3b1a09af0bad274e07161336994610d616b35?

[GitHub] [kafka] ableegoldman commented on pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2020-12-07 Thread GitBox
ableegoldman commented on pull request #9671: URL: https://github.com/apache/kafka/pull/9671#issuecomment-740339466 Kicked off 30 versions of the system test which has seemed to be flaky due to this bug: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4302/

[jira] [Resolved] (KAFKA-7819) Trogdor - Improve RoundTripWorker

2020-12-07 Thread Gwen Shapira (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-7819. - Fix Version/s: 2.2.0 Resolution: Fixed Closing since I noticed the PR was merged. >

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-07 Thread GitBox
vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r537995450 ## File path: clients/src/main/resources/common/message/LeaderChangeMessage.json ## @@ -22,7 +22,11 @@ {"name": "LeaderId", "type": "int32",

[GitHub] [kafka] ableegoldman commented on a change in pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9671: URL: https://github.com/apache/kafka/pull/9671#discussion_r537990731 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -248,18 +243,26 @@ protected

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-07 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r537993156 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1037,6 +1047,14 @@ private boolean handleFetchResponse(

[GitHub] [kafka] ableegoldman commented on a change in pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9671: URL: https://github.com/apache/kafka/pull/9671#discussion_r537992012 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -235,11 +235,6 @@ protected

[GitHub] [kafka] ableegoldman commented on a change in pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9671: URL: https://github.com/apache/kafka/pull/9671#discussion_r537990731 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -248,18 +243,26 @@ protected

[GitHub] [kafka] jsancio commented on a change in pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch

2020-12-07 Thread GitBox
jsancio commented on a change in pull request #9505: URL: https://github.com/apache/kafka/pull/9505#discussion_r537990223 ## File path: clients/src/main/resources/common/message/FetchSnapshotResponse.json ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch

2020-12-07 Thread GitBox
jsancio commented on a change in pull request #9505: URL: https://github.com/apache/kafka/pull/9505#discussion_r537990130 ## File path: clients/src/main/resources/common/message/FetchSnapshotRequest.json ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ableegoldman commented on a change in pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9671: URL: https://github.com/apache/kafka/pull/9671#discussion_r537986486 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -853,7 +844,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r537976391 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r537974578 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r537955392 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r537958278 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,34 @@ class AlterIsrManagerImpl(val controllerChannelManager:

[GitHub] [kafka] apovzner commented on a change in pull request #9685: KAFKA-10748: Add IP connection rate throttling metric

2020-12-07 Thread GitBox
apovzner commented on a change in pull request #9685: URL: https://github.com/apache/kafka/pull/9685#discussion_r537955330 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1753,9 +1761,9 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,

[GitHub] [kafka] mumrah commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
mumrah commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r537948141 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,34 @@ class AlterIsrManagerImpl(val controllerChannelManager:

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -778,6 +793,10 @@ object ConfigCommand extends Config { val brokerLogger =

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -778,6 +793,10 @@ object ConfigCommand extends Config { val brokerLogger =

[GitHub] [kafka] junrao merged pull request #9710: MINOR: Remove redundant default parameter values in call to LogSegment.open

2020-12-07 Thread GitBox
junrao merged pull request #9710: URL: https://github.com/apache/kafka/pull/9710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] splett2 commented on pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on pull request #9628: URL: https://github.com/apache/kafka/pull/9628#issuecomment-740266395 Thanks for the feedback @dajac I went ahead and also refactored some tests in `ConfigCommandTest` that were a bit repetitive. Let me know what you think

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245587#comment-17245587 ] A. Sophie Blee-Goldman commented on KAFKA-10772: Specifically, I'm looking for the log

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537937603 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537937180 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245586#comment-17245586 ] A. Sophie Blee-Goldman commented on KAFKA-10772: Hey [~lkokhreidze] and/or

[GitHub] [kafka] ableegoldman commented on a change in pull request #9700: KAFKA-10813: InvalidProducerEpoch should be caught and throw as TaskMigrated

2020-12-07 Thread GitBox
ableegoldman commented on a change in pull request #9700: URL: https://github.com/apache/kafka/pull/9700#discussion_r537917953 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -199,7 +200,9 @@ private void

[jira] [Resolved] (KAFKA-10818) Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-10818. - Resolution: Fixed > Skip conversion to `Struct` when serializing generated requests/responses >

[GitHub] [kafka] ijuma commented on pull request #7409: KAFKA-10818: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread GitBox
ijuma commented on pull request #7409: URL: https://github.com/apache/kafka/pull/7409#issuecomment-740248672 Thanks for the review! Will post the follow up in a bit. This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma merged pull request #7409: KAFKA-10818: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread GitBox
ijuma merged pull request #7409: URL: https://github.com/apache/kafka/pull/7409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-10818) Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10818: Fix Version/s: 2.8.0 > Skip conversion to `Struct` when serializing generated requests/responses

[jira] [Created] (KAFKA-10818) Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-10818: --- Summary: Skip conversion to `Struct` when serializing generated requests/responses Key: KAFKA-10818 URL: https://issues.apache.org/jira/browse/KAFKA-10818 Project:

[GitHub] [kafka] abbccdda commented on pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
abbccdda commented on pull request #9564: URL: https://github.com/apache/kafka/pull/9564#issuecomment-740244739 Hit unrelated stream test failure, retest This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] lct45 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

2020-12-07 Thread GitBox
lct45 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r537899383 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -444,6 +444,27 @@ private void handleStreamsUncaughtException(final

[GitHub] [kafka] lct45 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

2020-12-07 Thread GitBox
lct45 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r537899383 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -444,6 +444,27 @@ private void handleStreamsUncaughtException(final

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r537868629 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[GitHub] [kafka] hachikuji merged pull request #9512: KAFKA-10394: generate snapshot

2020-12-07 Thread GitBox
hachikuji merged pull request #9512: URL: https://github.com/apache/kafka/pull/9512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r537867972 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-07 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r537867021 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-07 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-740199487 Benchmark results run against trunk: https://paste.ubuntu.com/p/zwKyQSrmDX/ This is an automated message

[GitHub] [kafka] d8tltanc edited a comment on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-07 Thread GitBox
d8tltanc edited a comment on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-740036778 https://paste.ubuntu.com/p/zKYc6rk6WY/ Benchmark with AclAuthorizer::updateCache With aclCount=50 and resourceCount=20, 20 call to updateCache

[GitHub] [kafka] rayokota commented on pull request #9701: KAFKA-10713: (redux) Also allow underscore in protocol name

2020-12-07 Thread GitBox
rayokota commented on pull request #9701: URL: https://github.com/apache/kafka/pull/9701#issuecomment-740192213 Perhaps we should have a KIP and discussion for this since it changes existing public behavior? In the meantime, we should probably revert the original PR.

[GitHub] [kafka] kowshik commented on pull request #9710: MINOR: Remove redundant default parameter values in call to LogSegment.open

2020-12-07 Thread GitBox
kowshik commented on pull request #9710: URL: https://github.com/apache/kafka/pull/9710#issuecomment-740186296 cc @junrao @ijuma for review This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kowshik opened a new pull request #9710: MINOR: Remove redundant default parameter values in call to LogSegment.open

2020-12-07 Thread GitBox
kowshik opened a new pull request #9710: URL: https://github.com/apache/kafka/pull/9710 Few call sites in `Log.scala` were passing redundant default values when making calls to `LogSegment.open(...)`. In this PR, I've cleaned these up. **Test plan:** Relying on existing unit and

[jira] [Assigned] (KAFKA-9126) Extend `StreamJoined` to allow more store configs

2020-12-07 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas reassigned KAFKA-9126: -- Assignee: (was: Leah Thomas) > Extend `StreamJoined` to allow more store configs >

[jira] [Assigned] (KAFKA-9126) Extend `StreamJoined` to allow more store configs

2020-12-07 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas reassigned KAFKA-9126: -- Assignee: Leah Thomas > Extend `StreamJoined` to allow more store configs >

[jira] [Updated] (KAFKA-10715) Support Kafka connect converter for AVRO

2020-12-07 Thread Ravindranath Kakarla (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindranath Kakarla updated KAFKA-10715: - Remaining Estimate: 72h (was: 336h) Original Estimate: 72h (was: 336h) >

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r537811235 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -198,7 +198,7 @@ private static FilterResult

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-12-07 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r537799398 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -386,6 +390,10 @@ public long maxOffset() {

[GitHub] [kafka] APaMio commented on pull request #9705: MINOR: Using primitive data types for loop index

2020-12-07 Thread GitBox
APaMio commented on pull request #9705: URL: https://github.com/apache/kafka/pull/9705#issuecomment-740157289 This request for change the loop index from wraps type to primitive type and some relative modify, those indices just used to pass as an argument not as an object, so I thought

[jira] [Commented] (KAFKA-10715) Support Kafka connect converter for AVRO

2020-12-07 Thread Ravindranath Kakarla (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245501#comment-17245501 ] Ravindranath Kakarla commented on KAFKA-10715: -- Can I contribute this change? > Support

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-12-07 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r537799341 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -198,7 +198,7 @@ private static FilterResult

[jira] [Issue Comment Deleted] (KAFKA-10715) Support Kafka connect converter for AVRO

2020-12-07 Thread Ravindra Nath Kakarla (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Nath Kakarla updated KAFKA-10715: -- Comment: was deleted (was: Can I contribute this change?) > Support Kafka

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-12-07 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r537791276 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -386,6 +390,10 @@ public long maxOffset() {

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r537789168 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -125,15 +129,25 @@ class

[jira] [Updated] (KAFKA-10792) Source tasks can block herder thread by hanging during stop

2020-12-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10792: -- Fix Version/s: (was: 2.7.1) > Source tasks can block herder thread by hanging during stop

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r537788538 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -34,8 +34,12 @@ import scala.collection.mutable import

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r537786674 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r537776855 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -386,6 +390,10 @@ public long maxOffset() {

[jira] [Commented] (KAFKA-10715) Support Kafka connect converter for AVRO

2020-12-07 Thread Ravindra Nath Kakarla (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245470#comment-17245470 ] Ravindra Nath Kakarla commented on KAFKA-10715: --- Can I contribute this change? > Support

[GitHub] [kafka] hachikuji commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r537757487 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -472,4 +490,106 @@ private EpochStartOffset(int epoch, long startOffset) {

[jira] [Updated] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10772: Fix Version/s: (was: 2.7.0) > java.lang.IllegalStateException: There are insufficient bytes

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245460#comment-17245460 ] Bill Bejeck commented on KAFKA-10772: - Hi [~vvcephei],  Since this appears to be an outstanding

[GitHub] [kafka] mumrah commented on pull request #9693: Refactor ZK ISR updates to use AlterIsrManager

2020-12-07 Thread GitBox
mumrah commented on pull request #9693: URL: https://github.com/apache/kafka/pull/9693#issuecomment-740123591 @hachikuji yes indeed. I just pushed a commit which does just that (removes PartitionStateStore) I also pushed a change which relocates the ISR propagation logic to

[jira] [Updated] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10772: - Fix Version/s: 2.7.0 > java.lang.IllegalStateException: There are insufficient bytes available

[jira] [Updated] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10772: - Priority: Blocker (was: Major) > java.lang.IllegalStateException: There are insufficient bytes

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245456#comment-17245456 ] John Roesler commented on KAFKA-10772: -- Hey [~bbejeck] , this might be a bit aggressive, but I

[GitHub] [kafka] hachikuji commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r537742991 ## File path: clients/src/main/resources/common/message/LeaderChangeMessage.json ## @@ -22,7 +22,11 @@ {"name": "LeaderId", "type": "int32",

[GitHub] [kafka] hachikuji opened a new pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

2020-12-07 Thread GitBox
hachikuji opened a new pull request #9709: URL: https://github.com/apache/kafka/pull/9709 We should configure a reconnect backoff for controller connections to prevent tight reconnect loops when the controller cannot be reached. I have borrowed the same configuration we use in

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r537709868 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:

[GitHub] [kafka] lct45 opened a new pull request #9708: [KAFKA-9126]: KIP-689: Add options to enable/disable logging for `StreamJoined`

2020-12-07 Thread GitBox
lct45 opened a new pull request #9708: URL: https://github.com/apache/kafka/pull/9708 Adds `withLoggingEnabled` and `withLoggingDisabled` for `StreamJoined` to give `StreamJoined` the same flexibility as `Materialized` This

[GitHub] [kafka] hachikuji commented on a change in pull request #9693: Refactor ZK ISR updates to use AlterIsrManager

2020-12-07 Thread GitBox
hachikuji commented on a change in pull request #9693: URL: https://github.com/apache/kafka/pull/9693#discussion_r537704021 ## File path: core/src/main/scala/kafka/server/ZkIsrManager.scala ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Created] (KAFKA-10817) Add clusterId validation to Fetch handling

2020-12-07 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10817: --- Summary: Add clusterId validation to Fetch handling Key: KAFKA-10817 URL: https://issues.apache.org/jira/browse/KAFKA-10817 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-10811) System exit from MirrorConnectorsIntegrationTest#testReplication

2020-12-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10811: -- Affects Version/s: (was: 2.5.1) (was: 2.6.0) > System exit

[jira] [Updated] (KAFKA-10811) System exit from MirrorConnectorsIntegrationTest#testReplication

2020-12-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10811: -- Fix Version/s: (was: 2.6.1) (was: 2.5.2) > System exit from

[jira] [Updated] (KAFKA-10816) Connect REST API should have a resource that can be used as a readiness probe

2020-12-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10816: -- Description: There are a few ways to accurately detect whether a Connect worker is

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-07 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-740056125 Hi @rajinisivaram. Thanks for the detailed review! I’ve addressed all comments you left. Also, after some optimization on the `resourceCache`, the benchmark looks much better

[jira] [Created] (KAFKA-10816) Connect REST API should have a resource that can be used as a readiness probe

2020-12-07 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10816: - Summary: Connect REST API should have a resource that can be used as a readiness probe Key: KAFKA-10816 URL: https://issues.apache.org/jira/browse/KAFKA-10816

  1   2   >