wcarlson5 commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803517708
@lct45 you might need to pick this to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vvcephei commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803507718
Thanks, @wcarlson5 and @ableegoldman !
Good point; I added a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
abbccdda commented on a change in pull request #10309:
URL: https://github.com/apache/kafka/pull/10309#discussion_r598134855
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java
##
@@ -880,6 +931,10 @@ public void verify() {
[
https://issues.apache.org/jira/browse/KAFKA-12515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
feyman updated KAFKA-12515:
---
Description:
*Background:*
Currently, `ApiVersionManager` generates `ApiVersionResponse` without
[
https://issues.apache.org/jira/browse/KAFKA-12515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
feyman updated KAFKA-12515:
---
Description:
*Background:*
Currently, `ApiVersionManager` generates `ApiVersionResponse` without
feyman created KAFKA-12515:
--
Summary: ApiVersionManager should create response based on request
version
Key: KAFKA-12515
URL: https://issues.apache.org/jira/browse/KAFKA-12515
Project: Kafka
Issue
vvcephei commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803501841
Hey @guozhangwang or maybe @ableegoldman , do you think you could take a
quick look at this?
In the javadoc for KIP-695's `currentLag` API, I even stated that it would
vvcephei opened a new pull request #10369:
URL: https://github.com/apache/kafka/pull/10369
Return null for partitionLag if there is no current position.
This was the desired semantics, the lack of the check was an
oversight.
Patches: KIP-695
Patches:
John Roesler created KAFKA-12514:
Summary: NPE in SubscriptionState
Key: KAFKA-12514
URL: https://issues.apache.org/jira/browse/KAFKA-12514
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-3745:
---
Fix Version/s: 3.0.0
> Consider adding join key to ValueJoiner interface
>
bbejeck commented on pull request #10150:
URL: https://github.com/apache/kafka/pull/10150#issuecomment-803500675
Merged #10150 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bbejeck merged pull request #10150:
URL: https://github.com/apache/kafka/pull/10150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305593#comment-17305593
]
Ben Chen commented on KAFKA-12492:
--
Hi, how can I get assigned for this task? Thanks.
> Formatting of
[
https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305590#comment-17305590
]
A. Sophie Blee-Goldman commented on KAFKA-12509:
Sure thing, feel free to pick this up.
[
https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-12509:
--
Assignee: Ketul Gupta
> Tighten up StateDirectory thread locking
>
Krzysztof Piecuch created KAFKA-12513:
-
Summary: Kafka zookeeper client can't connect when the first
zookeeper server is offline
Key: KAFKA-12513
URL: https://issues.apache.org/jira/browse/KAFKA-12513
jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r598142353
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -349,11 +352,20 @@ class Log(@volatile private var _dir: File,
// Delete partition
jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r598142963
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1892,8 +1892,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r598142353
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -349,11 +352,20 @@ class Log(@volatile private var _dir: File,
// Delete partition
hachikuji commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r598141840
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1892,8 +1892,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
hachikuji commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r598141328
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -349,11 +352,20 @@ class Log(@volatile private var _dir: File,
// Delete partition
[
https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305519#comment-17305519
]
Ketul Gupta commented on KAFKA-12509:
-
Hi [~ableegoldman],Could you help me in this, I would like to
wenbingshen commented on pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#issuecomment-803429631
@junrao Please help review the latest code. I carefully checked the code and
added more detailed tests. I also successfully executed related test cases for
the
wenbingshen commented on pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#issuecomment-803323875
Merge trunk to trigger QA again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wenbingshen commented on pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#issuecomment-803281674
> @wenbingshen : Thanks for the PR. A few comments below. Also, since
partitionReassignment also modifies the partition assignment in ZK. Could you
verify that part of the
wenbingshen commented on a change in pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#discussion_r598088606
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1680,45 +1680,61 @@ class KafkaController(val config: KafkaConfig,
wenbingshen commented on a change in pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#discussion_r598088530
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1680,45 +1680,61 @@ class KafkaController(val config: KafkaConfig,
wenbingshen commented on a change in pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#discussion_r598088312
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1680,45 +1680,61 @@ class KafkaController(val config: KafkaConfig,
wenbingshen commented on a change in pull request #10346:
URL: https://github.com/apache/kafka/pull/10346#discussion_r598088143
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1680,45 +1680,61 @@ class KafkaController(val config: KafkaConfig,
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598082304
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java
##
@@ -1195,20 +1270,9
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598081851
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java
##
@@ -1133,20 +1219,9
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598081851
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java
##
@@ -1133,20 +1219,9
dengziming commented on pull request #10368:
URL: https://github.com/apache/kafka/pull/10368#issuecomment-803271573
I tried multiple versions of JDK but still failed to reproduce it, it's
weird so I tried to reproduce it here, . @dajac
--
This is an automated message from the Apache
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598081851
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java
##
@@ -1133,20 +1219,9
dajac commented on pull request #10368:
URL: https://github.com/apache/kafka/pull/10368#issuecomment-803270241
Have you been able to reproduce it locally? I've tried but couldn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on pull request #10326:
URL: https://github.com/apache/kafka/pull/10326#issuecomment-803270024
Thanks for the explanation.
When you say that the consumer was stuck. Are you saying that the consumer
was trying to fetch an offset that the newly added replica did not
dengziming commented on pull request #10312:
URL: https://github.com/apache/kafka/pull/10312#issuecomment-803269307
cc @chia7712 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dengziming opened a new pull request #10368:
URL: https://github.com/apache/kafka/pull/10368
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598079706
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -489,12 +473,10 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598077882
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -60,8 +60,6 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598078087
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -192,28 +188,11 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598079320
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -258,17 +241,12 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598078620
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -248,6 +227,10 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598078375
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -192,28 +188,11 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598078087
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -192,28 +188,11 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598078087
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -192,28 +188,11 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598078087
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -192,28 +188,11 @@
showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598077882
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -60,8 +60,6 @@
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-12495:
--
Description:
In Kafka Connect, we implement incremental cooperative rebalance algorithm
based on
49 matches
Mail list logo
