[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-16 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r615204809 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataContext.java ## @@ -0,0 +1,83 @@ +/* + *

[GitHub] [kafka] vvcephei commented on pull request #10508: KAFKA-12633: Remove deprecated APIs in TopologyTestDriver

2021-04-16 Thread GitBox
vvcephei commented on pull request #10508: URL: https://github.com/apache/kafka/pull/10508#issuecomment-821758278 Looks like there are some related test failures, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] wenbingshen opened a new pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest

2021-04-16 Thread GitBox
wenbingshen opened a new pull request #10551: URL: https://github.com/apache/kafka/pull/10551 As the title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-16 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324153#comment-17324153 ] Travis Bischel commented on KAFKA-12675: Yep, that's as I understood it :). For me, running the

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324150#comment-17324150 ] Luke Chen commented on KAFKA-12675: --- [~twmb], I didn't phrase it clearly. The 5 seconds is to run

[GitHub] [kafka] C0urante commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
C0urante commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615189609 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615186346 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615186466 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java ## @@ -129,4 +133,32 @@

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615186466 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java ## @@ -129,4 +133,32 @@

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615186466 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java ## @@ -129,4 +133,32 @@

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615186346 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-16 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324139#comment-17324139 ] Travis Bischel commented on KAFKA-12675: Interesting, I'm looking forward to seeing the changes,

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324137#comment-17324137 ] Luke Chen commented on KAFKA-12675: --- [~ableegoldman], agree! In this ticket, what I will do is to

[GitHub] [kafka] rondagostino opened a new pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

2021-04-16 Thread GitBox
rondagostino opened a new pull request #10550: URL: https://github.com/apache/kafka/pull/10550 This patch adds support for running the ZooKeeper-based `kafka.security.authorizer.AclAuthorizer` with KRaft clusters. Set the `authorizer.class.name` config as well as the `zookeeper.connect`

[jira] [Commented] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-04-16 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324135#comment-17324135 ] Travis Bischel commented on KAFKA-12671: I've mostly worked around this issue in my client with

[GitHub] [kafka] junrao commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

2021-04-16 Thread GitBox
junrao commented on pull request #10489: URL: https://github.com/apache/kafka/pull/10489#issuecomment-821730346 Yet another option is to have a new server-api module. We can move the following server side apis that are currently in the client module to the new module. include

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-16 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614993697 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerdes.java ## @@ -0,0 +1,56 @@

[GitHub] [kafka] C0urante commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
C0urante commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615168657 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[GitHub] [kafka] guozhangwang commented on a change in pull request #10502: KAFKA-12630: Remove deprecated KafkaClientSupplier#getAdminClient in Streams

2021-04-16 Thread GitBox
guozhangwang commented on a change in pull request #10502: URL: https://github.com/apache/kafka/pull/10502#discussion_r615155809 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaClientSupplier.java ## @@ -31,29 +30,14 @@ * @see

[jira] [Updated] (KAFKA-10549) Add topic ID support to ListOffsets, OffsetForLeaders

2021-04-16 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10549: --- Description: ListOffsets, OffsetForLeaders protocols will replace topic name with topic ID

[GitHub] [kafka] kpatelatwork opened a new pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-16 Thread GitBox
kpatelatwork opened a new pull request #10549: URL: https://github.com/apache/kafka/pull/10549 …e plugin class in the plugin paths *A plugin like converter or connector can exists multiple times in the plugin-path and user may not realize that one of those copies will be used. The

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-16 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324090#comment-17324090 ] A. Sophie Blee-Goldman commented on KAFKA-12675: [~twmb] would you be interested in

[jira] [Updated] (KAFKA-12676) Improve sticky general assignor underlying algorithm for the unequal subscriptions case

2021-04-16 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12676: --- Summary: Improve sticky general assignor underlying algorithm for the

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

2021-04-16 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324089#comment-17324089 ] A. Sophie Blee-Goldman commented on KAFKA-12675: Yeah just to clarify, what [~twmb]

[GitHub] [kafka] guozhangwang commented on pull request #10537: KAFKA-10847: Delete Time-ordered duplicated records using deleteRange() internally

2021-04-16 Thread GitBox
guozhangwang commented on pull request #10537: URL: https://github.com/apache/kafka/pull/10537#issuecomment-821576713 Thanks @spena , I will merge after green builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] spena commented on pull request #10537: KAFKA-10847: Delete Time-ordered duplicated records using deleteRange() internally

2021-04-16 Thread GitBox
spena commented on pull request #10537: URL: https://github.com/apache/kafka/pull/10537#issuecomment-821561295 Thanks @guozhangwang , I applied the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] spena commented on a change in pull request #10537: KAFKA-10847: Delete Time-ordered duplicated records using deleteRange() internally

2021-04-16 Thread GitBox
spena commented on a change in pull request #10537: URL: https://github.com/apache/kafka/pull/10537#discussion_r615119322 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java ## @@ -96,31 +71,36 @@ public long

[GitHub] [kafka] spena commented on a change in pull request #10537: KAFKA-10847: Delete Time-ordered duplicated records using deleteRange() internally

2021-04-16 Thread GitBox
spena commented on a change in pull request #10537: URL: https://github.com/apache/kafka/pull/10537#discussion_r615119263 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java ## @@ -30,62 +30,37 @@ /** * A {@link

[GitHub] [kafka] spena commented on a change in pull request #10537: KAFKA-10847: Delete Time-ordered duplicated records using deleteRange() internally

2021-04-16 Thread GitBox
spena commented on a change in pull request #10537: URL: https://github.com/apache/kafka/pull/10537#discussion_r615117396 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentedBytesStore.java ## @@ -151,6 +159,18 @@ */ Bytes

[GitHub] [kafka] mumrah commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-04-16 Thread GitBox
mumrah commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r615098075 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a change in pull request #10537: KAFKA-10847: Delete Time-ordered duplicated records using deleteRange() internally

2021-04-16 Thread GitBox
guozhangwang commented on a change in pull request #10537: URL: https://github.com/apache/kafka/pull/10537#discussion_r615051072 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentedBytesStore.java ## @@ -151,6 +159,18 @@ */

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-821515617 Replied under each review comment, waiting for response before pushing the review changes. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615075871 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static public

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615075349 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static public

[jira] [Commented] (KAFKA-12396) Dedicated exception for kstreams when null key received

2021-04-16 Thread Valery Kokorev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324004#comment-17324004 ] Valery Kokorev commented on KAFKA-12396: [~mjsax] thank you for your time. I added some changes

[jira] [Created] (KAFKA-12679) Rebalancing a restoring or running task may cause directory livelocking with newly created task

2021-04-16 Thread Peter Nahas (Jira)
Peter Nahas created KAFKA-12679: --- Summary: Rebalancing a restoring or running task may cause directory livelocking with newly created task Key: KAFKA-12679 URL: https://issues.apache.org/jira/browse/KAFKA-12679

[GitHub] [kafka] Nathan22177 commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-16 Thread GitBox
Nathan22177 commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r615025615 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -326,6 +326,7 @@ public void putAll(final List>

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615021158 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs,

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615020981 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs,

[GitHub] [kafka] kowshik edited a comment on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-16 Thread GitBox
kowshik edited a comment on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-821333025 @junrao: Thanks for the review! I have addressed the latest comments and also fixed the broken unit test in `PartitionLockTest` suite. This PR is ready for review. --

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-16 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-821333025 @junrao: Thanks for the review! I have addressed the latest comments and also fixed the broken `PartitionLockTest` test. This PR is ready for review. -- This is an automated

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615010709 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-12396) Dedicated exception for kstreams when null key received

2021-04-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323977#comment-17323977 ] Matthias J. Sax commented on KAFKA-12396: - Thanks for the PR [~Nathan22177] – I added you to the

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615010709 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

2021-04-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323975#comment-17323975 ] Matthias J. Sax commented on KAFKA-12566: - Another one for

[jira] [Created] (KAFKA-12678) Flaky Test CustomQuotaCallbackTest.testCustomQuotaCallback

2021-04-16 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12678: --- Summary: Flaky Test CustomQuotaCallbackTest.testCustomQuotaCallback Key: KAFKA-12678 URL: https://issues.apache.org/jira/browse/KAFKA-12678 Project: Kafka

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615008995 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

2021-04-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323958#comment-17323958 ] Matthias J. Sax commented on KAFKA-12566: -

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-16 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r615007673 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -326,6 +326,7 @@ public void putAll(final List>

[jira] [Updated] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-04-16 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12677: - Priority: Major (was: Blocker) > The raftCluster always send to the wrong active controller

[jira] [Commented] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-04-16 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323955#comment-17323955 ] Colin McCabe commented on KAFKA-12677: -- [~showuon]: thanks for looking at this. This test failure

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615005374 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615005374 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (KAFKA-12396) Dedicated exception for kstreams when null key received

2021-04-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-12396: --- Assignee: Valery Kokorev > Dedicated exception for kstreams when null key received

[jira] [Assigned] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-04-16 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12677: Affects Version/s: 2.8.0 Assignee: Colin McCabe Priority:

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r614954404 ## File path: checkstyle/import-control.xml ## @@ -179,6 +179,7 @@ + Review comment: Otherwise the build will fail with: ```

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r614950753 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] mimaison commented on pull request #10277: KAFKA-9914: Fix replication cycle detection

2021-04-16 Thread GitBox
mimaison commented on pull request #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-821255420 Sorry for the delay, it's on my radar but I've not had time to take a look at it yet. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] chia7712 merged pull request #10546: MINOR: remove redundant parentheses from ControllerApis

2021-04-16 Thread GitBox
chia7712 merged pull request #10546: URL: https://github.com/apache/kafka/pull/10546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-04-16 Thread Haoran Xuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323879#comment-17323879 ] Haoran Xuan commented on KAFKA-12574: - Thanks, [~guozhang] for the clarification! I'm curious about

[GitHub] [kafka] chia7712 commented on pull request #10546: MINOR: remove redundant parentheses from ControllerApis

2021-04-16 Thread GitBox
chia7712 commented on pull request #10546: URL: https://github.com/apache/kafka/pull/10546#issuecomment-821234294 unrelated error. merge to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ivanyu commented on pull request #10277: KAFKA-9914: Fix replication cycle detection

2021-04-16 Thread GitBox
ivanyu commented on pull request #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-821219631 Hi @mimaison and @ryannedolan Sorry for the ping. Do you think this could be merged now? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (KAFKA-8863) Add InsertHeader and DropHeaders connect transforms KIP-145

2021-04-16 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-8863. Fix Version/s: 3.0.0 Reviewer: Mickael Maison Assignee: Tom Bentley

[jira] [Commented] (KAFKA-8863) Add InsertHeader and DropHeaders connect transforms KIP-145

2021-04-16 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323847#comment-17323847 ] Tom Bentley commented on KAFKA-8863: These SMTs were added in

[GitHub] [kafka] tombentley merged pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

2021-04-16 Thread GitBox
tombentley merged pull request #9549: URL: https://github.com/apache/kafka/pull/9549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] tombentley commented on pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

2021-04-16 Thread GitBox
tombentley commented on pull request #9549: URL: https://github.com/apache/kafka/pull/9549#issuecomment-821204260 Failing tests are those reported in [KAFKA-12629](https://issues.apache.org/jira/browse/KAFKA-12629), [KAFKA-12284](https://issues.apache.org/jira/browse/KAFKA-12284) and

[jira] [Updated] (KAFKA-12672) Running test-kraft-server-start results in error

2021-04-16 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-12672: Affects Version/s: (was: 2.8.0) 3.0.0 > Running

[jira] [Updated] (KAFKA-12672) Running test-kraft-server-start results in error

2021-04-16 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-12672: Affects Version/s: 2.8.0 > Running test-kraft-server-start results in error >

[jira] [Updated] (KAFKA-12672) Running test-kraft-server-start results in error

2021-04-16 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-12672: Fix Version/s: 2.8.1 3.0.0 > Running test-kraft-server-start results in error

[GitHub] [kafka] showuon commented on pull request #10338: KAFKA-10251: wait for consumer rebalance completed before consuming records

2021-04-16 Thread GitBox
showuon commented on pull request #10338: URL: https://github.com/apache/kafka/pull/10338#issuecomment-821186344 All failed tests are unrelated. Thanks. ``` Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics() Build /

[GitHub] [kafka] showuon commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-04-16 Thread GitBox
showuon commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-821181732 @ijuma , could you please check this PR? Thank you. Failed tests are all un-related. ``` Build / JDK 15 and Scala 2.13 /

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-04-16 Thread GitBox
showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-821180026 @ijuma , could you please help review the PR? Thank you. The failed tests are all un-related. ``` Build / JDK 11 and Scala 2.13 /

[GitHub] [kafka] showuon commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-16 Thread GitBox
showuon commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-821176472 Failed tests are all un-related. (Not in MirrorMakerIntegrationTest) ``` ) Build / JDK 8 and Scala 2.12 /

[jira] [Commented] (KAFKA-12396) Dedicated exception for kstreams when null key received

2021-04-16 Thread Valery Kokorev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323783#comment-17323783 ] Valery Kokorev commented on KAFKA-12396: Hello! I want to help with the task. Please assign it

[GitHub] [kafka] Vasilisck commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-16 Thread GitBox
Vasilisck commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-821148252 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] Nathan22177 opened a new pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-16 Thread GitBox
Nathan22177 opened a new pull request #10548: URL: https://github.com/apache/kafka/pull/10548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [kafka] showuon commented on pull request #10541: KAFKA-12284: increase request timeout to make tests reliable

2021-04-16 Thread GitBox
showuon commented on pull request #10541: URL: https://github.com/apache/kafka/pull/10541#issuecomment-821070153 new PR: https://github.com/apache/kafka/pull/10547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] showuon commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-16 Thread GitBox
showuon commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-821069903 @mimaison @ning2008wisc , I've updated the PR, please help review it. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-04-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-12677: -- Description: We introduce KIP-500 to introduce a Self-Managed Metadata Quorum. We should always have

[jira] [Commented] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-04-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322747#comment-17322747 ] Luke Chen commented on KAFKA-12677: --- [~cmccabe], could you take a look at this bug? If you are busy,

[jira] [Commented] (KAFKA-12629) Flaky Test RaftClusterTest

2021-04-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322745#comment-17322745 ] Luke Chen commented on KAFKA-12629: --- Found the root cause and a bug is created in KAFKA-12677. >

[jira] [Created] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-04-16 Thread Luke Chen (Jira)
Luke Chen created KAFKA-12677: - Summary: The raftCluster always send to the wrong active controller and never update Key: KAFKA-12677 URL: https://issues.apache.org/jira/browse/KAFKA-12677 Project: Kafka

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-16 Thread GitBox
satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-821008456 Thanks @junrao for the review. Addressed your comments in commit [1973eda](https://github.com/apache/kafka/pull/10271/commits/1973eda32071797b8a0f090cfba9508086ae1510). --

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-16 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614644324 ## File path: storage/src/main/resources/META-INF/services/org.apache.kafka.common.config.provider.ConfigProvider ## @@ -0,0 +1,16 @@ + # Licensed to

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-16 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614644034 ## File path: storage/src/main/resources/message/RemotePartitionDeleteMetadata.json ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation

[GitHub] [kafka] wenbingshen closed pull request #10290: KAFKA-12445: Improve the display of ConsumerPerformance indicators

2021-04-16 Thread GitBox
wenbingshen closed pull request #10290: URL: https://github.com/apache/kafka/pull/10290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-10886) Kafka crashed in windows environment2

2021-04-16 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322702#comment-17322702 ] Wenbing Shen commented on KAFKA-10886: -- [~asrivastava] I have the repaired binary file, and it has

[GitHub] [kafka] satishd edited a comment on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-16 Thread GitBox
satishd edited a comment on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-820437818 Thanks @kowshik for the review. Addressed them with the commit [5250b79](https://github.com/apache/kafka/pull/10271/commits/5250b79cef6d21c73d2b2a12ef7cd95a00e9f034).

[jira] [Resolved] (KAFKA-12445) Improve the display of ConsumerPerformance indicators

2021-04-16 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen resolved KAFKA-12445. -- Resolution: Won't Do > Improve the display of ConsumerPerformance indicators >

[jira] [Commented] (KAFKA-10886) Kafka crashed in windows environment2

2021-04-16 Thread Anchal Srivastava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322693#comment-17322693 ] Anchal Srivastava commented on KAFKA-10886: --- [~wenbing.shen] Hi, I tried to apply the patch on

[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-16 Thread GitBox
cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r614601622 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -192,64 +194,77 @@ private void maybeDeleteActiveConsumers(final String

[jira] [Commented] (KAFKA-10886) Kafka crashed in windows environment2

2021-04-16 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322672#comment-17322672 ] Wenbing Shen commented on KAFKA-10886: -- [~asrivastava]  Sorry, the patch has not been merged into

[GitHub] [kafka] chia7712 merged pull request #10400: MINOR: fix package name in core test

2021-04-16 Thread GitBox
chia7712 merged pull request #10400: URL: https://github.com/apache/kafka/pull/10400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-10886) Kafka crashed in windows environment2

2021-04-16 Thread Anchal Srivastava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322653#comment-17322653 ] Anchal Srivastava commented on KAFKA-10886: --- [~wenbing.shen] Could you please let me know from

[GitHub] [kafka] showuon opened a new pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-16 Thread GitBox
showuon opened a new pull request #10547: URL: https://github.com/apache/kafka/pull/10547 The `MirrorConnectorsIntegrationTests` recently failed with ``` TimeoutException: The request timed out. ``` quite frequently. After investigation, the reason is the `createTopic` in the

[GitHub] [kafka] chia7712 commented on a change in pull request #10498: MINOR: remove `checksumOrNull` and `isValid` from Record

2021-04-16 Thread GitBox
chia7712 commented on a change in pull request #10498: URL: https://github.com/apache/kafka/pull/10498#discussion_r614588327 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -279,8 +279,10 @@ object DumpLogSegments { if (batch.magic >=

[GitHub] [kafka] chia7712 opened a new pull request #10546: MINOR: remove redundant parentheses from ControllerApis

2021-04-16 Thread GitBox
chia7712 opened a new pull request #10546: URL: https://github.com/apache/kafka/pull/10546 from https://github.com/apache/kafka/pull/10505#discussion_r614264455 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test