jsancio commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r744007754
##
File path:
metadata/src/test/java/org/apache/kafka/controller/ConfigurationControlManagerTest.java
##
@@ -72,6 +73,14 @@
define("ghi",
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439526#comment-17439526
]
David Mao edited comment on KAFKA-13388 at 11/5/21, 10:20 PM:
--
[~dhofftgt]
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439526#comment-17439526
]
David Mao commented on KAFKA-13388:
---
[~dhofftgt]
Why do we expect a connection in
jsancio commented on a change in pull request #11457:
URL: https://github.com/apache/kafka/pull/11457#discussion_r744002667
##
File path: core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala
##
@@ -163,6 +163,14 @@ abstract class QuorumTestHarness extends
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743997732
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -659,88 +670,108 @@ class FetchSessionTest {
}
@Test
- def
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743983833
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743981159
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743979130
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -285,52 +268,57 @@ public FetchRequestData build() {
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743977547
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String,
} else {
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743976846
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743973792
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743973388
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
kirktrue commented on pull request #11465:
URL: https://github.com/apache/kafka/pull/11465#issuecomment-962191924
@junrao - perhaps you might have a chance to look at this? It's basically
some clean up from the main OAuth merge.
Not sure if this should go directly to `trunk` or the
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743949497
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648
@junrao I think this should solve the issue. Please take a look
cc @kowshik
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743682843
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +692,22 @@ private void
RivenSun2 commented on pull request #11461:
URL: https://github.com/apache/kafka/pull/11461#issuecomment-961575399
@guozhangwang @ijuma
please help check this PR when available. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac commented on pull request #11429:
URL: https://github.com/apache/kafka/pull/11429#issuecomment-961343546
@ijuma Should we pick this one to the 3.1 branch as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-961940047
@showuon Thanks again.
please browse it when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjinleekr commented on pull request #11430:
URL: https://github.com/apache/kafka/pull/11430#issuecomment-961934705
@rajinisivaram Here is the fix; I allowed the asterisks following the base
implementation and commented on how to mix numbers & the other symbols in the
string. (oh,
showuon commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-961821207
No, only committers can merge the PR. @hachikuji, could you help check this
PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on pull request #11467:
URL: https://github.com/apache/kafka/pull/11467#issuecomment-961343975
@showuon Thanks. I will take a look soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743574922
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
RivenSun2 commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-961805853
@showuon , can you help to merge this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
showuon commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743635124
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +692,22 @@ private void
showuon commented on a change in pull request #11467:
URL: https://github.com/apache/kafka/pull/11467#discussion_r742808430
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -100,8 +100,6 @@
* {@code
* Properties props = new
showuon commented on pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#issuecomment-961861164
@UnityLung @chia7712 @rhauch , please help review this PR. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on pull request #11429:
URL: https://github.com/apache/kafka/pull/11429#issuecomment-961367197
@dajac Makes sense, pushed to trunk, 3.1 and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
upsidedownsmile commented on pull request #11375:
URL: https://github.com/apache/kafka/pull/11375#issuecomment-961878940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dongjinleekr commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r743692427
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public
soceanainn commented on pull request #11470:
URL: https://github.com/apache/kafka/pull/11470#issuecomment-961908428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648
@junrao I think this should solve the issue. Please take a look
cc @kowshik
--
This is an automated message from the Apache Git Service.
To respond to the message, please
bdesert commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r743062367
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java
##
@@ -152,6 +155,48 @@ public void
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743682843
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +692,22 @@ private void
RivenSun2 commented on pull request #11461:
URL: https://github.com/apache/kafka/pull/11461#issuecomment-961575399
@guozhangwang @ijuma
please help check this PR when available. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac commented on pull request #11429:
URL: https://github.com/apache/kafka/pull/11429#issuecomment-961343546
@ijuma Should we pick this one to the 3.1 branch as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-961940047
@showuon Thanks again.
please browse it when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-13434:
-
Summary: Add a public API for AbstractCoordinator (was: Add a public API
for
dongjinleekr commented on pull request #11430:
URL: https://github.com/apache/kafka/pull/11430#issuecomment-961934705
@rajinisivaram Here is the fix; I allowed the asterisks following the base
implementation and commented on how to mix numbers & the other symbols in the
string. (oh,
showuon commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-961821207
No, only committers can merge the PR. @hachikuji, could you help check this
PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on pull request #11467:
URL: https://github.com/apache/kafka/pull/11467#issuecomment-961343975
@showuon Thanks. I will take a look soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
RivenSun2 commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-961805853
@showuon , can you help to merge this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
showuon commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743635124
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +692,22 @@ private void
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742933244
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
showuon commented on a change in pull request #11467:
URL: https://github.com/apache/kafka/pull/11467#discussion_r742808430
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -100,8 +100,6 @@
* {@code
* Properties props = new
showuon commented on pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#issuecomment-961861164
@UnityLung @chia7712 @rhauch , please help review this PR. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#issuecomment-961259072
@jolshan It seems that there are a few compilation errors, at least for `JDK
8 and Scala 2.12`. Could you check?
--
This is an automated message from the Apache Git Service.
To
ijuma commented on pull request #11429:
URL: https://github.com/apache/kafka/pull/11429#issuecomment-961367197
@dajac Makes sense, pushed to trunk, 3.1 and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Ryan Leslie created KAFKA-13435:
---
Summary: Group won't consume partitions added after static member
restart
Key: KAFKA-13435
URL: https://issues.apache.org/jira/browse/KAFKA-13435
Project: Kafka
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743909554
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743908454
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
Hector G created KAFKA-13434:
Summary: Add a public API for AbstractCoordinatos
Key: KAFKA-13434
URL: https://issues.apache.org/jira/browse/KAFKA-13434
Project: Kafka
Issue Type: Improvement
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743841128
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743839587
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743839587
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743836225
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743830862
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -66,16 +69,28 @@ public PartitionData(
int
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743830587
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12886:
Fix Version/s: (was: 3.1.0)
3.2.0
> Enable request forwarding by default
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439340#comment-17439340
]
David Jacot commented on KAFKA-12886:
-
Moved it to 3.2.0.
> Enable request forwarding by default in
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743764793
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -285,52 +268,57 @@ public FetchRequestData build() {
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743763229
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String,
} else {
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743759128
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743759128
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743759128
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -93,27 +93,42 @@ class CachedPartition(val topic: String,
def this(topic:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743756690
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -163,18 +178,37 @@ class CachedPartition(val topic: String,
mustRespond
}
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743755936
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743753874
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743753319
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743044369
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743751246
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -242,65 +244,68 @@ public void testIncrementals() {
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743750508
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -314,8 +356,7 @@ public int maxBytes() {
// For
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743749915
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -199,26 +235,31 @@ public FetchRequest build(short version) {
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743745314
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -262,11 +262,12 @@ public synchronized int
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648
@junrao I think this should solve the issue. Please take a look
cc @kowshik
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-961940047
@showuon Thanks again.
please browse it when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjinleekr commented on pull request #11430:
URL: https://github.com/apache/kafka/pull/11430#issuecomment-961934705
@rajinisivaram Here is the fix; I allowed the asterisks following the base
implementation and commented on how to mix numbers & the other symbols in the
string. (oh,
dengziming opened a new pull request #11471:
URL: https://github.com/apache/kafka/pull/11471
*More detailed description of your change*
Replace EasyMock with Mockito in connect:file
*Summary of testing strategy (including rationale)*
QA
--
This is an automated message
dongjinleekr commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r743692427
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743683585
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +693,18 @@ private void
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743682843
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +692,22 @@ private void
soceanainn commented on pull request #11470:
URL: https://github.com/apache/kafka/pull/11470#issuecomment-961908428
cc @junrao as you were involved in earlier PRs / threads on this topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
soceanainn opened a new pull request #11470:
URL: https://github.com/apache/kafka/pull/11470
Originally, Callback would return a null metadata value when an error
occurred.
This was partially changed by
[KAFKA-3303](https://issues.apache.org/jira/browse/KAFKA-3303), where in some
[
https://issues.apache.org/jira/browse/KAFKA-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-13093:
Fix Version/s: (was: 3.1.0)
3.2.0
> KIP-724: Log compaction should write
upsidedownsmile commented on pull request #11375:
URL: https://github.com/apache/kafka/pull/11375#issuecomment-961878940
@cadonna could you review this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743634380
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +693,18 @@ private void
showuon commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r743635124
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -692,10 +692,22 @@ private void
showuon commented on pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#issuecomment-961861164
@UnityLung @chia7712 @rhauch , please help review this PR. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 opened a new pull request #11469:
URL: https://github.com/apache/kafka/pull/11469
Zookeeper connection always does SASL checks currently. That behavior
produces false warnings to kafka log. For example:
### using PLAINTEXT
```
[2021-11-05 11:39:33,738] INFO Opening
showuon commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-961821207
No, only committers can merge the PR. @hachikuji, could you help check this
PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743578530
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -3530,37 +3534,37 @@ class KafkaApisTest {
def
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743578382
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -659,88 +670,108 @@ class FetchSessionTest {
}
@Test
- def
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743578252
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -659,88 +670,108 @@ class FetchSessionTest {
}
@Test
- def
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743577292
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -4814,6 +4842,7 @@ private void
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743576928
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743575635
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r743574922
##
File path:
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java
##
@@ -428,82 +442,165 @@ public void
RivenSun2 commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-961805853
@showuon , can you help to merge this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439095#comment-17439095
]
Bruno Cadonna commented on KAFKA-12291:
---
[~dajac] I downgraded it to Critical. Sorry for the
[
https://issues.apache.org/jira/browse/KAFKA-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-12291:
--
Priority: Critical (was: Blocker)
> Fix Ignored Upgrade Tests in streams_upgrade_test.py:
>
1 - 100 of 106 matches
Mail list logo
