[jira] [Updated] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

2021-11-08 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13437: - Affects Version/s: 3.0.0 > Broker parameter optimization: security.inter.broker.protocol and >

[jira] [Updated] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

2021-11-08 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13437: - Description: h1. 1. security.inter.broker.protocol Firstly see this parameter comment {code:java}

[jira] [Created] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

2021-11-08 Thread RivenSun (Jira)
RivenSun created KAFKA-13437: Summary: Broker parameter optimization: security.inter.broker.protocol and num.network.threads Key: KAFKA-13437 URL: https://issues.apache.org/jira/browse/KAFKA-13437

[jira] [Comment Edited] (KAFKA-12220) Replace PowerMock by Mockito

2021-11-08 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440831#comment-17440831 ] Liam Clarke-Hutchinson edited comment on KAFKA-12220 at 11/9/21, 12:42 AM:

[jira] [Comment Edited] (KAFKA-12220) Replace PowerMock by Mockito

2021-11-08 Thread Liam Clarke-Hutchinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440831#comment-17440831 ] Liam Clarke-Hutchinson edited comment on KAFKA-12220 at 11/9/21, 12:42 AM:

[jira] [Commented] (KAFKA-12220) Replace PowerMock by Mockito

2021-11-08 Thread Liam Clarke (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440831#comment-17440831 ] Liam Clarke commented on KAFKA-12220: - Hi [~chia7712] and [~ijuma] - I hit Powermock/Easymock issues

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745182731 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -270,36 +273,320 @@ public void testFetchNormal()

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440817#comment-17440817 ] Guozhang Wang commented on KAFKA-13435: --- Updating the affected version since this bug still exists

[jira] [Updated] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13435: -- Affects Version/s: 3.0.0 (was: 2.7.0) > Group won't consume

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440816#comment-17440816 ] Guozhang Wang commented on KAFKA-13435: --- Hello [~rleslie], thanks for your reported issue. I

[jira] [Updated] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13435: -- Priority: Critical (was: Major) > Group won't consume partitions added after static member

[GitHub] [kafka] junrao commented on a change in pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-08 Thread GitBox
junrao commented on a change in pull request #11470: URL: https://github.com/apache/kafka/pull/11470#discussion_r745176383 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java ## @@ -25,10 +25,12 @@ /** * A callback method the user can

[GitHub] [kafka] showuon commented on pull request #11451: KAFKA-13419: resetStateAndRejoin when rebalanceInProgress in syncgroup

2021-11-08 Thread GitBox
showuon commented on pull request #11451: URL: https://github.com/apache/kafka/pull/11451#issuecomment-963672449 @guozhangwang , no, no need to retrigger it. I found some slow rebalance issue after this change, an have a proposal for that. I should be able to finish the KIP today (my

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2021-11-08 Thread GitBox
dongjinleekr commented on pull request #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-963630902 @splett2 Could you have a look while I am updating #11474? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

2021-11-08 Thread GitBox
dongjinleekr commented on a change in pull request #11474: URL: https://github.com/apache/kafka/pull/11474#discussion_r745139046 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] splett2 commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

2021-11-08 Thread GitBox
splett2 commented on a change in pull request #11474: URL: https://github.com/apache/kafka/pull/11474#discussion_r745132675 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] splett2 commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

2021-11-08 Thread GitBox
splett2 commented on a change in pull request #11474: URL: https://github.com/apache/kafka/pull/11474#discussion_r745132675 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig, }

[jira] [Commented] (KAFKA-13350) Handle task corrupted exception on a per state store basis

2021-11-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440760#comment-17440760 ] Guozhang Wang commented on KAFKA-13350: --- The broker would return on the first met

[GitHub] [kafka] soceanainn commented on a change in pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-08 Thread GitBox
soceanainn commented on a change in pull request #11470: URL: https://github.com/apache/kafka/pull/11470#discussion_r745122437 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java ## @@ -25,10 +25,12 @@ /** * A callback method the user

[GitHub] [kafka] junrao commented on a change in pull request #11470: MINOR: Update docs for producer callbacks to reflect current behaviour

2021-11-08 Thread GitBox
junrao commented on a change in pull request #11470: URL: https://github.com/apache/kafka/pull/11470#discussion_r745109562 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java ## @@ -25,10 +25,12 @@ /** * A callback method the user can

[GitHub] [kafka] guozhangwang commented on pull request #11449: MINOR: Log client disconnect events at INFO level

2021-11-08 Thread GitBox
guozhangwang commented on pull request #11449: URL: https://github.com/apache/kafka/pull/11449#issuecomment-963575647 Sounds good. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] niket-goel opened a new pull request #11477: MINOR: Adding a constant to denote UNKNOWN leader in LeaderAndEpoch

2021-11-08 Thread GitBox
niket-goel opened a new pull request #11477: URL: https://github.com/apache/kafka/pull/11477 Verified that the KafkaRaftClientTest passes with the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] dajac commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11474: URL: https://github.com/apache/kafka/pull/11474#discussion_r745092766 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745091391 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

2021-11-08 Thread GitBox
dongjinleekr commented on a change in pull request #11474: URL: https://github.com/apache/kafka/pull/11474#discussion_r745086781 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -894,9 +894,11 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-11-08 Thread GitBox
dongjinleekr commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r745085224 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public

[GitHub] [kafka] vvcephei merged pull request #11412: KAFKA-10543: Convert KTable joins to new PAPI

2021-11-08 Thread GitBox
vvcephei merged pull request #11412: URL: https://github.com/apache/kafka/pull/11412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji commented on a change in pull request #11449: MINOR: Log client disconnect events at INFO level

2021-11-08 Thread GitBox
hachikuji commented on a change in pull request #11449: URL: https://github.com/apache/kafka/pull/11449#discussion_r745072515 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -319,23 +319,29 @@ public void disconnect(String nodeId) {

[GitHub] [kafka] dongjinleekr commented on pull request #11454: KAFKA-13341: Quotas are not applied to requests with null clientId

2021-11-08 Thread GitBox
dongjinleekr commented on pull request #11454: URL: https://github.com/apache/kafka/pull/11454#issuecomment-963550148 Hi @flysen, Thanks for the reporting. It seems like this issue is a little bit coupled with your case. I will have a look around. -- This is an automated message from

[GitHub] [kafka] hachikuji commented on a change in pull request #11449: MINOR: Log client disconnect events at INFO level

2021-11-08 Thread GitBox
hachikuji commented on a change in pull request #11449: URL: https://github.com/apache/kafka/pull/11449#discussion_r745071482 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -923,7 +930,7 @@ private void handleApiVersionsResponse(List

[GitHub] [kafka] hachikuji commented on a change in pull request #11449: MINOR: Log client disconnect events at INFO level

2021-11-08 Thread GitBox
hachikuji commented on a change in pull request #11449: URL: https://github.com/apache/kafka/pull/11449#discussion_r745061966 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -319,23 +319,29 @@ public void disconnect(String nodeId) {

[GitHub] [kafka] dajac commented on pull request #11468: MINOR: Introduce `ApiKeyVersionsSource` annotation for `ParameterizedTest`

2021-11-08 Thread GitBox
dajac commented on pull request #11468: URL: https://github.com/apache/kafka/pull/11468#issuecomment-963535821 @hachikuji What do you think about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745060151 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745053425 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -340,11 +340,9 @@ public FetchRequestData build() {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745050475 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -238,11 +237,13 @@ public String toString() { *

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745050242 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -340,11 +340,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745033891 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -238,11 +237,13 @@ public String toString() { *

[GitHub] [kafka] hachikuji commented on a change in pull request #11448: KAFKA-13417; Ensure dynamic reconfigurations set old config properly

2021-11-08 Thread GitBox
hachikuji commented on a change in pull request #11448: URL: https://github.com/apache/kafka/pull/11448#discussion_r745021117 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -516,7 +516,15 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745010308 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -340,11 +340,9 @@ public FetchRequestData build() {

[jira] [Updated] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-11-08 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Leslie updated KAFKA-13435: Description: When using consumer groups with static membership, if the consumer marked as leader

[GitHub] [kafka] jeqo commented on a change in pull request #11412: KAFKA-10543: Convert KTable joins to new PAPI

2021-11-08 Thread GitBox
jeqo commented on a change in pull request #11412: URL: https://github.com/apache/kafka/pull/11412#discussion_r744982312 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java ## @@ -142,7 +142,7 @@ public void process(final

[GitHub] [kafka] jeqo commented on a change in pull request #11412: KAFKA-10543: Convert KTable joins to new PAPI

2021-11-08 Thread GitBox
jeqo commented on a change in pull request #11412: URL: https://github.com/apache/kafka/pull/11412#discussion_r744970521 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResolverJoinProcessorSupplierTest.java ## @@

[GitHub] [kafka] hachikuji commented on a change in pull request #11448: KAFKA-13417; Ensure dynamic reconfigurations set old config properly

2021-11-08 Thread GitBox
hachikuji commented on a change in pull request #11448: URL: https://github.com/apache/kafka/pull/11448#discussion_r744968165 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -516,7 +516,15 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] ccding commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-11-08 Thread GitBox
ccding commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r744962539 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -655,6 +655,7 @@ class UnifiedLog(@volatile var logStartOffset: Long, def close():

[GitHub] [kafka] bdesert commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-08 Thread GitBox
bdesert commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r744959917 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -519,6 +521,47 @@

[GitHub] [kafka] bdesert commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-08 Thread GitBox
bdesert commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r744959364 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -519,6 +521,47 @@

[GitHub] [kafka] junrao commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-11-08 Thread GitBox
junrao commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r744958189 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1504,6 +1505,8 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** *

[GitHub] [kafka] junrao commented on a change in pull request #11465: OAuth updates 1

2021-11-08 Thread GitBox
junrao commented on a change in pull request #11465: URL: https://github.com/apache/kafka/pull/11465#discussion_r744941462 ## File path: tools/src/main/java/org/apache/kafka/tools/OAuthCompatibilityTool.java ## @@ -208,71 +172,231 @@ public static void main(String[] args) {

[GitHub] [kafka] vvcephei commented on a change in pull request #11412: KAFKA-10543: Convert KTable joins to new PAPI

2021-11-08 Thread GitBox
vvcephei commented on a change in pull request #11412: URL: https://github.com/apache/kafka/pull/11412#discussion_r744947553 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignJoinSubscriptionSendProcessorSupplier.java ## @@

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744942958 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] splett2 commented on a change in pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

2021-11-08 Thread GitBox
splett2 commented on a change in pull request #11474: URL: https://github.com/apache/kafka/pull/11474#discussion_r744934377 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -953,6 +957,16 @@ class ReplicaManager(val config: KafkaConfig, }

[jira] [Commented] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2021-11-08 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440593#comment-17440593 ] Edoardo Comar commented on KAFKA-13407: --- Hi we're experiencing a similar issue. We think the

[GitHub] [kafka] edoardocomar opened a new pull request #11476: KAFKA-13407: Always start controller when broker wins election

2021-11-08 Thread GitBox
edoardocomar opened a new pull request #11476: URL: https://github.com/apache/kafka/pull/11476 Add a call to `onControllerFailover` into code path where `elect` is called, and the broker discovers it has already been elected. We found that by restarting the ZK leader we could

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744906035 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744905470 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] ccding removed a comment on pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-11-08 Thread GitBox
ccding removed a comment on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648 @junrao I think this should solve the issue. Please take a look cc @kowshik -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744892585 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744883112 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744880575 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744877634 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] dajac commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-11-08 Thread GitBox
dajac commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744875433 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[jira] [Commented] (KAFKA-13388) Kafka Producer nodes stuck in CHECKING_API_VERSIONS

2021-11-08 Thread David Hoffman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440513#comment-17440513 ] David Hoffman commented on KAFKA-13388: --- I've been trying to get more info. I enabled debug

[GitHub] [kafka] mimaison commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-08 Thread GitBox
mimaison commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r744779966 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -519,6 +521,47 @@

[jira] [Commented] (KAFKA-13388) Kafka Producer nodes stuck in CHECKING_API_VERSIONS

2021-11-08 Thread David Hoffman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440509#comment-17440509 ] David Hoffman commented on KAFKA-13388: --- [~david.mao] It's my understanding that there would be an

[GitHub] [kafka] mimaison commented on a change in pull request #11401: KAFKA-13255: use exclude filter for new topics

2021-11-08 Thread GitBox
mimaison commented on a change in pull request #11401: URL: https://github.com/apache/kafka/pull/11401#discussion_r744762582 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java ## @@ -152,6 +155,48 @@ public void

[GitHub] [kafka] mimaison commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-11-08 Thread GitBox
mimaison commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r744751390 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] flysen edited a comment on pull request #11454: KAFKA-13341: Quotas are not applied to requests with null clientId

2021-11-08 Thread GitBox
flysen edited a comment on pull request #11454: URL: https://github.com/apache/kafka/pull/11454#issuecomment-963164070 @dongjinleekr Ill follow up to this with our findings. Not 100% sure it's relevant. When `/config/clients/` exist no new JMX metrics for

[jira] [Updated] (KAFKA-13434) Add a public API for AbstractCoordinator

2021-11-08 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino updated KAFKA-13434: - Description: KIP-795:

[jira] [Updated] (KAFKA-13434) Add a public API for AbstractCoordinator

2021-11-08 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino updated KAFKA-13434: - Description: KIP-795:

[GitHub] [kafka] flysen commented on pull request #11454: KAFKA-13341: Quotas are not applied to requests with null clientId

2021-11-08 Thread GitBox
flysen commented on pull request #11454: URL: https://github.com/apache/kafka/pull/11454#issuecomment-963164070 @dongjinleekr Ill follow up to this with our findings. Not 100% sure it's relevant. When `/config/clients/` exist no new JMX metrics for `kafka.server:type=Produce,user=xx` will

[GitHub] [kafka] mimaison commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

2021-11-08 Thread GitBox
mimaison commented on pull request #11212: URL: https://github.com/apache/kafka/pull/11212#issuecomment-962970196 > Cool. So... the version info in the headers will be changed from 1 to 3.1.0, 3.1.0, ... etc. Do I understand correctly? Yes, with this change, this will report the