cmccabe commented on a change in pull request #11577:
URL: https://github.com/apache/kafka/pull/11577#discussion_r765472880
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1015,6 +1048,11 @@ private void resetState() {
*/
cmccabe commented on a change in pull request #11577:
URL: https://github.com/apache/kafka/pull/11577#discussion_r765472041
##
File path:
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala
##
@@ -47,7 +52,17 @@ class ControllerConfigurationValidator
cmccabe commented on a change in pull request #11577:
URL: https://github.com/apache/kafka/pull/11577#discussion_r765467726
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -251,6 +254,36 @@ public QuorumController build() throws
mjsax opened a new pull request #11584:
URL: https://github.com/apache/kafka/pull/11584
Simply reading log by sorting partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
guozhangwang commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-989541506
I made another pass and it LGTM. @dajac do you want to make another pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456150#comment-17456150
]
John Roesler commented on KAFKA-13526:
--
Tried the serde passing thing, which didn't work that well.
vvcephei opened a new pull request #11583:
URL: https://github.com/apache/kafka/pull/11583
Just experimenting with what would happen if we pass serdes around and just
skip translating data in the Metered stores at all.
I think this winds up being a little messy because didn't want
hachikuji commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r765427639
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1887,15 +1891,21 @@ class KafkaConfig private(doLog: Boolean, val props:
[
https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12980.
-
Fix Version/s: 3.2.0
Resolution: Fixed
> Allow consumers to return from poll
hachikuji merged pull request #11046:
URL: https://github.com/apache/kafka/pull/11046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei opened a new pull request #11582:
URL: https://github.com/apache/kafka/pull/11582
Implement the KeyQuery and RawKeyQuery as proposed in KIP-796
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
jeffkbkim commented on pull request #11571:
URL: https://github.com/apache/kafka/pull/11571#issuecomment-989475604
@dajac the errors come from
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1833:
```
new LeaveGroupResponse(
guozhangwang commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r765364839
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -108,6 +124,44 @@ private void
mjsax commented on pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#issuecomment-989362828
@guozhangwang Not yet. There was actually failing tests, because some test
rely on the removed call to `closeToError()`. Need to rewrite those test what
is not straightforward
mjsax commented on pull request #11535:
URL: https://github.com/apache/kafka/pull/11535#issuecomment-989348043
@richard-axual Did you see the comments on the Jira? Would like to get those
answered before we merge this. It's unclear if we should really be robust
against this error or
[
https://issues.apache.org/jira/browse/KAFKA-13500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456061#comment-17456061
]
Matthias J. Sax commented on KAFKA-13500:
-
I guess it's related. If the restoration thread is
[
https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456057#comment-17456057
]
Jun Rao commented on KAFKA-13077:
-
[~shivakumar] : Not sure what's leading to the warning. It would be
John Roesler created KAFKA-13526:
Summary: IQv2: Consider more generic logic for mapping between
binary and typed queries
Key: KAFKA-13526
URL: https://issues.apache.org/jira/browse/KAFKA-13526
[
https://issues.apache.org/jira/browse/KAFKA-13525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reassigned KAFKA-13525:
Assignee: John Roesler
> IQv2: Implement KeyQuery from the KIP
>
John Roesler created KAFKA-13525:
Summary: IQv2: Implement KeyQuery from the KIP
Key: KAFKA-13525
URL: https://issues.apache.org/jira/browse/KAFKA-13525
Project: Kafka
Issue Type: Sub-task
John Roesler created KAFKA-13524:
Summary: IQv2: Add option to query from caches
Key: KAFKA-13524
URL: https://issues.apache.org/jira/browse/KAFKA-13524
Project: Kafka
Issue Type: Sub-task
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989303922
We can merge this after we get a green build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
John Roesler created KAFKA-13523:
Summary: Implement IQv2 support in global stores
Key: KAFKA-13523
URL: https://issues.apache.org/jira/browse/KAFKA-13523
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-13491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler closed KAFKA-13491.
> Implement IQv2 Framework
>
>
> Key: KAFKA-13491
>
[
https://issues.apache.org/jira/browse/KAFKA-13506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler closed KAFKA-13506.
> IQv2: Transmit position to standbys
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/KAFKA-13506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-13506.
--
Resolution: Fixed
> IQv2: Transmit position to standbys
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-13491.
--
Resolution: Fixed
> Implement IQv2 Framework
>
>
>
vvcephei opened a new pull request #11581:
URL: https://github.com/apache/kafka/pull/11581
* Fill in the Position response in the IQv2 result.
* Enforce PositionBound in IQv2 queries.
* Update integration testing approach to leverage consistent queries.
### Committer Checklist
[
https://issues.apache.org/jira/browse/KAFKA-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reassigned KAFKA-13522:
Assignee: John Roesler
> IQv2: Implement position tracking and bounding in API
>
John Roesler created KAFKA-13522:
Summary: IQv2: Implement position tracking and bounding in API
Key: KAFKA-13522
URL: https://issues.apache.org/jira/browse/KAFKA-13522
Project: Kafka
Issue
dajac commented on pull request #11576:
URL: https://github.com/apache/kafka/pull/11576#issuecomment-989274136
@cmccabe This is a blocker for 3.1. Could also merge it to the 3.1 branch
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#issuecomment-989263370
@mjsax is this ready for final reviews?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe merged pull request #11576:
URL: https://github.com/apache/kafka/pull/11576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456008#comment-17456008
]
Guozhang Wang commented on KAFKA-13500:
---
I'm wondering if it could be subsumed by the restoration
soondenana opened a new pull request #11580:
URL: https://github.com/apache/kafka/pull/11580
A list of `ConfigResource` class is passed as argument to
`AdminClient::describeConfigs` api to indicate configuration of the
entities to fetch. The `ConfigResource` class is made up of two
[
https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455976#comment-17455976
]
Josep Prat commented on KAFKA-12370:
Thanks [~guozhang] I really appreciate it!
The most unclear
[
https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455970#comment-17455970
]
Guozhang Wang commented on KAFKA-12370:
---
Thanks [~josep.prat]. I will take a look at the KIP.
>
[
https://issues.apache.org/jira/browse/KAFKA-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455964#comment-17455964
]
Jeremy Custenborder commented on KAFKA-13505:
-
Glad you got it working. Sorry about the
mumrah commented on a change in pull request #11577:
URL: https://github.com/apache/kafka/pull/11577#discussion_r765181618
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1015,6 +1048,11 @@ private void resetState() {
*/
vvcephei merged pull request #11513:
URL: https://github.com/apache/kafka/pull/11513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765093493
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java
##
@@ -91,29 +90,20 @@ public void
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765090882
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/GlobalStateStoreProviderTest.java
##
@@ -110,6 +111,9 @@ public void
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765074461
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStoreTest.java
##
@@ -103,18 +142,22 @@ public
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765074233
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStoreTest.java
##
@@ -103,18 +142,22 @@ public
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765067376
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorContextImplTest.java
##
@@ -120,7 +129,7 @@ public void
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765066972
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765062259
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -106,10 +111,13 @@
private final
vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765060632
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java
##
@@ -79,15 +94,21 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-13521:
-
Issue Type: Bug (was: Improvement)
> Supress changelog schema version breaks migration
C0urante commented on a change in pull request #10910:
URL: https://github.com/apache/kafka/pull/10910#discussion_r764951107
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ErrorHandlingMetrics.java
##
@@ -138,4 +142,12 @@ public void
Hector Geraldino created KAFKA-13521:
Summary: Supress changelog schema version breaks migration
Key: KAFKA-13521
URL: https://issues.apache.org/jira/browse/KAFKA-13521
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455286#comment-17455286
]
ASF GitHub Bot commented on KAFKA-13520:
bbejeck commented on pull request #387:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455285#comment-17455285
]
ASF GitHub Bot commented on KAFKA-13520:
bbejeck merged pull request #387:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455241#comment-17455241
]
Dongjin Lee commented on KAFKA-13247:
-
[~tmargaryan] I see. But then, I think using a separate
showuon commented on pull request #11578:
URL: https://github.com/apache/kafka/pull/11578#issuecomment-988798681
@ableegoldman , please take a look at the simple change to fix the flaky
test. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455213#comment-17455213
]
Luke Chen commented on KAFKA-13520:
---
Make sense! Thanks.
> Quickstart does not work at topic creation
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455207#comment-17455207
]
Robin Moffatt commented on KAFKA-13520:
---
Thanks Luke, good that it will be fixed. Is the release
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455205#comment-17455205
]
Luke Chen commented on KAFKA-13520:
---
[~rmoff] , thanks for the report. But this bug is fixed in
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robin Moffatt updated KAFKA-13520:
--
Affects Version/s: 3.0.0
> Quickstart does not work at topic creation step
>
[
https://issues.apache.org/jira/browse/KAFKA-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455196#comment-17455196
]
Robin Moffatt commented on KAFKA-13520:
---
https://github.com/apache/kafka-site/pull/387
>
Robin Moffatt created KAFKA-13520:
-
Summary: Quickstart does not work at topic creation step
Key: KAFKA-13520
URL: https://issues.apache.org/jira/browse/KAFKA-13520
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee reassigned KAFKA-13518:
---
Assignee: Dongjin Lee
> Update gson and netty-codec in 3.0.0
>
dongjinleekr opened a new pull request #11579:
URL: https://github.com/apache/kafka/pull/11579
Here is the fix. Since [spotbugs 4.5.1 was released just 12 hours
ago](https://github.com/spotbugs/spotbugs/releases/tag/4.5.1), it would take a
little bit to be synched with maven central.
[
https://issues.apache.org/jira/browse/KAFKA-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455192#comment-17455192
]
Dongjin Lee commented on KAFKA-13518:
-
The security problems on netty-codec were already fixed with
Sergey Lemekhov created KAFKA-13519:
---
Summary: Same JAAS configuration used for all producers
Key: KAFKA-13519
URL: https://issues.apache.org/jira/browse/KAFKA-13519
Project: Kafka
Issue
Pavel Kuznetsov created KAFKA-13518:
---
Summary: Update gson and netty-codec in 3.0.0
Key: KAFKA-13518
URL: https://issues.apache.org/jira/browse/KAFKA-13518
Project: Kafka
Issue Type: Bug
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r764724467
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java
##
@@ -0,0 +1,75 @@
+/*
+ *
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r764716888
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java
##
@@ -0,0 +1,75 @@
+/*
+ *
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r764716888
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java
##
@@ -0,0 +1,75 @@
+/*
+ *
69 matches
Mail list logo
