[
https://issues.apache.org/jira/browse/KAFKA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan updated KAFKA-14366:
---
Description:
Hi All,
We are facing an issue while the client consumer restart (again not all
restarts are
Chetan created KAFKA-14366:
--
Summary: Kafka consumer rebalance issue, offsets points back to
very old committed offset
Key: KAFKA-14366
URL: https://issues.apache.org/jira/browse/KAFKA-14366
Project: Kafka
kirktrue opened a new pull request, #12831:
URL: https://github.com/apache/kafka/pull/12831
Generalize `Fetcher` into an interface of the same name and rename the
original `Fetcher` into `FetcherThreadSafe`. Generalize appropriate call sites
to use the general interface instead of the
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630184#comment-17630184
]
Ramiz Mehran commented on KAFKA-14282:
--
I am also facing the same. Adding logs below:
vamossagar12 commented on PR #12826:
URL: https://github.com/apache/kafka/pull/12826#issuecomment-1306629502
> @vamossagar12 Can you expand on the importance of this change?
>
> Is the single `long` with `0` as a sentinel any different in readability
than a `Timer` object with `null`
vamossagar12 commented on code in PR #12826:
URL: https://github.com/apache/kafka/pull/12826#discussion_r1016131415
##
clients/src/main/java/org/apache/kafka/common/utils/Timer.java:
##
@@ -172,6 +172,17 @@ public long currentTimeMs() {
return currentTimeMs;
}
+
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1306499515
@dajac thanks for the review, i have addressed the comments. i'm a bit
confused since the new parameterized replica fetcher test seems to be failing
in jdk 8 / scala 2.12
--
This is
gharris1727 opened a new pull request, #12830:
URL: https://github.com/apache/kafka/pull/12830
Signed-off-by: Greg Harris
The GRACEFUL_SHUTDOWN_TIMEOUT_MS for the Trogdor JsonRestServer is 100ms. In
heavily loaded CI environments, this timeout can be exceeded. When this
happens, it
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630099#comment-17630099
]
tony mancill commented on KAFKA-8154:
-
We have observed this this behavior when using either
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630098#comment-17630098
]
Matthias J. Sax commented on KAFKA-14294:
-
Why do you think we don't commit? Based on the code,
cmccabe opened a new pull request, #12829:
URL: https://github.com/apache/kafka/pull/12829
We should avoid using Message.highestSupportedVersion to generate metadata
records. Instead, we need to pick the correct record version based on the
current metadata version which is in effect. In
ableegoldman merged PR #12760:
URL: https://github.com/apache/kafka/pull/12760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Scanteianu commented on PR #12753:
URL: https://github.com/apache/kafka/pull/12753#issuecomment-1306344430
@showuon could I get another review please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
philipnee closed pull request #12792: [Test]gradle oom fix
URL: https://github.com/apache/kafka/pull/12792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14345:
Labels: flaky-test (was: )
> Flakey Tests for Connection Quotas should use correct error bounds
jsancio merged PR #12819:
URL: https://github.com/apache/kafka/pull/12819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lihaosky commented on PR #12166:
URL: https://github.com/apache/kafka/pull/12166#issuecomment-1306192045
@mjsax can help approve and merge as a committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gharris1727 opened a new pull request, #12828:
URL: https://github.com/apache/kafka/pull/12828
Currently, all RestClient methods are static, and require more complicated
mocking mechanisms compared to an implementation which uses instance methods.
Additionally, the current model creates a
qingwei91 commented on code in PR #12166:
URL: https://github.com/apache/kafka/pull/12166#discussion_r1015852039
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java:
##
@@ -333,6 +352,87 @@ public void
hachikuji commented on PR #12819:
URL: https://github.com/apache/kafka/pull/12819#issuecomment-1306108755
@jsancio Here is a link to a run of the `reassign_partitions_test.py`, which
uses the console consumer service:
[
https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-14354:
-
Summary: Add 'destroyed()' callback method to Connector API (was: Add
delete callback
Kirk True created KAFKA-14365:
-
Summary: Refactor Fetcher to allow different implementations
Key: KAFKA-14365
URL: https://issues.apache.org/jira/browse/KAFKA-14365
Project: Kafka
Issue Type:
gharris1727 commented on PR #12826:
URL: https://github.com/apache/kafka/pull/12826#issuecomment-1306029257
@vamossagar12 Can you expand on the importance of this change?
Is the single `long` with `0` as a sentinel any different in readability
than a `Timer` object with `null` as a
C0urante commented on PR #12544:
URL: https://github.com/apache/kafka/pull/12544#issuecomment-1306016049
Thanks @mimaison, good catch with the missing hyphen suffixes in the default
client IDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gharris1727 commented on code in PR #12826:
URL: https://github.com/apache/kafka/pull/12826#discussion_r1015749550
##
clients/src/main/java/org/apache/kafka/common/utils/Timer.java:
##
@@ -172,6 +172,17 @@ public long currentTimeMs() {
return currentTimeMs;
}
+
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1015721786
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1015721355
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {
[
https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629931#comment-17629931
]
Jocelyn commented on KAFKA-13891:
-
This ticket was reverted, see PR here:
mimaison commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1015686984
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -289,15 +292,16 @@ public static String RESTART_KEY(String
John Roesler created KAFKA-14364:
Summary: Support evolving serde with Foreign Key Join
Key: KAFKA-14364
URL: https://issues.apache.org/jira/browse/KAFKA-14364
Project: Kafka
Issue Type:
clolov commented on PR #12823:
URL: https://github.com/apache/kafka/pull/12823#issuecomment-1305894872
Thank you very much for the quick turnaround @C0urante!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14345:
Description:
The DynamicConnectionQuotaTest is an integration test targeting the throttling
[
https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14345:
Description:
The DynamicConnectionQuotaTest is an integration test targeting the throttling
[
https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14345:
Summary: Flakey Tests for Connection Quotas should use correct error bounds
(was: Flakey
C0urante merged PR #12823:
URL: https://github.com/apache/kafka/pull/12823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #12823:
URL: https://github.com/apache/kafka/pull/12823#issuecomment-1305875235
Changes in last commit were trivially verifiable, and the CI run for the
commit before that did not contain any relevant test failures. Merging...
--
This is an automated message from
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1015640636
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1015639560
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1015639016
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -214,7 +214,7 @@ public void configure(final WorkerConfig config)
[
https://issues.apache.org/jira/browse/KAFKA-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14363:
Summary: Add new `group-coordinator` module (was: Add new `coordinator`
module)
> Add new
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1015617856
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java:
##
@@ -0,0 +1,553 @@
+/*
+ *
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015611950
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -185,8 +160,13 @@ public void testRemove() throws Exception
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015611423
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -185,8 +160,13 @@ public void testRemove() throws Exception
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015610959
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,112 +75,83 @@ public void setup() {
clolov commented on PR #12418:
URL: https://github.com/apache/kafka/pull/12418#issuecomment-1305829036
Hello, yes I am, it is the next one on my list :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cadonna merged PR #12772:
URL: https://github.com/apache/kafka/pull/12772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12772:
URL: https://github.com/apache/kafka/pull/12772#issuecomment-1305801994
Build failures are unrelated:
```
Build / JDK 11 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[2]
Type=Raft-CoReside, Name=testAllTopicPartition,
C0urante commented on PR #12418:
URL: https://github.com/apache/kafka/pull/12418#issuecomment-1305757854
@clolov do you plan on revisiting this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1015535668
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -123,91 +134,91 @@ private enum SourceSink {
[
https://issues.apache.org/jira/browse/KAFKA-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14346.
---
Fix Version/s: 3.4.0
Resolution: Fixed
> Remove static methods from internal Connect
C0urante commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015522678
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -185,8 +160,13 @@ public void testRemove() throws
C0urante merged PR #12817:
URL: https://github.com/apache/kafka/pull/12817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac opened a new pull request, #12827:
URL: https://github.com/apache/kafka/pull/12827
Introduce new `coordinator` module that will host the future new group
coordinator as part of KIP-848.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
David Jacot created KAFKA-14363:
---
Summary: Add new `coordinator` module
Key: KAFKA-14363
URL: https://issues.apache.org/jira/browse/KAFKA-14363
Project: Kafka
Issue Type: Sub-task
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1015481020
##
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java:
##
@@ -69,6 +74,17 @@ public ReplicationPolicy replicationPolicy() {
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629832#comment-17629832
]
Mikael commented on KAFKA-14362:
The main thing that has caught my attention is the tight loop of
Mikael created KAFKA-14362:
--
Summary: Same message consumed by two consumers in the same group
after client restart
Key: KAFKA-14362
URL: https://issues.apache.org/jira/browse/KAFKA-14362
Project: Kafka
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1305605846
Hey @cadonna, Adam Retter has been very helpful in responding to my mail, so
I have updated the pull request with his suggestion. I believe this is option
2, but the reasoning behind it
cadonna commented on PR #12772:
URL: https://github.com/apache/kafka/pull/12772#issuecomment-1305567683
I restarted the builds. Once the build results are acceptable, I will merge
the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
cadonna merged PR #12684:
URL: https://github.com/apache/kafka/pull/12684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12684:
URL: https://github.com/apache/kafka/pull/12684#issuecomment-1305550037
Build failures are unrelated:
```
Build / JDK 11 and Scala 2.13 /
cadonna merged PR #12773:
URL: https://github.com/apache/kafka/pull/12773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12773:
URL: https://github.com/apache/kafka/pull/12773#issuecomment-1305538249
Build failures are unrelated:
```
Build / JDK 17 and Scala 2.13 /
cadonna commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1015362789
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo
clolov commented on PR #12823:
URL: https://github.com/apache/kafka/pull/12823#issuecomment-1305432745
Hey @C0urante! Thanks a lot for the review. Hopefully I have addressed the
first batch of comments :)
--
This is an automated message from the Apache Git Service.
To respond to the
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015279648
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,122 +74,74 @@ public void setup() {
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015276765
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,122 +74,74 @@ public void setup() {
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015261223
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,122 +74,74 @@ public void setup() {
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1015259138
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,122 +74,74 @@ public void setup() {
[
https://issues.apache.org/jira/browse/KAFKA-14344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14344.
Fix Version/s: 3.4.0
Resolution: Fixed
> Improve MM2 integration test by building
mimaison merged PR #12804:
URL: https://github.com/apache/kafka/pull/12804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r1015231438
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##
@@ -1036,6 +1036,52 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE,
showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1015224638
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -117,30 +117,41 @@ private boolean allSubscriptionsEqual(Set
tombentley commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1015179206
##
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java:
##
@@ -56,7 +58,11 @@ public class MirrorClientConfig extends
cadonna commented on PR #12808:
URL: https://github.com/apache/kafka/pull/12808#issuecomment-1305329469
Test failures in `TaskManagerTest` are related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1015152908
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -3455,6 +3455,21 @@ class UnifiedLogTest {
assertFalse(newDir.exists())
}
+ @Test
+ def
[
https://issues.apache.org/jira/browse/KAFKA-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-14211:
--
Fix Version/s: 3.2.0
> Streams log message has partition and offset transposed
>
[
https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629692#comment-17629692
]
Bruno Cadonna commented on KAFKA-13887:
---
[~ableegoldman] Agreed! Closed the ticket as you
[
https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13887.
---
Resolution: Not A Problem
> Running multiple instance of same stateful KafkaStreams
urbandan commented on PR #12392:
URL: https://github.com/apache/kafka/pull/12392#issuecomment-1305253651
@artemlivshits The scenario you mentioned is already covered, even without
this change - when a transaction times out, the transaction coordinator bumps
the epoch, so it already fences
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629661#comment-17629661
]
A. Sophie Blee-Goldman commented on KAFKA-14282:
Thanks for the report. I'll try to look
[
https://issues.apache.org/jira/browse/KAFKA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-14325:
--
Assignee: A. Sophie Blee-Goldman
> NullPointer in
[
https://issues.apache.org/jira/browse/KAFKA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629652#comment-17629652
]
A. Sophie Blee-Goldman commented on KAFKA-14325:
Hm, nice catch, we should definitely
[
https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629647#comment-17629647
]
A. Sophie Blee-Goldman commented on KAFKA-13887:
[~cadonna] think we can we close this
85 matches
Mail list logo