[
https://issues.apache.org/jira/browse/KAFKA-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635723#comment-17635723
]
Suresh Rukmangathan commented on KAFKA-14184:
-
Few updates:-
# We are using
dajac commented on PR #12845:
URL: https://github.com/apache/kafka/pull/12845#issuecomment-1319647546
@jeffkbkim Thanks for the review. I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1026102820
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2530,208 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1026101492
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2530,208 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1026099763
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- def
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1026098011
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -161,6 +166,12 @@ class KafkaApis(val requestChannel: RequestChannel,
* Top-level method that handles all
[
https://issues.apache.org/jira/browse/KAFKA-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635680#comment-17635680
]
Matthias J. Sax commented on KAFKA-14184:
-
The stack trace is highly suspicious. Based on the
[
https://issues.apache.org/jira/browse/KAFKA-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635667#comment-17635667
]
Matthias J. Sax commented on KAFKA-14374:
-
Thanks for creating a ticket. I am not sure right now
jeffkbkim commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1025980136
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -161,6 +166,12 @@ class KafkaApis(val requestChannel: RequestChannel,
* Top-level method that handles
showuon merged PR #12868:
URL: https://github.com/apache/kafka/pull/12868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji opened a new pull request, #12873:
URL: https://github.com/apache/kafka/pull/12873
As many have noticed, the idempotent producer implementation is complex.
This patch attempts to introduce a new simulation-based testing methodology
which which enables testing of more complex
ableegoldman commented on code in PR #12869:
URL: https://github.com/apache/kafka/pull/12869#discussion_r1025891177
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -611,9 +616,11 @@ boolean runLoop() {
ableegoldman commented on code in PR #12869:
URL: https://github.com/apache/kafka/pull/12869#discussion_r1025887660
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -298,6 +298,7 @@ public boolean isRunning() {
private volatile
C0urante commented on PR #12295:
URL: https://github.com/apache/kafka/pull/12295#issuecomment-1319344550
@dstelljes Good news! Now that we've eliminated the need to mock the static
APIs for the `RestClient` and `Plugins` classes, we don't have to worry about
the issues posed by them in the
soarez opened a new pull request, #12872:
URL: https://github.com/apache/kafka/pull/12872
Cherry-picked and slightly modified commit 5bd556a49b. The change was made
in line in
`core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: 61`
to remove the `threadMode`
C0urante merged PR #12866:
URL: https://github.com/apache/kafka/pull/12866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #12866:
URL: https://github.com/apache/kafka/pull/12866#issuecomment-1319327985
Test failures are unrelated; merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
C0urante merged PR #12828:
URL: https://github.com/apache/kafka/pull/12828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #12828:
URL: https://github.com/apache/kafka/pull/12828#issuecomment-1319311409
Test failures are unrelated; merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on PR #12752:
URL: https://github.com/apache/kafka/pull/12752#issuecomment-1319300532
@soarez : I tried to cherry-pick the PR to the 3.3. branch, but got a
compilation error. Do you think you could submit a separate PR for 3.3? Thanks.
```
[Error]
junrao merged PR #12752:
URL: https://github.com/apache/kafka/pull/12752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim updated KAFKA-14372:
-
Description:
The default replica selector chooses a replica solely on whether the
broker.rack matches
[
https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-14354:
-
Description: It would be useful for Connectors to know when its instance is
being
[
https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-14354:
-
Summary: Add 'isDeleted' parameter when stopping a Connector (was: Add
'destroyed()'
[
https://issues.apache.org/jira/browse/KAFKA-14372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim updated KAFKA-14372:
-
Description:
The default replica selector chooses a replica solely on whether the
broker.rack matches
C0urante commented on code in PR #12800:
URL: https://github.com/apache/kafka/pull/12800#discussion_r1025529528
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -325,11 +325,12 @@ public Future set(final Map
values, final
C0urante commented on code in PR #12800:
URL: https://github.com/apache/kafka/pull/12800#discussion_r1025541314
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -329,6 +329,60 @@ public void testGetSetNull() throws
[
https://issues.apache.org/jira/browse/KAFKA-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-14396:
---
Assignee: Greg Harris
> Flaky memory leak tests rely on System.gc for correctness
>
C0urante commented on code in PR #12866:
URL: https://github.com/apache/kafka/pull/12866#discussion_r1025503951
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/CryptoLibrary.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #12847:
URL: https://github.com/apache/kafka/pull/12847#discussion_r1025502783
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##
@@ -135,4 +133,71 @@ class GroupCoordinatorAdapterTest {
C0urante commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1025489778
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -43,10 +43,38 @@
import java.util.concurrent.ExecutionException;
vamossagar12 commented on code in PR #12803:
URL: https://github.com/apache/kafka/pull/12803#discussion_r1025489083
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java:
##
@@ -459,12 +461,23 @@ private List
gharris1727 commented on code in PR #12866:
URL: https://github.com/apache/kafka/pull/12866#discussion_r1025479365
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/CryptoLibrary.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
dajac commented on PR #12870:
URL: https://github.com/apache/kafka/pull/12870#issuecomment-1318954178
I have to add a few unit tests in KafkaApisTest. There are none at the
moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-14398:
--
Fix Version/s: 3.4.0
> Update EndToEndAuthorizerTest.scala to test with ZK and KRAFT quorum servers
>
[
https://issues.apache.org/jira/browse/KAFKA-14375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-14375:
--
Fix Version/s: 3.4.0
> Remove use of "authorizer-properties" in EndToEndAuthorizationTest.scala
>
[
https://issues.apache.org/jira/browse/KAFKA-14375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano resolved KAFKA-14375.
---
Resolution: Fixed
> Remove use of "authorizer-properties" in
gharris1727 commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1025464638
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -43,10 +43,38 @@
import java.util.concurrent.ExecutionException;
[
https://issues.apache.org/jira/browse/KAFKA-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reassigned KAFKA-14398:
-
Assignee: Proven Provenzano
> Update EndToEndAuthorizerTest.scala to test with
Proven Provenzano created KAFKA-14398:
-
Summary: Update EndToEndAuthorizerTest.scala to test with ZK and
KRAFT quorum servers
Key: KAFKA-14398
URL: https://issues.apache.org/jira/browse/KAFKA-14398
mumrah merged PR #12860:
URL: https://github.com/apache/kafka/pull/12860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
omkreddy merged PR #12843:
URL: https://github.com/apache/kafka/pull/12843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on code in PR #12866:
URL: https://github.com/apache/kafka/pull/12866#discussion_r1025383865
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/CryptoLibrary.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
mumrah commented on code in PR #12815:
URL: https://github.com/apache/kafka/pull/12815#discussion_r1025397641
##
core/src/main/scala/kafka/migration/ZkMigrationClient.scala:
##
@@ -0,0 +1,359 @@
+package kafka.migration
+
+import kafka.api.LeaderAndIsr
+import
vvcephei commented on code in PR #12869:
URL: https://github.com/apache/kafka/pull/12869#discussion_r1025368358
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -298,6 +298,7 @@ public boolean isRunning() {
private volatile
C0urante commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1025340543
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RestForwardingIntegrationTest.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software
C0urante commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1025336265
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RestForwardingIntegrationTest.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software
dajac opened a new pull request, #12870:
URL: https://github.com/apache/kafka/pull/12870
This patch adds `OffsetFetch` to the new `GroupCoordinator` interface and
updates `KafkaApis` to use it. The changes in `KafkaApis` are larger than what
I was hoping for. I think that we should
divijvaidya commented on PR #12590:
URL: https://github.com/apache/kafka/pull/12590#issuecomment-1318726600
@dajac please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635370#comment-17635370
]
Mikael commented on KAFKA-14362:
When comparing successful test runs with those that generate duplicate
[
https://issues.apache.org/jira/browse/KAFKA-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Tiernay updated KAFKA-9156:
---
Attachment: image-2022-11-17-09-02-20-774.png
> LazyTimeIndex & LazyOffsetIndex may cause
[
https://issues.apache.org/jira/browse/KAFKA-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635367#comment-17635367
]
Bob Tiernay commented on KAFKA-9156:
We too are hitting this on AWS MSK Kafka version 2.8.1:
[
https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635340#comment-17635340
]
Ahmed Sobeh edited comment on KAFKA-6579 at 11/17/22 12:44 PM:
---
will give
[
https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635340#comment-17635340
]
Ahmed Sobeh commented on KAFKA-6579:
will give this a shoft if it's ok [~teamurko]
> Consolidate
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Sobeh reassigned KAFKA-10409:
---
Assignee: (was: Ahmed Sobeh)
> Refactor Kafka Streams RocksDb iterators
>
[ https://issues.apache.org/jira/browse/KAFKA-10409 ]
Ahmed Sobeh deleted comment on KAFKA-10409:
-
was (Author: JIRAUSER295920):
WIll pick this up and take a look if it's ok with everyone watching
> Refactor Kafka Streams RocksDb iterators
>
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Sobeh reassigned KAFKA-10409:
---
Assignee: Ahmed Sobeh
> Refactor Kafka Streams RocksDb iterators
>
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635338#comment-17635338
]
Ahmed Sobeh commented on KAFKA-10409:
-
WIll pick this up and take a look if it's ok with everyone
vamossagar12 commented on PR #12802:
URL: https://github.com/apache/kafka/pull/12802#issuecomment-1318504959
@gharris1727 , i believe this ticket was created by you. Can you take a look
at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
vamossagar12 closed pull request #12826: Using Timer class to track expiry in
IncrementalCooperativeAssignor
URL: https://github.com/apache/kafka/pull/12826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vamossagar12 commented on PR #12826:
URL: https://github.com/apache/kafka/pull/12826#issuecomment-1318417587
@gharris1727 Thanks for the confirmation! Let me close this PR.
BTW: `we can leave this long as-is for a little longer.` this was nice :)
--
This is an automated message
patrik-marton commented on code in PR #12846:
URL: https://github.com/apache/kafka/pull/12846#discussion_r1024994387
##
connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java:
##
@@ -174,4 +153,84 @@ public void
patrik-marton commented on code in PR #12846:
URL: https://github.com/apache/kafka/pull/12846#discussion_r1024987213
##
connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java:
##
@@ -174,4 +153,84 @@ public void
mimaison merged PR #12839:
URL: https://github.com/apache/kafka/pull/12839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #12845:
URL: https://github.com/apache/kafka/pull/12845#issuecomment-1318257181
Rebased the PR. Ready for second round.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
65 matches
Mail list logo
