[GitHub] [kafka] iblislin commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()

2023-01-03 Thread GitBox
iblislin commented on PR #12371: URL: https://github.com/apache/kafka/pull/12371#issuecomment-1370579167 There are related discussions on StackOverflow: https://stackoverflow.com/questions/74679400. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] iblislin commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()

2023-01-03 Thread GitBox
iblislin commented on PR #12371: URL: https://github.com/apache/kafka/pull/12371#issuecomment-1370578419 Hi, I still ran into the issue of NPE on a 3.3.1 cluster with 3 nodes. The actual line throwing the NPE is here:

[jira] [Created] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2023-01-03 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-14567: --- Summary: Kafka Streams crashes after ProducerFencedException Key: KAFKA-14567 URL: https://issues.apache.org/jira/browse/KAFKA-14567 Project: Kafka

[jira] [Updated] (KAFKA-14566) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-03 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14566: Description: h2. PROBLEM The Consumer and Producer interceptor interfaces and their

[jira] [Created] (KAFKA-14566) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-03 Thread Terry Beard (Jira)
Terry Beard created KAFKA-14566: --- Summary: Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces Key: KAFKA-14566 URL: https://issues.apache.org/jira/browse/KAFKA-14566

[jira] [Created] (KAFKA-14565) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-03 Thread Terry Beard (Jira)
Terry Beard created KAFKA-14565: --- Summary: Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces Key: KAFKA-14565 URL: https://issues.apache.org/jira/browse/KAFKA-14565

[GitHub] [kafka] abscondment opened a new pull request, #13070: KAFKA-14564: Upgrade netty to 4.1.86 to address CVEs

2023-01-03 Thread GitBox
abscondment opened a new pull request, #13070: URL: https://github.com/apache/kafka/pull/13070 For [KAFKA-14564](https://issues.apache.org/jira/browse/KAFKA-14564): upgrade to Netty 4.1.86 Fixes the following: * [CVE-2022-41881](https://nvd.nist.gov/vuln/detail/CVE-2022-41881)

[jira] [Commented] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2023-01-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654211#comment-17654211 ] Matthias J. Sax commented on KAFKA-13295: - Thanks. SG. > Long restoration times for new tasks

[jira] [Updated] (KAFKA-14564) Upgrade Netty to 4.1.86.Final to fix CVEs

2023-01-03 Thread Brendan Ribera (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brendan Ribera updated KAFKA-14564: --- Summary: Upgrade Netty to 4.1.86.Final to fix CVEs (was: Upgrade Netty to 4.1.86 to fix

[jira] [Created] (KAFKA-14564) Upgrade Netty to 4.1.86 to fix CVEs

2023-01-03 Thread Brendan Ribera (Jira)
Brendan Ribera created KAFKA-14564: -- Summary: Upgrade Netty to 4.1.86 to fix CVEs Key: KAFKA-14564 URL: https://issues.apache.org/jira/browse/KAFKA-14564 Project: Kafka Issue Type: Bug

[GitHub] [kafka] C0urante commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
C0urante commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1370166878 You can just request that the fix be backported on the PR itself. It also helps (but doesn't guarantee a backport) if you populate the `Affects Version/s` field in Jira so that we know

[GitHub] [kafka] chia7712 closed pull request #13035: [WIP] KAFKA-9087 The changed future log causes that ReplicaAlterLogDirsThre…

2023-01-03 Thread GitBox
chia7712 closed pull request #13035: [WIP] KAFKA-9087 The changed future log causes that ReplicaAlterLogDirsThre… URL: https://github.com/apache/kafka/pull/13035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] csolidum commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
csolidum commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1370118613 @C0urante thanks for the thorough reply. This isn't happening too frequently so i'm fine waiting for the 3.4.1 release. Is the right way to make sure this change is include to email the

[jira] [Resolved] (KAFKA-10550) Update AdminClient and kafka-topics.sh to support topic IDs

2023-01-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-10550. Resolution: Fixed I think the scope of the kip – describe and delete has been completed

[jira] [Created] (KAFKA-14563) Remove AddPartitionsToTxn call for newer clients as optimization

2023-01-03 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14563: -- Summary: Remove AddPartitionsToTxn call for newer clients as optimization Key: KAFKA-14563 URL: https://issues.apache.org/jira/browse/KAFKA-14563 Project: Kafka

[jira] [Assigned] (KAFKA-14561) Improve transactions experience for older clients by ensuring ongoing transaction

2023-01-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-14561: -- Assignee: Justine Olshan > Improve transactions experience for older clients by

[jira] [Created] (KAFKA-14562) Implement epoch bump after every transaction

2023-01-03 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14562: -- Summary: Implement epoch bump after every transaction Key: KAFKA-14562 URL: https://issues.apache.org/jira/browse/KAFKA-14562 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-14561) Improve transactions experience for older clients by ensuring ongoing transaction

2023-01-03 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14561: -- Summary: Improve transactions experience for older clients by ensuring ongoing transaction Key: KAFKA-14561 URL: https://issues.apache.org/jira/browse/KAFKA-14561

[jira] [Updated] (KAFKA-14402) Transactions Server Side Defense

2023-01-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14402: --- Issue Type: Improvement (was: Task) > Transactions Server Side Defense >

[GitHub] [kafka] C0urante commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
C0urante commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1370104970 That's the best summary I can provide right now; @mimaison please keep me honest if anything is misleading or incorrect  -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] C0urante commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
C0urante commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1370104415 @csolidum We can backport bug fixes that are low-risk and non-invasive (such as this one) to older branches so that they'll appear in subsequent releases. However, for active releases

[GitHub] [kafka] ivanyu commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-03 Thread GitBox
ivanyu commented on PR #13067: URL: https://github.com/apache/kafka/pull/13067#issuecomment-1370097055 There are four places where `KafkaMetricsGroup` methods are overridden, it's always `metricName`. Sometimes it comes with some logic like in `UnifiedLog`. We of course can change this in

[jira] [Commented] (KAFKA-9087) ReplicaAlterLogDirs stuck and restart fails with java.lang.IllegalStateException: Offset mismatch for the future replica

2023-01-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654133#comment-17654133 ] Chia-Ping Tsai commented on KAFKA-9087: --- [~junrao] Sorry for late response. {quote}So,

[jira] [Comment Edited] (KAFKA-14453) Flaky test suite MirrorConnectorsWithCustomForwardingAdminIntegrationTest

2023-01-03 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654131#comment-17654131 ] Chris Egerton edited comment on KAFKA-14453 at 1/3/23 6:22 PM: --- [~mjsax]

[jira] [Commented] (KAFKA-14453) Flaky test suite MirrorConnectorsWithCustomForwardingAdminIntegrationTest

2023-01-03 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654131#comment-17654131 ] Chris Egerton commented on KAFKA-14453: --- [~mjsax] I've got a lot on my plate over the next couple

[GitHub] [kafka] csolidum commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
csolidum commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1370085587 @mimaison @gharris1727 @C0urante Still getting a sense of what the kafka release process is like for bug fixes. Is there a way to request this patch is included into the next 3.3.X

[GitHub] [kafka] C0urante commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2023-01-03 Thread GitBox
C0urante commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1060830766 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -780,6 +774,14 @@ protected void stopServices() {

[GitHub] [kafka] csolidum commented on a diff in pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
csolidum commented on code in PR #13052: URL: https://github.com/apache/kafka/pull/13052#discussion_r1060839550 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -189,14 +189,17 @@ private Map listConsumerGroupOffsets(String g

[GitHub] [kafka] jolshan commented on pull request #13068: KAFKA-13999: Add ProducerIdCount metric

2023-01-03 Thread GitBox
jolshan commented on PR #13068: URL: https://github.com/apache/kafka/pull/13068#issuecomment-1370083728 Ah I believe had a slightly different idea for implementation where the size was not evaluated on every call, but rather a variable was updated every time we added or removed producer

[GitHub] [kafka] fvaleri commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-03 Thread GitBox
fvaleri commented on PR #13067: URL: https://github.com/apache/kafka/pull/13067#issuecomment-1370083367 Hi @ivanyu, thanks for looking into this. >Currently, classes-users of the KafkaMetricsGroup trait sometimes override its methods to tune its behavior (mostly, names). If

[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-03 Thread GitBox
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1370081626 @mimaison Thanks for the review. I addressed or replied to each comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-03 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060836979 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-03 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060835881 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-03 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060835881 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] C0urante commented on a diff in pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

2023-01-03 Thread GitBox
C0urante commented on code in PR #11818: URL: https://github.com/apache/kafka/pull/11818#discussion_r1060825828 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -294,5 +302,9 @@ boolean update(long upstreamOffset, long

[GitHub] [kafka] mimaison commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-03 Thread GitBox
mimaison commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060760759 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (KAFKA-14560) Remove old client protocol API versions in Kafka 4.0 (KIP-896)

2023-01-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14560: Fix Version/s: 4.0.0 > Remove old client protocol API versions in Kafka 4.0 (KIP-896) >

[jira] [Updated] (KAFKA-14560) Remove old client protocol API versions in Kafka 4.0 (KIP-896)

2023-01-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14560: Priority: Blocker (was: Major) > Remove old client protocol API versions in Kafka 4.0 (KIP-896)

[GitHub] [kafka] viktorsomogyi commented on pull request #13069: MINOR: Check process role and set correct logdirs

2023-01-03 Thread GitBox
viktorsomogyi commented on PR #13069: URL: https://github.com/apache/kafka/pull/13069#issuecomment-1369948285 (Also the PR will need test changes at least but I wanted to start some conversation early on.) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] viktorsomogyi commented on pull request #13069: MINOR: Check process role and set correct logdirs

2023-01-03 Thread GitBox
viktorsomogyi commented on PR #13069: URL: https://github.com/apache/kafka/pull/13069#issuecomment-1369947044 @rondagostino would you please help understanding why does the controller need the log.dirs config? Does it store any data in log.dirs? As per my understanding it only needs

[GitHub] [kafka] viktorsomogyi opened a new pull request, #13069: MINOR: Check process role and set correct logdirs

2023-01-03 Thread GitBox
viktorsomogyi opened a new pull request, #13069: URL: https://github.com/apache/kafka/pull/13069 Currently a controller role will fail if no log.dirs are specified. This is caused by KafkaRaftServer as it merges the configs in log.dirs and metadata.log.dir. If the paths in log.dirs weren't

[jira] [Created] (KAFKA-14560) Remove old client protocol API versions in Kafka 4.0 (KIP-896)

2023-01-03 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-14560: --- Summary: Remove old client protocol API versions in Kafka 4.0 (KIP-896) Key: KAFKA-14560 URL: https://issues.apache.org/jira/browse/KAFKA-14560 Project: Kafka

[jira] [Commented] (KAFKA-14542) Deprecate OffsetFetch/Commit version 0 and remove them in 4.0

2023-01-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654070#comment-17654070 ] Ismael Juma commented on KAFKA-14542: -

[jira] [Updated] (KAFKA-12872) KIP-724: Drop support for message formats v0 and v1

2023-01-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12872: Priority: Blocker (was: Major) > KIP-724: Drop support for message formats v0 and v1 >

[jira] [Commented] (KAFKA-14255) Fetching from follower should be disallowed if fetch from follower is disabled

2023-01-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654059#comment-17654059 ] Ismael Juma commented on KAFKA-14255: - [~dajac] A couple more projects worth filing a ticket for: *

[GitHub] [kafka] mimaison commented on a diff in pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-03 Thread GitBox
mimaison commented on code in PR #13052: URL: https://github.com/apache/kafka/pull/13052#discussion_r1060672958 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -189,14 +189,17 @@ private Map listConsumerGroupOffsets(String g

[GitHub] [kafka] clolov commented on pull request #13068: KAFKA-13999: Add ProducerIdCount metric

2023-01-03 Thread GitBox
clolov commented on PR #13068: URL: https://github.com/apache/kafka/pull/13068#issuecomment-1369826380 For visibility: @artemlivshits - as the original author @showuon - as you commented on the JIRA ticket and I believe you have the knowledge to review the change @jolshan - as you

[GitHub] [kafka] clolov opened a new pull request, #13068: KAFKA-13999: Add ProducerIdCount metric

2023-01-03 Thread GitBox
clolov opened a new pull request, #13068: URL: https://github.com/apache/kafka/pull/13068 _Summary_ This PR provides an implementation of KIP-847 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-847%3A+Add+ProducerIdCount+metrics). As far as I can tell, the original author

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #13032: KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer

2023-01-03 Thread GitBox
viktorsomogyi commented on code in PR #13032: URL: https://github.com/apache/kafka/pull/13032#discussion_r1060471853 ## clients/src/test/java/org/apache/kafka/common/protocol/DataOutputStreamWritableTest.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-01-03 Thread GitBox
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1060450083 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -723,7 +752,11 @@ private void sendPrivileged(String key,