[GitHub] [kafka] satishd merged pull request #13079: MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

2023-01-04 Thread GitBox
satishd merged PR #13079: URL: https://github.com/apache/kafka/pull/13079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on pull request #13079: MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

2023-01-04 Thread GitBox
satishd commented on PR #13079: URL: https://github.com/apache/kafka/pull/13079#issuecomment-1371882997 These intermittent test failures are not related to this change, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] iamazy commented on pull request #13072: KAFKA-14570: Add missing closing parenthesis symbol

2023-01-04 Thread GitBox
iamazy commented on PR #13072: URL: https://github.com/apache/kafka/pull/13072#issuecomment-1371872165 @ijuma please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dengziming closed pull request #10467: KAFKA-12609: Rewrite ListOffsets using AdminApiDriver

2023-01-04 Thread GitBox
dengziming closed pull request #10467: KAFKA-12609: Rewrite ListOffsets using AdminApiDriver URL: https://github.com/apache/kafka/pull/10467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dengziming closed pull request #10147: MINOR: Add raft resigned state metric name

2023-01-04 Thread GitBox
dengziming closed pull request #10147: MINOR: Add raft resigned state metric name URL: https://github.com/apache/kafka/pull/10147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dengziming closed pull request #9500: Investigate Flaky tests

2023-01-04 Thread GitBox
dengziming closed pull request #9500: Investigate Flaky tests URL: https://github.com/apache/kafka/pull/9500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] Naancy commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2023-01-04 Thread GitBox
Naancy commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1062120831 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -273,26 +273,29 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

2023-01-04 Thread GitBox
ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1062119225 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochCheckpoint.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

2023-01-04 Thread GitBox
ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1062119225 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochCheckpoint.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-04 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1062116212 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] satishd commented on pull request #13043: KAFKA-14558 Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module.

2023-01-04 Thread GitBox
satishd commented on PR #13043: URL: https://github.com/apache/kafka/pull/13043#issuecomment-1371789074 @ijuma I rebased it with trunk to resolve the conflicts, working on addressing your review comments. I will let you once I am done with my changes. -- This is an automated message

[GitHub] [kafka] satishd commented on pull request #13079: MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

2023-01-04 Thread GitBox
satishd commented on PR #13079: URL: https://github.com/apache/kafka/pull/13079#issuecomment-1371756473 @ijuma: Filed https://issues.apache.org/jira/browse/KAFKA-14574 as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (KAFKA-14574) Add doc generation as part of the CI build process

2023-01-04 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-14574: -- Summary: Add doc generation as part of the CI build process Key: KAFKA-14574 URL: https://issues.apache.org/jira/browse/KAFKA-14574 Project: Kafka Issue

[GitHub] [kafka] satishd merged pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
satishd merged PR #13065: URL: https://github.com/apache/kafka/pull/13065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-04 Thread GitBox
satishd commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1062049275 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] satishd commented on pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
satishd commented on PR #13065: URL: https://github.com/apache/kafka/pull/13065#issuecomment-1371669507 Failing test does not seem to be related to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma commented on pull request #13079: MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

2023-01-04 Thread GitBox
ijuma commented on PR #13079: URL: https://github.com/apache/kafka/pull/13079#issuecomment-1371663717 We should ideally run this as part of the CI build. Maybe file a JIRA for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] junrao commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-04 Thread GitBox
junrao commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1062032815 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] satishd commented on pull request #13079: MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

2023-01-04 Thread GitBox
satishd commented on PR #13079: URL: https://github.com/apache/kafka/pull/13079#issuecomment-1371638327 cc @ijuma @showuon @omkreddy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] satishd opened a new pull request, #13079: MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs.

2023-01-04 Thread GitBox
satishd opened a new pull request, #13079: URL: https://github.com/apache/kafka/pull/13079 MINOR Fixed doc generation for LogConfig class in genTopicConfigDocs. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] jolshan commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

2023-01-04 Thread GitBox
jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1371634002 Thanks @anatasiavela and @artemlivshits -- I'll take a look at the build when it completes, but this looks pretty good so far. -- This is an automated message from the Apache Git

[GitHub] [kafka] jolshan commented on a diff in pull request #13068: KAFKA-13999: Add ProducerIdCount metric

2023-01-04 Thread GitBox
jolshan commented on code in PR #13068: URL: https://github.com/apache/kafka/pull/13068#discussion_r1062016540 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -502,6 +503,8 @@ class ProducerStateManager( private var lastMapOffset = 0L private var

[GitHub] [kafka] jolshan commented on pull request #13068: KAFKA-13999: Add ProducerIdCount metric

2023-01-04 Thread GitBox
jolshan commented on PR #13068: URL: https://github.com/apache/kafka/pull/13068#issuecomment-1371625876 Here's the alternative PR: https://github.com/apache/kafka/pull/13078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe closed pull request #13028: KAFKA-14458: Introduce RPC support during ZK migration

2023-01-04 Thread GitBox
cmccabe closed pull request #13028: KAFKA-14458: Introduce RPC support during ZK migration URL: https://github.com/apache/kafka/pull/13028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cmccabe commented on pull request #13028: KAFKA-14458: Introduce RPC support during ZK migration

2023-01-04 Thread GitBox
cmccabe commented on PR #13028: URL: https://github.com/apache/kafka/pull/13028#issuecomment-1371610742 LGTM committed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] anatasiavela opened a new pull request, #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

2023-01-04 Thread GitBox
anatasiavela opened a new pull request, #13078: URL: https://github.com/apache/kafka/pull/13078 This is the PR for the implementation of KIP-847: https://cwiki.apache.org/confluence/display/KAFKA/KIP-847%3A+Add+ProducerIdCount+metrics Add ProducerIdCount metric at the broker level:

[GitHub] [kafka] ijuma commented on pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

2023-01-04 Thread GitBox
ijuma commented on PR #13075: URL: https://github.com/apache/kafka/pull/13075#issuecomment-1371558425 Is it possible to add a test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
ijuma commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371550279 Merged to trunk, 3.4 and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14571. - Resolution: Fixed > ZkMetadataCache.getClusterMetadata is missing rack information in

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

2023-01-04 Thread GitBox
mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1061951302 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java: ## @@ -24,8 +24,6 @@ public class ChangedDeserializer implements

[GitHub] [kafka] jsancio commented on pull request #13058: KAFKA-14557; Lock metadata log dir

2023-01-04 Thread GitBox
jsancio commented on PR #13058: URL: https://github.com/apache/kafka/pull/13058#issuecomment-1371500365 I should mention that the long term solution would be to extend the LogManager to support the kraft metadata log but there are issues like

[GitHub] [kafka] ijuma merged pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
ijuma merged PR #13073: URL: https://github.com/apache/kafka/pull/13073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
ijuma commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371494418 I see, makes sense. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] jsancio commented on a diff in pull request #13058: KAFKA-14557; Lock metadata log dir

2023-01-04 Thread GitBox
jsancio commented on code in PR #13058: URL: https://github.com/apache/kafka/pull/13058#discussion_r1061930398 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -154,6 +192,8 @@ class KafkaRaftManager[T]( scheduler.shutdown() netChannel.close()

[jira] [Commented] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654663#comment-17654663 ] Edoardo Comar commented on KAFKA-14571: --- classified as minor because the the Cluster object

[GitHub] [kafka] jsancio commented on a diff in pull request #13058: KAFKA-14557; Lock metadata log dir

2023-01-04 Thread GitBox
jsancio commented on code in PR #13058: URL: https://github.com/apache/kafka/pull/13058#discussion_r1061928077 ## core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala: ## @@ -81,25 +100,99 @@ class RaftManagerTest { ) } - @Test - def

[jira] [Updated] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-14571: -- Priority: Minor (was: Major) > ZkMetadataCache.getClusterMetadata is missing rack

[GitHub] [kafka] edoardocomar commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
edoardocomar commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371482567 @ijuma the `Cluster` object returned from `MetadataCache.getClusterMetadata(...)` is passed to `ClientQuotaCallback.updateClusterMetadata(...)` so I'd say it is used,

[GitHub] [kafka] ijuma commented on a diff in pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests

2023-01-04 Thread GitBox
ijuma commented on code in PR #12210: URL: https://github.com/apache/kafka/pull/12210#discussion_r1061872501 ## tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py: ## @@ -73,6 +75,7 @@ def min_cluster_size(self):

[GitHub] [kafka] jsancio commented on pull request #13077: KAFKA-14545; Add 3.3.x streams system tests

2023-01-04 Thread GitBox
jsancio commented on PR #13077: URL: https://github.com/apache/kafka/pull/13077#issuecomment-1371398327 @cadonna can you review this PR? Running system tests on this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jsancio opened a new pull request, #13077: KAFKA-14545; Add 3.3.x streams system tests

2023-01-04 Thread GitBox
jsancio opened a new pull request, #13077: URL: https://github.com/apache/kafka/pull/13077 Add 3.3.x stream upgrade tests. The streams/upgrade-system-tests-33 directory was created by coping streams/upgrade-system-tests-32 without changes. ### Committer Checklist (excluded from

[jira] [Updated] (KAFKA-14573) RoundRobinPartitioner doesn't work as expected with topic that has 6 partitions

2023-01-04 Thread Stephane Maarek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephane Maarek updated KAFKA-14573: Description: Create a topic with 6 partitions (that's how the behavior is observed) ```

[jira] [Updated] (KAFKA-14573) RoundRobinPartitioner doesn't work as expected with topic that has 6 partitions

2023-01-04 Thread Stephane Maarek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephane Maarek updated KAFKA-14573: Description: Create a topic with 6 partitions (that's how the behavior is observed) ```

[jira] [Created] (KAFKA-14573) RoundRobinPartitioner doesn't work as expected with topic that has 6 partitions

2023-01-04 Thread Stephane Maarek (Jira)
Stephane Maarek created KAFKA-14573: --- Summary: RoundRobinPartitioner doesn't work as expected with topic that has 6 partitions Key: KAFKA-14573 URL: https://issues.apache.org/jira/browse/KAFKA-14573

[GitHub] [kafka] jsancio commented on pull request #13076: KAFKA-14279; Add 3.3.x to core compatibility tests

2023-01-04 Thread GitBox
jsancio commented on PR #13076: URL: https://github.com/apache/kafka/pull/13076#issuecomment-1371367643 @cadonna can you review this PR? Running system tests on this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jsancio opened a new pull request, #13076: KAFKA-14279; Add 3.3.x to core compatibility tests

2023-01-04 Thread GitBox
jsancio opened a new pull request, #13076: URL: https://github.com/apache/kafka/pull/13076 Now that 3.3.x exist, add system tests for upgrade, downgrade and client compatibility. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] jsancio commented on a diff in pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests

2023-01-04 Thread GitBox
jsancio commented on code in PR #12210: URL: https://github.com/apache/kafka/pull/12210#discussion_r1061836000 ## tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py: ## @@ -73,6 +75,7 @@ def min_cluster_size(self):

[jira] [Created] (KAFKA-14572) Migrate EmbeddedKafkaCluster used by Streams integration tests from EmbeddedZookeeper to KRaft

2023-01-04 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-14572: --- Summary: Migrate EmbeddedKafkaCluster used by Streams integration tests from EmbeddedZookeeper to KRaft Key: KAFKA-14572 URL:

[GitHub] [kafka] mimaison commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-04 Thread GitBox
mimaison commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1371348167 Yes but I can't merge it in the 3.4 branch at the moment as it's frozen for the release. I'll try to remember to do it once 3.4.0 is out. Feel free to follow up here if you don't see it

[jira] [Updated] (KAFKA-14279) Add 3.3.1 to broker/client and stream upgrade/compatibility tests

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14279: --- Description: Per the penultimate bullet on the [release

[GitHub] [kafka] csolidum commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-04 Thread GitBox
csolidum commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1371337791 @mimaison Thanks for merging. Would it be possible to get this included in the 3.4.1 patch? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
ijuma commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371218226 @edoardocomar Got it. If this is not exposed internally, then we can adjust it back to minor. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] edoardocomar commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
edoardocomar commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371208107 > Thanks for the PR. Does this mean we are returning incorrect information to clients? Hi @ijuma thankfully we're not returning incorrect info in the describeCluster API

[GitHub] [kafka] chia7712 opened a new pull request, #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

2023-01-04 Thread GitBox
chia7712 opened a new pull request, #13075: URL: https://github.com/apache/kafka/pull/13075 ``` [2019-06-11 17:58:46,304] ERROR [ReplicaAlterLogDirsThread-1]: Error due to (kafka.server.ReplicaAlterLogDirsThread) org.apache.kafka.common.KafkaException: Error processing data for

[GitHub] [kafka] ruslankrivoshein opened a new pull request, #13074: update.from is revealed for Upgrade doc

2023-01-04 Thread GitBox
ruslankrivoshein opened a new pull request, #13074: URL: https://github.com/apache/kafka/pull/13074 Since 0.10.1.2 is long ago released, this config param should be revealed. This PR doesn't touch codebase, so no necessary to test it. -- This is an automated message from the

[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: MINOR fix to include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
ijuma commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371169685 Thanks for the PR. Does this mean we are returning incorrect information to clients? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14571: Fix Version/s: 3.3.3 3.4.0 > ZkMetadataCache.getClusterMetadata is missing

[jira] [Updated] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14571: Priority: Major (was: Blocker) > ZkMetadataCache.getClusterMetadata is missing rack information

[jira] [Updated] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14571: Priority: Blocker (was: Minor) > ZkMetadataCache.getClusterMetadata is missing rack information

[GitHub] [kafka] ijuma commented on pull request #13043: KAFKA-14558 Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module.

2023-01-04 Thread GitBox
ijuma commented on PR #13043: URL: https://github.com/apache/kafka/pull/13043#issuecomment-1371165209 @satishd Just checking that you saw the review for this PR (there was an issue with the notifications in a previous one, I believe). I was planning to merge this before reviewing the next

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1061663838 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ivanyu commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
ivanyu commented on PR #13067: URL: https://github.com/apache/kafka/pull/13067#issuecomment-1371142944 @ijuma I don't see much difference with `QuorumControllerMetrics` on the low level. Tags are not used in `QuorumControllerMetrics` (this is situational I think); type names are set

[GitHub] [kafka] tombentley commented on a diff in pull request #13071: MINOR: doc: note how JDK-8136913 can affect client SASL

2023-01-04 Thread GitBox
tombentley commented on code in PR #13071: URL: https://github.com/apache/kafka/pull/13071#discussion_r1061629778 ## docs/security.html: ## @@ -677,7 +677,11 @@ To configure SASL authentication on the clients, select a SASL mechanism that is enabled

[GitHub] [kafka] mimaison commented on a diff in pull request #13071: MINOR: doc: note how JDK-8136913 can affect client SASL

2023-01-04 Thread GitBox
mimaison commented on code in PR #13071: URL: https://github.com/apache/kafka/pull/13071#discussion_r1061610280 ## docs/security.html: ## @@ -677,7 +677,11 @@ To configure SASL authentication on the clients, select a SASL mechanism that is enabled in

[GitHub] [kafka] ivanyu commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
ivanyu commented on code in PR #13065: URL: https://github.com/apache/kafka/pull/13065#discussion_r1061598386 ## storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ivanyu commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
ivanyu commented on code in PR #13065: URL: https://github.com/apache/kafka/pull/13065#discussion_r1061598967 ## storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ivanyu commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
ivanyu commented on code in PR #13065: URL: https://github.com/apache/kafka/pull/13065#discussion_r1061595160 ## storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (KAFKA-14565) Improving Interceptor Resource Leakage Prevention

2023-01-04 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Summary: Improving Interceptor Resource Leakage Prevention (was: Interceptor Resource Leakage

[jira] [Updated] (KAFKA-14565) Interceptor Resource Leakage Prevention

2023-01-04 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Summary: Interceptor Resource Leakage Prevention (was: Add A No Implementation Default Open

[GitHub] [kafka] edoardocomar commented on pull request #13073: KAFKA-14571: MINOR fix to include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
edoardocomar commented on PR #13073: URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371027547 commit can be cherry picked cleanly in 3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] edoardocomar opened a new pull request, #13073: KAFKA-14571: MINOR fix to include rack info in ZkMetadataCache.getClusterMetadata

2023-01-04 Thread GitBox
edoardocomar opened a new pull request, #13073: URL: https://github.com/apache/kafka/pull/13073 `ZkMetadataCache.getClusterMetadata` returns a Cluster object where the aliveNodes were missing their rack info. problem: when ZkMetadataCache updates the metadataSnapshot, includes the

[jira] [Updated] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes

2023-01-04 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-14571: -- Summary: ZkMetadataCache.getClusterMetadata is missing rack information in aliveNodes (was:

[jira] [Created] (KAFKA-14571) ZkMetadataCache.getClusterMetadata is missing rack information for aliveNodes

2023-01-04 Thread Edoardo Comar (Jira)
Edoardo Comar created KAFKA-14571: - Summary: ZkMetadataCache.getClusterMetadata is missing rack information for aliveNodes Key: KAFKA-14571 URL: https://issues.apache.org/jira/browse/KAFKA-14571

[jira] [Updated] (KAFKA-14570) Problem description missing closing parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Description: In

[jira] [Updated] (KAFKA-14570) Problem description missing closing parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Summary: Problem description missing closing parenthesis symbol (was: Problem description missing right

[GitHub] [kafka] iamazy opened a new pull request, #13072: KAFKA-14570: Add missing closing parenthesis symbol

2023-01-04 Thread GitBox
iamazy opened a new pull request, #13072: URL: https://github.com/apache/kafka/pull/13072 There should add missing closing parenthesis symbol for problem description. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[jira] [Updated] (KAFKA-14570) Problem description missing right parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Description: In

[jira] [Updated] (KAFKA-14570) Problem description missing right parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Description: In

[jira] [Updated] (KAFKA-14570) Problem description missing right parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Description: In

[jira] [Updated] (KAFKA-14570) Problem description missing right parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Description: In

[jira] [Updated] (KAFKA-14570) Problem description missing right parenthesis symbol

2023-01-04 Thread iamazy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] iamazy updated KAFKA-14570: --- Description: In

[jira] [Created] (KAFKA-14570) Problem description missing right parenthesis symbol

2023-01-04 Thread iamazy (Jira)
iamazy created KAFKA-14570: -- Summary: Problem description missing right parenthesis symbol Key: KAFKA-14570 URL: https://issues.apache.org/jira/browse/KAFKA-14570 Project: Kafka Issue Type:

[GitHub] [kafka] lbownik commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
lbownik commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1061467816 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] lbownik commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
lbownik commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1061466176 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] lbownik commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
lbownik commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1061458021 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-14566) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-04 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14566: Description: h2. PROBLEM The Consumer and Producer interceptor interfaces and their

[jira] [Updated] (KAFKA-14566) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-04 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14566: Description: h2. PROBLEM The Consumer and Producer interceptor interfaces and their

[GitHub] [kafka] lbownik commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
lbownik commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1061455377 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-14565) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-04 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: h2. PROBLEM The Consumer and Producer interceptor interfaces and their

[jira] [Updated] (KAFKA-14565) Add A No Implementation Default Open Method To Consumer and Producer Interceptor Interfaces

2023-01-04 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: h2. PROBLEM The Consumer and Producer interceptor interfaces and their

[GitHub] [kafka] fvaleri commented on pull request #13071: MINOR: doc: note how JDK-8136913 can affect client SASL

2023-01-04 Thread GitBox
fvaleri commented on PR #13071: URL: https://github.com/apache/kafka/pull/13071#issuecomment-1370887362 LGTM. This can spare some headaches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2023-01-04 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1061433053 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -780,6 +774,14 @@ protected void stopServices() {

[GitHub] [kafka] dengziming commented on a diff in pull request #13050: MINOR: add error reason when controller failed to handle events

2023-01-04 Thread GitBox
dengziming commented on code in PR #13050: URL: https://github.com/apache/kafka/pull/13050#discussion_r1061409335 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -432,8 +432,8 @@ private Throwable handleEventException(String name,

[jira] [Commented] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654417#comment-17654417 ] Ismael Juma commented on KAFKA-14524: - "I'm also wondering if the move away from Scala would qualify

[jira] [Comment Edited] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654415#comment-17654415 ] Ismael Juma edited comment on KAFKA-14524 at 1/4/23 11:47 AM: --

[jira] [Comment Edited] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654413#comment-17654413 ] Matthew de Detrich edited comment on KAFKA-14524 at 1/4/23 11:45 AM: -

[jira] [Commented] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654415#comment-17654415 ] Ismael Juma commented on KAFKA-14524: - [~mdedetrich-aiven] Please check KAFKA-14470 where this is

[jira] [Comment Edited] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654413#comment-17654413 ] Matthew de Detrich edited comment on KAFKA-14524 at 1/4/23 11:44 AM: -

[jira] [Commented] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654413#comment-17654413 ] Matthew de Detrich commented on KAFKA-14524: I believe the main intention of this is to

[jira] [Updated] (KAFKA-14545) MirrorCheckpointTask throws NullPointerException when group hasn't consumed from some partitions

2023-01-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14545: --- Affects Version/s: 3.4.0 > MirrorCheckpointTask throws NullPointerException when group

  1   2   >