satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063147960
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063072191
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063071578
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063070497
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063068193
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063067653
##
storage/src/main/java/org/apache/kafka/server/log/internals/LastRecord.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063067362
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -354,9 +356,10 @@ class LogSegmentTest {
// recover again, but this time assuming the
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
showuon commented on PR #13083:
URL: https://github.com/apache/kafka/pull/13083#issuecomment-1373098778
Happy new year! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ijuma commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063058965
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-14465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655220#comment-17655220
]
jianbin.chen commented on KAFKA-14465:
--
Can you help me with this question?
>
ableegoldman merged PR #13083:
URL: https://github.com/apache/kafka/pull/13083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman opened a new pull request, #13083:
URL: https://github.com/apache/kafka/pull/13083
It's 2023 now y'all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ableegoldman closed pull request #7824: MINOR: flush only the evicted dirty
entry
URL: https://github.com/apache/kafka/pull/7824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard reassigned KAFKA-14565:
---
Assignee: Terry Beard
> Improving Interceptor Resource Leakage Prevention
>
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Fix Version/s: 3.5.0
> Improving Interceptor Resource Leakage Prevention
>
jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063013207
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063013207
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063012777
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
junrao commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1063005106
##
core/src/test/scala/unit/kafka/server/epoch/LeaderEpochFileCacheTest.scala:
##
@@ -243,282 +245,287 @@ class LeaderEpochFileCacheTest {
//Given
val cache
chia7712 commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063007860
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
littlehorse-eng commented on code in PR #13082:
URL: https://github.com/apache/kafka/pull/13082#discussion_r1062979323
##
docs/streams/developer-guide/config-streams.html:
##
@@ -778,10 +778,21 @@ rack.aware.assignment.tagsmax.warmup.replicas
-
littlehorse-eng opened a new pull request, #13082:
URL: https://github.com/apache/kafka/pull/13082
Documentation only—Minor clarification on how max.warmup.replicas works;
specifically, that one "warmup replica" corresponds to a Task that is restoring
its state. Also clarifies how
chia7712 commented on PR #13075:
URL: https://github.com/apache/kafka/pull/13075#issuecomment-1372912104
> is this because the log's highwatermark is lower or higher than the
futureLog's?
higher, and thanks to @junrao for the great explanation.
--
This is an automated
vladimirdyuzhev commented on PR #13081:
URL: https://github.com/apache/kafka/pull/13081#issuecomment-1372892329
Some tests are failed, but apparently it has nothing to do with Kerberos:
```
testSendNonCompressedMessageWithCreateTime(String) >
[
https://issues.apache.org/jira/browse/KAFKA-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655155#comment-17655155
]
Chia-Ping Tsai commented on KAFKA-9087:
---
[~junrao] Please take a look at
[
https://issues.apache.org/jira/browse/KAFKA-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655153#comment-17655153
]
Jun Rao commented on KAFKA-9087:
[~chia7712] : Thanks for the explanation. Great find! I agree that this
jolshan commented on PR #13075:
URL: https://github.com/apache/kafka/pull/13075#issuecomment-1372876700
So the error occurs when the fetch offset is not the futureLog's log end
offset.
Just curious -- is this because the log's highwatermark is lower or higher
than the futureLog's?
jsancio commented on PR #13077:
URL: https://github.com/apache/kafka/pull/13077#issuecomment-1372724189
Same failure again:
mjsax commented on code in PR #13077:
URL: https://github.com/apache/kafka/pull/13077#discussion_r1062838773
##
streams/upgrade-system-tests-33/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
jsancio merged PR #13076:
URL: https://github.com/apache/kafka/pull/13076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vladimirdyuzhev opened a new pull request, #13081:
URL: https://github.com/apache/kafka/pull/13081
When keytab file is not used, and the necessary configuration data are
provided by the SASL callback handler, the Kerberos TGT renewal fails because
the code is not re-using the configured
philipnee commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1062809110
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #13049:
URL: https://github.com/apache/kafka/pull/13049#discussion_r1062797781
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation
jsancio commented on PR #13077:
URL: https://github.com/apache/kafka/pull/13077#issuecomment-1372590378
Here are the system test results:
jsancio commented on PR #13076:
URL: https://github.com/apache/kafka/pull/13076#issuecomment-1372586923
Thanks for the review @ijuma. Here are the results:
[
https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14597:
Component/s: metrics
streams
> [Streams] record-e2e-latency-max is not
[
https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atul Jain updated KAFKA-14597:
--
Description:
I was following this KIP documentation
Atul Jain created KAFKA-14597:
-
Summary: [Streams] record-e2e-latency-max is not reporting correct
metrics
Key: KAFKA-14597
URL: https://issues.apache.org/jira/browse/KAFKA-14597
Project: Kafka
gharris1727 commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1062744806
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -723,7 +752,11 @@ private void sendPrivileged(String key,
gharris1727 commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1062726003
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
[
https://issues.apache.org/jira/browse/KAFKA-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655063#comment-17655063
]
Ismael Juma commented on KAFKA-14547:
-
Related KIP
Mickael Maison created KAFKA-14594:
--
Summary: Move LogDirsCommand to tools
Key: KAFKA-14594
URL: https://issues.apache.org/jira/browse/KAFKA-14594
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14593:
--
Summary: Move LeaderElectionCommand to tools
Key: KAFKA-14593
URL: https://issues.apache.org/jira/browse/KAFKA-14593
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14595:
--
Summary: Move ReassignPartitionsCommand to tools
Key: KAFKA-14595
URL: https://issues.apache.org/jira/browse/KAFKA-14595
Project: Kafka
Issue Type:
Mickael Maison created KAFKA-14596:
--
Summary: Move TopicCommand to tools
Key: KAFKA-14596
URL: https://issues.apache.org/jira/browse/KAFKA-14596
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14590:
--
Summary: Move DelegationTokenCommand to tools
Key: KAFKA-14590
URL: https://issues.apache.org/jira/browse/KAFKA-14590
Project: Kafka
Issue Type:
Mickael Maison created KAFKA-14591:
--
Summary: Move DeleteRecordsCommand to tools
Key: KAFKA-14591
URL: https://issues.apache.org/jira/browse/KAFKA-14591
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14592:
--
Summary: Move FeatureCommand to tools
Key: KAFKA-14592
URL: https://issues.apache.org/jira/browse/KAFKA-14592
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14589:
--
Summary: Move ConsumerGroupCommand to tools
Key: KAFKA-14589
URL: https://issues.apache.org/jira/browse/KAFKA-14589
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14588:
--
Summary: Move ConfigCommand to tools
Key: KAFKA-14588
URL: https://issues.apache.org/jira/browse/KAFKA-14588
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14587:
--
Summary: Move AclCommand to tools
Key: KAFKA-14587
URL: https://issues.apache.org/jira/browse/KAFKA-14587
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14586:
--
Summary: Move StreamsResetter to tools
Key: KAFKA-14586
URL: https://issues.apache.org/jira/browse/KAFKA-14586
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14585:
--
Summary: Move StorageTool to tools
Key: KAFKA-14585
URL: https://issues.apache.org/jira/browse/KAFKA-14585
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14583:
--
Summary: Move ReplicaVerificationTool to tools
Key: KAFKA-14583
URL: https://issues.apache.org/jira/browse/KAFKA-14583
Project: Kafka
Issue Type:
Mickael Maison created KAFKA-14584:
--
Summary: Move StateChangeLogMerger to tools
Key: KAFKA-14584
URL: https://issues.apache.org/jira/browse/KAFKA-14584
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14581:
--
Summary: Move GetOffsetShell to tools
Key: KAFKA-14581
URL: https://issues.apache.org/jira/browse/KAFKA-14581
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14582:
--
Summary: Move JmxTool to tools
Key: KAFKA-14582
URL: https://issues.apache.org/jira/browse/KAFKA-14582
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14578:
--
Summary: Move ConsumerPerformance to tools
Key: KAFKA-14578
URL: https://issues.apache.org/jira/browse/KAFKA-14578
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14580:
--
Summary: Move EndToEndLatency to tools
Key: KAFKA-14580
URL: https://issues.apache.org/jira/browse/KAFKA-14580
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14579:
--
Summary: Move DumpLogSegments to tools
Key: KAFKA-14579
URL: https://issues.apache.org/jira/browse/KAFKA-14579
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14577:
--
Summary: Move ConsoleProducer to tools
Key: KAFKA-14577
URL: https://issues.apache.org/jira/browse/KAFKA-14577
Project: Kafka
Issue Type: Sub-task
Mickael Maison created KAFKA-14576:
--
Summary: Move ConsoleConsumer to tools
Key: KAFKA-14576
URL: https://issues.apache.org/jira/browse/KAFKA-14576
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14575:
---
Summary: Move ClusterTool to tools (was: Move ClusterTool)
> Move ClusterTool to tools
>
mimaison opened a new pull request, #13080:
URL: https://github.com/apache/kafka/pull/13080
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062646329
##
metadata/src/main/java/org/apache/kafka/controller/MigrationControlManager.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062645398
##
metadata/src/main/java/org/apache/kafka/metadata/migration/BrokersRpcClient.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062640868
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -348,7 +345,7 @@ class KafkaServer(
time = time,
metrics = metrics,
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1062635407
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062634566
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -292,7 +292,7 @@ class BrokerLifecycleManager(
}
val data = new
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062634160
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -55,7 +55,7 @@ class BrokerLifecycleManager(
val config: KafkaConfig,
val time: Time,
Mickael Maison created KAFKA-14575:
--
Summary: Move ClusterTool
Key: KAFKA-14575
URL: https://issues.apache.org/jira/browse/KAFKA-14575
Project: Kafka
Issue Type: Sub-task
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062628793
##
core/src/main/scala/kafka/server/BrokerEpochManager.scala:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062627093
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -51,7 +51,7 @@
},
{ "name": "Rack", "type": "string", "versions": "0+",
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1062611257
##
docs/streams/developer-guide/processor-api.html:
##
@@ -396,6 +397,21 @@
+
+ReadOnly
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1062606439
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard reassigned KAFKA-14565:
---
Assignee: (was: Terry Beard)
> Improving Interceptor Resource Leakage Prevention
>
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14566:
Description: (was: h2. PROBLEM
The Consumer and Producer interceptor interfaces and their
divijvaidya commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1062290508
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -576,6 +576,13 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}, period =
88 matches
Mail list logo
