[GitHub] [kafka] ijuma commented on pull request #13059: MINOR: KafkaConfig should not expose internal config when queried for non-internal values

2023-01-14 Thread GitBox
ijuma commented on PR #13059: URL: https://github.com/apache/kafka/pull/13059#issuecomment-1383078896 @showuon Are you going to merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

2023-01-14 Thread GitBox
ijuma commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1383076727 > The current approach guarantees that size is strongly consistent with the data stored in the map. That is not required for a metric though. That said, I didn't look at the

[GitHub] [kafka] ijuma commented on a diff in pull request #13099: KAFKA-14604: avoid SASL session expiration time overflowed when calculation

2023-01-14 Thread GitBox
ijuma commented on code in PR #13099: URL: https://github.com/apache/kafka/pull/13099#discussion_r1070520573 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String oldSuffix, String

[GitHub] [kafka] ijuma commented on pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

2023-01-14 Thread GitBox
ijuma commented on PR #13102: URL: https://github.com/apache/kafka/pull/13102#issuecomment-1383075297 @jsancio @hachikuji Was there a reason to have this field or was it added accidentally? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on a diff in pull request #13105: MINOR: fix typo in KafkaConsumer.java

2023-01-14 Thread GitBox
ijuma commented on code in PR #13105: URL: https://github.com/apache/kafka/pull/13105#discussion_r1070519853 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1472,7 +1472,7 @@ public boolean isDone() { /** * Callbacks that are

[GitHub] [kafka] ijuma merged pull request #13109: MINOR: doc: sendfile implement in `TransferableRecords` instead of `MessageSet`

2023-01-14 Thread GitBox
ijuma merged PR #13109: URL: https://github.com/apache/kafka/pull/13109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma opened a new pull request, #13121: MINOR: Remove some connect tests from Java 17 block list

2023-01-14 Thread GitBox
ijuma opened a new pull request, #13121: URL: https://github.com/apache/kafka/pull/13121 Most were converted not to use PowerMock, but some no longer exist. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[GitHub] [kafka] yashmayya opened a new pull request, #13120: MINOR: Connect Javadocs improvements

2023-01-14 Thread GitBox
yashmayya opened a new pull request, #13120: URL: https://github.com/apache/kafka/pull/13120 Some common themes: - Replace blank lines (which are ignored) with `` to separate paragraphs. For those wondering about the omitted closing `` tags, this is actually the recommended style

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

2023-01-14 Thread GitBox
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1382883307 https://github.com/apache/kafka/pull/13095#discussion_r1069689088 I looked at other classes in tool and saw arg4jparse being used in them and assumed that this is the

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

2023-01-14 Thread GitBox
vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070379239 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

2023-01-14 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676938#comment-17676938 ] Balaji Rao commented on KAFKA-14624: {quote} Thanks for reporting this issue – will need to think

[jira] [Commented] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

2023-01-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676934#comment-17676934 ] Matthias J. Sax commented on KAFKA-14624: - Thanks for reporting this issue – will need to think

[jira] [Created] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

2023-01-14 Thread Balaji Rao (Jira)
Balaji Rao created KAFKA-14624: -- Summary: State restoration is broken with standby tasks and cache-enabled stores in processor API Key: KAFKA-14624 URL: https://issues.apache.org/jira/browse/KAFKA-14624