[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1073197282 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1386596236 @ijuma It looks like the changes that were done in the conversions were accidentally dropped in my local repo while doing a few rebases in my trunk. I should have checked that before

[GitHub] [kafka] vcrfxia opened a new pull request, #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

vcrfxia opened a new pull request, #13126: URL: https://github.com/apache/kafka/pull/13126 [KIP-889](https://cwiki.apache.org/confluence/display/KAFKA/KIP-889%3A+Versioned+State+Stores) proposed the introduction of versioned key-value stores, as well as a RocksDB-based implementation. The

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1071365497 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -2104,7 +2105,7 @@ object UnifiedLog extends Logging { // (or later snapshots). Otherwise, if there is no

[GitHub] [kafka] ijuma commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

ijuma commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1386277046 @jolshan From what you're saying, there are some thread safety bugs, but their impact is likely minor and hence why we haven't noticed them. From my perspective, we really need to document

[jira] [Updated] (KAFKA-14302) Infinite probing rebalance if a changelog topic got emptied

[ https://issues.apache.org/jira/browse/KAFKA-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14302: Priority: Critical (was: Major) > Infinite probing rebalance if a changelog topic got

[GitHub] [kafka] jolshan commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

jolshan commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1072903070 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig, // epoch, a sentinel

[GitHub] [kafka] jolshan commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

jolshan commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1072900020 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig, // epoch, a sentinel

[GitHub] [kafka] jolshan commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

jolshan commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1072895900 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig, // epoch, a sentinel

[GitHub] [kafka] jolshan commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

jolshan commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1072893785 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -1971,16 +1971,22 @@ object TestUtils extends Logging { ) } + def currentIsr(admin: Admin,

[GitHub] [kafka] jolshan commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1386151839 @divijvaidya I'm also a bit confused by this comment: > In cases when we have just one (or two) producers, this metric would be highly unreliable (not just stale) as it provides an

[GitHub] [kafka] jolshan commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1386149959 > Has anyone checked that we always acquire a lock when we call methods like activeProducers and isEmpty? I wonder if this class has thread safety bugs. @ijuma I actually did take

[GitHub] [kafka] jolshan commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1386129325 I noticed that we don't consider the stability of responses. (I assume though that if the request is unstable, the response is too.) Just curious if there are any potential gaps

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1072868862 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -86,14 +100,7 @@ class DefaultApiVersionManager( finalizedFeatures.features.map(kv =>

[GitHub] [kafka] cmccabe commented on pull request #13117: KAFKA-14621 Disallow authorizers during ZK migration

cmccabe commented on PR #13117: URL: https://github.com/apache/kafka/pull/13117#issuecomment-1386112450 merged to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1072862469 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1072861634 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1072860670 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on PR #13112: URL: https://github.com/apache/kafka/pull/13112#issuecomment-1386095725 Took a first pass. I think the one thing that is tricky is the conversions between Java and scala. It may not be avoidable though. I'll take another pass soon. -- This is an automated

[GitHub] [kafka] gharris1727 commented on pull request #13084: KAFKA-14598: Fix flaky ConnectRestApiTest

gharris1727 commented on PR #13084: URL: https://github.com/apache/kafka/pull/13084#issuecomment-1386092163 Thanks @ashwinpankaj for following up, I think that this is good after one last nit comment. > To test this theory, in my latest revision I have set retry_on_exc to True in

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13084: KAFKA-14598: Fix flaky ConnectRestApiTest

gharris1727 commented on code in PR #13084: URL: https://github.com/apache/kafka/pull/13084#discussion_r1072856520 ## tests/kafkatest/tests/connect/connect_rest_test.py: ## @@ -90,7 +90,8 @@ def test_rest_api(self, connect_protocol, metadata_quorum):

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1072855094 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel, if (topicPartition.topic ==

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1072842347 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -357,8 +354,9 @@ class KafkaApis(val requestChannel: RequestChannel, new UpdateMetadataResponse(new

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1072840736 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel, if (topicPartition.topic ==

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1072839205 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -511,4 +532,57 @@ class GroupCoordinatorAdapter( future } + + override

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1072836630 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -282,8 +283,12 @@ class BrokerServer( tokenManager.startup() // does nothing, we just need a token

[GitHub] [kafka] mumrah merged pull request #13117: KAFKA-14621 Disallow authorizers during ZK migration

mumrah merged PR #13117: URL: https://github.com/apache/kafka/pull/13117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1072528536 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -619,6 +619,9 @@ object KafkaConfig { val PasswordEncoderKeyLengthProp =

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676546#comment-17676546 ] Alexandre Dupriez edited comment on KAFKA-14139 at 1/17/23 8:25 PM:

[jira] [Created] (KAFKA-14627) Modernize Connect plugin discovery

Greg Harris created KAFKA-14627: --- Summary: Modernize Connect plugin discovery Key: KAFKA-14627 URL: https://issues.apache.org/jira/browse/KAFKA-14627 Project: Kafka Issue Type: New Feature

[GitHub] [kafka] dajac merged pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac merged PR #12902: URL: https://github.com/apache/kafka/pull/12902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1072693482 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config:

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1072654169 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try {

[GitHub] [kafka] hachikuji commented on pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

hachikuji commented on PR #13107: URL: https://github.com/apache/kafka/pull/13107#issuecomment-1385840547 @jolshan @dajac This patch has been updated to loosen the epoch check on the broker side. The original approach seemed a little risky in the case a reassignment is cancelled and

[jira] [Commented] (KAFKA-14625) CheckpointFile read and write API consistency

[ https://issues.apache.org/jira/browse/KAFKA-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677880#comment-17677880 ] Ismael Juma commented on KAFKA-14625: - Personally I'm not convinced this needs to be changed. >

[jira] [Commented] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677877#comment-17677877 ] Justine Olshan commented on KAFKA-14190: ^ +1 to the points above.  I think that this was

[jira] [Commented] (KAFKA-14625) CheckpointFile read and write API consistency

[ https://issues.apache.org/jira/browse/KAFKA-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677875#comment-17677875 ] Sagar Rao commented on KAFKA-14625: --- hey [~satish.duggana] , i am assuming you plan to work on this?

[GitHub] [kafka] jolshan commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1385825635 What you say makes sense Colin. I do think its a bit tricky to make such a big code change to support folks using older and deprecated tools. I also understand the point of view

[GitHub] [kafka] guozhangwang closed pull request #11367: MINOR: Do not copy on range for in-memory shared store in stream stream left/out joins

guozhangwang closed pull request #11367: MINOR: Do not copy on range for in-memory shared store in stream stream left/out joins URL: https://github.com/apache/kafka/pull/11367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1072496029 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-13709) Document exactly-once support for source connectors

[ https://issues.apache.org/jira/browse/KAFKA-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677833#comment-17677833 ] ASF GitHub Bot commented on KAFKA-13709: C0urante merged PR #478: URL:

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1072418814 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1072418814 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] vamossagar12 commented on pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

vamossagar12 commented on PR #12802: URL: https://github.com/apache/kafka/pull/12802#issuecomment-1385618036 hey @C0urante bumping this one. Plz review whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1072366317 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

ijuma commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1385597771 Has anyone checked that we always acquire a lock when we call methods like `activeProducers` and `isEmpty`? I wonder if this class has thread safety bugs. -- This is an automated message

[GitHub] [kafka] ijuma commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

ijuma commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1385589558 @divijvaidya Producer ids don't change often, do I am not sure what you mean by: > In cases when we have just one (or two) producers, this metric would be highly unreliable (not

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072326336 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072305087 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] 51n15t9r commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

51n15t9r commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1385546015 @ijuma , @showuon - Sorry to bring this up in a closed thread. Other than the vulnerabilities, zookeeper 3.6 is also EOL since December 2022. Would it be useful to spend the

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072305087 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072271288 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072271288 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] mimaison commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

mimaison commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072229304 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1072224151 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1072223766 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1072223447 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -293,14 +295,14 @@ class Partition(val topicPartition: TopicPartition, private var controllerEpoch: Int =

[jira] [Assigned] (KAFKA-14576) Move ConsoleConsumer to tools

[ https://issues.apache.org/jira/browse/KAFKA-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-14576: - Assignee: Christo Lolov > Move ConsoleConsumer to tools >

[GitHub] [kafka] satishd commented on pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on PR #13046: URL: https://github.com/apache/kafka/pull/13046#issuecomment-1385392475 Thanks @ijuma for the updated comments. Addressed them with inline and update the PR with latest commit. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1385391553 Thanks @ijuma for the review comments. Addressed them inline and updated the PR with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1072167191 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -191,7 +192,7 @@ class LogLoader( // Reload all snapshots into the ProducerStateManager cache, the

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1072167191 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -191,7 +192,7 @@ class LogLoader( // Reload all snapshots into the ProducerStateManager cache, the

[GitHub] [kafka] divijvaidya commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

divijvaidya commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1385362966 **Proposal: Using concurrent map for ProducerStateManager.producers (currently a mutable.Map)** **Pros** - Simplifies code (prevents future bugs by accidental update to map

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1071392892 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1071392892 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] yufeiyan1220 opened a new pull request, #13125: KAFKA-14626 Kafka Consumer Coordinator does not cleanup all metrics

yufeiyan1220 opened a new pull request, #13125: URL: https://github.com/apache/kafka/pull/13125 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Created] (KAFKA-14626) Kafka Consumer Coordinator does not cleanup all metrics

Feiyan Yu created KAFKA-14626: - Summary: Kafka Consumer Coordinator does not cleanup all metrics Key: KAFKA-14626 URL: https://issues.apache.org/jira/browse/KAFKA-14626 Project: Kafka Issue

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072024066 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072022574 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1072022248 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] lucasbru commented on a diff in pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

lucasbru commented on code in PR #13082: URL: https://github.com/apache/kafka/pull/13082#discussion_r1072016340 ## docs/streams/developer-guide/config-streams.html: ## @@ -778,10 +778,21 @@ rack.aware.assignment.tagsmax.warmup.replicas -

[GitHub] [kafka] keashem commented on pull request #13124: MINOR: Rename testDeadToDeadIllegalTransition to testDeadToDeadTransition in GroupMetadataTest

keashem commented on PR #13124: URL: https://github.com/apache/kafka/pull/13124#issuecomment-1385052326 @hachikuji plz take a look~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] keashem opened a new pull request, #13124: MINOR: Rename testDeadToDeadIllegalTransition to testDeadToDeadTransition in GroupMetadataTest

keashem opened a new pull request, #13124: URL: https://github.com/apache/kafka/pull/13124 The Dead GroupState has a valid previous state: Dead, so transition from Dead to Dead won't throw IllegalStateException. The unit test testDeadToDeadIllegalTransition should be renamed