[GitHub] [kafka] Playerharperb commented on pull request #13162: fix: replace an inefficient loop in kafka internals

2023-01-24 Thread via GitHub
Playerharperb commented on PR #13162: URL: https://github.com/apache/kafka/pull/13162#issuecomment-1403125466 Hello my name is playerharp...@gmail.com and I am interested in this job posting on the website -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-14651) Add connectorDeleted flag when stopping tasks

2023-01-24 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino updated KAFKA-14651: - Description: Jira ticket for

[jira] [Created] (KAFKA-14651) Add connectorDeleted flag when stopping tasks

2023-01-24 Thread Hector Geraldino (Jira)
Hector Geraldino created KAFKA-14651: Summary: Add connectorDeleted flag when stopping tasks Key: KAFKA-14651 URL: https://issues.apache.org/jira/browse/KAFKA-14651 Project: Kafka Issue

[GitHub] [kafka] rayokota commented on pull request #12126: KAFKA-8713 KIP-581: Add new conf serialize.accept.optional.null in connect-json

2023-01-24 Thread via GitHub
rayokota commented on PR #12126: URL: https://github.com/apache/kafka/pull/12126#issuecomment-1403014501 @blueberrysugarhigh , sorry I'm not the author of this PR and I haven't tried it myself. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] blueberrysugarhigh commented on pull request #12126: KAFKA-8713 KIP-581: Add new conf serialize.accept.optional.null in connect-json

2023-01-24 Thread via GitHub
blueberrysugarhigh commented on PR #12126: URL: https://github.com/apache/kafka/pull/12126#issuecomment-1402996186 > @rayokota sorry for bothering you. I'm trying to maintain my own version of `JsonConverter`. I just copied the code and pasted it to a new class `JsonConverter`. and I

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

2023-01-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680403#comment-17680403 ] A. Sophie Blee-Goldman commented on KAFKA-14533: I'll give it a few more days before

[GitHub] [kafka] cmccabe merged pull request #13151: Fail broker and controller startup on authorizer failure

2023-01-24 Thread via GitHub
cmccabe merged PR #13151: URL: https://github.com/apache/kafka/pull/13151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14650) IQv2 can throw ConcurrentModificationException when accessing Tasks

2023-01-24 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14650: -- Summary: IQv2 can throw ConcurrentModificationException when accessing Tasks Key: KAFKA-14650 URL: https://issues.apache.org/jira/browse/KAFKA-14650

[GitHub] [kafka] guozhangwang commented on pull request #13160: chore: fix flaky DefaultStateUpdaterTest

2023-01-24 Thread via GitHub
guozhangwang commented on PR #13160: URL: https://github.com/apache/kafka/pull/13160#issuecomment-1402827998 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] guozhangwang merged pull request #13160: chore: fix flaky DefaultStateUpdaterTest

2023-01-24 Thread via GitHub
guozhangwang merged PR #13160: URL: https://github.com/apache/kafka/pull/13160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14649) Failures instantiating Connect plugins hides other plugins from REST API, or crash worker

2023-01-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14649: Description: Connect plugin path scanning evaluates the version() method of plugins to determine

[jira] [Updated] (KAFKA-14649) Failures instantiating Connect plugins hides other plugins from REST API, or crash worker

2023-01-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14649: Summary: Failures instantiating Connect plugins hides other plugins from REST API, or crash

[jira] [Updated] (KAFKA-14649) Failures instantiating Connect plugins hides other plugins from REST API

2023-01-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14649: Description: Connect plugin path scanning evaluates the version() method of plugins to determine

[jira] [Updated] (KAFKA-14649) Failures instantiating Connect plugins hides other plugins from REST API

2023-01-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14649: Summary: Failures instantiating Connect plugins hides other plugins from REST API (was: Failures

[jira] [Created] (KAFKA-14649) Failures instantiating Connect plugins crash worker on startup

2023-01-24 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14649: --- Summary: Failures instantiating Connect plugins crash worker on startup Key: KAFKA-14649 URL: https://issues.apache.org/jira/browse/KAFKA-14649 Project: Kafka

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

2023-01-24 Thread via GitHub
vcrfxia commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1085990051 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-14648) Do not fail clients if bootstrap servers is not immediately resolvable

2023-01-24 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14648: --- Summary: Do not fail clients if bootstrap servers is not immediately resolvable Key: KAFKA-14648 URL: https://issues.apache.org/jira/browse/KAFKA-14648

[GitHub] [kafka] cmccabe commented on a diff in pull request #13140: KAFKA-14644: Process should crash after failure in Raft IO thread

2023-01-24 Thread via GitHub
cmccabe commented on code in PR #13140: URL: https://github.com/apache/kafka/pull/13140#discussion_r1085968353 ## core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala: ## @@ -198,7 +200,8 @@ class RaftManagerTest { @Test def testShutdownIoThread(): Unit = { val

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

2023-01-24 Thread via GitHub
vcrfxia commented on code in PR #13142: URL: https://github.com/apache/kafka/pull/13142#discussion_r1085933946 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -351,13 +360,23 @@ public QueryResult query( @Override public ,

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

2023-01-24 Thread via GitHub
vcrfxia commented on code in PR #13142: URL: https://github.com/apache/kafka/pull/13142#discussion_r1085935187 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -383,7 +383,9 @@ public KeyValue makeNext() {

[GitHub] [kafka] dpcollins-google opened a new pull request, #13162: fix: replace an inefficient loop in kafka internals

2023-01-24 Thread via GitHub
dpcollins-google opened a new pull request, #13162: URL: https://github.com/apache/kafka/pull/13162 Instead use Channels.newChannel to write in larger chunks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] Cerchie opened a new pull request, #13161: Kafka 14128

2023-01-24 Thread via GitHub
Cerchie opened a new pull request, #13161: URL: https://github.com/apache/kafka/pull/13161 In response to [14128](https://issues.apache.org/jira/browse/KAFKA-14128). Addresses by moving final catch condition into an else block. Testing strategy: I'm attempting a unit test first.

[GitHub] [kafka] lucasbru opened a new pull request, #13160: chore: fix flaky DefaultStateUpdaterTest

2023-01-24 Thread via GitHub
lucasbru opened a new pull request, #13160: URL: https://github.com/apache/kafka/pull/13160 Mockito should not make named topologies paused by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] rajinisivaram merged pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-24 Thread via GitHub
rajinisivaram merged PR #13119: URL: https://github.com/apache/kafka/pull/13119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rajinisivaram commented on pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-24 Thread via GitHub
rajinisivaram commented on PR #13119: URL: https://github.com/apache/kafka/pull/13119#issuecomment-1402448121 Test failures not related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] nizhikov commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
nizhikov commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402420416 I can only imagine users who excluded mirror-client dependency for whatever reason :) Don't think we should consider such case as a blocker. -- This is an automated message from

[GitHub] [kafka] mimaison commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
mimaison commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402375492 The Config classes are not part of the public API. I suggested moving the interfaces without thinking too much about it, have you considered if this could break anything? -- This is

[GitHub] [kafka] mimaison commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-24 Thread via GitHub
mimaison commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1085565198 ## checkstyle/import-control.xml: ## @@ -347,7 +347,7 @@ - Review Comment: We seem to have the trailing space everywhere else, so maybe keep it

[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-24 Thread via GitHub
fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1085675650 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-24 Thread via GitHub
fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1085675650 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] fvaleri commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-24 Thread via GitHub
fvaleri commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1402347644 > we have pushed Exit.exit(1) down into CommandLineUtils. @clolov it wasn't pushed down, that's the original logic. The code you are referring to in ZkSecurityMigrator.scala:103 is

[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-24 Thread via GitHub
fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1085675650 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Assigned] (KAFKA-13999) Add ProducerCount metrics (KIP-847)

2023-01-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-13999: Assignee: Anastasia Vela > Add ProducerCount metrics (KIP-847) >

[jira] [Updated] (KAFKA-13999) Add ProducerCount metrics (KIP-847)

2023-01-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-13999: - Fix Version/s: 3.5.0 > Add ProducerCount metrics (KIP-847) >

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-01-24 Thread Bojan Blagojevic (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680275#comment-17680275 ] Bojan Blagojevic commented on KAFKA-14639: -- Thank you again for the quick response. I will try

[jira] [Updated] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-01-24 Thread Bojan Blagojevic (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bojan Blagojevic updated KAFKA-14639: - Attachment: consumers-jira.log > Kafka CooperativeStickyAssignor revokes/assigns

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

2023-01-24 Thread via GitHub
viktorsomogyi commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1085559673 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] nizhikov commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
nizhikov commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402195231 @mimaison Thanks for the review. What about *Config classes? like `MirrorCheckpointConfig` or `MirrorConnectorConfig`. Are the part of public API? Should I move them to

[GitHub] [kafka] mimaison commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
mimaison commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402188145 @nizhikov Thanks for looking at this issue. I don't think we can simply enable the javadoc on the `connect:mirror` project as it will also include all public classes from that module

[GitHub] [kafka] mimaison commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-24 Thread via GitHub
mimaison commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1085116578 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] MPeli commented on pull request #6329: KAFKA-1194: Fix renaming open files on Windows

2023-01-24 Thread via GitHub
MPeli commented on PR #6329: URL: https://github.com/apache/kafka/pull/6329#issuecomment-1402091415 Hi, I have created a new pull request. See #12331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-14565) Fix Interceptor Resource Leakage

2023-01-24 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Summary: Fix Interceptor Resource Leakage (was: Improve Interceptor Resource Leakage Prevention)

[jira] [Commented] (KAFKA-14487) Move LogManager to storage module

2023-01-24 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680230#comment-17680230 ] Sagar Rao commented on KAFKA-14487: --- [~ijuma] , is it ok if I can pick this one up? Seems like it's

[GitHub] [kafka] vamossagar12 commented on pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2023-01-24 Thread via GitHub
vamossagar12 commented on PR #12561: URL: https://github.com/apache/kafka/pull/12561#issuecomment-1402008138 @C0urante , thanks for your response. Makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ruslankrivoshein commented on pull request #13074: MINOR: upgrade.from is revealed for Upgrade doc

2023-01-24 Thread via GitHub
ruslankrivoshein commented on PR #13074: URL: https://github.com/apache/kafka/pull/13074#issuecomment-1401965227 @hachikuji, what do you think about this tiny edition? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] divijvaidya commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

2023-01-24 Thread via GitHub
divijvaidya commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1401824565 @dajac > Will this code still be around by the time tiered storage is completed? I don't know but my point is that this code change is simple and safe enough to add it to the

[GitHub] [kafka] vamossagar12 commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-01-24 Thread via GitHub
vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1401815286 @fvaleri , plz review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vamossagar12 opened a new pull request, #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-01-24 Thread via GitHub
vamossagar12 opened a new pull request, #13158: URL: https://github.com/apache/kafka/pull/13158 Moving TopicFilter to server-common/utils -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] divijvaidya commented on pull request #12331: KAFKA-1194: changes needed to run on Windows

2023-01-24 Thread via GitHub
divijvaidya commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-1401813587 @sjetha you should probably send an email to the [d...@kafka.apache.org](mailto:d...@kafka.apache.org) mailing list, explaining the urgency and asking for someone to take a look at

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-24 Thread Jochen Schalanda (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680181#comment-17680181 ] Jochen Schalanda commented on KAFKA-14646: -- Could it still be that the check in

[GitHub] [kafka] nizhikov opened a new pull request, #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
nizhikov opened a new pull request, #13157: URL: https://github.com/apache/kafka/pull/13157 Currently, javadoc task disabled for `:connect:mirror` module. This PR enables it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-01-24 Thread via GitHub
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1084960389 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -712,8 +733,16 @@ KafkaBasedLog

[jira] [Comment Edited] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-24 Thread Jochen Schalanda (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680143#comment-17680143 ] Jochen Schalanda edited comment on KAFKA-14646 at 1/24/23 8:42 AM: ---

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-24 Thread Jochen Schalanda (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680143#comment-17680143 ] Jochen Schalanda commented on KAFKA-14646: -- Unfortunately the two rolling updates (with

[jira] [Updated] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-24 Thread Jochen Schalanda (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Schalanda updated KAFKA-14646: - Description: Hey folks,   we've just updated an application from *_Kafka Streams 3.2.3

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-01-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680141#comment-17680141 ] A. Sophie Blee-Goldman commented on KAFKA-14639: Thanks for the additional logs, that

[GitHub] [kafka] fvaleri commented on pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-24 Thread via GitHub
fvaleri commented on PR #13136: URL: https://github.com/apache/kafka/pull/13136#issuecomment-1401539053 @mimaison @clolov @vamossagar12 this is ready for review if you have some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on pull request #13156: KAFKA-14533: re-enable 'false' and disable the 'true' parameter of SmokeTestDriverIntegrationTest

2023-01-24 Thread via GitHub
ableegoldman commented on PR #13156: URL: https://github.com/apache/kafka/pull/13156#issuecomment-1401535688 Merged to trunk and cherrypicked back to 3.4 since this is trivial and rather time-sensitive -- hopefully we can finally narrow down the culprit for good and have a better shot at

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

2023-01-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680134#comment-17680134 ] A. Sophie Blee-Goldman commented on KAFKA-14533: FYI after disabling the `false`

[GitHub] [kafka] ableegoldman merged pull request #13156: KAFKA-14533: re-enable 'false' and disable the 'true' parameter of SmokeTestDriverIntegrationTest

2023-01-24 Thread via GitHub
ableegoldman merged PR #13156: URL: https://github.com/apache/kafka/pull/13156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #13156: KAFKA-14533: re-enable 'false' and disable the 'true' parameter of SmokeTestDriverIntegrationTest

2023-01-24 Thread via GitHub
ableegoldman commented on PR #13156: URL: https://github.com/apache/kafka/pull/13156#issuecomment-1401529084 cc @lucasbru @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ableegoldman opened a new pull request, #13156: KAFKA-14533: re-enable 'false' and disable the 'true' parameter of SmokeTestDriverIntegrationTest

2023-01-24 Thread via GitHub
ableegoldman opened a new pull request, #13156: URL: https://github.com/apache/kafka/pull/13156 I immediately saw a failure with `stateUpdaterEnabled = true` after disabling the `false` parameter, which suggests the problem actually does lie in the state updater itself and not the act of