[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-01-25 Thread via GitHub
vamossagar12 commented on code in PR #13158: URL: https://github.com/apache/kafka/pull/13158#discussion_r1087508896 ## server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

2023-01-25 Thread via GitHub
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1404639472 hi @mimaison would you plz review this PR whenever you get the chance? It's already approved by @fvaleri . Thanks -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14646. - Fix Version/s: 3.4.0 3.3.3 Resolution: Fixed >

[jira] [Commented] (KAFKA-13769) KTable FK join can miss records if an upstream non-key-changing operation changes key serializer

2023-01-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680858#comment-17680858 ] Matthias J. Sax commented on KAFKA-13769: - I just updated fixed version from 3.0.0 to 3.3.3 and

[jira] [Updated] (KAFKA-13769) KTable FK join can miss records if an upstream non-key-changing operation changes key serializer

2023-01-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13769: Fix Version/s: 3.4.0 3.3.3 (was: 3.3.0) >

[jira] [Updated] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14646: Affects Version/s: 3.3.1 3.3.0 > SubscriptionWrapper is of an

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680857#comment-17680857 ] Matthias J. Sax commented on KAFKA-14646: - Ok. Talked to Alex and he quickly figured it out –

[GitHub] [kafka] guozhangwang commented on pull request #13167: KAFKA-14650: Synchronize access to tasks inside task manager

2023-01-25 Thread via GitHub
guozhangwang commented on PR #13167: URL: https://github.com/apache/kafka/pull/13167#issuecomment-1404437326 ping @cadonna for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] guozhangwang opened a new pull request, #13167: KAFKA-14650: Synchronize access to tasks inside task manager

2023-01-25 Thread via GitHub
guozhangwang opened a new pull request, #13167: URL: https://github.com/apache/kafka/pull/13167 1) The major fix: synchronize access to tasks inside task manager. 2) Clarify on func names of StreamThread that maybe triggered outside the StreamThread. 3) Minor cleanups. ###

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680840#comment-17680840 ] Matthias J. Sax commented on KAFKA-14646: - Could be – let me sync with Alex who worked on the

[GitHub] [kafka] jsancio merged pull request #13154: MINOR; Make granting voter immutable

2023-01-25 Thread via GitHub
jsancio merged PR #13154: URL: https://github.com/apache/kafka/pull/13154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14553) RecordAccumulator hangs in infinite NOP loop

2023-01-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14553: --- Fix Version/s: 3.4.0 > RecordAccumulator hangs in infinite NOP loop >

[GitHub] [kafka] jsancio commented on pull request #13154: MINOR; Make granting voter immutable

2023-01-25 Thread via GitHub
jsancio commented on PR #13154: URL: https://github.com/apache/kafka/pull/13154#issuecomment-1404366998 Merging. Unrelated test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] kirktrue opened a new pull request, #13166: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-25 Thread via GitHub
kirktrue opened a new pull request, #13166: URL: https://github.com/apache/kafka/pull/13166 Removes logging of the HTTP response directly in all known cases to prevent potentially logging access tokens. Reviewers: Sushant Mahajan , Rajini Sivaram (cherry picked from commit

[GitHub] [kafka] cmccabe commented on pull request #13098: MINOR: remove BrokerMetadataListener

2023-01-25 Thread via GitHub
cmccabe commented on PR #13098: URL: https://github.com/apache/kafka/pull/13098#issuecomment-1404230760 Looks like something exited the Jenkins process. Rerunning. ``` [2023-01-24T22ː55ː33.723Z] Execution failed for task 'ːcoreːintegrationTest'. [2023-01-24T22ː55ː33.723Z] > Process

[GitHub] [kafka] mjsax commented on a diff in pull request #13164: MINOR: Fix scaladoc warnings

2023-01-25 Thread via GitHub
mjsax commented on code in PR #13164: URL: https://github.com/apache/kafka/pull/13164#discussion_r1087040518 ## streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Consumed.scala: ## @@ -43,7 +43,7 @@ object Consumed { ConsumedJ.`with`(keySerde,

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-01-25 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1086992753 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -155,7 +155,7 @@ private enum State { private boolean

[GitHub] [kafka] gharris1727 opened a new pull request, #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

2023-01-25 Thread via GitHub
gharris1727 opened a new pull request, #13165: URL: https://github.com/apache/kafka/pull/13165 The scanPluginPath -> getPluginDesc -> versionFor code path instantiates connectors in order to evaluate their version() method. This is the first call to initialize these classes, and so

[GitHub] [kafka] lucasbru opened a new pull request, #13164: chore: Fix scaladoc warnings

2023-01-25 Thread via GitHub
lucasbru opened a new pull request, #13164: URL: https://github.com/apache/kafka/pull/13164 Make sure no scaladoc warnings are emitted from the streams-scala project build. We cannot fully fix all scaladoc warnings due to limitations of the scaladoc tool, so this is a best-effort attempt

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-01-25 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1086981869 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try {

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-01-25 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1086981346 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try {

[jira] [Created] (KAFKA-14654) Connectors have incorrect Thread Context Classloader during initialization

2023-01-25 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14654: --- Summary: Connectors have incorrect Thread Context Classloader during initialization Key: KAFKA-14654 URL: https://issues.apache.org/jira/browse/KAFKA-14654 Project:

[jira] [Resolved] (KAFKA-14644) Process should stop after failure in raft IO thread

2023-01-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14644. - Fix Version/s: 3.5.0 Resolution: Fixed > Process should stop after failure in

[GitHub] [kafka] hachikuji merged pull request #13140: KAFKA-14644: Process should crash after failure in Raft IO thread

2023-01-25 Thread via GitHub
hachikuji merged PR #13140: URL: https://github.com/apache/kafka/pull/13140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-5072) Kafka topics should allow custom metadata configs within some config namespace

2023-01-25 Thread Barak (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680707#comment-17680707 ] Barak commented on KAFKA-5072: -- This would be very useful. > Kafka topics should allow custom metadata

[jira] [Commented] (KAFKA-14525) Move CLI tools from `core` to `tools` module

2023-01-25 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680637#comment-17680637 ] Federico Valeri commented on KAFKA-14525: - Thanks [~omnia_h_ibrahim]. FYI, I created the

[GitHub] [kafka] fvaleri commented on pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-25 Thread via GitHub
fvaleri commented on PR #13136: URL: https://github.com/apache/kafka/pull/13136#issuecomment-1403712199 Thanks @mimaison. I addressed all your comments and now working on the test suite. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-25 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1086694567 ## tools/src/main/java/org/apache/kafka/tools/JmxCommand.java: ## @@ -0,0 +1,441 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Assigned] (KAFKA-14579) Move DumpLogSegments to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14579: - Assignee: Omnia Ibrahim > Move DumpLogSegments to tools >

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-25 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1086675903 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -801,21 +801,15 @@ object ConsumerGroupCommand extends Logging { partitionsToReset.map {

[jira] [Assigned] (KAFKA-14595) Move ReassignPartitionsCommand to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14595: - Assignee: Omnia Ibrahim > Move ReassignPartitionsCommand to tools >

[jira] [Assigned] (KAFKA-14589) Move ConsumerGroupCommand to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14589: - Assignee: Omnia Ibrahim > Move ConsumerGroupCommand to tools >

[jira] [Assigned] (KAFKA-14588) Move ConfigCommand to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14588: - Assignee: Omnia Ibrahim > Move ConfigCommand to tools > --- >

[jira] [Assigned] (KAFKA-14577) Move ConsoleProducer to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14577: - Assignee: Omnia Ibrahim > Move ConsoleProducer to tools >

[jira] [Assigned] (KAFKA-14587) Move AclCommand to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14587: - Assignee: Omnia Ibrahim > Move AclCommand to tools > > >

[jira] [Assigned] (KAFKA-14578) Move ConsumerPerformance to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14578: - Assignee: Omnia Ibrahim > Move ConsumerPerformance to tools >

[jira] [Assigned] (KAFKA-14593) Move LeaderElectionCommand to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14593: - Assignee: Omnia Ibrahim > Move LeaderElectionCommand to tools >

[jira] [Commented] (KAFKA-14525) Move CLI tools from `core` to `tools` module

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680625#comment-17680625 ] Omnia Ibrahim commented on KAFKA-14525: --- I would like to help with some of these. Will assign some

[jira] [Assigned] (KAFKA-14596) Move TopicCommand to tools

2023-01-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14596: - Assignee: Omnia Ibrahim > Move TopicCommand to tools > -- > >

[GitHub] [kafka] fvaleri commented on a diff in pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-01-25 Thread via GitHub
fvaleri commented on code in PR #13158: URL: https://github.com/apache/kafka/pull/13158#discussion_r1086613346 ## server-common/src/test/java/org/apache/kafka/server/util/TopicFilterTest.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] urbandan commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

2023-01-25 Thread via GitHub
urbandan commented on PR #13163: URL: https://github.com/apache/kafka/pull/13163#issuecomment-1403439915 @C0urante @viktorsomogyi Can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (KAFKA-14419) Same message consumed again by the same stream task after partition is lost and reassigned

2023-01-25 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680544#comment-17680544 ] Mikael edited comment on KAFKA-14419 at 1/25/23 10:35 AM: -- Hi, sorry about the

[jira] [Commented] (KAFKA-14419) Same message consumed again by the same stream task after partition is lost and reassigned

2023-01-25 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680544#comment-17680544 ] Mikael commented on KAFKA-14419: Hi, sorry about the log delay. Now I finally got around to running a

[jira] [Updated] (KAFKA-14324) [CVE-2018-25032] introduced by rocksdbjni:6.29.4.1

2023-01-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14324: -- Fix Version/s: 3.2.4 3.1.3 3.0.3

[GitHub] [kafka] urbandan opened a new pull request, #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

2023-01-25 Thread via GitHub
urbandan opened a new pull request, #13163: URL: https://github.com/apache/kafka/pull/13163 …esolution properties. MirrorMakerConfig extends AbstractConfig, which resolves config provider based references eagerly, construction time. Because of this, Connector configurations created

[jira] [Created] (KAFKA-14653) MM2 should delay resolving config provider references

2023-01-25 Thread Daniel Urban (Jira)
Daniel Urban created KAFKA-14653: Summary: MM2 should delay resolving config provider references Key: KAFKA-14653 URL: https://issues.apache.org/jira/browse/KAFKA-14653 Project: Kafka Issue

[jira] [Updated] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2023-01-25 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-10586: - Issue Type: Task (was: Improvement) > Full support for distributed mode in dedicated

[GitHub] [kafka] urbandan commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

2023-01-25 Thread via GitHub
urbandan commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1086404484 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] Schm1tz1 commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

2023-01-25 Thread via GitHub
Schm1tz1 commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1086368344 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-14652) Improve MM2 logging by adding the flow information to the context

2023-01-25 Thread Daniel Urban (Jira)
Daniel Urban created KAFKA-14652: Summary: Improve MM2 logging by adding the flow information to the context Key: KAFKA-14652 URL: https://issues.apache.org/jira/browse/KAFKA-14652 Project: Kafka