beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092652543
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -414,34 +414,51 @@ private T getConfiguredInstance(Object klass,
Class t, Map T
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092652543
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -414,34 +414,51 @@ private T getConfiguredInstance(Object klass,
Class t, Map T
gharris1727 commented on PR #13178:
URL: https://github.com/apache/kafka/pull/13178#issuecomment-1411301405
After #13181 is merged, I'll rebase and remove my fairness patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gharris1727 commented on code in PR #13181:
URL: https://github.com/apache/kafka/pull/13181#discussion_r1092643889
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -87,6 +90,7 @@ public MirrorSourceTask() {}
@Override
public
C0urante commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092632585
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -414,34 +414,51 @@ private T getConfiguredInstance(Object klass,
Class t, Map T
C0urante opened a new pull request, #13181:
URL: https://github.com/apache/kafka/pull/13181
The [Jira](https://issues.apache.org/jira/browse/KAFKA-14610) contains a
more detailed description of the motivation for this change. To summarize, if
there are bursty topic partitions, offset sync
guozhangwang commented on code in PR #13025:
URL: https://github.com/apache/kafka/pull/13025#discussion_r1092598270
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ReadOnlyTask.java:
##
@@ -190,7 +190,7 @@ public void clearTaskTimeout() {
@Override
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682775#comment-17682775
]
Calvin Liu edited comment on KAFKA-14139 at 1/31/23 10:38 PM:
--
Hi
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682775#comment-17682775
]
Calvin Liu edited comment on KAFKA-14139 at 1/31/23 10:13 PM:
--
Hi
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682775#comment-17682775
]
Calvin Liu edited comment on KAFKA-14139 at 1/31/23 10:01 PM:
--
Hi
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682775#comment-17682775
]
Calvin Liu commented on KAFKA-14139:
Hi [~adupriez] , Thanks for checking this issue. I have been
vvcephei merged PR #12879:
URL: https://github.com/apache/kafka/pull/12879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei commented on PR #12879:
URL: https://github.com/apache/kafka/pull/12879#issuecomment-1411120341
There was only one test failure, which was in an unrelated component:
`[Build / JDK 8 and Scala 2.12 /
mumrah opened a new pull request, #13180:
URL: https://github.com/apache/kafka/pull/13180
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-146347
Thanks @fvaleri , I made the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092516181
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -168,6 +169,7 @@ public class KafkaConsumerTest {
private final int
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092513735
##
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##
@@ -54,6 +58,12 @@ public void testConfiguredInstances() {
[
https://issues.apache.org/jira/browse/KAFKA-14487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682769#comment-17682769
]
Sagar Rao edited comment on KAFKA-14487 at 1/31/23 9:22 PM:
I started
[
https://issues.apache.org/jira/browse/KAFKA-14487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682769#comment-17682769
]
Sagar Rao commented on KAFKA-14487:
---
I started looking at this. It depends on
pprovenzano commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1411037660
I just updated AlterUserScramCredentialsRequestTest to work in KRaft after
finding it while looking into the tests you wanted. It covers a lot of what you
want testing
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1092446989
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -573,7 +591,20 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
private val
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1092445406
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -585,23 +616,35 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
private
mumrah commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1092435602
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -585,23 +616,35 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
private var
guozhangwang commented on PR #12654:
URL: https://github.com/apache/kafka/pull/12654#issuecomment-1410999341
@mjsax tried to resolve the long commit history but it seems not possible,
so I created a new PR (with the same branch name) here:
https://github.com/apache/kafka/pull/13179 it's
guozhangwang opened a new pull request, #13179:
URL: https://github.com/apache/kafka/pull/13179
1. Add the new API (default impl is empty) to StateRestoreListener.
2. Update related unit tests
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
guozhangwang closed pull request #12654: KAFKA-10575: Add onRestoreSuspsnded to
StateRestoreListener
URL: https://github.com/apache/kafka/pull/12654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
C0urante commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1092418826
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -711,9 +752,32 @@ KafkaBasedLog
Greg Harris created KAFKA-14666:
---
Summary: MM2 should translate consumer group offsets behind
replication flow
Key: KAFKA-14666
URL: https://issues.apache.org/jira/browse/KAFKA-14666
Project: Kafka
guozhangwang commented on PR #12654:
URL: https://github.com/apache/kafka/pull/12654#issuecomment-1410947553
> Why has this PR 392 commits?
I created this branch / PR around Oct. 2022, and then I rebased on top of
trunk. My local branch is in right place but it seems github cannot
guozhangwang commented on code in PR #12654:
URL: https://github.com/apache/kafka/pull/12654#discussion_r1092384524
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##
@@ -197,6 +198,49 @@ public void
guozhangwang commented on code in PR #12654:
URL: https://github.com/apache/kafka/pull/12654#discussion_r1092383808
##
streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java:
##
@@ -37,6 +37,9 @@
* These two interfaces serve different restoration
[
https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-12468:
---
Assignee: Greg Harris
> Initial offsets are copied from source to target cluster
>
[
https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-12566:
---
Assignee: Greg Harris (was: Luke Chen)
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682707#comment-17682707
]
Greg Harris commented on KAFKA-12566:
-
Hey [~showuon] I'm going to assign this issue to me, as I had
guozhangwang commented on PR #13167:
URL: https://github.com/apache/kafka/pull/13167#issuecomment-1410914374
@lucasbru You're right! I think this issue exists even before #12397.
After thinking that a bit, along with forward looking that IQ would need to
access the Tasks plus the
gharris1727 opened a new pull request, #13178:
URL: https://github.com/apache/kafka/pull/13178
This PR addresses three distinct but closely related issues:
1. [KAFKA-12468](https://issues.apache.org/jira/browse/KAFKA-12468) "Initial
offsets are copied from source to target cluster"
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1092320492
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -86,14 +100,7 @@ class DefaultApiVersionManager(
finalizedFeatures.features.map(kv => (kv._1,
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1092319133
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682678#comment-17682678
]
Ismael Juma commented on KAFKA-14661:
-
3.6.x supported zk 3.4 clients, so this change has
guozhangwang commented on PR #13025:
URL: https://github.com/apache/kafka/pull/13025#issuecomment-1410815034
ack, will take a look asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
C0urante commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092133488
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -476,14 +479,22 @@ public List getConfiguredInstances(List
classNames, Class t, M
lucasbru commented on PR #13025:
URL: https://github.com/apache/kafka/pull/13025#issuecomment-1410798829
@guozhangwang also wanted to have a look (note that I didn't address Brunos
comments yet)
--
This is an automated message from the Apache Git Service.
To respond to the message,
mimaison commented on code in PR #13136:
URL: https://github.com/apache/kafka/pull/13136#discussion_r1088957590
##
checkstyle/import-control.xml:
##
@@ -407,7 +407,8 @@
-
+
+
Review Comment:
Can we keep the trailing spaces like all other
[
https://issues.apache.org/jira/browse/KAFKA-14664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-14664:
Description:
The `poll-idle-ratio-avg` metric is intended to track how idle the raft IO
guozhangwang commented on PR #13164:
URL: https://github.com/apache/kafka/pull/13164#issuecomment-1410744946
LGTM, Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
guozhangwang merged PR #13164:
URL: https://github.com/apache/kafka/pull/13164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yashmayya commented on code in PR #13120:
URL: https://github.com/apache/kafka/pull/13120#discussion_r1092188566
##
connect/api/src/main/java/org/apache/kafka/connect/connector/policy/ConnectorClientConfigOverridePolicy.java:
##
@@ -23,25 +23,25 @@
import java.util.List;
jeqo opened a new pull request, #13177:
URL: https://github.com/apache/kafka/pull/13177
https://issues.apache.org/jira/browse/KAFKA-14441
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
[
https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682648#comment-17682648
]
Matthias J. Sax commented on KAFKA-14660:
-
The original PR did not make sense, as if
[
https://issues.apache.org/jira/browse/KAFKA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682643#comment-17682643
]
Federico Valeri commented on KAFKA-14584:
-
Users have to migrate from "kafka-run-class.sh
[
https://issues.apache.org/jira/browse/KAFKA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri updated KAFKA-14584:
Fix Version/s: 3.5.0
> Move StateChangeLogMerger to tools
>
[
https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri updated KAFKA-14582:
Fix Version/s: 3.5.0
> Move JmxTool to tools
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682641#comment-17682641
]
Federico Valeri commented on KAFKA-14582:
-
Users have to migrate from "kafka-run-class.sh
[
https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur reopened KAFKA-14553:
--
> RecordAccumulator hangs in infinite NOP loop
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14553:
-
Fix Version/s: (was: 3.4.0)
> RecordAccumulator hangs in infinite NOP loop
>
[
https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-14553.
--
Resolution: Duplicate
> RecordAccumulator hangs in infinite NOP loop
>
[
https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur closed KAFKA-14553.
Assignee: Luke Chen
> RecordAccumulator hangs in infinite NOP loop
>
[
https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682621#comment-17682621
]
Divij Vaidya edited comment on KAFKA-14661 at 1/31/23 3:43 PM:
---
>From Zk
[
https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682621#comment-17682621
]
Divij Vaidya edited comment on KAFKA-14661 at 1/31/23 3:43 PM:
---
>From Zk
[
https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682621#comment-17682621
]
Divij Vaidya commented on KAFKA-14661:
--
>From Zk 3.8.1 release notes [1]
- ZooKeeper clients from
[
https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682618#comment-17682618
]
Jochen Schalanda commented on KAFKA-14646:
--
[~mjsax] Unfortunately we already "solved" the
divijvaidya commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1410523645
@anatasiavela the proposal (using concurrentHashMap for producers) impacts
this change. Let me try to explain why.
Currently you are using `producerIdCount` and updating it on
[
https://issues.apache.org/jira/browse/KAFKA-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-14656.
--
Resolution: Fixed
> Brokers rejecting LISR during ZK migration
>
Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1092035905
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##
@@ -538,6 +544,8 @@ protected Map getNumPartitions(final
Set
Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1092034974
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##
@@ -466,7 +469,10 @@ public Set makeReady(final Map topics) {
Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1092027837
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause)
Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1092026440
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##
@@ -521,7 +524,7 @@ protected Map getNumPartitions(final
Set
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1092017609
##
clients/src/test/java/org/apache/kafka/test/MockConsumerInterceptor.java:
##
@@ -55,6 +58,11 @@ public void configure(Map configs) {
Object clientIdValue =
dpcollins-google commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1091834852
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
lucasbru commented on PR #13164:
URL: https://github.com/apache/kafka/pull/13164#issuecomment-1410168606
@mjsax can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fvaleri commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1410076642
> @mimaison , I updated the system test to point to the new class. That one
place seemed to be the only one relevant in this case.
Do you have a test run output that shows it works
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-141003
@mimaison , I updated the system test to point to the new class. That one
place seemed to be the only one relevant in this case.
--
This is an automated message from the Apache
Hangleton commented on code in PR #13176:
URL: https://github.com/apache/kafka/pull/13176#discussion_r1091621015
##
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##
@@ -79,6 +81,18 @@ class MigrationPropagator(
_image = image
}
+ /**
+ * A very
urbandan commented on code in PR #13163:
URL: https://github.com/apache/kafka/pull/13163#discussion_r1091581987
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -246,13 +246,22 @@ public Map originals(Map
configOverrides) {
*/
urbandan commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1091577828
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache
mjsax merged PR #13142:
URL: https://github.com/apache/kafka/pull/13142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1409929859
Merged the other PR -- can you rebase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
77 matches
Mail list logo
