[GitHub] [kafka] vcrfxia commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1094000371 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-14060) Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

2023-02-01 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino reassigned KAFKA-14060: Assignee: Hector Geraldino (was: Chris Egerton) > Replace EasyMock and

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1093929163 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentsTest.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1093924959 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13186: KAFKA-14491: [4/N] Improvements to segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13186: URL: https://github.com/apache/kafka/pull/13186#discussion_r1093920852 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -146,41 +164,39 @@ interface SegmentValue {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093919450 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,554 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] vcrfxia commented on pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on PR #13126: URL: https://github.com/apache/kafka/pull/13126#issuecomment-1413015517 Thanks, @mjsax ! Addressed your latest review comments in https://github.com/apache/kafka/pull/13186 and responded inline here. > The test cases are really hard to read IMHO,

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093914257 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093913489 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093912650 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093910815 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,518 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093909835 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,518 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093907117 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,554 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093904949 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,554 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1093903403 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,554 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] vcrfxia opened a new pull request, #13186: KAFKA-14491: [4/N] Improvements to segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
vcrfxia opened a new pull request, #13186: URL: https://github.com/apache/kafka/pull/13186 Minor changes to the segment value format introduced in https://github.com/apache/kafka/pull/13126, as a follow-up to the latest PR review. * "segment" -> "segment row" in javadocs, where

[jira] [Commented] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

2023-02-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683183#comment-17683183 ] Jason Gustafson commented on KAFKA-14672: - [~kirktrue] Nope. Please do. > Producer queue time

[jira] [Assigned] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

2023-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-14672: - Assignee: Kirk True > Producer queue time does not reflect batches expired in the accumulator

[jira] [Commented] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

2023-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683182#comment-17683182 ] Kirk True commented on KAFKA-14672: --- Mind if I grab this, [~hachikuji]  > Producer queue time does

[jira] [Comment Edited] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

2023-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683182#comment-17683182 ] Kirk True edited comment on KAFKA-14672 at 2/2/23 12:33 AM: Mind if I grab

[jira] [Updated] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

2023-02-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14672: Description: The producer exposes two metrics for the time a record has spent in the

[GitHub] [kafka] guozhangwang closed pull request #12391: KAFKA-10199: Add task updater metrics

2023-02-01 Thread via GitHub
guozhangwang closed pull request #12391: KAFKA-10199: Add task updater metrics URL: https://github.com/apache/kafka/pull/12391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] guozhangwang commented on pull request #12391: KAFKA-10199: Add task updater metrics

2023-02-01 Thread via GitHub
guozhangwang commented on PR #12391: URL: https://github.com/apache/kafka/pull/12391#issuecomment-1412931728 Closing this PR to rebase and create a new PR later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

2023-02-01 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14672: --- Summary: Producer queue time does not reflect batches expired in the accumulator Key: KAFKA-14672 URL: https://issues.apache.org/jira/browse/KAFKA-14672

[GitHub] [kafka] gharris1727 opened a new pull request, #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

2023-02-01 Thread via GitHub
gharris1727 opened a new pull request, #13185: URL: https://github.com/apache/kafka/pull/13185 [Jira](https://issues.apache.org/jira/browse/KAFKA-14670) This is the first part of the above ticket, applied only to SinkConnector and SourceConnector plugins. Additional PRs will cover the

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

2023-02-01 Thread via GitHub
mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1093821934 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +47,85 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

2023-02-01 Thread via GitHub
mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1093813869 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -46,33 +45,40 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1093792394 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1093791731 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1093789522 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1093787328 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -106,6 +109,13 @@ public void shutdown() throws InterruptedException {

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

2023-02-01 Thread via GitHub
mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1093764504 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 opened a new pull request, #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

2023-02-01 Thread via GitHub
gharris1727 opened a new pull request, #13184: URL: https://github.com/apache/kafka/pull/13184 Signed-off-by: Greg Harris For several reasons, the PredicatedTransformation should not be a Transformation, see ticket for details. This refactor just naively wraps all transformations

[GitHub] [kafka] mumrah opened a new pull request, #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-01 Thread via GitHub
mumrah opened a new pull request, #13183: URL: https://github.com/apache/kafka/pull/13183 Prior to this patch, when we handle a new MetadataDelta during dual write mode in the KRaft controller, we always send UMR to the ZK brokers. This patch changes the behavior to only send UMR if the

[jira] [Created] (KAFKA-14671) Refactor PredicatedTransformation to not implement Transformation

2023-02-01 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14671: --- Summary: Refactor PredicatedTransformation to not implement Transformation Key: KAFKA-14671 URL: https://issues.apache.org/jira/browse/KAFKA-14671 Project: Kafka

[GitHub] [kafka] mjsax commented on pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
mjsax commented on PR #13126: URL: https://github.com/apache/kafka/pull/13126#issuecomment-1412741570 Most of my comments are educational or nits. I merged this PR already, and if you want to address anything (feel free to ignore), let's do a follow up PR. Wanted to merge this to unblock

[GitHub] [kafka] mjsax merged pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
mjsax merged PR #13126: URL: https://github.com/apache/kafka/pull/13126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14670) Refactor connect plugins to be called from wrapper classes

2023-02-01 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14670: --- Summary: Refactor connect plugins to be called from wrapper classes Key: KAFKA-14670 URL: https://issues.apache.org/jira/browse/KAFKA-14670 Project: Kafka

[GitHub] [kafka] gharris1727 opened a new pull request, #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

2023-02-01 Thread via GitHub
gharris1727 opened a new pull request, #13182: URL: https://github.com/apache/kafka/pull/13182 Plugin path scanning can fail for multiple reasons: 1. A developer incorrectly implements a plugin (e.g. by not providing a default constructor) 2. A packaging mistake happens, and some

[GitHub] [kafka] junrao commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

2023-02-01 Thread via GitHub
junrao commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1093672007 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on pull request #13180: MINOR: Add a summary of the metadata migration

2023-02-01 Thread via GitHub
cmccabe commented on PR #13180: URL: https://github.com/apache/kafka/pull/13180#issuecomment-1412624413 Thanks for the PR. WIth regard to the formatting changes, can we use the style we've been doing elsewhere in the scala code of: ``` functionName( parameterA: typeA,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13180: MINOR: Add a summary of the metadata migration

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13180: URL: https://github.com/apache/kafka/pull/13180#discussion_r1093640509 ## metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationSummary.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #13180: MINOR: Add a summary of the metadata migration

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13180: URL: https://github.com/apache/kafka/pull/13180#discussion_r1093639638 ## metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationSummary.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-02-01 Thread via GitHub
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1093620557 ## clients/src/main/java/org/apache/kafka/common/utils/Timer.java: ## @@ -161,7 +161,7 @@ public long remainingMs() { /** * Get the current time in

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-02-01 Thread via GitHub
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1093606834 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -711,9 +768,35 @@ KafkaBasedLog

[GitHub] [kafka] cmccabe commented on a diff in pull request #13176: MINOR: some ZK migration code cleanups.

2023-02-01 Thread via GitHub
cmccabe commented on code in PR #13176: URL: https://github.com/apache/kafka/pull/13176#discussion_r1093550518 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -79,6 +81,18 @@ class MigrationPropagator( _image = image } + /** + * A very

[GitHub] [kafka] cmccabe merged pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-02-01 Thread via GitHub
cmccabe merged PR #13169: URL: https://github.com/apache/kafka/pull/13169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-14668) Avoid sending unnecessary UMR in migration mode

2023-02-01 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-14668: Assignee: David Arthur > Avoid sending unnecessary UMR in migration mode >

[jira] [Updated] (KAFKA-14668) Avoid sending unnecessary UMR in migration mode

2023-02-01 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14668: - Description: While the KRaftMigrationDriver is in "dual write" mode, in addition to

[jira] [Updated] (KAFKA-14668) Avoid sending unnecessary UMR in migration mode

2023-02-01 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14668: - Summary: Avoid sending unnecessary UMR in migration mode (was: NoOpRecord causes unnecessary

[jira] [Created] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-02-01 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14669: -- Summary: Include MirrorMaker connector configurations in docs Key: KAFKA-14669 URL: https://issues.apache.org/jira/browse/KAFKA-14669 Project: Kafka

[jira] [Created] (KAFKA-14668) NoOpRecord causes unnecessary UMR in migration mode

2023-02-01 Thread David Arthur (Jira)
David Arthur created KAFKA-14668: Summary: NoOpRecord causes unnecessary UMR in migration mode Key: KAFKA-14668 URL: https://issues.apache.org/jira/browse/KAFKA-14668 Project: Kafka Issue

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1093501099 ## tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] C0urante commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-02-01 Thread via GitHub
C0urante commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1093416934 ## clients/src/main/java/org/apache/kafka/common/utils/Timer.java: ## @@ -161,7 +161,7 @@ public long remainingMs() { /** * Get the current time in

[GitHub] [kafka] C0urante commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-02-01 Thread via GitHub
C0urante commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1093433981 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -711,9 +768,35 @@ KafkaBasedLog

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1093445449 ## tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682944#comment-17682944 ] Alexandre Dupriez edited comment on KAFKA-14139 at 2/1/23 4:12 PM: --- Hi

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682944#comment-17682944 ] Alexandre Dupriez edited comment on KAFKA-14139 at 2/1/23 4:12 PM: --- Hi

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-02-01 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() {

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-02-01 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() {

[GitHub] [kafka] mimaison commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
mimaison commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1093412947 ## tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] C0urante commented on a diff in pull request #13181: KAFKA-14610: Publish Mirror Maker 2 offset syncs in task commit() method

2023-02-01 Thread via GitHub
C0urante commented on code in PR #13181: URL: https://github.com/apache/kafka/pull/13181#discussion_r1093398759 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -87,6 +90,7 @@ public MirrorSourceTask() {} @Override public

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-02-01 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() {

[GitHub] [kafka] C0urante commented on a diff in pull request #13181: KAFKA-14610: Publish Mirror Maker 2 offset syncs in task commit() method

2023-02-01 Thread via GitHub
C0urante commented on code in PR #13181: URL: https://github.com/apache/kafka/pull/13181#discussion_r1093398759 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -87,6 +90,7 @@ public MirrorSourceTask() {} @Override public

[jira] [Commented] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-02-01 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683035#comment-17683035 ] Christo Lolov commented on KAFKA-14661: ---

[jira] [Updated] (KAFKA-14667) Delayed leader election operation gets stuck in purgatory

2023-02-01 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-14667: - Description: This was observed with Kafka 3.1.1, but I believe that latest versions are also

[jira] [Created] (KAFKA-14667) Delayed leader election operation gets stuck in purgatory

2023-02-01 Thread Daniel Urban (Jira)
Daniel Urban created KAFKA-14667: Summary: Delayed leader election operation gets stuck in purgatory Key: KAFKA-14667 URL: https://issues.apache.org/jira/browse/KAFKA-14667 Project: Kafka

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-02-01 Thread via GitHub
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1093090686 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -711,9 +752,32 @@ KafkaBasedLog

[jira] [Comment Edited] (KAFKA-14186) Add unit tests for BatchFileWriter

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682961#comment-17682961 ] Alexandre Dupriez edited comment on KAFKA-14186 at 2/1/23 10:38 AM:

[jira] [Assigned] (KAFKA-14186) Add unit tests for BatchFileWriter

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez reassigned KAFKA-14186: - Assignee: Alexandre Dupriez > Add unit tests for BatchFileWriter >

[jira] [Commented] (KAFKA-14186) Add unit tests for BatchFileWriter

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682961#comment-17682961 ] Alexandre Dupriez commented on KAFKA-14186: --- {{BatchFileWriterReaderTest}} provides a unit

[jira] [Comment Edited] (KAFKA-14186) Add unit tests for BatchFileWriter

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682961#comment-17682961 ] Alexandre Dupriez edited comment on KAFKA-14186 at 2/1/23 10:37 AM:

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682944#comment-17682944 ] Alexandre Dupriez edited comment on KAFKA-14139 at 2/1/23 10:05 AM:

[jira] [Commented] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682944#comment-17682944 ] Alexandre Dupriez commented on KAFKA-14139: --- Hi Calvin, yes, sure, I assigned the JIRA to you. 

[jira] [Assigned] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-02-01 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez reassigned KAFKA-14139: - Assignee: Calvin Liu (was: Alexandre Dupriez) > Replaced disk can lead to

[jira] [Commented] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-02-01 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682938#comment-17682938 ] Christo Lolov commented on KAFKA-14661: --- I will draft a KIP later today if we think this is still

[jira] [Commented] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-02-01 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682936#comment-17682936 ] Christo Lolov commented on KAFKA-14661: --- For Zookeeper 3.8.0: {code:java} ZooKeeper clients from

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
me` without the argument (true is implicit). ``` $ bin/kafka-run-class.sh org.apache.kafka.tools.JmxTool \ --jmx-url service:jmx:rmi:///jndi/rmi://:9990/jmxrmi \ --object-name kafka.server:type=BrokerTopicMetrics,name=MessagesInPerSec \ --attributes FifteenMinuteRate,Fi

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
me` without the argument (true is implicit). ``` $ bin/kafka-run-class.sh org.apache.kafka.tools.JmxTool \ --jmx-url service:jmx:rmi:///jndi/rmi://:9990/jmxrmi \ --object-name kafka.server:type=BrokerTopicMetrics,name=MessagesInPerSec \ --attributes Fift

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
me` without the argument (true is implicit). ``` $ bin/kafka-run-class.sh org.apache.kafka.tools.JmxTool \ --jmx-url service:jmx:rmi:///jndi/rmi://:9990/jmxrmi \ --object-name kafka.server:type=BrokerTopicMetrics,name=MessagesInPerSec \ --attributes FifteenM

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
me` without the argument (true is implicit). ``` $ bin/kafka-run-class.sh org.apache.kafka.tools.JmxTool \ --jmx-url service:jmx:rmi:///jndi/rmi://:9990/jmxrmi \ --object-name kafka.server:type=BrokerTopicMetrics,name=MessagesInPerSec \ --attributes FifteenM

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
2000); +oneTimeOpt = parser.accepts("one-time", "Flag to indicate run once only.") +.withOptionalArg() Review Comment: Here I'm fixing the following issue with the old implementation: It is rather common to pass boolean options without the arg

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1092895124 ## tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1092895124 ## tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
fvaleri commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1092890819 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -1033,7 +1033,7 @@ object ConsumerGroupCommand extends Logging { val describeOpt =