[GitHub] [kafka] yashmayya commented on pull request #13194: MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask

yashmayya commented on PR #13194: URL: https://github.com/apache/kafka/pull/13194#issuecomment-1415265813 Hey @C0urante, could you please take a look at this one-liner comment update whenever you get a chance? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] yashmayya opened a new pull request, #13194: MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask

yashmayya opened a new pull request, #13194: URL: https://github.com/apache/kafka/pull/13194 - Handling of consumer rebalance related failures in sink tasks was added in https://github.com/apache/kafka/pull/767 - Exceptions thrown in the consumer rebalance listener are swallowed by the

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095387492 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mjsax merged pull request #13186: KAFKA-14491: [4/N] Improvements to segment value format for RocksDB versioned store

mjsax merged PR #13186: URL: https://github.com/apache/kafka/pull/13186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

mjsax commented on PR #13126: URL: https://github.com/apache/kafka/pull/13126#issuecomment-1415043376 `TEST_CASES` is clear and also the names of the test methods are clear. It's really the code iterating over the test cases with all the loops (forward, backward) and nested if/else control

[GitHub] [kafka] omkreddy closed pull request #12399: KAFKA-14063: Prevent malicious tiny payloads from causing OOMs with variably sized collections

omkreddy closed pull request #12399: KAFKA-14063: Prevent malicious tiny payloads from causing OOMs with variably sized collections URL: https://github.com/apache/kafka/pull/12399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1095367325 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentsTest.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1095365120 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino reassigned KAFKA-14659: Assignee: Hector Geraldino > source-record-write-[rate|total] metrics include

[GitHub] [kafka] hgeraldino opened a new pull request, #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

hgeraldino opened a new pull request, #13193: URL: https://github.com/apache/kafka/pull/13193 This PR aligns the description for `source-record-write-rate` and `source-record-write-total` metrics, and excludes the filtered records from the metrics being published. Today, the

[GitHub] [kafka] jolshan commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1414584410 @ijuma Do you have any concerns with switching to ConcurrentHashMap here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] jolshan commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1414580619 @Hangleton We can try to get this merged before https://github.com/apache/kafka/pull/13040 if that helps. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] kirktrue commented on pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher

kirktrue commented on PR #13192: URL: https://github.com/apache/kafka/pull/13192#issuecomment-1414573568 cc @hachikuji @rajinisivaram @philipnee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] kirktrue opened a new pull request, #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher

kirktrue opened a new pull request, #13192: URL: https://github.com/apache/kafka/pull/13192 Extract from `Fetcher` the APIs that are related to metadata operations into a new class named `MetadataFetcher`. This will allow the refactoring of `Fetcher` and `MetadataFetcher` for the new

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1414556430 @guozhangwang - would you have time to review this 梁 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683598#comment-17683598 ] Guozhang Wang commented on KAFKA-12639: --- Yeah that would work better I think. >

[GitHub] [kafka] ijuma commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

ijuma commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1095220913 ## server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java: ## @@ -66,4 +67,27 @@ public static T waitWithLogging( throw new

[GitHub] [kafka] hgeraldino opened a new pull request, #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

hgeraldino opened a new pull request, #13191: URL: https://github.com/apache/kafka/pull/13191 This PR is part of the larger initiative of migrating tests from EasyMock/PowerMock to Mockito](https://issues.apache.org/jira/browse/KAFKA-7438), and is a "blocker" of

[jira] [Created] (KAFKA-14675) Extract metadata-related tasks from Fetcher into MetadataFetcher

Kirk True created KAFKA-14675: - Summary: Extract metadata-related tasks from Fetcher into MetadataFetcher Key: KAFKA-14675 URL: https://issues.apache.org/jira/browse/KAFKA-14675 Project: Kafka

[jira] [Commented] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683597#comment-17683597 ] Andy Coates commented on KAFKA-14660: - [~mjsax] can you provide a link to the PR that fixed this DBZ

[jira] [Reopened] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates reopened KAFKA-14660: - The issue here is more the SonaType security vulnerability report than any impossible to reach

[GitHub] [kafka] guozhangwang commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

guozhangwang commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1414532246 @shekhar-rajak please let me know after you've updated the PR incorporating previous comments. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang merged pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

guozhangwang merged PR #12777: URL: https://github.com/apache/kafka/pull/12777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] Hangleton commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

Hangleton commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095052846 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] Hangleton commented on pull request #12399: KAFKA-14063: Prevent malicious tiny payloads from causing OOMs with variably sized collections

Hangleton commented on PR #12399: URL: https://github.com/apache/kafka/pull/12399#issuecomment-1414383920 The vulnerability has been addressed by the following commits. - [Apache Kafka 2.8](https://github.com/apache/kafka/commit/14951a83e3fdead212156e5532359500d72f68bc) - [Apache

[jira] [Updated] (KAFKA-14490) Consider using UncheckedIOException instead of IOException in the log layer

[ https://issues.apache.org/jira/browse/KAFKA-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14490: -- Summary: Consider using UncheckedIOException instead of IOException in the log layer

[GitHub] [kafka] philipnee opened a new pull request, #13190: KAFKA-12539: exit upon expired timer to prevent tight looping

philipnee opened a new pull request, #13190: URL: https://github.com/apache/kafka/pull/13190 In AbstractCoordinator#joinGroupIfNeeded - joinGroup request will be retried without proper backoff, due to the expired timer. This is an uncommon scenario and possibly only appears during the

[GitHub] [kafka] Hangleton commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

Hangleton commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1414321689 Thanks @anatasiavela for the PR. Apologies for any repeat, just wanted to ask if you would plan to have this merged before or after

[GitHub] [kafka] vcrfxia opened a new pull request, #13189: KAFKA-14491: [6/N] Support restoring RocksDB versioned store from changelog

vcrfxia opened a new pull request, #13189: URL: https://github.com/apache/kafka/pull/13189 (This PR is stacked on https://github.com/apache/kafka/pull/13188, which in turn is stacked on https://github.com/apache/kafka/pull/13143. Only the last commit (`add restore`) needs to be reviewed as

[GitHub] [kafka] vcrfxia opened a new pull request, #13188: KAFKA-14491: [5/N] Support basic operations for RocksDB versioned store

vcrfxia opened a new pull request, #13188: URL: https://github.com/apache/kafka/pull/13188 (This PR is stacked on https://github.com/apache/kafka/pull/13143; the first commit does not need to be reviewed separately.) Introduces the VersionedKeyValueStore interface proposed in

[jira] [Comment Edited] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683545#comment-17683545 ] Philip Nee edited comment on KAFKA-12639 at 2/2/23 7:16 PM: Hey

[jira] [Commented] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683545#comment-17683545 ] Philip Nee commented on KAFKA-12639: Hey [~matiss.gutmanis] - I'm arriving at the same conclusion as

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094930020 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094928271 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094922008 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094918202 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -538,12 +553,23 @@ public void run() throws Exception {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094915210 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mdedetrich commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1414149629 Sorry I have just been busy with other things, will look into it next week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] OneCricketeer commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1094853715 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] OneCricketeer commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1094853715 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683497#comment-17683497 ] Calvin Liu commented on KAFKA-14139: Hi Alex, I am not aware of such simulation frameworks existed.

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1414078362 Ack. Let me update the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] AndrefcBarber commented on pull request #6329: KAFKA-1194: Fix renaming open files on Windows

AndrefcBarber commented on PR #6329: URL: https://github.com/apache/kafka/pull/6329#issuecomment-1414061654 Hi, trying to sell this great product to our company to resolve streaming. I followed the comments and proposed solutions from Kafka-1194(2016) to present. @robertbraeutigam &

[GitHub] [kafka] shekhar-rajak commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

shekhar-rajak commented on PR #12777: URL: https://github.com/apache/kafka/pull/12777#issuecomment-1414050155 Hi, This PR already have one approval and ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] clolov commented on a diff in pull request #13180: MINOR: Add a summary of the metadata migration

clolov commented on code in PR #13180: URL: https://github.com/apache/kafka/pull/13180#discussion_r1094798424 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -415,7 +416,7 @@ public void run() throws Exception {

[GitHub] [kafka] mumrah commented on pull request #13180: MINOR: Add a summary of the metadata migration

mumrah commented on PR #13180: URL: https://github.com/apache/kafka/pull/13180#issuecomment-1414048688 @cmccabe, here's the new metadata summary format: > [2023-02-02 11:21:52,175] TRACE Sending RPCs to broker before moving to dual-write mode. Metadata at offset 122 and epoch 1

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094788715 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Comment Edited] (KAFKA-14584) Move StateChangeLogMerger to tools

[ https://issues.apache.org/jira/browse/KAFKA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682643#comment-17682643 ] Federico Valeri edited comment on KAFKA-14584 at 2/2/23 4:37 PM: - Users

[jira] [Comment Edited] (KAFKA-14582) Move JmxTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682641#comment-17682641 ] Federico Valeri edited comment on KAFKA-14582 at 2/2/23 4:37 PM: - Users

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094784273 ## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ## @@ -94,6 +100,8 @@ public class MockAdminClient extends AdminClient { private

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094783958 ## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ## @@ -596,22 +604,89 @@ synchronized public DeleteRecordsResult deleteRecords(Map future

[jira] [Updated] (KAFKA-14671) Refactor PredicatedTransformation to not implement Transformation

[ https://issues.apache.org/jira/browse/KAFKA-14671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14671: Description: The PredicatedTransformation

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094783703 ## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ## @@ -596,22 +604,89 @@ synchronized public DeleteRecordsResult deleteRecords(Map future

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094781236 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094781664 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094780253 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] yashmayya commented on pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

yashmayya commented on PR #12984: URL: https://github.com/apache/kafka/pull/12984#issuecomment-1414002141 Thanks Greg and Chris for the great reviews on this one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] gharris1727 commented on pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

gharris1727 commented on PR #13184: URL: https://github.com/apache/kafka/pull/13184#issuecomment-1414001178 @clolov Perhaps that's where a name change would help. If this was named `TransformationStage`, with a `TransformationChain` made up of multiple `TransformationStage`s and a

[GitHub] [kafka] C0urante merged pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

C0urante merged PR #12984: URL: https://github.com/apache/kafka/pull/12984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14674) Backport fix for KAFKA-14455 to 3.3 and 3.4 branches

Chris Egerton created KAFKA-14674: - Summary: Backport fix for KAFKA-14455 to 3.3 and 3.4 branches Key: KAFKA-14674 URL: https://issues.apache.org/jira/browse/KAFKA-14674 Project: Kafka Issue

[GitHub] [kafka] fvaleri commented on pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

fvaleri commented on PR #13171: URL: https://github.com/apache/kafka/pull/13171#issuecomment-1413963412 Rebased. Thanks @clolov and @mimaison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094720518 ## tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094714174 ## tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] mumrah commented on pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

mumrah commented on PR #13183: URL: https://github.com/apache/kafka/pull/13183#issuecomment-1413948935 Updates: * Factored out the CompletableFuture from the MetadataChangeEvent so it's only used in the unit test * Removed QueueClosingException, replaced with

[GitHub] [kafka] fvaleri commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

fvaleri commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094601295 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] C0urante commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

C0urante commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1094686354 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -711,9 +768,35 @@ KafkaBasedLog

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094686108 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094685504 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #13180: MINOR: Add a summary of the metadata migration

mumrah commented on code in PR #13180: URL: https://github.com/apache/kafka/pull/13180#discussion_r1094684342 ## metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationSummary.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a diff in pull request #13180: MINOR: Add a summary of the metadata migration

mumrah commented on code in PR #13180: URL: https://github.com/apache/kafka/pull/13180#discussion_r1094683166 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -415,7 +416,7 @@ public void run() throws Exception {

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-14060) Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

[ https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683465#comment-17683465 ] Chris Egerton commented on KAFKA-14060: --- [~hgeraldino] that's fine, thanks for the heads up. >

[jira] [Assigned] (KAFKA-14059) Replace EasyMock and PowerMock with Mockito in WorkerSourceTaskTest

[ https://issues.apache.org/jira/browse/KAFKA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14059: - Assignee: (was: Chris Egerton) > Replace EasyMock and PowerMock with Mockito in

[GitHub] [kafka] clolov commented on a diff in pull request #13172: KAFKA-14590: Move DelegationTokenCommand to tools

clolov commented on code in PR #13172: URL: https://github.com/apache/kafka/pull/13172#discussion_r1094656127 ## build.gradle: ## @@ -1763,6 +1763,7 @@ project(':tools') { implementation libs.jacksonJDK8Datatypes implementation libs.slf4jApi implementation

[GitHub] [kafka] mimaison commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

mimaison commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1094636765 ## build.gradle: ## @@ -1763,6 +1763,7 @@ project(':tools') { implementation libs.jacksonJDK8Datatypes implementation libs.slf4jApi implementation

[GitHub] [kafka] clolov commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

clolov commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1094628589 ## build.gradle: ## @@ -1763,6 +1763,7 @@ project(':tools') { implementation libs.jacksonJDK8Datatypes implementation libs.slf4jApi implementation

[GitHub] [kafka] mumrah commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

mumrah commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094617299 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {

[GitHub] [kafka] mumrah commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

mumrah commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094614887 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1094564674 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1094564674 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-14673) High watermark listener

David Jacot created KAFKA-14673: --- Summary: High watermark listener Key: KAFKA-14673 URL: https://issues.apache.org/jira/browse/KAFKA-14673 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1080718765 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] Hangleton commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

Hangleton commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1094530705 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; +

[jira] [Commented] (KAFKA-14060) Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

[ https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683418#comment-17683418 ] Hector Geraldino commented on KAFKA-14060: -- Hey [~ChrisEgerton], I wrote a patch for

[GitHub] [kafka] beardt commented on pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on PR #13168: URL: https://github.com/apache/kafka/pull/13168#issuecomment-1413758244 I went ahead and reintroduced the InterceptorTestConfig as I do not think it adds anymore complexity than `TestConfig` and `ClassTestConfig` while also making

[GitHub] [kafka] clolov commented on pull request #12449: KAFKA-12947: Replace EasyMock and PowerMock with Mockito for StreamsMetricsImplTest

clolov commented on PR #12449: URL: https://github.com/apache/kafka/pull/12449#issuecomment-1413745195 Hello @dplavcic and @cadonna, how is this pull request fairing? Is there something outstanding as a review or comments to be addressed? -- This is an automated message from the Apache

[jira] [Assigned] (KAFKA-14667) Delayed leader election operation gets stuck in purgatory

[ https://issues.apache.org/jira/browse/KAFKA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-14667: --- Assignee: Viktor Somogyi-Vass > Delayed leader election operation gets

[GitHub] [kafka] clolov commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

clolov commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1413742398 Hello @mdedetrich and @cadonna! Is there something still remaining for this pull request or are we ready to merge it? There are around 4 pull requests remaining of this migration and I

[GitHub] [kafka] clolov commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

clolov commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1413740025 @shekhar-rajak, I would quite like to complete the migration for streams, so I will wait for a response for another week. Afterwards I will open a separate pull request based on this one

[GitHub] [kafka] clolov commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

clolov commented on PR #12777: URL: https://github.com/apache/kafka/pull/12777#issuecomment-1413738931 @cadonna is it possible get a review here as well? @shekhar-rajak, if there are any comments is it possible for you to address them. I will circle back in a week's time and if there are

[GitHub] [kafka] Hangleton commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

Hangleton commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1094474509 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpointFile.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1413735823 @cadonna I have rebased this on the latest trunk. Is it possible to get a review? This pull requests is one of the last remaining ones for completing the Mockito migration for streams.

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

Hangleton commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1094454976 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {

[jira] [Assigned] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14595: --- Assignee: Nikolay Izhikov (was: Omnia Ibrahim) > Move ReassignPartitionsCommand

[jira] [Commented] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683377#comment-17683377 ] Omnia Ibrahim commented on KAFKA-14595: --- [~nizhikov] sure > Move ReassignPartitionsCommand to

[GitHub] [kafka] clolov commented on pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

clolov commented on PR #13184: URL: https://github.com/apache/kafka/pull/13184#issuecomment-1413610633 To be honest, when I read this code a class which is "kind of" like a Transformation but throws because some methods are not implemented made more sense than wrapping Transformations in a

[GitHub] [kafka] Hangleton commented on a diff in pull request #13176: MINOR: some ZK migration code cleanups.

Hangleton commented on code in PR #13176: URL: https://github.com/apache/kafka/pull/13176#discussion_r1094408921 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -79,6 +81,18 @@ class MigrationPropagator( _image = image } + /** + * A very

  1   2   >