[GitHub] [kafka] satishd commented on pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on PR #13046: URL: https://github.com/apache/kafka/pull/13046#issuecomment-1420265571 These test failures seem to be unrelated. I rebased the PR against trunk. I will wait for the test results. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #13206: [KAFKA-14685] Refactor logic to handle OFFSET_MOVED_TO_TIERED_STORAGE error

rittikaadhikari commented on code in PR #13206: URL: https://github.com/apache/kafka/pull/13206#discussion_r1097985124 ## core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] yashmayya commented on pull request #13120: MINOR: Connect Javadocs improvements

yashmayya commented on PR #13120: URL: https://github.com/apache/kafka/pull/13120#issuecomment-1420163844 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] hgeraldino commented on pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

hgeraldino commented on PR #13191: URL: https://github.com/apache/kafka/pull/13191#issuecomment-1420146327 > Thanks @hgeraldino! > > I'm a little confused by the amount of churn here--it seems like a lot of utility methods related to topic creation, record transformation, etc. have

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

hgeraldino commented on code in PR #13191: URL: https://github.com/apache/kafka/pull/13191#discussion_r1098136639 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -639,93 +814,25 @@ public void

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

hgeraldino commented on code in PR #13191: URL: https://github.com/apache/kafka/pull/13191#discussion_r1098135416 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -129,7 +131,7 @@ public class

[GitHub] [kafka] mjsax opened a new pull request, #13209: MINOR: remove unnecessary helper method

mjsax opened a new pull request, #13209: URL: https://github.com/apache/kafka/pull/13209 The helper method in question was updated via KIP-622 instead of removed. Cf https://github.com/apache/kafka/commit/029f5a136ae2c74f7f93e716bcc30ce90d8241ad -- This is an automated message from the

[GitHub] [kafka] gharris1727 commented on pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

gharris1727 commented on PR #13208: URL: https://github.com/apache/kafka/pull/13208#issuecomment-1420026975 I verified that this fix corrects the flakey failures I was seeing in ConnectDistributedTest.test_bounce by manually running the tests with a flush interval of 1ms. -- This is an

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1098052600 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-5756) Synchronization issue on flush

[ https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684977#comment-17684977 ] Greg Harris commented on KAFKA-5756: [~mimaison] I have opened a PR that I think may alleviate this

[jira] [Assigned] (KAFKA-5756) Synchronization issue on flush

[ https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-5756: -- Assignee: Greg Harris > Synchronization issue on flush > -- > >

[GitHub] [kafka] gharris1727 opened a new pull request, #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

gharris1727 opened a new pull request, #13208: URL: https://github.com/apache/kafka/pull/13208 Both the SourceTaskOffsetCommitter and WorkerSourceTask trigger offset commits. Currently, when both threads attempt to start concurrent flushes, the second to call beginFlush receives an

[jira] [Created] (KAFKA-14686) MockAdminClient.createTopics does not provide TopicMetadataAndConfig

Kirk True created KAFKA-14686: - Summary: MockAdminClient.createTopics does not provide TopicMetadataAndConfig Key: KAFKA-14686 URL: https://issues.apache.org/jira/browse/KAFKA-14686 Project: Kafka

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1098020205 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3509,6 +3510,13 @@ class KafkaApis(val requestChannel: RequestChannel, ) } + def

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1098014628 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -212,6 +215,36 @@ public boolean isVersionSupported(short apiVersion) { return

[jira] [Commented] (KAFKA-14685) TierStateMachine interface for building remote aux log

[ https://issues.apache.org/jira/browse/KAFKA-14685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684968#comment-17684968 ] Matthew Wong commented on KAFKA-14685: -- https://github.com/apache/kafka/pull/13206 >

[jira] [Created] (KAFKA-14685) TierStateMachine interface for building remote aux log

Matthew Wong created KAFKA-14685: Summary: TierStateMachine interface for building remote aux log Key: KAFKA-14685 URL: https://issues.apache.org/jira/browse/KAFKA-14685 Project: Kafka Issue

[GitHub] [kafka] hachikuji opened a new pull request, #13207: KAFKA-14664; Fix inaccurate raft idle ratio metric

hachikuji opened a new pull request, #13207: URL: https://github.com/apache/kafka/pull/13207 The raft idle ratio is currently computed as the average of all recorded poll durations. This tends to underestimate the actual idle ratio since it treats all measurements equally regardless how

[GitHub] [kafka] junrao commented on pull request #13206: Refactor logic to handle OFFSET_MOVED_TO_TIERED_STORAGE error

junrao commented on PR #13206: URL: https://github.com/apache/kafka/pull/13206#issuecomment-1419883513 cc @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] mattwong949 opened a new pull request, #13206: Refactor logic to handle OFFSET_MOVED_TO_TIERED_STORAGE error

mattwong949 opened a new pull request, #13206: URL: https://github.com/apache/kafka/pull/13206 This PR adds the TierStateMachine interface to handle all state transitions related to tiered storage and building the remote log aux state. The new interface supports a `start` and

[jira] [Commented] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684958#comment-17684958 ] Matthias J. Sax commented on KAFKA-14660: - Correct. 3.4.0 is already voted and should be

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1419776869 @dejan2609 We'll wait for the final release, but it's fine to start working through the issues. Looks like the build failed. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on a diff in pull request #13179: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

mjsax commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097933056 ## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration

[GitHub] [kafka] mjsax commented on a diff in pull request #13179: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

mjsax commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097933056 ## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration

[GitHub] [kafka] mjsax commented on a diff in pull request #13179: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

mjsax commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097933056 ## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration

[GitHub] [kafka] mjsax commented on a diff in pull request #13179: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

mjsax commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097931763 ## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration

[GitHub] [kafka] philipnee commented on a diff in pull request #13021: KAFKA-14468: Implement CommitRequestManager to manage the commit and autocommit requests

philipnee commented on code in PR #13021: URL: https://github.com/apache/kafka/pull/13021#discussion_r1097801059 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/GroupStateManager.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684947#comment-17684947 ] Hector Geraldino commented on KAFKA-14132: -- Perfect. Entered

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino updated KAFKA-14132: - Description: {color:#de350b}Some of the tests below use EasyMock as well. For those

[jira] [Created] (KAFKA-14684) Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskThreadedTest

Hector Geraldino created KAFKA-14684: Summary: Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskThreadedTest Key: KAFKA-14684 URL: https://issues.apache.org/jira/browse/KAFKA-14684

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1097911296 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel, }

[jira] [Created] (KAFKA-14683) Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskTest

Hector Geraldino created KAFKA-14683: Summary: Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskTest Key: KAFKA-14683 URL: https://issues.apache.org/jira/browse/KAFKA-14683 Project:

[GitHub] [kafka] C0urante commented on a diff in pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

C0urante commented on code in PR #13191: URL: https://github.com/apache/kafka/pull/13191#discussion_r1097852548 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -129,7 +131,7 @@ public class AbstractWorkerSourceTaskTest

[jira] [Updated] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14682: -- Description: We've started using [strict

[jira] [Commented] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684909#comment-17684909 ] Chris Egerton commented on KAFKA-14682: --- [~divijvaidya] FYI, this may interest you. > Unused

[jira] [Created] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

Chris Egerton created KAFKA-14682: - Summary: Unused stubbings are not reported by Mockito during CI builds Key: KAFKA-14682 URL: https://issues.apache.org/jira/browse/KAFKA-14682 Project: Kafka

[GitHub] [kafka] vladimirdyuzhev commented on pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

vladimirdyuzhev commented on PR #13081: URL: https://github.com/apache/kafka/pull/13081#issuecomment-1419634909 Created JIRA [KAFKA-14681](https://issues.apache.org/jira/browse/KAFKA-14681) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (KAFKA-14681) Refreshing Kerberos TGT is not using CallbackHandler (causing failure to refresh)

[ https://issues.apache.org/jira/browse/KAFKA-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vlad D. updated KAFKA-14681: Description: The JAAS + Kerberos authentication in KerberosLogin.java class, when obtaining Kerberos

[jira] [Updated] (KAFKA-14681) Refreshing Kerberos TGT is not using CallbackHandler (causing failure to refresh)

[ https://issues.apache.org/jira/browse/KAFKA-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vlad D. updated KAFKA-14681: Description: The JAAS + Kerberos authentication in KerberosLogin.java class, when obtaining Kerberos

[jira] [Updated] (KAFKA-14681) Refreshing Kerberos TGT is not using CallbackHandler (causing failure to refresh)

[ https://issues.apache.org/jira/browse/KAFKA-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vlad D. updated KAFKA-14681: Description: The JAAS + Kerberos authentication in KerberosLogin.java class, when obtaining Kerberos

[jira] [Created] (KAFKA-14681) Refreshing Kerberos TGT is not using CallbackHandler (causing failure to refresh)

Vlad D. created KAFKA-14681: --- Summary: Refreshing Kerberos TGT is not using CallbackHandler (causing failure to refresh) Key: KAFKA-14681 URL: https://issues.apache.org/jira/browse/KAFKA-14681 Project:

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1419585603 Related to #13199 Thanx for heads up @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (KAFKA-13972) Reassignment cancellation causes stray replicas

[ https://issues.apache.org/jira/browse/KAFKA-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13972. - Resolution: Fixed > Reassignment cancellation causes stray replicas >

[GitHub] [kafka] jsancio commented on a diff in pull request #13197: Minor: Decode the envelope requests for the request log

jsancio commented on code in PR #13197: URL: https://github.com/apache/kafka/pull/13197#discussion_r1097782211 ## core/src/main/scala/kafka/network/RequestConvertToJson.scala: ## @@ -60,7 +61,16 @@ object RequestConvertToJson { case req: ElectLeadersRequest =>

[GitHub] [kafka] dejan2609 opened a new pull request, #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 opened a new pull request, #13205: URL: https://github.com/apache/kafka/pull/13205 details: * gradle upgrade: 7.6 -->> 8.0-rc-3 * spotbugs plugin upgrade: 5.0.9 -->> 5.0.13 * declaration test.dependsOn(':spotlessScalaCheck') removed for

[GitHub] [kafka] cmccabe merged pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0

cmccabe merged PR #13198: URL: https://github.com/apache/kafka/pull/13198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-14680) Gradle version upgrade 7 -->> 8

[ https://issues.apache.org/jira/browse/KAFKA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684864#comment-17684864 ] Ismael Juma edited comment on KAFKA-14680 at 2/6/23 6:31 PM: -

[jira] [Commented] (KAFKA-14680) Gradle version upgrade 7 -->> 8

[ https://issues.apache.org/jira/browse/KAFKA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684864#comment-17684864 ] Ismael Juma commented on KAFKA-14680: - [https://github.com/apache/kafka/pull/13199] helps. > Gradle

[jira] [Created] (KAFKA-14680) Gradle version upgrade 7 -->> 8

Dejan Stojadinović created KAFKA-14680: -- Summary: Gradle version upgrade 7 -->> 8 Key: KAFKA-14680 URL: https://issues.apache.org/jira/browse/KAFKA-14680 Project: Kafka Issue Type:

[GitHub] [kafka] mumrah commented on pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

mumrah commented on PR #13183: URL: https://github.com/apache/kafka/pull/13183#issuecomment-1419529065 Gotcha, yea the docs are still in progress. We'll have something published soon (hopefully before the release announcement) -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13179: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

guozhangwang commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097749095 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -986,8 +986,23 @@ public void unregister(final Collection

[jira] [Resolved] (KAFKA-14663) High throughput topics can starve low-throughput MM2 offset syncs

[ https://issues.apache.org/jira/browse/KAFKA-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14663. --- Resolution: Duplicate > High throughput topics can starve low-throughput MM2 offset syncs >

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13179: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

guozhangwang commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097746204 ## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration

[GitHub] [kafka] FireBurn commented on pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

FireBurn commented on PR #13183: URL: https://github.com/apache/kafka/pull/13183#issuecomment-1419452307 Fab, I've just built 3.4.0 from the tag, but couldn't find the migration docs, so worried it had been delayed to 3.4.1 -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mumrah commented on pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

mumrah commented on PR #13183: URL: https://github.com/apache/kafka/pull/13183#issuecomment-1419445476 @FireBurn, no it hasn't been delayed. We have an early access version coming out in 3.4.0 which will be announced this week. We plan on back-porting the remaining ZK migration work to the

[GitHub] [kafka] FireBurn commented on pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

FireBurn commented on PR #13183: URL: https://github.com/apache/kafka/pull/13183#issuecomment-1419426113 Has ZK migration to Kraft been delayed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1097662809 ## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ## @@ -870,7 +870,37 @@ synchronized public AlterReplicaLogDirsResult

[GitHub] [kafka] ijuma commented on pull request #13199: MINOR: Update build and test dependencies for 3.5

ijuma commented on PR #13199: URL: https://github.com/apache/kafka/pull/13199#issuecomment-1419378585 @showuon This is now ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #13199: MINOR: Update build and test dependencies for 3.5

ijuma commented on PR #13199: URL: https://github.com/apache/kafka/pull/13199#issuecomment-1419378251 JDK 11 build passed, the other two had unrelated failures: > Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2,

[GitHub] [kafka] OmniaGM opened a new pull request, #13204: KAFKA-14593: Move LeaderElectionCommand to tools

OmniaGM opened a new pull request, #13204: URL: https://github.com/apache/kafka/pull/13204 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Created] (KAFKA-14679) Add new __consumer_offsets records

David Jacot created KAFKA-14679: --- Summary: Add new __consumer_offsets records Key: KAFKA-14679 URL: https://issues.apache.org/jira/browse/KAFKA-14679 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] dajac commented on pull request #13200: KAFKA-14678: Move `__consumer_offsets` records from `core` to `group-coordinator`

dajac commented on PR #13200: URL: https://github.com/apache/kafka/pull/13200#issuecomment-1419247177 @mimaison Thanks! Created KAFKA-14678. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (KAFKA-14678) Move __consumer_offsets records from core to group-coordinator

David Jacot created KAFKA-14678: --- Summary: Move __consumer_offsets records from core to group-coordinator Key: KAFKA-14678 URL: https://issues.apache.org/jira/browse/KAFKA-14678 Project: Kafka

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097469398 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] clolov commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

clolov commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1097383481 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -49,6 +49,25 @@ import org.apache.kafka.server.log.internals.{AppendOrigin, FetchDataInfo, Fetch import

[GitHub] [kafka] dajac opened a new pull request, #13203: MINOR: Add KIP-848 new `__consumer_offsets` records

dajac opened a new pull request, #13203: URL: https://github.com/apache/kafka/pull/13203 WIP. https://github.com/apache/kafka/pull/13200 must go first. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[GitHub] [kafka] fvaleri commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

fvaleri commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1097421951 ## docs/upgrade.html: ## @@ -19,6 +19,16 @@

[GitHub] [kafka] dajac opened a new pull request, #13202: KAFKA-14513; Add broker side PartitionAssignor interface

dajac opened a new pull request, #13202: URL: https://github.com/apache/kafka/pull/13202 This patch adds the broker side `PartitionAssignor` interface as detailed in KIP-848. The interfaces differs a bit from the KIP in the following ways: * The POJOs are not defined within the interface

[GitHub] [kafka] fvaleri commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

fvaleri commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1097421951 ## docs/upgrade.html: ## @@ -19,6 +19,16 @@

[GitHub] [kafka] fvaleri commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

fvaleri commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1097421951 ## docs/upgrade.html: ## @@ -19,6 +19,16 @@

[GitHub] [kafka] fvaleri commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

fvaleri commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1097421951 ## docs/upgrade.html: ## @@ -19,6 +19,16 @@

[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0

clolov commented on code in PR #13198: URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323 ## core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala: ## @@ -174,7 +174,7 @@ class FeatureCommandUnitTest { @Test def testMetadataVersionsToString():

[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0

clolov commented on code in PR #13198: URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323 ## core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala: ## @@ -174,7 +174,7 @@ class FeatureCommandUnitTest { @Test def testMetadataVersionsToString():

[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0

clolov commented on code in PR #13198: URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323 ## core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala: ## @@ -174,7 +174,7 @@ class FeatureCommandUnitTest { @Test def testMetadataVersionsToString():

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097364723 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] clolov commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

clolov commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1097398711 ## docs/upgrade.html: ## @@ -19,6 +19,16 @@

[GitHub] [kafka] dajac commented on a diff in pull request #13200: MINOR: Move `__consumer_offsets` records from `core` to `group-coordinator`

dajac commented on code in PR #13200: URL: https://github.com/apache/kafka/pull/13200#discussion_r1097390286 ## build.gradle: ## @@ -1266,6 +1272,23 @@ project(':group-coordinator') { javadoc { enabled = false } + + task processMessages(type:JavaExec) { +

[GitHub] [kafka] dajac commented on a diff in pull request #13200: MINOR: Move `__consumer_offsets` records from `core` to `group-coordinator`

dajac commented on code in PR #13200: URL: https://github.com/apache/kafka/pull/13200#discussion_r1097389168 ## checkstyle/import-control.xml: ## @@ -341,7 +341,9 @@ + Review Comment: Yes. The generated code needs this. -- This is an automated

[GitHub] [kafka] C0urante commented on pull request #13181: KAFKA-14610: Publish Mirror Maker 2 offset syncs in task commit() method

C0urante commented on PR #13181: URL: https://github.com/apache/kafka/pull/13181#issuecomment-1419098772 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] clolov commented on a diff in pull request #13200: MINOR: Move `__consumer_offsets` records from `core` to `group-coordinator`

clolov commented on code in PR #13200: URL: https://github.com/apache/kafka/pull/13200#discussion_r1097379412 ## checkstyle/import-control.xml: ## @@ -341,7 +341,9 @@ + Review Comment: For my curiosity, are these lines needed in the context of this

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097364723 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

fqaiser94 commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1097375552 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +47,85 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] clolov commented on pull request #13199: MINOR: Update build and test dependencies for 3.5

clolov commented on PR #13199: URL: https://github.com/apache/kafka/pull/13199#issuecomment-1419072645 Do we use some tool which suggests these newer versions or we do the checks manually for each release? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097364723 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] Schm1tz1 commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

Schm1tz1 commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1097355787 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on pull request #13200: MINOR: Move `__consumer_offsets` records from `core` to `group-coordinator`

dajac commented on PR #13200: URL: https://github.com/apache/kafka/pull/13200#issuecomment-1419045542 @mimaison Could you review this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097338495 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097335270 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097332224 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097332224 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684639#comment-17684639 ] Nikolay Izhikov commented on KAFKA-14595: - [~omnia_h_ibrahim] Thanks to let me know! > Move

[jira] [Comment Edited] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684635#comment-17684635 ] Omnia Ibrahim edited comment on KAFKA-14595 at 2/6/23 12:41 PM: Hi

[jira] [Commented] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684635#comment-17684635 ] Omnia Ibrahim commented on KAFKA-14595: --- Hi [~nizhikov], just a note, I moved the methods

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097325246 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] OmniaGM opened a new pull request, #13201: KAFKA-14596: Move TopicCommand to tools

OmniaGM opened a new pull request, #13201: URL: https://github.com/apache/kafka/pull/13201 This pr include - The changes include switching Scala code to java - Move TopicCommand and all test cases to tools - The PR depends on #13171 to replace the usage of `CoreUtils.duplicate` by

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097238384 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -0,0 +1,403 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Assigned] (KAFKA-14578) Move ConsumerPerformance to tools

[ https://issues.apache.org/jira/browse/KAFKA-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14578: --- Assignee: Federico Valeri > Move ConsumerPerformance to tools >

[GitHub] [kafka] mimaison merged pull request #13128: MINOR: Define a root project name in the Gradle settings file

mimaison merged PR #13128: URL: https://github.com/apache/kafka/pull/13128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1097245192 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mimaison merged pull request #13120: MINOR: Connect Javadocs improvements

mimaison merged PR #13120: URL: https://github.com/apache/kafka/pull/13120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >