[GitHub] [kafka] dajac merged pull request #13245: KAFKA-14704; Follower should truncate before incrementing high watermark (for 3.2 and earlier)

dajac merged PR #13245: URL: https://github.com/apache/kafka/pull/13245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14719) Talk about a problem: a return code

[ https://issues.apache.org/jira/browse/KAFKA-14719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenxingwuying updated KAFKA-14719: --- Description: I'm not sure whether it is a problem.   I write record to kafka when I use

[GitHub] [kafka] nizhikov commented on pull request #13247: [WIP] KAFKA-14595 Move value object of ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1430864188 @ijuma > Is server-common the right module? When move `ReassignPartitionsCommand` finished all classes must land in `tools` module. So the answer is No -

[GitHub] [kafka] shenxingwuying opened a new pull request, #13254: WIP KAFKA-14719: Fix a return code during broker is bootstrapping

shenxingwuying opened a new pull request, #13254: URL: https://github.com/apache/kafka/pull/13254 I am not sure this patch is reasonable, maybe the return code is by design? *More detailed description of your change, if necessary. The PR title and PR message become the

[jira] [Updated] (KAFKA-14719) Talk about a problem: a return code

[ https://issues.apache.org/jira/browse/KAFKA-14719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenxingwuying updated KAFKA-14719: --- Summary: Talk about a problem: a return code (was: Talk about a problem) > Talk about a

[jira] [Created] (KAFKA-14719) Talk about a problem

shenxingwuying created KAFKA-14719: -- Summary: Talk about a problem Key: KAFKA-14719 URL: https://issues.apache.org/jira/browse/KAFKA-14719 Project: Kafka Issue Type: Task

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes"

[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688824#comment-17688824 ] Sagar Rao commented on KAFKA-13152: --- Thanks [~guozhang] , [~mimaison]  > Replace

[GitHub] [kafka] philipnee opened a new pull request, #13253: KAFKA-14253 - More informative logging

philipnee opened a new pull request, #13253: URL: https://github.com/apache/kafka/pull/13253 Includes 2 requirements from the ticket: - Include the number of members in the group (I.e., "15 members participating" and "to 15 clients as") - sort the member ids (to help compare the

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1106606138 ## core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala: ## @@ -42,10 +46,18 @@ import scala.jdk.CollectionConverters._ * Also tests

[GitHub] [kafka] vcrfxia opened a new pull request, #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia opened a new pull request, #13252: URL: https://github.com/apache/kafka/pull/13252 (This PR is stacked on https://github.com/apache/kafka/pull/13249 and https://github.com/apache/kafka/pull/13250. Only the last commit needs to be reviewed separately.) This PR introduces the

[GitHub] [kafka] vcrfxia opened a new pull request, #13251: KAFKA-14491: [10/N] Add changelogging wrapper for versioned stores

vcrfxia opened a new pull request, #13251: URL: https://github.com/apache/kafka/pull/13251 (This PR is stacked on https://github.com/apache/kafka/pull/13249 and https://github.com/apache/kafka/pull/13250. Only the last commit needs to be reviewed separately.) This PR introduces the

[GitHub] [kafka] vcrfxia opened a new pull request, #13250: KAFKA-14491: [9/N] Add versioned bytes store and supplier

vcrfxia opened a new pull request, #13250: URL: https://github.com/apache/kafka/pull/13250 (This PR is stacked on https://github.com/apache/kafka/pull/13249. Only the last commit needs to be reviewed separately.) As part of introducing versioned key-value stores in

[GitHub] [kafka] vcrfxia opened a new pull request, #13249: KAFKA-14491: [8/N] Add serdes for ValueAndTimestamp with null value

vcrfxia opened a new pull request, #13249: URL: https://github.com/apache/kafka/pull/13249 As part of introducing versioned key-value stores in [KIP-889](https://cwiki.apache.org/confluence/display/KAFKA/KIP-889%3A+Versioned+State+Stores), we'd like a way to represent a versioned key-value

[GitHub] [kafka] anatasiavela commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1106571516 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -213,6 +216,19 @@ class ProducerStateManager( snapshots = loadSnapshots() } +

[GitHub] [kafka] anatasiavela commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1106571410 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -504,7 +520,7 @@ class ProducerStateManager( * Truncate the producer id mapping and remove

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1106569321 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ## @@ -523,6 +537,63 @@ public void shouldRestoreMultipleBatches() {

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1106568364 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -297,6 +312,12 @@ void restoreBatch(final Collection> records) {

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1106567105 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -283,7 +293,12 @@ public void init(final StateStoreContext context,

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1430621318 Gradle 8 has been released. Have you been able to figure out why the build is failing? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] bachmanity1 commented on a diff in pull request #13246: KAFKA-14707: Improve array size check

bachmanity1 commented on code in PR #13246: URL: https://github.com/apache/kafka/pull/13246#discussion_r1106542835 ## clients/src/main/java/org/apache/kafka/common/protocol/types/ArrayOf.java: ## @@ -72,10 +74,10 @@ public Object read(ByteBuffer buffer) { else if (size

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

vcrfxia commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1106532591 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -297,6 +312,12 @@ void restoreBatch(final Collection> records) {

[GitHub] [kafka] ijuma commented on pull request #13246: KAFKA-14707: Improve array size check

ijuma commented on PR #13246: URL: https://github.com/apache/kafka/pull/13246#issuecomment-1430570552 Checking for OOM is a security issue, so we cannot do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma commented on pull request #13247: [WIP] KAFKA-14595 Move value object of ReassignPartitionsCommand to java

ijuma commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1430569601 Is `server-common` the right module? What requires access to these classes aside from `tools`? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1106482112 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -283,7 +293,12 @@ public void init(final StateStoreContext context,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

kirktrue commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1106476882 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-14717) KafkaStreams can' get running if the rebalance happens before StreamThread gets shutdown completely

[ https://issues.apache.org/jira/browse/KAFKA-14717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14717: Component/s: streams > KafkaStreams can' get running if the rebalance happens before

[GitHub] [kafka] kirktrue commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

kirktrue commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1106476284 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on pull request #12957: MINOR: Fix flaky testClientDisconnectionUpdatesRequestMetrics() (#11987)

jolshan commented on PR #12957: URL: https://github.com/apache/kafka/pull/12957#issuecomment-1430506039 Is this an issue only on 3.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] hachikuji commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

hachikuji commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1106467125 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

hachikuji commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1106464011 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13248: KAFKA-14717 KafkaStreams can' get running if the rebalance happens be…

guozhangwang commented on code in PR #13248: URL: https://github.com/apache/kafka/pull/13248#discussion_r1106408656 ## streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java: ## @@ -257,6 +258,23 @@ private Thread

[jira] [Resolved] (KAFKA-12150) Consumer group refresh not working with clustered MM2 setup

[ https://issues.apache.org/jira/browse/KAFKA-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-12150. --- Resolution: Duplicate > Consumer group refresh not working with clustered MM2 setup >

[jira] [Resolved] (KAFKA-12893) MM2 fails to replicate if starting two+ nodes same time

[ https://issues.apache.org/jira/browse/KAFKA-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-12893. --- Resolution: Duplicate > MM2 fails to replicate if starting two+ nodes same time >

[jira] [Resolved] (KAFKA-10857) Mirror Maker 2 - replication not working when deploying multiple instances

[ https://issues.apache.org/jira/browse/KAFKA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10857. --- Resolution: Duplicate > Mirror Maker 2 - replication not working when deploying multiple

[jira] [Updated] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-10586: -- Fix Version/s: 3.5.0 > Full support for distributed mode in dedicated MirrorMaker 2.0

[jira] [Resolved] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10586. --- Resolution: Done > Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

[jira] [Updated] (KAFKA-14653) MM2 should delay resolving config provider references

[ https://issues.apache.org/jira/browse/KAFKA-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14653: -- Fix Version/s: 3.5.0 > MM2 should delay resolving config provider references >

[GitHub] [kafka] C0urante merged pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

C0urante merged PR #13163: URL: https://github.com/apache/kafka/pull/13163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14718) Flaky DedicatedMirrorIntegrationTest test suite

Chris Egerton created KAFKA-14718: - Summary: Flaky DedicatedMirrorIntegrationTest test suite Key: KAFKA-14718 URL: https://issues.apache.org/jira/browse/KAFKA-14718 Project: Kafka Issue

[GitHub] [kafka] C0urante commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

C0urante commented on PR #13163: URL: https://github.com/apache/kafka/pull/13163#issuecomment-1430408893 Test failures appear unrelated (the newly-introduced dedicated MM2 integration tests seem to be flaking out on Jenkins; filed KAFKA-14718 to track). Merging... -- This is an

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes"

[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688701#comment-17688701 ] Mickael Maison commented on KAFKA-13152: Ok, I've added it to the release plan. Thanks >

[GitHub] [kafka] mattwong949 commented on pull request #13206: [KAFKA-14685] Refactor logic to handle OFFSET_MOVED_TO_TIERED_STORAGE error

mattwong949 commented on PR #13206: URL: https://github.com/apache/kafka/pull/13206#issuecomment-1430302196 sorry for the delay on any open comments, I'll be able to reply to and iterate on them by tomorrow -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] chia7712 opened a new pull request, #13248: KAFKA-14717 KafkaStreams can' get running if the rebalance happens be…

chia7712 opened a new pull request, #13248: URL: https://github.com/apache/kafka/pull/13248 I noticed this issue when tracing #12590 StreamThread closes the consumer before changing state to DEAD. If the partition rebalance happens quickly, the other StreamThreads can't change

[GitHub] [kafka] guozhangwang commented on pull request #13025: KAFKA-14299: Fix pause and resume with state updater

guozhangwang commented on PR #13025: URL: https://github.com/apache/kafka/pull/13025#issuecomment-1430280435 @lucasbru seems I forgot to send those pending comments from last week, sorry... anyways there's only one comment that I had here:

[jira] [Created] (KAFKA-14717) KafkaStreams can' get running if the rebalance happens before StreamThread gets shutdown completely

Chia-Ping Tsai created KAFKA-14717: -- Summary: KafkaStreams can' get running if the rebalance happens before StreamThread gets shutdown completely Key: KAFKA-14717 URL:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

guozhangwang commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1102201605 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -258,21 +269,27 @@ private List getTasksAndActions() {

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes"

[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688684#comment-17688684 ] Guozhang Wang commented on KAFKA-13152: --- Thanks [~mimaison], this is still quite relevant and we'd

[jira] [Commented] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688679#comment-17688679 ] Matthias J. Sax commented on KAFKA-14713: - Sounds like a duplicate to

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

guozhangwang commented on code in PR #13082: URL: https://github.com/apache/kafka/pull/13082#discussion_r1106267030 ## docs/streams/developer-guide/config-streams.html: ## @@ -778,10 +778,20 @@ rack.aware.assignment.tagsmax.warmup.replicas -

[GitHub] [kafka] C0urante commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

C0urante commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1106250177 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java: ## @@ -98,6 +104,24 @@ private boolean flushing() { return

[GitHub] [kafka] C0urante commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

C0urante commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1106236517 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -135,38 +135,40 @@ public void testFlushFailureReplacesOffsets()

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1106229439 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1106229439 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] C0urante commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

C0urante commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1106203170 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -256,14 +257,25 @@ private void maybeBeginTransaction() {

[jira] [Commented] (KAFKA-14716) Connect schema does not allow struct default values

[ https://issues.apache.org/jira/browse/KAFKA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688651#comment-17688651 ] Chris Egerton commented on KAFKA-14716: --- [~durban] is this a duplicate of KAFKA-12694? > Connect

[jira] [Updated] (KAFKA-14693) KRaft Controller and ProcessExitingFaultHandler can deadlock shutdown

[ https://issues.apache.org/jira/browse/KAFKA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14693: --- Fix Version/s: 3.5.0 > KRaft Controller and

[jira] [Resolved] (KAFKA-14693) KRaft Controller and ProcessExitingFaultHandler can deadlock shutdown

[ https://issues.apache.org/jira/browse/KAFKA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14693. Resolution: Fixed > KRaft Controller and

[GitHub] [kafka] jsancio merged pull request #13227: KAFKA-14693; Kafka node should halt instead of exit

jsancio merged PR #13227: URL: https://github.com/apache/kafka/pull/13227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

gharris1727 commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1106151656 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -16,40 +16,88 @@ */ package org.apache.kafka.connect.mirror;

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

gharris1727 commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1106151042 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -134,9 +138,9 @@ public String version() { @Override

[GitHub] [kafka] hachikuji merged pull request #13242: MINOR: Better logging to distinguish clean vs unclean loading times

hachikuji merged PR #13242: URL: https://github.com/apache/kafka/pull/13242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] urbandan commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

urbandan commented on PR #13163: URL: https://github.com/apache/kafka/pull/13163#issuecomment-1430082523 Thanks for the reviews @C0urante! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] C0urante commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

C0urante commented on PR #13163: URL: https://github.com/apache/kafka/pull/13163#issuecomment-1430077887 @urbandan Ah yes, apologies for missing that. You're right, we don't need any more coverage for the `MirrorMakerConfig` class. I also agree that the manual config transformations

[GitHub] [kafka] jolshan commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1430066349 @anatasiavela do you mind rebasing again  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-14716) Connect schema does not allow struct default values

[ https://issues.apache.org/jira/browse/KAFKA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-14716: - Description: The ConnectSchema API should allow specifying a composite (struct) default value

[jira] [Created] (KAFKA-14716) Connect schema does not allow struct default values

Daniel Urban created KAFKA-14716: Summary: Connect schema does not allow struct default values Key: KAFKA-14716 URL: https://issues.apache.org/jira/browse/KAFKA-14716 Project: Kafka Issue

[GitHub] [kafka] philipnee commented on a diff in pull request #13238: KAFKA-14708: Use Java thread instead of kafka library for example purpose

philipnee commented on code in PR #13238: URL: https://github.com/apache/kafka/pull/13238#discussion_r1106061755 ## examples/src/main/java/kafka/examples/Consumer.java: ## @@ -63,33 +63,36 @@ public Consumer(final String topic, this.numMessageToConsume =

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1106023715 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -134,9 +138,9 @@ public String version() { @Override public

[GitHub] [kafka] philipnee commented on a diff in pull request #13238: KAFKA-14708: Use Java thread instead of kafka library for example purpose

philipnee commented on code in PR #13238: URL: https://github.com/apache/kafka/pull/13238#discussion_r1106052765 ## examples/src/main/java/kafka/examples/Consumer.java: ## @@ -63,33 +63,36 @@ public Consumer(final String topic, this.numMessageToConsume =

[jira] [Updated] (KAFKA-14578) Move ConsumerPerformance to tools

[ https://issues.apache.org/jira/browse/KAFKA-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14578: Fix Version/s: 3.5.0 > Move ConsumerPerformance to tools >

[GitHub] [kafka] urbandan commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

urbandan commented on PR #13163: URL: https://github.com/apache/kafka/pull/13163#issuecomment-1429994157 Rebased the change on trunk and resolved conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] urbandan commented on pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

urbandan commented on PR #13163: URL: https://github.com/apache/kafka/pull/13163#issuecomment-1429992202 @C0urante Existing tests (testWorkerConfigs and testClientConfigProperties) already cover the config provider resolution (they use ${fake:secret:password} and FakeConfigProvider), I

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes"

[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688565#comment-17688565 ] Mickael Maison commented on KAFKA-13152: Is KIP-770 still in progress? If so do you want me to

[jira] [Updated] (KAFKA-14395) Add config to configure client supplier for KafkaStreams

[ https://issues.apache.org/jira/browse/KAFKA-14395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14395: --- Fix Version/s: 3.5.0 > Add config to configure client supplier for KafkaStreams >

[jira] [Created] (KAFKA-14715) Reduce Fetcher#parseRecord() memory copy

Mickael Maison created KAFKA-14715: -- Summary: Reduce Fetcher#parseRecord() memory copy Key: KAFKA-14715 URL: https://issues.apache.org/jira/browse/KAFKA-14715 Project: Kafka Issue Type:

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1429942230 Thanks for the review, David. I am working on adding unit tests for `OffsetCommitResponse` and the server-side handling of the request/response, and fix the bugs you have identified.

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105987099 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105985661 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[jira] [Assigned] (KAFKA-14644) Process should stop after failure in raft IO thread

[ https://issues.apache.org/jira/browse/KAFKA-14644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14644: -- Assignee: Jason Gustafson > Process should stop after failure in raft IO thread >

[jira] [Assigned] (KAFKA-14570) Problem description missing closing parenthesis symbol

[ https://issues.apache.org/jira/browse/KAFKA-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14570: -- Assignee: iamazy > Problem description missing closing parenthesis symbol >

[jira] [Assigned] (KAFKA-14564) Upgrade Netty to 4.1.86.Final to fix CVEs

[ https://issues.apache.org/jira/browse/KAFKA-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14564: -- Assignee: Brendan Ribera > Upgrade Netty to 4.1.86.Final to fix CVEs >

[jira] [Assigned] (KAFKA-13632) MirrorMaker 2.0 NPE and Warning "Failure to commit records" for filtered records

[ https://issues.apache.org/jira/browse/KAFKA-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-13632: -- Assignee: Rens Groothuijsen > MirrorMaker 2.0 NPE and Warning "Failure to commit

[jira] [Assigned] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14646: -- Assignee: Matthias J. Sax > SubscriptionWrapper is of an incompatible version (Kafka

[jira] [Assigned] (KAFKA-14236) ListGroups request produces too much Denied logs in authorizer

[ https://issues.apache.org/jira/browse/KAFKA-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14236: -- Assignee: Alexandre GRIFFAUT > ListGroups request produces too much Denied logs in

[jira] [Assigned] (KAFKA-14225) lazy val exemptSensor Could Cause Deadlock

[ https://issues.apache.org/jira/browse/KAFKA-14225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14225: -- Assignee: Huilin Shi > lazy val exemptSensor Could Cause Deadlock >

[jira] [Resolved] (KAFKA-14696) CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack via SASL JAAS JndiLoginModule configuration using Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14696. Resolution: Fixed > CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack

[jira] [Updated] (KAFKA-14696) CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack via SASL JAAS JndiLoginModule configuration using Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14696: --- Fix Version/s: 3.4.0 > CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack

[jira] [Updated] (KAFKA-14696) CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack via SASL JAAS JndiLoginModule configuration using Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14696: --- Fix Version/s: (was: 3.4.0) > CVE-2023-25194: Apache Kafka: Possible RCE/Denial of

[GitHub] [kafka] nizhikov commented on pull request #13247: [WIP] KAFKA-14595 Move value object of ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1429798487 @mimaison This PR is a first part of moving `ReassignPartitionsCommand` to java and `tools` module. Can you, please, take a look? -- This is an automated message from the

[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105855843 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105854122 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105846605 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel,

[jira] [Created] (KAFKA-14714) Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

Satish Duggana created KAFKA-14714: -- Summary: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module. Key: KAFKA-14714 URL: https://issues.apache.org/jira/browse/KAFKA-14714

[jira] [Commented] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688492#comment-17688492 ] Nikolay Izhikov commented on KAFKA-14595: - > I move the `PartitionReassignmentState` class into

[GitHub] [kafka] satishd commented on pull request #13235: MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.

satishd commented on PR #13235: URL: https://github.com/apache/kafka/pull/13235#issuecomment-1429693785 Thanks @showuon for your review. > Overall LGTM! But do you think we should add a null `producerStateEntry` test case? Can you be more specific about the test case you are

[jira] [Created] (KAFKA-14713) Kafka Streams global table startup takes too long

Tamas created KAFKA-14713: - Summary: Kafka Streams global table startup takes too long Key: KAFKA-14713 URL: https://issues.apache.org/jira/browse/KAFKA-14713 Project: Kafka Issue Type: Bug

[GitHub] [kafka] cadonna commented on a diff in pull request #13127: KAFKA-14586: Moving StreamResetter to tools

cadonna commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1105688687 ## streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java: ## @@ -16,7 +16,7 @@ */ package org.apache.kafka.streams.tools; -import

[GitHub] [kafka] cadonna commented on a diff in pull request #13127: KAFKA-14586: Moving StreamResetter to tools

cadonna commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1105688687 ## streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java: ## @@ -16,7 +16,7 @@ */ package org.apache.kafka.streams.tools; -import

[GitHub] [kafka] cadonna commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

cadonna commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1105612105 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ReadOnlyTask.java: ## @@ -190,7 +190,7 @@ public void clearTaskTimeout() { @Override

[jira] [Commented] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688429#comment-17688429 ] Nikolay Izhikov commented on KAFKA-14595: - Hello To reduce changes and make them reviewable I

  1   2   >