vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1108126016
##
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java:
##
@@ -16,7 +16,7 @@
*/
package org.apache.kafka.streams.tools;
-import
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1432614316
@fvaleri , I fixed the above error. Some of the containers had died because
of which the error occurred. I have a clean run of the system test now:
```
[
https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas resolved KAFKA-14713.
---
Fix Version/s: 3.4.0
Resolution: Invalid
> Kafka Streams global table startup takes too long
>
[
https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689533#comment-17689533
]
Tamas edited comment on KAFKA-14713 at 2/16/23 5:51 AM:
Entry point would be the
[
https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689533#comment-17689533
]
Tamas commented on KAFKA-14713:
---
Entry point would be the
[
https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas updated KAFKA-14713:
--
Affects Version/s: 3.0.2
> Kafka Streams global table startup takes too long
>
Satish Duggana created KAFKA-14726:
--
Summary: Move/rewrite LogReadInfo, LogOffsetSnapshot, and
LogStartOffsetIncrementReason to storage module.
Key: KAFKA-14726
URL:
gharris1727 commented on PR #13178:
URL: https://github.com/apache/kafka/pull/13178#issuecomment-1432451859
Unfortunately those test failures only appear in the EOS test and appear to
be caused by EOS mode.
This is because MM2 doesn't do the periodic background commits that the
offset
[
https://issues.apache.org/jira/browse/KAFKA-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-14708.
---
Fix Version/s: 3.5.0
Resolution: Fixed
> Remove kafka.examples.Consumer dependancy on
showuon merged PR #13238:
URL: https://github.com/apache/kafka/pull/13238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1107962390
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -389,22 +389,27 @@ public void logUnused() {
private T
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1107961671
##
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##
@@ -599,6 +624,31 @@ public TestConfig(Map props) {
}
}
+private
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689450#comment-17689450
]
Chris Egerton edited comment on KAFKA-5756 at 2/16/23 2:53 AM:
---
I've merged
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-5756:
-
Fix Version/s: 3.3.3
> Synchronization issue on flush
> --
>
>
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-5756:
-
Fix Version/s: 3.4.1
> Synchronization issue on flush
> --
>
>
C0urante commented on PR #13178:
URL: https://github.com/apache/kafka/pull/13178#issuecomment-1432402907
Hmmm... there appear to be some integration test failures. I've reproduced
some of them locally too, which makes flakiness an unlikely cause. Can you look
into the integration test
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689450#comment-17689450
]
Chris Egerton edited comment on KAFKA-5756 at 2/16/23 2:30 AM:
---
I've merged
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689450#comment-17689450
]
Chris Egerton commented on KAFKA-5756:
--
I've merged Greg's fix and updated the fix version to 3.5.0,
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689450#comment-17689450
]
Chris Egerton edited comment on KAFKA-5756 at 2/16/23 2:30 AM:
---
I've merged
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-5756.
--
Resolution: Fixed
> Synchronization issue on flush
> --
>
>
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-5756:
-
Fix Version/s: 3.5.0
(was: 1.0.0)
(was: 0.11.0.1)
C0urante merged PR #13208:
URL: https://github.com/apache/kafka/pull/13208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #13208:
URL: https://github.com/apache/kafka/pull/13208#issuecomment-1432384080
Test failures are unrelated; merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax merged PR #13249:
URL: https://github.com/apache/kafka/pull/13249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #13249:
URL: https://github.com/apache/kafka/pull/13249#discussion_r1107868729
##
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampDeserializer.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
mjsax commented on code in PR #13249:
URL: https://github.com/apache/kafka/pull/13249#discussion_r1107868286
##
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerializer.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1107930541
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1249,7 +1263,7 @@ private ConsumerRecords poll(final Timer timer,
final
mjsax merged PR #13243:
URL: https://github.com/apache/kafka/pull/13243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirktrue commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1107920860
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java:
##
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1107920411
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java:
##
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1107920035
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java:
##
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation
guozhangwang commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107858293
##
clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequestTest.java:
##
@@ -17,43 +17,138 @@
package org.apache.kafka.common.requests;
mjsax commented on code in PR #13249:
URL: https://github.com/apache/kafka/pull/13249#discussion_r1107869144
##
streams/src/test/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerdeTest.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software
mjsax commented on code in PR #13249:
URL: https://github.com/apache/kafka/pull/13249#discussion_r1107868729
##
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampDeserializer.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
mjsax commented on code in PR #13249:
URL: https://github.com/apache/kafka/pull/13249#discussion_r1107868286
##
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerializer.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #13253:
URL: https://github.com/apache/kafka/pull/13253#discussion_r1107866090
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -637,8 +638,12 @@ private boolean
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14722:
Description: We introduce a "BooleanSerde" via
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689401#comment-17689401
]
Matthias J. Sax commented on KAFKA-14722:
-
Thanks for you interest. We will need a KIP for this
kirktrue commented on code in PR #13192:
URL: https://github.com/apache/kafka/pull/13192#discussion_r1107862255
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java:
##
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation
guozhangwang commented on code in PR #13253:
URL: https://github.com/apache/kafka/pull/13253#discussion_r1107854555
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -637,8 +638,12 @@ private boolean
jolshan commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1107851690
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -318,6 +358,25 @@ class Partition(val topicPartition: TopicPartition,
def inSyncReplicaIds: Set[Int] =
jolshan commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1107850529
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -285,6 +314,17 @@ class Partition(val topicPartition: TopicPartition,
// If ReplicaAlterLogDir command
jolshan commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1107850529
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -285,6 +314,17 @@ class Partition(val topicPartition: TopicPartition,
// If ReplicaAlterLogDir command
hachikuji commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1107792509
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -44,11 +44,40 @@ import org.apache.kafka.common.utils.Time
import
jeffkbkim commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107838433
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends
vcrfxia commented on code in PR #13249:
URL: https://github.com/apache/kafka/pull/13249#discussion_r1107815109
##
streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerde.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689379#comment-17689379
]
Spacrocket edited comment on KAFKA-14722 at 2/15/23 10:44 PM:
--
Hello
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689379#comment-17689379
]
RockieRockie commented on KAFKA-14722:
--
Hello everyone, I would like to take this ticket :)
> Make
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
RockieRockie reassigned KAFKA-14722:
Assignee: RockieRockie
> Make BooleanSerde public
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-14664:
Fix Version/s: 3.5.0
> Raft idle ratio is inaccurate
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-14664.
-
Resolution: Fixed
> Raft idle ratio is inaccurate
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-14664:
Affects Version/s: 3.3.2
3.3.1
3.4.0
hachikuji merged PR #13207:
URL: https://github.com/apache/kafka/pull/13207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107785855
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java:
##
@@ -99,6 +112,7 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs)
philipnee commented on PR #13253:
URL: https://github.com/apache/kafka/pull/13253#issuecomment-1432116469
Ideally, we want "1 member" or "n member**s**". But we don't need this much
grammatical optimization.
--
This is an automated message from the Apache Git Service.
To respond
philipnee commented on PR #13238:
URL: https://github.com/apache/kafka/pull/13238#issuecomment-1432105559
The failing tests seem unrelated:
```
Build / JDK 11 and Scala 2.13 / [2] tlsProtocol=TLSv1.2, useInlinePem=true –
org.apache.kafka.common.network.SslTransportLayerTest
15s
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107771622
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -66,24 +97,22 @@ public Builder(final String transactionalId,
hachikuji commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107764891
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {
hachikuji commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107762271
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java:
##
@@ -99,6 +112,7 @@ public void maybeSetThrottleTimeMs(int
[
https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689356#comment-17689356
]
Matthias J. Sax edited comment on KAFKA-14713 at 2/15/23 9:44 PM:
--
What
[
https://issues.apache.org/jira/browse/KAFKA-14725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14725:
--
Summary: Improve cancellation semantics for connector tasks (was: Improve
cancellation
hachikuji commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107760565
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java:
##
@@ -49,28 +52,37 @@ public class AddPartitionsToTxnResponse extends
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107759662
##
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##
@@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107759481
##
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##
@@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
hachikuji commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107759467
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -66,24 +97,22 @@ public Builder(final String transactionalId,
[
https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689356#comment-17689356
]
Matthias J. Sax commented on KAFKA-14713:
-
What version are you using? – Also, can you point me
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107757784
##
clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json:
##
@@ -22,22 +22,35 @@
// Version 2 adds the support for new error code
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107757784
##
clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json:
##
@@ -22,22 +22,35 @@
// Version 2 adds the support for new error code
C0urante commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1107747315
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -389,22 +389,27 @@ public void logUnused() {
private T
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107751395
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java:
##
@@ -49,28 +52,37 @@ public class AddPartitionsToTxnResponse extends
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107751863
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java:
##
@@ -99,6 +112,7 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs)
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107748914
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107748914
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107748914
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107747037
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -66,24 +97,22 @@ public Builder(final String transactionalId,
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107745666
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107745160
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107744819
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends
C0urante commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1432056618
@urbandan I don't think I follow what you mean by "Use the Schema methods";
it might be easier to illustrate with a code snippet?
I'm not really in favor of removing the
Chris Egerton created KAFKA-14725:
-
Summary: Improve cancellation semantics for source tasks
Key: KAFKA-14725
URL: https://issues.apache.org/jira/browse/KAFKA-14725
Project: Kafka
Issue
mjsax commented on code in PR #13243:
URL: https://github.com/apache/kafka/pull/13243#discussion_r1107711967
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java:
##
@@ -523,6 +537,63 @@ public void shouldRestoreMultipleBatches() {
mjsax commented on code in PR #13243:
URL: https://github.com/apache/kafka/pull/13243#discussion_r1107707006
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -458,8 +460,22 @@ public void writeLatestValues(final WriteBatch
mjsax commented on code in PR #13243:
URL: https://github.com/apache/kafka/pull/13243#discussion_r1107705172
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java:
##
@@ -523,6 +537,63 @@ public void shouldRestoreMultipleBatches() {
mjsax commented on code in PR #13243:
URL: https://github.com/apache/kafka/pull/13243#discussion_r1107704159
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -283,7 +293,12 @@ public void init(final StateStoreContext context,
vcrfxia commented on code in PR #13252:
URL: https://github.com/apache/kafka/pull/13252#discussion_r1107700533
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java:
##
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software
C0urante commented on code in PR #13191:
URL: https://github.com/apache/kafka/pull/13191#discussion_r1107510674
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java:
##
@@ -235,115 +236,100 @@ public void testMetricsGroup() {
vcrfxia commented on PR #13243:
URL: https://github.com/apache/kafka/pull/13243#issuecomment-1431970157
> One more thought: should we add verification about the
"droppedRecordSensor" into all unit tests that drop records?
Included this test update in the latest commit. I believe I've
vcrfxia commented on code in PR #13243:
URL: https://github.com/apache/kafka/pull/13243#discussion_r1107672610
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -283,7 +293,12 @@ public void init(final StateStoreContext context,
gharris1727 commented on code in PR #13208:
URL: https://github.com/apache/kafka/pull/13208#discussion_r1107669147
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java:
##
@@ -100,23 +104,45 @@ private boolean flushing() {
/**
gharris1727 commented on code in PR #13208:
URL: https://github.com/apache/kafka/pull/13208#discussion_r1107664475
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##
@@ -135,38 +135,40 @@ public void
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107662689
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -66,24 +97,22 @@ public Builder(final String transactionalId,
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107662160
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -101,15 +130,61 @@ public String toString() {
public
hachikuji commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107606857
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends
jeffkbkim commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107649386
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -101,15 +130,61 @@ public String toString() {
public
jeffkbkim commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1107649386
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -101,15 +130,61 @@ public String toString() {
public
gharris1727 commented on code in PR #13178:
URL: https://github.com/apache/kafka/pull/13178#discussion_r1107647929
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##
@@ -578,7 +551,7 @@ public void
Kirk True created KAFKA-14724:
-
Summary: Port tests in FetcherTest to FetchRequestManagerTest
Key: KAFKA-14724
URL: https://issues.apache.org/jira/browse/KAFKA-14724
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14274:
--
Parent: (was: KAFKA-14246)
Issue Type: Improvement (was: Sub-task)
> Introduce
[
https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14274:
--
Summary: Introduce FetchRequestManager to integrate fetch into new consumer
threading refactor (was:
gharris1727 commented on code in PR #13178:
URL: https://github.com/apache/kafka/pull/13178#discussion_r1107634292
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java:
##
@@ -30,7 +30,7 @@ public class OffsetSyncStoreTest {
static class
1 - 100 of 180 matches
Mail list logo
