[GitHub] [kafka] kowshik commented on pull request #13272: MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

kowshik commented on PR #13272: URL: https://github.com/apache/kafka/pull/13272#issuecomment-1435489782 @junrao Thanks for the review! I've addressed the comment in bc94d6d3a7a541e5d84d735b45ea4435f63a0974. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] kowshik commented on a diff in pull request #13272: MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

kowshik commented on code in PR #13272: URL: https://github.com/apache/kafka/pull/13272#discussion_r1110637054 ## core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala: ## @@ -118,6 +120,46 @@ class LocalLeaderEndPointTest { assertEquals((4, 3L),

[GitHub] [kafka] RivenSun2 commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

RivenSun2 commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1435480289 @showuon Thanks for your suggestions! To be honest, I also considered throwing an exception directly in the `timeToNextHeartbeat` method before, because this is also done in the

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1435477923 Moving the time check just broke a bunch of unit test  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] philipnee commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

philipnee commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1435476445 Hey! Just to chime in here: I like the idea of throwing an exception there and it seems fairly straightforward. To restart the heartbeat thread, is it sufficient to do that on

[GitHub] [kafka] showuon commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

showuon commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1435470639 > In general I think if the background thread dies for whatever the reason we should consider the following actions in precedence: 1. Make sure the consumer now falls into an

[GitHub] [kafka] RivenSun2 commented on pull request #11976: KAFKA-13771: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

RivenSun2 commented on PR #11976: URL: https://github.com/apache/kafka/pull/11976#issuecomment-1435465075 added test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110472349 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110472349 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110474085 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110473150 ## server-common/src/main/java/org/apache/kafka/server/common/ProducerIdsBlock.java: ## @@ -32,11 +34,25 @@ public class ProducerIdsBlock { private final int

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110472349 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] RivenSun2 commented on pull request #11976: KAFKA-13771: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

RivenSun2 commented on PR #11976: URL: https://github.com/apache/kafka/pull/11976#issuecomment-1435435497 @omkreddy Thank you very much for your reply. I will add testCase later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] RivenSun2 commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

RivenSun2 commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-143540 Hi @guozhangwang thank you for your reply. Can we introduce a state like "ABNORMAL" in a new PR, this state may only appear on consumers with heartbeat threads (group.id!=null).

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110464884 ## server-common/src/main/java/org/apache/kafka/server/common/ProducerIdsBlock.java: ## @@ -32,11 +34,25 @@ public class ProducerIdsBlock { private final int

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110463718 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1110458817 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java: ## @@ -17,23 +17,30 @@ package

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1110458455 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/KeyValueStoreMaterializerTest.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1110458195 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilderTest.java: ## @@ -154,17 +154,34 @@ public void

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1110457053 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractReadOnlyDecorator.java: ## @@ -68,6 +70,8 @@ public void close() { static StateStore

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1110456636 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java: ## @@ -48,20 +55,30 @@ public StoreBuilder> materialize() {

[GitHub] [kafka] hachikuji commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

hachikuji commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1110454390 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -252,6 +230,11 @@ public void teardown() throws Exception { }

[GitHub] [kafka] vcrfxia opened a new pull request, #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia opened a new pull request, #13274: URL: https://github.com/apache/kafka/pull/13274 (This PR is stacked on https://github.com/apache/kafka/pull/13251, https://github.com/apache/kafka/pull/13252, and https://github.com/apache/kafka/pull/13264. The first three commits on this PR do

[GitHub] [kafka] hachikuji commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

hachikuji commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1110451696 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcher.java: ## @@ -0,0 +1,717 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

hachikuji commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1110451025 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1269,6 +1283,11 @@ private ConsumerRecords poll(final Timer timer, final

[GitHub] [kafka] hachikuji commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

hachikuji commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1110445520 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1249,7 +1263,7 @@ private ConsumerRecords poll(final Timer timer, final

[GitHub] [kafka] hachikuji commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

hachikuji commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110443918 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] hachikuji commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

hachikuji commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110442234 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110442122 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] hachikuji commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

hachikuji commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110441561 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] kirktrue commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

kirktrue commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1110423708 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcher.java: ## @@ -0,0 +1,717 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-13659) MM2 should read all offset syncs at start up

[ https://issues.apache.org/jira/browse/KAFKA-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13659. --- Fix Version/s: 3.5.0 Resolution: Fixed > MM2 should read all offset syncs at start

[jira] [Resolved] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-12566. --- Fix Version/s: 3.5.0 Resolution: Fixed > Flaky Test

[GitHub] [kafka] C0urante merged pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante merged PR #13178: URL: https://github.com/apache/kafka/pull/13178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14680) Gradle version upgrade 7 -->> 8

[ https://issues.apache.org/jira/browse/KAFKA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-14680: --- Description: +*Gradle 8 release notes:*+ * {*}{*}{*}8.0:{*} **

[jira] [Updated] (KAFKA-14680) Gradle version upgrade 7 -->> 8

[ https://issues.apache.org/jira/browse/KAFKA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-14680: --- Description: *Gradle 8 release notes:* *

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1110327711 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1435229905 Thanks, @guozhangwang, that's my understanding as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mjsax commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

mjsax commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1110240934 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-14442) GlobalKTable restoration waits requestTimeout during application restart

[ https://issues.apache.org/jira/browse/KAFKA-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690563#comment-17690563 ] Matthias J. Sax commented on KAFKA-14442: - Just learned about

[jira] [Resolved] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14713. - Resolution: Fixed > Kafka Streams global table startup takes too long >

[jira] [Commented] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690560#comment-17690560 ] Matthias J. Sax commented on KAFKA-14713: - Ah. Thanks. That makes sense. Did not look into the

[jira] [Reopened] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reopened KAFKA-14713: - > Kafka Streams global table startup takes too long >

[jira] [Updated] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14713: Fix Version/s: 3.2.0 (was: 3.4.0) > Kafka Streams global table

[GitHub] [kafka] junrao commented on a diff in pull request #13272: MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

junrao commented on code in PR #13272: URL: https://github.com/apache/kafka/pull/13272#discussion_r1110288858 ## core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala: ## @@ -118,6 +120,46 @@ class LocalLeaderEndPointTest { assertEquals((4, 3L),

[GitHub] [kafka] junrao commented on a diff in pull request #13268: MINOR: Introduce OffsetAndEpoch in LeaderEndpoint interface return values

junrao commented on code in PR #13268: URL: https://github.com/apache/kafka/pull/13268#discussion_r1110272453 ## core/src/main/scala/kafka/server/OffsetAndEpoch.scala: ## @@ -0,0 +1,24 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110270761 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110268297 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] ijuma commented on a diff in pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

ijuma commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1110263293 ## core/src/test/scala/other/kafka/StressTestLog.scala: ## @@ -123,7 +123,8 @@ object StressTestLog { class WriterThread(val log: UnifiedLog) extends WorkerThread

[GitHub] [kafka] ijuma commented on a diff in pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

ijuma commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1110263293 ## core/src/test/scala/other/kafka/StressTestLog.scala: ## @@ -123,7 +123,8 @@ object StressTestLog { class WriterThread(val log: UnifiedLog) extends WorkerThread

[jira] [Resolved] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14623. --- Resolution: Fixed > OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging >

[jira] [Comment Edited] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690543#comment-17690543 ] Kirk True edited comment on KAFKA-14623 at 2/17/23 7:31 PM: -Reopening to

[jira] [Updated] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14623: -- Affects Version/s: (was: 3.1.0) (was: 3.2.0)

[GitHub] [kafka] junrao commented on a diff in pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

junrao commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1110260488 ## core/src/test/scala/other/kafka/StressTestLog.scala: ## @@ -123,7 +123,8 @@ object StressTestLog { class WriterThread(val log: UnifiedLog) extends WorkerThread

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110247044 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequestTest.java: ## @@ -17,43 +17,138 @@ package org.apache.kafka.common.requests;

[jira] [Reopened] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-14623: --- Reopening to fix in 3.1.x and 3.2.x branches. > OAuth's HttpAccessTokenRetriever potentially leaks

[jira] [Updated] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14623: -- Affects Version/s: 3.3.2 3.2.3 3.2.2

[GitHub] [kafka] mjsax merged pull request #13250: KAFKA-14491: [9/N] Add versioned bytes store and supplier

mjsax merged PR #13250: URL: https://github.com/apache/kafka/pull/13250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rondagostino opened a new pull request, #13273: KAFKA-14731: Upgrade ZooKeeper to 3.6.4

rondagostino opened a new pull request, #13273: URL: https://github.com/apache/kafka/pull/13273 We have https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-14661 opened to upgrade ZooKeeper from 3.6.3 to 3.8.1, and that will likely be actioned in time for 3.5.0. But in the meantime,

[jira] [Comment Edited] (KAFKA-14731) Upgrade ZooKeeper to 3.6.4

[ https://issues.apache.org/jira/browse/KAFKA-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690531#comment-17690531 ] Ron Dagostino edited comment on KAFKA-14731 at 2/17/23 6:39 PM: Fixes in

[jira] [Commented] (KAFKA-14731) Upgrade ZooKeeper to 3.6.4

[ https://issues.apache.org/jira/browse/KAFKA-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690531#comment-17690531 ] Ron Dagostino commented on KAFKA-14731: --- Fixes in 3.6.4:

[jira] [Created] (KAFKA-14731) Upgrade ZooKeeper to 3.6.4

Ron Dagostino created KAFKA-14731: - Summary: Upgrade ZooKeeper to 3.6.4 Key: KAFKA-14731 URL: https://issues.apache.org/jira/browse/KAFKA-14731 Project: Kafka Issue Type: Task Affects

[jira] [Updated] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-14661: -- Fix Version/s: (was: 3.4.1) (was: 3.3.3) > Upgrade Zookeeper to

[jira] [Comment Edited] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690451#comment-17690451 ] Demetrius Kellum edited comment on KAFKA-14698 at 2/17/23 6:01 PM: --- I

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110139153 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110117577 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110117043 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] C0urante commented on pull request #13262: KAFKA-14727: Enable periodic offset commits for EOS source tasks

C0urante commented on PR #13262: URL: https://github.com/apache/kafka/pull/13262#issuecomment-1434971635 Addressed the Mockito migration issues and backported to 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (KAFKA-14727) Connect EOS mode should periodically call task commit

[ https://issues.apache.org/jira/browse/KAFKA-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14727: -- Fix Version/s: 3.3.3 > Connect EOS mode should periodically call task commit >

[GitHub] [kafka] kowshik commented on pull request #13272: MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

kowshik commented on PR #13272: URL: https://github.com/apache/kafka/pull/13272#issuecomment-1434942445 Hi @junrao / @satishd / @mattwong949 -- Please could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] kowshik opened a new pull request, #13272: MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

kowshik opened a new pull request, #13272: URL: https://github.com/apache/kafka/pull/13272 I've added unit tests that were previously missing for the `LeaderEndpoint.fetchEpochEndOffsets()` public method. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

guozhangwang commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1434909837 As for this PR, I'm actually thinking if it makes sense to introduce a new state inside `MemberState`, e.g. "ABNORMAL" to indicate that the consumer is not usable at the moment ---

[GitHub] [kafka] guozhangwang commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

guozhangwang commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1434906588 This is an interesting find, thanks @RivenSun2 . In general I think if the background thread dies for whatever the reason we should consider the following actions in precedence:

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110062885 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] guozhangwang commented on pull request #13248: KAFKA-14717 KafkaStreams can' get running if the rebalance happens be…

guozhangwang commented on PR #13248: URL: https://github.com/apache/kafka/pull/13248#issuecomment-1434895998 LGTM. Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] guozhangwang merged pull request #13248: KAFKA-14717 KafkaStreams can' get running if the rebalance happens be…

guozhangwang merged PR #13248: URL: https://github.com/apache/kafka/pull/13248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #13025: KAFKA-14299: Fix pause and resume with state updater

guozhangwang commented on PR #13025: URL: https://github.com/apache/kafka/pull/13025#issuecomment-1434891336 @lucasbru the pause/ resume integration test fails again for J11/S13, could you take a look into it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mimaison commented on pull request #13266: MINOR: Fix PluginInfoTest for Connect

mimaison commented on PR #13266: URL: https://github.com/apache/kafka/pull/13266#issuecomment-1434850103 My bad, I thought I ran tests on all changed classes but clearly I missed some. Thanks @C0urante for the quick fix! -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on a diff in pull request #12990: KAFKA-14451: Rack-aware consumer partition assignment for RangeAssignor (KIP-881)

dajac commented on code in PR #12990: URL: https://github.com/apache/kafka/pull/12990#discussion_r1109783046 ## clients/src/main/java/org/apache/kafka/clients/consumer/RangeAssignor.java: ## @@ -63,9 +76,19 @@ * I0: [t0p0, t0p1, t1p0, t1p1] * I1: [t0p2, t1p2] * + * + *

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690451#comment-17690451 ] Demetrius Kellum commented on KAFKA-14698: -- I encountered a similar issue.  I was upgrading to

[GitHub] [kafka] C0urante commented on pull request #13266: MINOR: Fix PluginInfoTest for Connect

C0urante commented on PR #13266: URL: https://github.com/apache/kafka/pull/13266#issuecomment-1434814552 @clolov No worries :) It may be worth checking the CI build results for your PRs in the future. I know it can be tricky to tell sometimes if a test failure is due to flakiness or

[GitHub] [kafka] C0urante merged pull request #13266: MINOR: Fix PluginInfoTest for Connect

C0urante merged PR #13266: URL: https://github.com/apache/kafka/pull/13266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on pull request #13266: MINOR: Fix PluginInfoTest for Connect

C0urante commented on PR #13266: URL: https://github.com/apache/kafka/pull/13266#issuecomment-1434809151 Since this is causing build failures on trunk and, with the exception of a two-line comment, the changes revert the test class in question to its last green state, I'm going to merge

[GitHub] [kafka] C0urante commented on a diff in pull request #13266: MINOR: Fix PluginInfoTest for Connect

C0urante commented on code in PR #13266: URL: https://github.com/apache/kafka/pull/13266#discussion_r1109946722 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfoTest.java: ## @@ -19,17 +19,19 @@ import

[jira] [Commented] (KAFKA-14730) Move AdminOperationException to server-commons

[ https://issues.apache.org/jira/browse/KAFKA-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690407#comment-17690407 ] Nikolay Izhikov commented on KAFKA-14730: - Hello [~mimaison]. Can you, please, take a look at

[GitHub] [kafka] nizhikov commented on pull request #13271: KAFKA-14730 AdminOperationException moved to java

nizhikov commented on PR #13271: URL: https://github.com/apache/kafka/pull/13271#issuecomment-1434682486 @mimaison Can you, please, take a look at my changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] nizhikov opened a new pull request, #13271: KAFKA-14730 AdminOperationException moved to java

nizhikov opened a new pull request, #13271: URL: https://github.com/apache/kafka/pull/13271 This PR moves `AdminOperationException` class to java ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] hgeraldino commented on pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

hgeraldino commented on PR #13191: URL: https://github.com/apache/kafka/pull/13191#issuecomment-1434672313 Thanks for the thorough review @C0urante! I'll get to it right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-14730) Move AdminOperationException to server-commons

[ https://issues.apache.org/jira/browse/KAFKA-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14730: --- Assignee: Nikolay Izhikov > Move AdminOperationException to server-commons >

[jira] [Created] (KAFKA-14730) Move AdminOperationException to server-commons

Nikolay Izhikov created KAFKA-14730: --- Summary: Move AdminOperationException to server-commons Key: KAFKA-14730 URL: https://issues.apache.org/jira/browse/KAFKA-14730 Project: Kafka Issue

[GitHub] [kafka] tinaselenge commented on pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

tinaselenge commented on PR #13102: URL: https://github.com/apache/kafka/pull/13102#issuecomment-1434560483 Can this please be merged now? Or should we wait for responses to @ijuma's question? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] satishd commented on a diff in pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1109509032 ## core/src/test/scala/other/kafka/StressTestLog.scala: ## @@ -123,7 +123,8 @@ object StressTestLog { class WriterThread(val log: UnifiedLog) extends WorkerThread

[GitHub] [kafka] satishd commented on pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd commented on PR #13255: URL: https://github.com/apache/kafka/pull/13255#issuecomment-1434476881 Thanks @junrao for the review. Addressed the review comments inline and/or updated with the latest commits. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] satishd commented on a diff in pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1109631097 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Assigned] (KAFKA-14591) Move DeleteRecordsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14591: --- Assignee: Nikolay Izhikov (was: Mickael Maison) > Move DeleteRecordsCommand to

[jira] [Commented] (KAFKA-14591) Move DeleteRecordsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690310#comment-17690310 ] Mickael Maison commented on KAFKA-14591: Sure > Move DeleteRecordsCommand to tools >

[jira] [Commented] (KAFKA-14591) Move DeleteRecordsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690295#comment-17690295 ] Nikolay Izhikov commented on KAFKA-14591: - Hello, [~mimaison] Can I assign this ticket to

[GitHub] [kafka] satishd commented on a diff in pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1109509032 ## core/src/test/scala/other/kafka/StressTestLog.scala: ## @@ -123,7 +123,8 @@ object StressTestLog { class WriterThread(val log: UnifiedLog) extends WorkerThread

[GitHub] [kafka] RivenSun2 commented on pull request #11976: KAFKA-13771: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

RivenSun2 commented on PR #11976: URL: https://github.com/apache/kafka/pull/11976#issuecomment-1434365248 Hi @omkreddy could you help to review the PR? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] RivenSun2 commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

RivenSun2 commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1434359335 Hi @guozhangwang @showuon please help to review PR when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >