showuon commented on code in PR #13261:
URL: https://github.com/apache/kafka/pull/13261#discussion_r1113935551
##
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java:
##
@@ -688,8 +688,10 @@ public Object read(ByteBuffer buffer) {
if (size >
showuon merged PR #13100:
URL: https://github.com/apache/kafka/pull/13100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-12549:
---
Assignee: (was: Alex Sorokoumov)
> Allow state stores to opt-in transactional
[
https://issues.apache.org/jira/browse/KAFKA-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-13024:
---
Assignee: (was: Alex Sorokoumov)
> Kafka Streams is dropping messages with
mjsax closed pull request #11447: KAFKA-13024
URL: https://github.com/apache/kafka/pull/11447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
inglor commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439289819
@ijuma Thanks for the pointer - I have missed that.
@dejan2609 I can confirm your cdbb59fad79b4296b2095417274050b7f1ea1698 works
fine (as in it compiles the scala code) for
gharris1727 opened a new pull request, #13287:
URL: https://github.com/apache/kafka/pull/13287
The condition to check for whether task configs has changed is duplicated in
the Standalone and Distributed Herder classes.
This change refactors the implementation from DistributedHerder to
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1113713186
##
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##
@@ -633,13 +669,18 @@ class AbstractFetcherThreadTest {
mkBatch(baseOffset = 7,
dejan2609 commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439274615
@inglor thanx for stopping by, any insight or help is much appreciated!
@ijuma I scrapped fast solution that, suprisingly enough, works (at least
compilation is succesful, that
gharris1727 opened a new pull request, #13286:
URL: https://github.com/apache/kafka/pull/13286
The indentation for this constructor is sometimes compact and sometimes
expanded.
In order to make other changes easier to review, reformat each of these
constructor call-sites to be expanded.
[
https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-9803:
--
Assignee: (was: Boyang Chen)
> Allow producers to recover gracefully from
ijuma commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439267357
@inglor Thanks. The following comment explains that the way `-release` must
be set is a bit specific:
https://github.com/gradle/gradle/issues/23962#issuecomment-1437348400
--
This
inglor commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439265302
> Thanks @dejan2609. I still prefer the path I described here:
>
> > [gradle/gradle#23962
(comment)](https://github.com/gradle/gradle/issues/23962#issuecomment-1439115365)
>
[
https://issues.apache.org/jira/browse/KAFKA-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691832#comment-17691832
]
Ismael Juma commented on KAFKA-14737:
-
It makes sense to have a similar class in `server-common`,
philipnee commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1113694079
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -155,7 +155,7 @@ private enum State {
private boolean
guozhangwang commented on code in PR #13228:
URL: https://github.com/apache/kafka/pull/13228#discussion_r1113677550
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -109,17 +136,41 @@ public void run() {
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1113664534
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -683,33 +655,24 @@ abstract class AbstractFetcherThread(name: String,
* produced to
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1113664534
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -683,33 +655,24 @@ abstract class AbstractFetcherThread(name: String,
* produced to
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1113664441
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -400,12 +386,7 @@ abstract class AbstractFetcherThread(name: String,
case
ijuma commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439211043
Thanks @dejan2609. I still prefer the path I described here:
> https://github.com/gradle/gradle/issues/23962#issuecomment-1439115365
Do you know if that works?
--
This is an
philipnee commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1113642114
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -300,9 +301,13 @@ void runOnce() {
try {
mjsax commented on code in PR #13252:
URL: https://github.com/apache/kafka/pull/13252#discussion_r1110445053
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-14737:
-
Assignee: Omnia Ibrahim
> Move kafka.utils.json to server-common
>
jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1113612843
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -155,7 +155,7 @@ private enum State {
private boolean
Colin Shaw created KAFKA-14739:
--
Summary: Kafka consumer reading messages out of order after a
rebalance
Key: KAFKA-14739
URL: https://issues.apache.org/jira/browse/KAFKA-14739
Project: Kafka
philipnee commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1113611801
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -155,7 +155,7 @@ private enum State {
private boolean
dejan2609 commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439140880
@ijuma Good news, it seems that I managed to provide a workaround for Gradle
8.0.1 (and across all JDK/Scala versions that Apache Kafka uses and the moment).
I still need to test few
scholzj commented on PR #13216:
URL: https://github.com/apache/kafka/pull/13216#issuecomment-1439131216
@mimaison @fvaleri Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kowshik commented on PR #13268:
URL: https://github.com/apache/kafka/pull/13268#issuecomment-1439126402
@Hangleton Thanks for the review. I have addressed the comment, the PR is
ready for another pass.
--
This is an automated message from the Apache Git Service.
To respond to the
kowshik commented on code in PR #13268:
URL: https://github.com/apache/kafka/pull/13268#discussion_r1113595191
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -704,18 +708,18 @@ abstract class AbstractFetcherThread(name: String,
* Putting the two
kowshik commented on code in PR #13268:
URL: https://github.com/apache/kafka/pull/13268#discussion_r1113595191
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -704,18 +708,18 @@ abstract class AbstractFetcherThread(name: String,
* Putting the two
mjsax merged PR #13251:
URL: https://github.com/apache/kafka/pull/13251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kowshik commented on PR #13272:
URL: https://github.com/apache/kafka/pull/13272#issuecomment-1439108799
@junrao Thanks for the review! I've addressed the comment, PR is ready for
another pass. The CI test failures look unrelated to this PR.
--
This is an automated message from the Apache
kowshik commented on code in PR #13272:
URL: https://github.com/apache/kafka/pull/13272#discussion_r1113579561
##
core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala:
##
@@ -118,6 +120,61 @@ class LocalLeaderEndPointTest {
assertEquals((4, 3L),
chia7712 commented on code in PR #13285:
URL: https://github.com/apache/kafka/pull/13285#discussion_r1113497710
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -115,8 +115,8 @@ class SocketServer(val config: KafkaConfig,
private var stopped = false
//
chia7712 opened a new pull request, #13285:
URL: https://github.com/apache/kafka/pull/13285
The collections used by generating metrics are thread-safe already, so the
synchronization is unnecessary
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-13874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-13874:
--
Assignee: Chia-Ping Tsai
> Avoid synchronization in SocketServer metrics
>
junrao commented on code in PR #13272:
URL: https://github.com/apache/kafka/pull/13272#discussion_r1113490472
##
core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala:
##
@@ -118,6 +120,61 @@ class LocalLeaderEndPointTest {
assertEquals((4, 3L),
[
https://issues.apache.org/jira/browse/KAFKA-14718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14718:
-
Labels: flaky-test (was: )
> Flaky DedicatedMirrorIntegrationTest test suite
>
[
https://issues.apache.org/jira/browse/KAFKA-14718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14718:
-
Fix Version/s: 3.5.0
> Flaky DedicatedMirrorIntegrationTest test suite
>
divijvaidya commented on PR #13284:
URL: https://github.com/apache/kafka/pull/13284#issuecomment-1438985658
@C0urante please take a look when you get a chance. `unitTest` and
`integrationTest` succeed for me locally.
--
This is an automated message from the Apache Git Service.
To respond
divijvaidya opened a new pull request, #13284:
URL: https://github.com/apache/kafka/pull/13284
# Motivation
The test suite fails with the following error:
```
org.opentest4j.AssertionFailedError: Condition not met within timeout 3.
topic A.test-topic-0 was not created on
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1113450545
##
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##
@@ -23,17 +23,35 @@
// Version 2 adds the support for new error code
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1113435053
##
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##
@@ -23,17 +23,35 @@
// Version 2 adds the support for new error code
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1113435053
##
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##
@@ -23,17 +23,35 @@
// Version 2 adds the support for new error code
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1113432465
##
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##
@@ -23,17 +23,35 @@
// Version 2 adds the support for new error code
jolshan commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1438924572
Sorry these files keep changing @anatasiavela -- I will try to review as
soon as you complete the rebase (feel free to just merge trunk into it)
--
This is an automated message from
guozhangwang commented on PR #13025:
URL: https://github.com/apache/kafka/pull/13025#issuecomment-1438910896
LGTM! Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
guozhangwang merged PR #13025:
URL: https://github.com/apache/kafka/pull/13025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1438909145
Although, are we ok with handling these 4 exceptions the same way as before?
I know you previously mentioned that it might be better off to make the rules
more consistent, and I kind
guozhangwang commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1438908779
Oh got it, thanks! All good :) Please let me know when it's ready for a
final look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1113415976
##
clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequestTest.java:
##
@@ -17,43 +17,138 @@
package org.apache.kafka.common.requests;
philipnee commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1438907376
Hey @guozhangwang it's WIP - I think moving the timer check before the
exception handling block (that 4 exceptions), kind of breaks a bunch of tests,
as most tests are expecting the
guozhangwang commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1438904177
@philipnee is this the final version of this PR? Seems we are still honoring
the four exceptions indicating the mid-stage of a rebalance more than the
elapsed timer here?
--
This
[
https://issues.apache.org/jira/browse/KAFKA-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-5568:
-
Affects Version/s: 3.3.2
3.3.1
3.2.3
[
https://issues.apache.org/jira/browse/KAFKA-14530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-14530.
-
Fix Version/s: 3.5.0
Resolution: Fixed
> Check state updater more than once in
[
https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14675:
--
Affects Version/s: 3.5.0
> Extract metadata-related tasks from Fetcher into MetadataFetcher
>
hachikuji merged PR #13192:
URL: https://github.com/apache/kafka/pull/13192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691709#comment-17691709
]
Soumyajit Sahu commented on KAFKA-14738:
This isn't a big. You are listing topics as ANONYMOUS
[
https://issues.apache.org/jira/browse/KAFKA-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691708#comment-17691708
]
Soumyajit Sahu commented on KAFKA-14738:
This is not a bug. You are listing your topics as
Gabriel Lukacs created KAFKA-14738:
--
Summary: Topic disappears from kafka_topic.sh --list after
modifying it with kafka_acl.sh
Key: KAFKA-14738
URL: https://issues.apache.org/jira/browse/KAFKA-14738
mimaison commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r1113274635
##
build.gradle:
##
@@ -1756,6 +1756,7 @@ project(':tools') {
dependencies {
implementation project(':clients')
+implementation project(':core')
Review
Mickael Maison created KAFKA-14737:
--
Summary: Move kafka.utils.json to server-common
Key: KAFKA-14737
URL: https://issues.apache.org/jira/browse/KAFKA-14737
Project: Kafka
Issue Type:
mimaison commented on PR #13216:
URL: https://github.com/apache/kafka/pull/13216#issuecomment-1438720784
Thanks @scholzj for the PR. As suggested by Federico, can you also update
`tests/kafkatest/services/templates/connect_log4j.properties`?
--
This is an automated message from the
urbandan commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1438715691
@C0urante I was thinking of something similar to the ConnectSchema#equals,
but only expecting Schema instances, and using the methods instead of the
fields:
```
public static
mimaison commented on PR #6193:
URL: https://github.com/apache/kafka/pull/6193#issuecomment-1438697431
@armandfargeon No I'm not planning to work on this anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mimaison commented on code in PR #13215:
URL: https://github.com/apache/kafka/pull/13215#discussion_r1113147375
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dajac commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1113132735
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java:
##
@@ -59,7 +63,36 @@ public OffsetCommitRequest build(short version) {
[
https://issues.apache.org/jira/browse/KAFKA-14718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-14718:
Assignee: Divij Vaidya
> Flaky DedicatedMirrorIntegrationTest test suite
>
[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691649#comment-17691649
]
Chaitanya Mukka commented on KAFKA-14401:
-
Thanks for filing this [~sagarrao]! I can take this
[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chaitanya Mukka reassigned KAFKA-14401:
---
Assignee: Chaitanya Mukka
> Connector/Tasks reading offsets can get stuck if
omkreddy commented on PR #13282:
URL: https://github.com/apache/kafka/pull/13282#issuecomment-1438537221
Merged to trunk and 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
omkreddy merged PR #13282:
URL: https://github.com/apache/kafka/pull/13282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rondagostino merged PR #13273:
URL: https://github.com/apache/kafka/pull/13273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rondagostino commented on PR #13273:
URL: https://github.com/apache/kafka/pull/13273#issuecomment-1438493217
Latest run had 2 failures:
```
Build / JDK 11 and Scala 2.13 / testPollReturnsRecords() –
org.apache.kafka.clients.consumer.KafkaConsumerTest
<1s
Build / JDK 17 and Scala
yashmayya commented on PR #13276:
URL: https://github.com/apache/kafka/pull/13276#issuecomment-1438404922
Hi @C0urante, could you please take a look?
PS - I'd be happy to move the minor Javadoc improvements to a separate PR if
you'd like (we never got to a conclusion
emissionnebula commented on PR #13282:
URL: https://github.com/apache/kafka/pull/13282#issuecomment-1438402661
Thanks @omkreddy for the review. I have updated the description.
Also, the build seems to be failing due to unrelated test failures.
-
yashmayya commented on code in PR #13276:
URL: https://github.com/apache/kafka/pull/13276#discussion_r1112987230
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1870,7 +1880,16 @@ private Callable
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1438344033
> We can create the new Java classes in tools and not touch the existing
Scala code
Thanks for feedback.
OK. I will move new classes to tools and revert scala code changes
mimaison commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1438342481
> Are you suggesting to perform all moving in one PR? Or you have some plan
how to performa moving in several steps? If yes, please, share some guidelines
on how should I implement it.
vamossagar12 opened a new pull request, #13283:
URL: https://github.com/apache/kafka/pull/13283
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
showuon commented on code in PR #13280:
URL: https://github.com/apache/kafka/pull/13280#discussion_r1112773897
##
metadata/src/main/java/org/apache/kafka/image/TopicsImage.java:
##
@@ -76,8 +84,8 @@ public TopicImage getTopic(String name) {
}
public void
Hangleton commented on code in PR #13268:
URL: https://github.com/apache/kafka/pull/13268#discussion_r1112735419
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -704,18 +708,18 @@ abstract class AbstractFetcherThread(name: String,
* Putting the
emissionnebula opened a new pull request, #13282:
URL: https://github.com/apache/kafka/pull/13282
AclAuthorizerTest includes a lot of tests covering various scenarios that
are missing in StandardAuthorizerTest.
This PR changes the AclAuthorizerTest to run tests for both zk and kraft
Hangleton commented on PR #13214:
URL: https://github.com/apache/kafka/pull/13214#issuecomment-1438048548
Please ignore the request for review Frederico - was learning about the
refresh icon on Github...
--
This is an automated message from the Apache Git Service.
To respond to the
RivenSun2 commented on PR #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1438024130
Hi @cmccabe
Could you help to review the PR ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
86 matches
Mail list logo
